athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2023-07-23T08:59:29+02:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/64487jFEX renaming Decorator tool2023-07-23T08:59:29+02:00Sergi Rodriguez BoscajFEX renaming Decorator toolThis MR is to rename the jFEX decorator with a more consistent name.This MR is to rename the jFEX decorator with a more consistent name.https://gitlab.cern.ch/atlas/athena/-/merge_requests/64465ATR-27970 Pass correct SuperCell container to jFexEmulatedTowerMaker algorithm2023-07-23T08:59:30+02:00Sergi Rodriguez BoscaATR-27970 Pass correct SuperCell container to jFexEmulatedTowerMaker algorithmThis MR is mean to solve ATR-27970.
The problem here is that we were trying to read the key "SCell", however for Run2 we need the key "EmulatedSCell"
Similar to ATR-27893 and MR https://gitlab.cern.ch/atlas/athena/-/merge_requests/64284/This MR is mean to solve ATR-27970.
The problem here is that we were trying to read the key "SCell", however for Run2 we need the key "EmulatedSCell"
Similar to ATR-27893 and MR https://gitlab.cern.ch/atlas/athena/-/merge_requests/64284/https://gitlab.cern.ch/atlas/athena/-/merge_requests/64455ATR-27964 Support removed TriggerTowers with zero energy in MC L1Calo sim2023-07-23T08:59:30+02:00Sergi Rodriguez BoscaATR-27964 Support removed TriggerTowers with zero energy in MC L1Calo simThis MR is meant to solve ATR-27964. Warning are popping up because we are running on MC instead of Data. The TriggerTowers are done using the [`Run2TriggerTowerMakerCfg`](https://gitlab.cern.ch/atlas/athena/-/blob/23.0/Trigger/TrigT1/L1...This MR is meant to solve ATR-27964. Warning are popping up because we are running on MC instead of Data. The TriggerTowers are done using the [`Run2TriggerTowerMakerCfg`](https://gitlab.cern.ch/atlas/athena/-/blob/23.0/Trigger/TrigT1/L1CaloFEX/L1CaloFEXSim/python/L1CaloFEXSimCfg.py#L69) and it removes all Towers with et=0 energy.. and therefore not found in the container.
Added the Gaudi boolean property to specify to the algo if it is Data or MC and print or not the WARNING accordingly.
Warning is important for data since the TTs should be always present!
@tbold @tamartin @martindlhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/64438jFEX Adding h_ to the mon histograms2023-07-23T08:59:30+02:00Sergi Rodriguez BoscajFEX Adding h_ to the mon histogramsThis MR is meant to add the `h_` to some histograms in which it was missing. It should go in athena before the tier 0 han config update (still in progress)This MR is meant to add the `h_` to some histograms in which it was missing. It should go in athena before the tier 0 han config update (still in progress)https://gitlab.cern.ch/atlas/athena/-/merge_requests/64420jFEX solving SRjet localmaxima and used of EmulatedTowers2023-07-19T13:40:52+02:00Sergi Rodriguez BoscajFEX solving SRjet localmaxima and used of EmulatedTowersThis MR is meant to solve one problem with the LM finder of jFEX jets. Additionally, it starts using the Emulated towers instead of the legacy path (SCell/TriggerTower -> jTower -> Simulation, now only used for testing)
This does not af...This MR is meant to solve one problem with the LM finder of jFEX jets. Additionally, it starts using the Emulated towers instead of the legacy path (SCell/TriggerTower -> jTower -> Simulation, now only used for testing)
This does not affect operations at P1, since it is related to the jFEX Bitwise simulation. The problem observed in the local maxima finder is related to the seed Et comparison of the neighboring jFEX tower in diagonal. It was pointing at the wrong TriggerTower now it matches the firmware accordingly.https://gitlab.cern.ch/atlas/athena/-/merge_requests/64296Fixing jFEX input data monitoring2023-07-15T01:19:31+02:00Sergi Rodriguez BoscaFixing jFEX input data monitoringThis MR is meant to solve one problem in which the Tile information was also shown in the SCell sum histograms.This MR is meant to solve one problem in which the Tile information was also shown in the SCell sum histograms.https://gitlab.cern.ch/atlas/athena/-/merge_requests/64192jfex monitoring: moving algos2023-07-07T17:00:44+02:00Sergi Rodriguez Boscajfex monitoring: moving algosThis MR is to place the needed algorithm into the right place.This MR is to place the needed algorithm into the right place.https://gitlab.cern.ch/atlas/athena/-/merge_requests/64025jFEX monitoring update, solving ATR-27831 and ATLASRECTS-76622023-06-30T16:58:42+02:00Sergi Rodriguez BoscajFEX monitoring update, solving ATR-27831 and ATLASRECTS-7662This MR is solving few monitoring issues described in:
- ATLASRECTS-7662 - Memory degradation in RAWtoALL
- ATR-27831 - JfexInputMonAlg accessing nonexistent item jtowerEtMeV
It also adds a generic jFEX plot to spot global errors.
sett...This MR is solving few monitoring issues described in:
- ATLASRECTS-7662 - Memory degradation in RAWtoALL
- ATR-27831 - JfexInputMonAlg accessing nonexistent item jtowerEtMeV
It also adds a generic jFEX plot to spot global errors.
setting ~urgent flag since it makes express reconstruction crashhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/63937Thinning the jFEX input data2023-06-28T17:13:15+02:00Sergi Rodriguez BoscaThinning the jFEX input dataThis MR is meant to reduce the size by a factor of ~50% of the jFEX input data containers:`L1_jFexEmulatedTowers` and `L1_jFexDataTowers`
One boolean property has been added in each algorithm (`jFexEmulatedTowers` and `jFexInputByteStrea...This MR is meant to reduce the size by a factor of ~50% of the jFEX input data containers:`L1_jFexEmulatedTowers` and `L1_jFexDataTowers`
One boolean property has been added in each algorithm (`jFexEmulatedTowers` and `jFexInputByteStreamTool`) named: `DoThinning`. by default is `true`. It can be set to `false` in the JO script.
The main reduction comes because of the jTowers that belongs to the FPGA overlap regions are not saved, therefore only core tower remains.https://gitlab.cern.ch/atlas/athena/-/merge_requests/63909ATR-27804 - Updates to jFex effective thresholds2023-06-27T17:18:55+02:00Marco MontellaATR-27804 - Updates to jFex effective thresholds"This is the first attemp at the tuned thresholds with current jFEX calibration parameters. It should get us closer to turn-on curves in the correct location, but is probably not final. However, it should give us a better idea of the sor..."This is the first attemp at the tuned thresholds with current jFEX calibration parameters. It should get us closer to turn-on curves in the correct location, but is probably not final. However, it should give us a better idea of the sort rates to expect with the new jJ items. It will be useful to observe them when we get back into physics, but I wouldn't expect to enable them immediately. Let's see what they look like first."
This MR affects counts of numerous jFex chains.https://gitlab.cern.ch/atlas/athena/-/merge_requests/63755Updating jFEX monitoring with updated information2023-06-23T21:42:31+02:00Sergi Rodriguez BoscaUpdating jFEX monitoring with updated informationThis MR is meant to update the jFEX monitoring.
It modifies the existent input data monitoring, now it compares the DataTowers with the EmulatedTowers
It also created a new monitoring algorithm in which it compares the jFEX simulated TOB...This MR is meant to update the jFEX monitoring.
It modifies the existent input data monitoring, now it compares the DataTowers with the EmulatedTowers
It also created a new monitoring algorithm in which it compares the jFEX simulated TOBs with the decoded data TOBshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/63709Adding getters for the decorated variables2023-06-16T18:49:51+02:00Sergi Rodriguez BoscaAdding getters for the decorated variablesThis MR is meant to add the getters for the decorated variables in the jFexTower container.
It also solves one bug in the decorator algorithm, in which the TileEtMeV was not properly setThis MR is meant to add the getters for the decorated variables in the jFexTower container.
It also solves one bug in the decorator algorithm, in which the TileEtMeV was not properly sethttps://gitlab.cern.ch/atlas/athena/-/merge_requests/63671Adding jFEX calib parameters as in the firmware2023-06-14T17:59:26+02:00Sergi Rodriguez BoscaAdding jFEX calib parameters as in the firmwareThis MR is meant to implement the jet calibration parameters using the same integers as in the online DBThis MR is meant to implement the jet calibration parameters using the same integers as in the online DBhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/63428jFEX saturation for EmulatedTowers and fix saturation for DataTowers2023-06-03T13:42:08+02:00Sergi Rodriguez BoscajFEX saturation for EmulatedTowers and fix saturation for DataTowersThis MR is meant to add the saturation bit for the Emulated towers. The variable used in the calo cell container is `quality()` as suggested by the LAr experts.
Additionally, I fixed a bug found in the jFEX input data decoder where for ...This MR is meant to add the saturation bit for the Emulated towers. The variable used in the calo cell container is `quality()` as suggested by the LAr experts.
Additionally, I fixed a bug found in the jFEX input data decoder where for a given channel it decoded Tile and LATOME in the same way causing some Tile jTowers saturated. There is no saturation for Tile, hence should be always 0.
tagging @mhespinghttps://gitlab.cern.ch/atlas/athena/-/merge_requests/63376updating jFEX MET monitoring plots2023-06-01T15:00:59+02:00Sergi Rodriguez Boscaupdating jFEX MET monitoring plotsThis MR is meant to solve one problem spotted by @martindl. The Met and phi MET were not properly displayed since MR: https://gitlab.cern.ch/atlas/athena/-/merge_requests/62786This MR is meant to solve one problem spotted by @martindl. The Met and phi MET were not properly displayed since MR: https://gitlab.cern.ch/atlas/athena/-/merge_requests/62786https://gitlab.cern.ch/atlas/athena/-/merge_requests/63254Adding jFexTower builder to fill jTower for jFEX simulation2023-07-21T19:13:30+02:00Sergi Rodriguez BoscaAdding jFexTower builder to fill jTower for jFEX simulationThis MR is meant to introduce the jTowerMakerFromJfexTowers. It makes the jTower objects using different ways:
- If is MC it uses the legacy path: CaloCell/TriggerTower containers -> jTower -> jFex simulation (until now so far)
- if it i...This MR is meant to introduce the jTowerMakerFromJfexTowers. It makes the jTower objects using different ways:
- If is MC it uses the legacy path: CaloCell/TriggerTower containers -> jTower -> jFex simulation (until now so far)
- if it is Data (not `flags.Input.isMC`):
- if jFEX pre-scaled input data is available: L1_jFexDataTowers -> jTower -> jFex simulation
- if jFEX pre-scaled input data is **not** available: CaloCell/TriggerTower containers -> jTower -> jFex simulation (until now so far)
There is an additional procedure (for developer and testers). If we have L1_jFexEmulatedTowers, we can set `UseEmulated = True` in that case only if it is data, it can do:
- if jFEX pre-scaled input data is available: L1_jFexDataTowers -> jTower -> jFex simulation
- if jFEX pre-scaled input data is **not** available: L1_jFexEmulatedTowers -> jTower -> jFex simulation (**It has the same effect as CaloCell/TriggerTower containers -> jTower -> jFex simulation**)https://gitlab.cern.ch/atlas/athena/-/merge_requests/63156jFEX MET sign change to be missing vector Et2023-05-22T16:22:29+02:00Sergi Rodriguez BoscajFEX MET sign change to be missing vector EtThis MR is meant to return the Ex and Ey of the actual "missing" vector Et instead of the "visible" vector Et.This MR is meant to return the Ex and Ey of the actual "missing" vector Et instead of the "visible" vector Et.https://gitlab.cern.ch/atlas/athena/-/merge_requests/62945ATR-27067 - ET+ID Fix for eFex Threshold2023-05-11T15:19:05+02:00Marco MontellaATR-27067 - ET+ID Fix for eFex ThresholdChanges:
ID Thresholds for eEM items:
- Tightened reta M and T thresholds
- Tightened road M threshold
- Tightened wstot M threshold
ET Thresholds for eEM items:
- eEM3 to eEM5: thresholds decreased by 0.5 GeV
- eEM7 to eEM24: threshol...Changes:
ID Thresholds for eEM items:
- Tightened reta M and T thresholds
- Tightened road M threshold
- Tightened wstot M threshold
ET Thresholds for eEM items:
- eEM3 to eEM5: thresholds decreased by 0.5 GeV
- eEM7 to eEM24: thresholds decreased by 1 GeVhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/62834Adding jFEX 6b error into the monitoring2023-05-04T16:26:34+02:00Sergi Rodriguez BoscaAdding jFEX 6b error into the monitoringThis MR is meant to add some error bins into the tool histogram.
Those bins will monitor:
- Corrective Trailer
- Safe Mode
- Protocol error
- Length mismatch
- Header mismatch
- Processor Timeout
All present at the jFEX to ROB trailerThis MR is meant to add some error bins into the tool histogram.
Those bins will monitor:
- Corrective Trailer
- Safe Mode
- Protocol error
- Length mismatch
- Header mismatch
- Processor Timeout
All present at the jFEX to ROB trailerhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/62810Removing one hardcoded SCell ID from jFEX Simulation2023-05-03T15:42:34+02:00Sergi Rodriguez BoscaRemoving one hardcoded SCell ID from jFEX SimulationThis MR is meant to remove one hardcoded Scell ID in the jFEX simulation.
It was hardcoded because the LAr DB was claiming that the Scell was masked (in Athena) but not in the real time path.This MR is meant to remove one hardcoded Scell ID in the jFEX simulation.
It was hardcoded because the LAr DB was claiming that the Scell was masked (in Athena) but not in the real time path.