athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2023-07-21T19:13:30+02:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/63254Adding jFexTower builder to fill jTower for jFEX simulation2023-07-21T19:13:30+02:00Sergi Rodriguez BoscaAdding jFexTower builder to fill jTower for jFEX simulationThis MR is meant to introduce the jTowerMakerFromJfexTowers. It makes the jTower objects using different ways:
- If is MC it uses the legacy path: CaloCell/TriggerTower containers -> jTower -> jFex simulation (until now so far)
- if it i...This MR is meant to introduce the jTowerMakerFromJfexTowers. It makes the jTower objects using different ways:
- If is MC it uses the legacy path: CaloCell/TriggerTower containers -> jTower -> jFex simulation (until now so far)
- if it is Data (not `flags.Input.isMC`):
- if jFEX pre-scaled input data is available: L1_jFexDataTowers -> jTower -> jFex simulation
- if jFEX pre-scaled input data is **not** available: CaloCell/TriggerTower containers -> jTower -> jFex simulation (until now so far)
There is an additional procedure (for developer and testers). If we have L1_jFexEmulatedTowers, we can set `UseEmulated = True` in that case only if it is data, it can do:
- if jFEX pre-scaled input data is available: L1_jFexDataTowers -> jTower -> jFex simulation
- if jFEX pre-scaled input data is **not** available: L1_jFexEmulatedTowers -> jTower -> jFex simulation (**It has the same effect as CaloCell/TriggerTower containers -> jTower -> jFex simulation**)https://gitlab.cern.ch/atlas/athena/-/merge_requests/63156jFEX MET sign change to be missing vector Et2023-05-22T16:22:29+02:00Sergi Rodriguez BoscajFEX MET sign change to be missing vector EtThis MR is meant to return the Ex and Ey of the actual "missing" vector Et instead of the "visible" vector Et.This MR is meant to return the Ex and Ey of the actual "missing" vector Et instead of the "visible" vector Et.https://gitlab.cern.ch/atlas/athena/-/merge_requests/62945ATR-27067 - ET+ID Fix for eFex Threshold2023-05-11T15:19:05+02:00Marco MontellaATR-27067 - ET+ID Fix for eFex ThresholdChanges:
ID Thresholds for eEM items:
- Tightened reta M and T thresholds
- Tightened road M threshold
- Tightened wstot M threshold
ET Thresholds for eEM items:
- eEM3 to eEM5: thresholds decreased by 0.5 GeV
- eEM7 to eEM24: threshol...Changes:
ID Thresholds for eEM items:
- Tightened reta M and T thresholds
- Tightened road M threshold
- Tightened wstot M threshold
ET Thresholds for eEM items:
- eEM3 to eEM5: thresholds decreased by 0.5 GeV
- eEM7 to eEM24: thresholds decreased by 1 GeVhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/62834Adding jFEX 6b error into the monitoring2023-05-04T16:26:34+02:00Sergi Rodriguez BoscaAdding jFEX 6b error into the monitoringThis MR is meant to add some error bins into the tool histogram.
Those bins will monitor:
- Corrective Trailer
- Safe Mode
- Protocol error
- Length mismatch
- Header mismatch
- Processor Timeout
All present at the jFEX to ROB trailerThis MR is meant to add some error bins into the tool histogram.
Those bins will monitor:
- Corrective Trailer
- Safe Mode
- Protocol error
- Length mismatch
- Header mismatch
- Processor Timeout
All present at the jFEX to ROB trailerhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/62810Removing one hardcoded SCell ID from jFEX Simulation2023-05-03T15:42:34+02:00Sergi Rodriguez BoscaRemoving one hardcoded SCell ID from jFEX SimulationThis MR is meant to remove one hardcoded Scell ID in the jFEX simulation.
It was hardcoded because the LAr DB was claiming that the Scell was masked (in Athena) but not in the real time path.This MR is meant to remove one hardcoded Scell ID in the jFEX simulation.
It was hardcoded because the LAr DB was claiming that the Scell was masked (in Athena) but not in the real time path.https://gitlab.cern.ch/atlas/athena/-/merge_requests/62786jFEX MET fixing hemisphere sign2023-05-30T15:21:53+02:00Sergi Rodriguez BoscajFEX MET fixing hemisphere signThis MR is meant to solve one rounding problem due to the wrong place when assign the hemisphere sign.
With this MET and SumET algorithms are matching 100% for jFEX simulation.
PS. Applying noise cuts - Pileup subs. not studied yetThis MR is meant to solve one rounding problem due to the wrong place when assign the hemisphere sign.
With this MET and SumET algorithms are matching 100% for jFEX simulation.
PS. Applying noise cuts - Pileup subs. not studied yethttps://gitlab.cern.ch/atlas/athena/-/merge_requests/62687jFEX SumEt algorithm now bitwise2023-04-28T17:05:25+02:00Sergi Rodriguez BoscajFEX SumEt algorithm now bitwiseThis MR is meant to solve one problem with the SumEt algorithm in which the C-side was flipped in the simulation and therefore not properly calculated. Now, it matches 100% the data.This MR is meant to solve one problem with the SumEt algorithm in which the C-side was flipped in the simulation and therefore not properly calculated. Now, it matches 100% the data.https://gitlab.cern.ch/atlas/athena/-/merge_requests/62610Updating jFEX MET simulation2023-04-29T08:36:42+02:00Sergi Rodriguez BoscaUpdating jFEX MET simulationThis MR is meant to update the jFEX met simulation.
It solve one problem found on the FWD MET calculation as well as some rounding issues.
It modifies the interface of the EDM to retrieve the Ex and Ey to take into account the hemispher...This MR is meant to update the jFEX met simulation.
It solve one problem found on the FWD MET calculation as well as some rounding issues.
It modifies the interface of the EDM to retrieve the Ex and Ey to take into account the hemisphere sign.https://gitlab.cern.ch/atlas/athena/-/merge_requests/62489Updating jFEX jet Calib parameters2023-04-22T10:41:13+02:00Sergi Rodriguez BoscaUpdating jFEX jet Calib parametersThis MR is meant to update the jFEX jet calibration parameters, since they are updated at P1This MR is meant to update the jFEX jet calibration parameters, since they are updated at P1https://gitlab.cern.ch/atlas/athena/-/merge_requests/62323gFEX monitoring for decoder errors2023-04-14T20:45:22+02:00Sergi Rodriguez BoscagFEX monitoring for decoder errorsThis MR is meant to update the gFEX decoders to allow to store the gFEX error in one Global histogram.
This will also allow to appear these histograms in the Online histogram at P1 (OHP).
Discussed in ATR-27248
An example is:
![image](...This MR is meant to update the gFEX decoders to allow to store the gFEX error in one Global histogram.
This will also allow to appear these histograms in the Online histogram at P1 (OHP).
Discussed in ATR-27248
An example is:
![image](/uploads/0f3ae8ab9ca0190ec116e6699bf1fc7d/image.png)
Tagging @ctosciri @fizisist @landon and @rhowen for informationhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/62258Draft: Add gfex (input) monitoring to LVL1CaloMonitoringConfig2023-09-25T09:51:51+02:00Bastian SchlagDraft: Add gfex (input) monitoring to LVL1CaloMonitoringConfig - adds gfex monitoring & gfex input monitoring to `LVL1CaloMonitoringConfig` if `enableL1CaloPhase1` - adds gfex monitoring & gfex input monitoring to `LVL1CaloMonitoringConfig` if `enableL1CaloPhase1`https://gitlab.cern.ch/atlas/athena/-/merge_requests/62158jFEX input data and TOB decoders created now a histogram and solve ATR-272462023-04-10T20:30:25+02:00Sergi Rodriguez BoscajFEX input data and TOB decoders created now a histogram and solve ATR-27246This MR is meant to solve one problem at tier 0 described here: ATR-27246
One error has been masked as a DEBUG, experts are investigating the issue now. There is also a warning that has been reported, that is also masked as a DEBUG to n...This MR is meant to solve one problem at tier 0 described here: ATR-27246
One error has been masked as a DEBUG, experts are investigating the issue now. There is also a warning that has been reported, that is also masked as a DEBUG to not create noise.
Additionally, the JO now creates a Histogram when runHLT flag is set to True. This will allow to display the histogram in the ATLAS partition histogram display allowing the expert to see on the fly is there is any problem in the decoders, instead of printing the corresponding string.
Tagging also @rhowen and @landon to be aware of this HLT monitoring changehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/61858gFEX rounding input data issue2023-03-27T20:01:39+02:00Sergi Rodriguez BoscagFEX rounding input data issueThis MR is meant to solve one problem observed in the simulation about rounding the input SC Et.
The rounding has been move to the corresponding `compress` function.This MR is meant to solve one problem observed in the simulation about rounding the input SC Et.
The rounding has been move to the corresponding `compress` function.https://gitlab.cern.ch/atlas/athena/-/merge_requests/61846jFEX Jet calibration back - only eta dependent2023-03-27T20:01:39+02:00Sergi Rodriguez BoscajFEX Jet calibration back - only eta dependentThis MR is meant to put back the jFEX jet calibration. This time it is not Et-dependent, just eta-dependent.
Values used here are shown in the TDAQ ([slides here](https://indico.cern.ch/event/1255268/contributions/5288705/attachments/261...This MR is meant to put back the jFEX jet calibration. This time it is not Et-dependent, just eta-dependent.
Values used here are shown in the TDAQ ([slides here](https://indico.cern.ch/event/1255268/contributions/5288705/attachments/2612552/4514230/jFEX_performance_validation_Niklas_Schmitt.pdf))
Those parameters are still under study so there are some commented lines that we should leave there until a final decision - soon i hope.
Calibration factors are:
- `jFEX 3A/C = 1.66666667` - Most central FPGAs (abs. eta 0.0 - 0.8)
- `jFEX 2A/C = 1.97160883` - Middle FPGAs (abs. eta 0.8 - 1.6)
- `jFEX 1A/C = 1.65343915` - Forward FPGAs (abs. eta 1.6 - 4.9)
Rates/Counts in jJ items are expected to increase. You should notice that this is not what the hardware is doing nowadays, therefore we cannot make a 1 to 1 comparison.
Tagging @tamartin, @hillier and @cantel for further studies and x-checkshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/61845gFEX monitoring fixing phi range from -pi to pi2023-04-18T16:38:25+02:00Sergi Rodriguez BoscagFEX monitoring fixing phi range from -pi to piThis MR is meant to update some of the gFEX monitoring axis ranges for phi distributions
FYI @ssottocoThis MR is meant to update some of the gFEX monitoring axis ranges for phi distributions
FYI @ssottocohttps://gitlab.cern.ch/atlas/athena/-/merge_requests/61836Fixing jFEX input data decoder crash.2023-09-22T13:14:07+02:00Sergi Rodriguez BoscaFixing jFEX input data decoder crash.This MR is meant to fix one crash observed and reported in ATR-27054
The problem was that the Trailers where correctly set, however due to a non-expected word at the end, the algorithm tried to decode the next FPGA. That is was impossib...This MR is meant to fix one crash observed and reported in ATR-27054
The problem was that the Trailers where correctly set, however due to a non-expected word at the end, the algorithm tried to decode the next FPGA. That is was impossible since there are just 4 FPGAs..
The solution was to add one checker to know if there is something to decode, check that at least has two Trailers.https://gitlab.cern.ch/atlas/athena/-/merge_requests/61685Solving circular dependency and clean up2023-03-24T12:04:10+01:00Sergi Rodriguez BoscaSolving circular dependency and clean upThis MR is meant to solve one circular dependency found, and reported here: ATR-22275
To solve the circular dependency, I have disentangled the jTower creation from the simulation. This will allow a future MR where we will be able to se...This MR is meant to solve one circular dependency found, and reported here: ATR-22275
To solve the circular dependency, I have disentangled the jTower creation from the simulation. This will allow a future MR where we will be able to send jFEX input data as input of the simulation.
Additionally some clean up have been made.https://gitlab.cern.ch/atlas/athena/-/merge_requests/61604Solving emulator discrepancy2023-03-21T17:47:23+01:00Sergi Rodriguez BoscaSolving emulator discrepancyThis MR is meant to solve one discrepancy found in the jFEX emulator.
The encoded Et for DataTowers and EmulatedTowers was not iqual due to a round issue. Now it is fixThis MR is meant to solve one discrepancy found in the jFEX emulator.
The encoded Et for DataTowers and EmulatedTowers was not iqual due to a round issue. Now it is fixhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/61602Masking SCells when it is data2023-03-21T21:43:23+01:00Sergi Rodriguez BoscaMasking SCells when it is dataThis MR is meant to solve one problem observed in the prepossessing (ie. ATR-27084)
I will set the masking flag for jFEX and gFEX automatically depending on if it is MC or Data.
FYI @dzanzi @tamartinThis MR is meant to solve one problem observed in the prepossessing (ie. ATR-27084)
I will set the masking flag for jFEX and gFEX automatically depending on if it is MC or Data.
FYI @dzanzi @tamartinhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/61515Masking two jFEX warnings2023-03-14T21:41:50+01:00Sergi Rodriguez BoscaMasking two jFEX warningsThis MR is meant to mask two warning when processing 2022 data.This MR is meant to mask two warning when processing 2022 data.