athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2023-03-10T21:44:06+01:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/61400Updating jFEX with P1 Configuration2023-03-10T21:44:06+01:00Sergi Rodriguez BoscaUpdating jFEX with P1 ConfigurationThis MR is meant to update the jFEX configuration accordingly with P1.
Changes:
- Not jet energy calibration applied for jJ items (Small-R jets)
- No pileup subtraction applied
- Noise thresholds are depending on the calorimeter region, ...This MR is meant to update the jFEX configuration accordingly with P1.
Changes:
- Not jet energy calibration applied for jJ items (Small-R jets)
- No pileup subtraction applied
- Noise thresholds are depending on the calorimeter region, (EMB, HEC and EMEC = 1GeV, FCAL = 0MeV and Tile = 500MeV)
Jet forward algorithm is updated to do the same `if else` statement as the firmware.
NOTE: There is one supercell (Offline ID: 906973184) masked in athena, but not in the real time path. Therefore as a tmp solution we hardcode it in the code.https://gitlab.cern.ch/atlas/athena/-/merge_requests/61272Changing SC_ET to SC_ET_ID2023-03-06T21:42:03+01:00Sergi Rodriguez BoscaChanging SC_ET to SC_ET_IDThis MR is meant to solve a problem with the derivations: ATR-27060
The problem is that the LAr is reading our the Et bcided (just for the correct bcid) not previous and later bunch crossings.
Since the LAr tools are expecting now SC_ET...This MR is meant to solve a problem with the derivations: ATR-27060
The problem is that the LAr is reading our the Et bcided (just for the correct bcid) not previous and later bunch crossings.
Since the LAr tools are expecting now SC_ET_ID instead of SC_ET, I created this MR.
@thompson @jmaurerhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/61102Adding xtobs key names2023-03-02T11:50:13+01:00Sergi Rodriguez BoscaAdding xtobs key namesThis MR is meant to add the ending "Sim" when running the simulation and saves the EDM containers.This MR is meant to add the ending "Sim" when running the simulation and saves the EDM containers.https://gitlab.cern.ch/atlas/athena/-/merge_requests/60950jFEX tau updates and bugfixes2023-02-23T15:49:02+01:00Sergi Rodriguez BoscajFEX tau updates and bugfixesThis MR is meant to update the jFEX simulation.
It updates jFEX taus:
![Screenshot_from_2023-02-22_18-04-43](/uploads/24824a161b6ab74c60c5aaf2f517aff6/Screenshot_from_2023-02-22_18-04-43.png)
The Simulation matches with the run/lb: `dat...This MR is meant to update the jFEX simulation.
It updates jFEX taus:
![Screenshot_from_2023-02-22_18-04-43](/uploads/24824a161b6ab74c60c5aaf2f517aff6/Screenshot_from_2023-02-22_18-04-43.png)
The Simulation matches with the run/lb: `data22_13p6TeV.00440543.physics_Main.daq.RAW/data22_13p6TeV.00440543.physics_Main.daq.RAW._lb1200`
Some modification are also done to the jFEX jets but, they still need some investigations.
jFEX decorator also updated to allow different keys as input: `L1_jFexDataTowers` or `L1_jFexEmulatedTowers`https://gitlab.cern.ch/atlas/athena/-/merge_requests/60582JFEX simulation update2023-02-15T21:42:05+01:00Sergi Rodriguez BoscaJFEX simulation updateWith this MR I have updated the jFEX simulation solving the bugs found when comparing decoded jFEX TOB data and simulated TOBs.
Main changes are:
- Minor bugs on the central jets and taus
- Updated the fwd taus, since on the edges some t...With this MR I have updated the jFEX simulation solving the bugs found when comparing decoded jFEX TOB data and simulated TOBs.
Main changes are:
- Minor bugs on the central jets and taus
- Updated the fwd taus, since on the edges some trigger towers where not used in the seeding/local maxima search
- New fwd jets algorithm, not using the same list as the firmware is using. Actually useful to save CPU time and resources
- Cleaning of leftovers from other modifications.
The tests where done using cosmic data from 2022 (440915) and plots to represent the changes are:
For jJ:
![Screenshot_from_2023-02-10_14-29-37](/uploads/de05431d18f593912c354d06e2174b62/Screenshot_from_2023-02-10_14-29-37.png)
For jTaus:
![Screenshot_from_2023-02-10_14-31-33](/uploads/8c347fceba7a5a9c02474cb36958a8e9/Screenshot_from_2023-02-10_14-31-33.png)https://gitlab.cern.ch/atlas/athena/-/merge_requests/60082Updating the jFEX decorator with the masking and new variables2023-01-27T21:42:12+01:00Sergi Rodriguez BoscaUpdating the jFEX decorator with the masking and new variablesThis MR is meant to update the jFEX decorator.
- Now masking is applied to the SCells stored in the CaloCell container. One SCell masked will set its Et to 0
- Can be switched off with the Gaudi variable `SCellMasking` set to false
- ...This MR is meant to update the jFEX decorator.
- Now masking is applied to the SCells stored in the CaloCell container. One SCell masked will set its Et to 0
- Can be switched off with the Gaudi variable `SCellMasking` set to false
- Some modifications have been implemented to the decorator
- Now extra variables can be saved with setting the Gaudi variable `ExtraInfo` to true, default is false
- Two variables have been added `SCellEtMeV` and `TileEtMeV`, summer energy of Scells and Tile energy in MeV
- One variable (`emulated_jtowerEt`) is saved only and just only if the ReadHandleKey is `L1_jFexDataTowers`. This is done to save space in the derivations when the `L1_jFexEmulatedTowers` are written as well. This variables is the emulated/reconstructed **encoded** Et, summing up all the corresponding SCells for LAr or the tile et for Tile detector. It can be compared 1 to 1 with the `et_count` variable if all works fine as we expecthttps://gitlab.cern.ch/atlas/athena/-/merge_requests/60008Updating jFEX simulation to match the firmware2023-01-26T15:43:43+01:00Sergi Rodriguez BoscaUpdating jFEX simulation to match the firmwareThis MR is meant to solve minor bugs found when comparing with data.
In particular for central jets and Taus.
The testing sample was: `/eos/atlas/atlastier0/rucio/data_test/physics_L1Calo/00440915/data_test.00440915.physics_L1Calo.daq....This MR is meant to solve minor bugs found when comparing with data.
In particular for central jets and Taus.
The testing sample was: `/eos/atlas/atlastier0/rucio/data_test/physics_L1Calo/00440915/data_test.00440915.physics_L1Calo.daq.RAW/data_test.00440915.physics_L1Calo.daq.RAW._lb3*._0001.data`
FWD regions still needs to be tunes and corrected with the firmware lists.
Difference between Athena and real firmware:
1. Pileup is applied
2. Noise cut is set to 0
3. Jet calibration is applied
in the firmware:
1. Pileup not applied
2. Noise cuts (1000MeV for LAr, 500MeV for Tile and 0 MeV for FCAL)
3. No Jet calibration appliedhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/59799jFEX global phi bug due to FPGA ordering2023-01-17T21:42:53+01:00Sergi Rodriguez BoscajFEX global phi bug due to FPGA orderingThis MR is meant to solve one problem with the EDM globalPhi variable. negative phi was buggy due to the ordering of the FPGA (0, 1, 3, 2).This MR is meant to solve one problem with the EDM globalPhi variable. negative phi was buggy due to the ordering of the FPGA (0, 1, 3, 2).https://gitlab.cern.ch/atlas/athena/-/merge_requests/59066jFEX decorator bugfix2022-12-13T15:43:57+01:00Sergi Rodriguez BoscajFEX decorator bugfixThis MR is meant to solve a possible future crash at tier 0 processing when LATOME decodes bad SCells.This MR is meant to solve a possible future crash at tier 0 processing when LATOME decodes bad SCells.https://gitlab.cern.ch/atlas/athena/-/merge_requests/58943correction in rho+rms met algorithm2022-12-05T18:04:15+01:00Rajat Guptacorrection in rho+rms met algorithmThis MR makes a small correction in the alternative MET algorithm (Rho+RMS) in gFEX bit-wise simulation code. The RMS value calculated for the algorithm should use g-Tower ET value, not the 'pile-up (Rho)' subtracted from 'g-Tower ET' va...This MR makes a small correction in the alternative MET algorithm (Rho+RMS) in gFEX bit-wise simulation code. The RMS value calculated for the algorithm should use g-Tower ET value, not the 'pile-up (Rho)' subtracted from 'g-Tower ET' value.https://gitlab.cern.ch/atlas/athena/-/merge_requests/58912Updating jFEX monitoring to add invalid code mapping2022-12-07T15:42:49+01:00Sergi Rodriguez BoscaUpdating jFEX monitoring to add invalid code mappingThis MR is meant to update the jFEX monitoring to include Invalid code mapping coming from LATOME.
Also includes changes in the Phi coordinate to match the actually Tower size (Pi/32)This MR is meant to update the jFEX monitoring to include Invalid code mapping coming from LATOME.
Also includes changes in the Phi coordinate to match the actually Tower size (Pi/32)https://gitlab.cern.ch/atlas/athena/-/merge_requests/58640Adding eFEX and gFEX in the python script2022-11-23T16:54:54+01:00Sergi Rodriguez BoscaAdding eFEX and gFEX in the python scriptThis MR is meant to get a python script with all FEXes available to decode data and run the L1calo simulation with Run3 data.
Command: `python -m L1CaloFEXSim.FEXReprocessingRun3 --filesInput "/eos/atlas/atlastier0/rucio/data22_13p6Te...This MR is meant to get a python script with all FEXes available to decode data and run the L1calo simulation with Run3 data.
Command: `python -m L1CaloFEXSim.FEXReprocessingRun3 --filesInput "/eos/atlas/atlastier0/rucio/data22_13p6TeV/physics_Main/00439798/data22_13p6TeV.00439798.physics_Main.daq.RAW/data22_13p6TeV.00439798.physics_Main.daq.RAW._lb1220._SFO-17._0001.data" --evtMax 1 --outputLevel WARNING --outputs eFex jFex gFex`https://gitlab.cern.ch/atlas/athena/-/merge_requests/58609Adding efex/gfex tower ID variables2022-11-23T10:45:06+01:00Sergi Rodriguez BoscaAdding efex/gfex tower ID variablesThis MR is meant to add two variables into the tower EDM for eFEX and gFEX.
They are not yet initialized, so the variable is empty for now. They will be initialized in a next MR.
Tagging @thompson @rbielski @ctosciri @watsona @willThis MR is meant to add two variables into the tower EDM for eFEX and gFEX.
They are not yet initialized, so the variable is empty for now. They will be initialized in a next MR.
Tagging @thompson @rbielski @ctosciri @watsona @willhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/58495jFEX EDMs now istob variable correctly filled2022-11-21T20:03:14+01:00Sergi Rodriguez BoscajFEX EDMs now istob variable correctly filledThis MR is meant to fill correctly the `istob` variabled in the EDMs for jFEX systemThis MR is meant to fill correctly the `istob` variabled in the EDMs for jFEX systemhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/58401Adding Input Data Monitoring Algorithms of FEXes2022-11-15T21:15:39+01:00Rajat GuptaAdding Input Data Monitoring Algorithms of FEXesThe MR adds monitoring algorithm for the input data of EFex, GFex and JFex.The MR adds monitoring algorithm for the input data of EFex, GFex and JFex.https://gitlab.cern.ch/atlas/athena/-/merge_requests/58388Temporarily add extra decoding of phase-1 L1Calo TOBs offline (duplicate HLT ...2022-11-21T18:07:31+01:00Rafal Bielskirafal.bielski@cern.chTemporarily add extra decoding of phase-1 L1Calo TOBs offline (duplicate HLT decoding)Temporarily enable decoding TOBs in reco/monitoring jobs during commissioning of the phase-1 L1Calo system. This duplicates the TOBs decoded during HLT data-taking at P1 if that is enabled, which is currently not the default hence the ne...Temporarily enable decoding TOBs in reco/monitoring jobs during commissioning of the phase-1 L1Calo system. This duplicates the TOBs decoded during HLT data-taking at P1 if that is enabled, which is currently not the default hence the need for extra offline decoding.
Once the online decoding of TOBs in HLT is fully commissioned and running (ATR-26025), the reco/monitoring jobs should always read the TOBs from HLT result instead of decoding them again. The TOBs in HLT result are linked to Trigger Decisions in the HLT Navigation which facilitates analysis and studies. The duplicated TOBs decoded offline are only needed as long as TOBs in HLT result may be missing because the decoding is not yet enabled in HLT.
Relevant Jira: ATR-26026
FYI @thompson, @serodrighttps://gitlab.cern.ch/atlas/athena/-/merge_requests/58306Add extra config flags to allow disabling each phase-1 L1Calo FEX individually2022-11-15T20:29:15+01:00Rafal Bielskirafal.bielski@cern.chAdd extra config flags to allow disabling each phase-1 L1Calo FEX individuallyAdd flags:
* `Trigger.L1.doeFex`
* `Trigger.L1.dojFex`
* `Trigger.L1.dogFex`
* `Trigger.L1.doTopoPhase1`
which allow to disable the software path, i.e. decoding or simulation, for each of the new phase-1 L1Calo/Topo systems individually...Add flags:
* `Trigger.L1.doeFex`
* `Trigger.L1.dojFex`
* `Trigger.L1.dogFex`
* `Trigger.L1.doTopoPhase1`
which allow to disable the software path, i.e. decoding or simulation, for each of the new phase-1 L1Calo/Topo systems individually even when the more general flags would enable them.
The main intention here is to allow disabling one of the systems in the data decoding path at P1 in case it is misbehaving (either the hardware/firmware or the decoder software) or we are uncertain about its stability.
Relevant Jira: ATR-26025https://gitlab.cern.ch/atlas/athena/-/merge_requests/58290Draft: masking a warning for P12022-11-15T10:08:38+01:00Sergi Rodriguez BoscaDraft: masking a warning for P1This draft is meant to mask a warning until the jFEX read out is fixed.
Tagging @rbielski
Also mention, not sure if it is required.. but i changed a bit the message to make it more comprehensive. (https://gitlab.cern.ch/atlas/athena/-/...This draft is meant to mask a warning until the jFEX read out is fixed.
Tagging @rbielski
Also mention, not sure if it is required.. but i changed a bit the message to make it more comprehensive. (https://gitlab.cern.ch/atlas/athena/-/merge_requests/58025)https://gitlab.cern.ch/atlas/athena/-/merge_requests/58218Adding jFex tower emulator2022-11-11T20:08:30+01:00Sergi Rodriguez BoscaAdding jFex tower emulatorThis MR is meant to add the jFEX emulator. This tool will be used to reconstruct the jFEX towers using the LATOME (CaloCell) and Tile (xAOD::TriggerTower) decoders.
- The name given for the output container is `jFexEmulatedTowers` in con...This MR is meant to add the jFEX emulator. This tool will be used to reconstruct the jFEX towers using the LATOME (CaloCell) and Tile (xAOD::TriggerTower) decoders.
- The name given for the output container is `jFexEmulatedTowers` in contrast of the `jFexDataTowers`
There are some features that needs to be implemented:
- Encoded energy tool from LAr
- Masking Scell tool from LAr
both of them are now placeholders (not accurate)
Additionally the Scell and Tile mapping for jFEX are moved to the corresponding CVMFS folder.https://gitlab.cern.ch/atlas/athena/-/merge_requests/58101jFex Decorator Tile energy encoded2022-11-08T16:49:17+01:00Sergi Rodriguez BoscajFex Decorator Tile energy encodedThis MR is meant to change the decorator for the jFEX towers. Instead of saving the Tile energy in MeV, we store now the jepCP encoded energy.
A direct comparison can be done then to the encoded jFEX encoded Et.
Additionally old Tower ...This MR is meant to change the decorator for the jFEX towers. Instead of saving the Tile energy in MeV, we store now the jepCP encoded energy.
A direct comparison can be done then to the encoded jFEX encoded Et.
Additionally old Tower key name `L1_jTowers` have been change to `L1_jFexDataTowers`