athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2023-10-06T15:58:53+02:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/66187ATLASRECTS-7761: DecorHandles lock when going out of scope2023-10-06T15:58:53+02:00Christos Anastopouloschristos.anastopoulos@cern.chATLASRECTS-7761: DecorHandles lock when going out of scopeATLASRECTS-7761:
WriteDecorHandles lock when going out of scope.
So we can not have them created inside a for loop(given a condition)
Should help with failing SPOT testsATLASRECTS-7761:
WriteDecorHandles lock when going out of scope.
So we can not have them created inside a for loop(given a condition)
Should help with failing SPOT testshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/65505jFEX BS errors ATLASRECTS-77242023-09-04T15:26:39+02:00Sergi Rodriguez BoscajFEX BS errors ATLASRECTS-7724This is meant to update the jFEX BS decoders.
It now checks the ROD Trailers where there are some bits reserved for ROD error map.
For TOBs:
- If any of the error bits is set will return a ERROR and returning FAILURE. Event goes to debu...This is meant to update the jFEX BS decoders.
It now checks the ROD Trailers where there are some bits reserved for ROD error map.
For TOBs:
- If any of the error bits is set will return a ERROR and returning FAILURE. Event goes to debug stream
For jFEX Input data:
- If any error bit is set, prints a WARNING and do not decode the input. Data is corrupted, but does not stop the reconstruction.
Additionally
- I updates the Monitoring histogram accordingly, with location: `ROD Error` and title the bit set to 1: `Corrective Trailer`,`Payload CRC`,`Header CRC`,`Length mismatch`,`Header mismatch` or `Processor Timeout`
- Error/Warning message is more clear now.https://gitlab.cern.ch/atlas/athena/-/merge_requests/64938Fix for ATR-28066 : Temporarily re-add gSuperCellTowerMapper to gFEXDriver2023-08-11T19:39:27+02:00Sergi Rodriguez BoscaFix for ATR-28066 : Temporarily re-add gSuperCellTowerMapper to gFEXDriverThis MR is meant to fix the Run2 test error reported in ATR-28066.
It does not solve the real problem underneath.. It is meant to quickly restore the test - so @ctosciri will have more time to clean up the gFEXDriver algorithm.
Also dis...This MR is meant to fix the Run2 test error reported in ATR-28066.
It does not solve the real problem underneath.. It is meant to quickly restore the test - so @ctosciri will have more time to clean up the gFEXDriver algorithm.
Also discussed in https://gitlab.cern.ch/atlas/athena/-/merge_requests/64533#note_7007367https://gitlab.cern.ch/atlas/athena/-/merge_requests/64465ATR-27970 Pass correct SuperCell container to jFexEmulatedTowerMaker algorithm2023-07-23T08:59:30+02:00Sergi Rodriguez BoscaATR-27970 Pass correct SuperCell container to jFexEmulatedTowerMaker algorithmThis MR is mean to solve ATR-27970.
The problem here is that we were trying to read the key "SCell", however for Run2 we need the key "EmulatedSCell"
Similar to ATR-27893 and MR https://gitlab.cern.ch/atlas/athena/-/merge_requests/64284/This MR is mean to solve ATR-27970.
The problem here is that we were trying to read the key "SCell", however for Run2 we need the key "EmulatedSCell"
Similar to ATR-27893 and MR https://gitlab.cern.ch/atlas/athena/-/merge_requests/64284/https://gitlab.cern.ch/atlas/athena/-/merge_requests/64455ATR-27964 Support removed TriggerTowers with zero energy in MC L1Calo sim2023-07-23T08:59:30+02:00Sergi Rodriguez BoscaATR-27964 Support removed TriggerTowers with zero energy in MC L1Calo simThis MR is meant to solve ATR-27964. Warning are popping up because we are running on MC instead of Data. The TriggerTowers are done using the [`Run2TriggerTowerMakerCfg`](https://gitlab.cern.ch/atlas/athena/-/blob/23.0/Trigger/TrigT1/L1...This MR is meant to solve ATR-27964. Warning are popping up because we are running on MC instead of Data. The TriggerTowers are done using the [`Run2TriggerTowerMakerCfg`](https://gitlab.cern.ch/atlas/athena/-/blob/23.0/Trigger/TrigT1/L1CaloFEX/L1CaloFEXSim/python/L1CaloFEXSimCfg.py#L69) and it removes all Towers with et=0 energy.. and therefore not found in the container.
Added the Gaudi boolean property to specify to the algo if it is Data or MC and print or not the WARNING accordingly.
Warning is important for data since the TTs should be always present!
@tbold @tamartin @martindlhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/64025jFEX monitoring update, solving ATR-27831 and ATLASRECTS-76622023-06-30T16:58:42+02:00Sergi Rodriguez BoscajFEX monitoring update, solving ATR-27831 and ATLASRECTS-7662This MR is solving few monitoring issues described in:
- ATLASRECTS-7662 - Memory degradation in RAWtoALL
- ATR-27831 - JfexInputMonAlg accessing nonexistent item jtowerEtMeV
It also adds a generic jFEX plot to spot global errors.
sett...This MR is solving few monitoring issues described in:
- ATLASRECTS-7662 - Memory degradation in RAWtoALL
- ATR-27831 - JfexInputMonAlg accessing nonexistent item jtowerEtMeV
It also adds a generic jFEX plot to spot global errors.
setting ~urgent flag since it makes express reconstruction crashhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/62158jFEX input data and TOB decoders created now a histogram and solve ATR-272462023-04-10T20:30:25+02:00Sergi Rodriguez BoscajFEX input data and TOB decoders created now a histogram and solve ATR-27246This MR is meant to solve one problem at tier 0 described here: ATR-27246
One error has been masked as a DEBUG, experts are investigating the issue now. There is also a warning that has been reported, that is also masked as a DEBUG to n...This MR is meant to solve one problem at tier 0 described here: ATR-27246
One error has been masked as a DEBUG, experts are investigating the issue now. There is also a warning that has been reported, that is also masked as a DEBUG to not create noise.
Additionally, the JO now creates a Histogram when runHLT flag is set to True. This will allow to display the histogram in the ATLAS partition histogram display allowing the expert to see on the fly is there is any problem in the decoders, instead of printing the corresponding string.
Tagging also @rhowen and @landon to be aware of this HLT monitoring changehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/61602Masking SCells when it is data2023-03-21T21:43:23+01:00Sergi Rodriguez BoscaMasking SCells when it is dataThis MR is meant to solve one problem observed in the prepossessing (ie. ATR-27084)
I will set the masking flag for jFEX and gFEX automatically depending on if it is MC or Data.
FYI @dzanzi @tamartinThis MR is meant to solve one problem observed in the prepossessing (ie. ATR-27084)
I will set the masking flag for jFEX and gFEX automatically depending on if it is MC or Data.
FYI @dzanzi @tamartinhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/61272Changing SC_ET to SC_ET_ID2023-03-06T21:42:03+01:00Sergi Rodriguez BoscaChanging SC_ET to SC_ET_IDThis MR is meant to solve a problem with the derivations: ATR-27060
The problem is that the LAr is reading our the Et bcided (just for the correct bcid) not previous and later bunch crossings.
Since the LAr tools are expecting now SC_ET...This MR is meant to solve a problem with the derivations: ATR-27060
The problem is that the LAr is reading our the Et bcided (just for the correct bcid) not previous and later bunch crossings.
Since the LAr tools are expecting now SC_ET_ID instead of SC_ET, I created this MR.
@thompson @jmaurerhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/58573Masking jFEX decoding Warning2022-11-22T14:56:53+01:00Sergi Rodriguez BoscaMasking jFEX decoding WarningThis MR is meant to mask temporarily the warning that causes problems when decoding jFEX TOBs at Tier 0
Tagging @rbielskiThis MR is meant to mask temporarily the warning that causes problems when decoding jFEX TOBs at Tier 0
Tagging @rbielskihttps://gitlab.cern.ch/atlas/athena/-/merge_requests/57708Changing mapping files to be read from DataGroup2022-10-21T12:25:11+02:00Sergi Rodriguez BoscaChanging mapping files to be read from DataGroupThis MR is meant to change the path of the mappings to be read from the DataGroup.
JIRA: ATLASG-2372
FYI: @rbielski, @tamartin
JIRA: ATR-26025This MR is meant to change the path of the mappings to be read from the DataGroup.
JIRA: ATLASG-2372
FYI: @rbielski, @tamartin
JIRA: ATR-26025https://gitlab.cern.ch/atlas/athena/-/merge_requests/56019solving bug found in debug build in master2022-08-19T14:24:56+02:00Sergi Rodriguez Boscasolving bug found in debug build in masterThis MR is meant to solve a Warning compilation problem found in debug build in master. See ATR-26195This MR is meant to solve a Warning compilation problem found in debug build in master. See ATR-26195Sergi Rodriguez BoscaSergi Rodriguez Boscahttps://gitlab.cern.ch/atlas/athena/-/merge_requests/55234Adding jFEX input data decoders2022-07-25T16:11:59+02:00Sergi Rodriguez BoscaAdding jFEX input data decodersThis MR is meant to add a tool to decode the input data read out from the jFEX system.
There is no possibility to run nowadays with P1 raw data, since jFEX is not included in the partition. Experts are working on it, therefore the added ...This MR is meant to add a tool to decode the input data read out from the jFEX system.
There is no possibility to run nowadays with P1 raw data, since jFEX is not included in the partition. Experts are working on it, therefore the added **files are full of commented printouts, that will be necessary for testing in the future.**
Also there commented one example to initialize and fill the EDM container, jTower. jTower EDM work is in process and will be merged soon, till then it will be commented.Sergi Rodriguez BoscaSergi Rodriguez Boscahttps://gitlab.cern.ch/atlas/athena/-/merge_requests/54496Fixing eFEX SuperCell mapping2022-06-30T23:30:49+02:00Sergi Rodriguez BoscaFixing eFEX SuperCell mappingThis MR is meant to fix the eFEX mapping. This will revert how the SC are considered in the eFEX algorithms.
Jira ticket: ATR-25310
This MR is replacing https://gitlab.cern.ch/atlas/athena/-/merge_requests/54425 (@tqiu)This MR is meant to fix the eFEX mapping. This will revert how the SC are considered in the eFEX algorithms.
Jira ticket: ATR-25310
This MR is replacing https://gitlab.cern.ch/atlas/athena/-/merge_requests/54425 (@tqiu)https://gitlab.cern.ch/atlas/athena/-/merge_requests/54433Solving a bug in eTau algorithm2022-06-30T23:30:49+02:00Sergi Rodriguez BoscaSolving a bug in eTau algorithmThis MR is meant to solve a problem with the eFEX tau algorithm. The problem was in a wrong initialization of a variable.
@watsonaThis MR is meant to solve a problem with the eFEX tau algorithm. The problem was in a wrong initialization of a variable.
@watsonahttps://gitlab.cern.ch/atlas/athena/-/merge_requests/54278Fixing the EM ineff. of eFEX2022-06-21T20:01:30+02:00Sergi Rodriguez BoscaFixing the EM ineff. of eFEXThis Mr is meant to solve a bug regarding the inefficiencies in the EM eFEX algorithm (ATR-25310).
Original MR from Alan: !54269 , resubmitted to target 22.0.This Mr is meant to solve a bug regarding the inefficiencies in the EM eFEX algorithm (ATR-25310).
Original MR from Alan: !54269 , resubmitted to target 22.0.https://gitlab.cern.ch/atlas/athena/-/merge_requests/54019Adding Tile Legacy TriggerTower container to rerun Phase1 L1Calo Sim2022-06-10T08:15:16+02:00Sergi Rodriguez BoscaAdding Tile Legacy TriggerTower container to rerun Phase1 L1Calo SimThis MR is meant to add the Tile container to be able to rerun the Phase1 L1Calo simulation at the ESD/AOD level.
With this we will be able to spot bugs, modify and compare with previous containers since we will be able to rerun the sim...This MR is meant to add the Tile container to be able to rerun the Phase1 L1Calo simulation at the ESD/AOD level.
With this we will be able to spot bugs, modify and compare with previous containers since we will be able to rerun the simulation without running again jobs in the grid.
Adding @thompson as Monitoring Coordinator.https://gitlab.cern.ch/atlas/athena/-/merge_requests/54010Fix problem with gXENC quantities2022-07-13T14:07:34+02:00Cecilia TosciriFix problem with gXENC quantitiesThis MR is meant to fix a bug reported in ATR-25669. A problem was observed for the values of gXENC inputs to L1Topo. This was caused by a wrong initialization of a vector of thresholds, which is now fixed. Since this issue was preventin...This MR is meant to fix a bug reported in ATR-25669. A problem was observed for the values of gXENC inputs to L1Topo. This was caused by a wrong initialization of a vector of thresholds, which is now fixed. Since this issue was preventing us from switching on gXENC and gXERHO in the simulation, it is critical to get this merged before the P1 release is frozen.https://gitlab.cern.ch/atlas/athena/-/merge_requests/53519jFEX Pileup and Noise threshold corrections to match firmware2022-05-25T18:13:32+02:00Sergi Rodriguez BoscajFEX Pileup and Noise threshold corrections to match firmwareThis MR is meant to mimic the firmware thresholds applied. With this MR some trigger count changes are expected, since running the test `test_trig_mc_v1Dev_grid.py` with the option `doEmptyMenu=True;` counts are reduced. i.e.:
- L1_4jJ50...This MR is meant to mimic the firmware thresholds applied. With this MR some trigger count changes are expected, since running the test `test_trig_mc_v1Dev_grid.py` with the option `doEmptyMenu=True;` counts are reduced. i.e.:
- L1_4jJ50 = 432
- L1_4jJ50 = 488
This makes L1 trigger counts closer to the legacy ones (i.e. L1_4J20 = 332)
The commented lines are temporary, since the discussion are still open in the JIRA ticket ATR-25029.
Tagging @tamartin for his interest and @mweirich as firmware algo. experthttps://gitlab.cern.ch/atlas/athena/-/merge_requests/52609High Eta Tau Fix2022-05-07T03:27:40+02:00Nicholas LuongoHigh Eta Tau FixFix an issue with eFEX taus where TOBs were not being created at highest eta values. This caused an inefficiency in HLT triggers wrt offline taus as documented on slide 7 here: https://indico.cern.ch/event/1142008/contributions/4792145/a...Fix an issue with eFEX taus where TOBs were not being created at highest eta values. This caused an inefficiency in HLT triggers wrt offline taus as documented on slide 7 here: https://indico.cern.ch/event/1142008/contributions/4792145/attachments/2420975/4146571/Slides_TauTrigger_ADM.pdf
This was due to the fact that at these eta values we are on the edge of eFEX and therefore the central tower is not fully surrounded. If we were to run the algorithm we would be checking non-existent towers and failing. Now we pass the eFEX and FPGA IDs into the algorithm so it is aware of when it is in an edge environment. When that is the case it defaults non-existent cell energies to zero in TOB energy and isolation calculations.
Trigger reference counts are also being updated. Note that tau counts should strictly increase as a result of this change.