athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2022-10-21T12:25:11+02:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/57708Changing mapping files to be read from DataGroup2022-10-21T12:25:11+02:00Sergi Rodriguez BoscaChanging mapping files to be read from DataGroupThis MR is meant to change the path of the mappings to be read from the DataGroup.
JIRA: ATLASG-2372
FYI: @rbielski, @tamartin
JIRA: ATR-26025This MR is meant to change the path of the mappings to be read from the DataGroup.
JIRA: ATLASG-2372
FYI: @rbielski, @tamartin
JIRA: ATR-26025https://gitlab.cern.ch/atlas/athena/-/merge_requests/51990Adding jFEX tau, jJ and jLJ thresholds2022-04-08T15:43:33+02:00Sergi Rodriguez BoscaAdding jFEX tau, jJ and jLJ thresholdsThis MR is meant to implement in the HLT seeding the threshold patterns for jTau, jJ and jLJ of L1Calo objects.
Also mentioned in JIRA ticket ATR-25308
Tagging also @khoo, @tamartin and @aranzazuThis MR is meant to implement in the HLT seeding the threshold patterns for jTau, jJ and jLJ of L1Calo objects.
Also mentioned in JIRA ticket ATR-25308
Tagging also @khoo, @tamartin and @aranzazuhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/65560L1CaloFEXSim: use hardcode eFEX noise cuts for data before 20232023-10-06T16:39:00+02:00Will ButtingerL1CaloFEXSim: use hardcode eFEX noise cuts for data before 2023Relates to ATR-28135.Relates to ATR-28135.https://gitlab.cern.ch/atlas/athena/-/merge_requests/65539Update LR jet LM logic - ATLASRECTS-76892023-09-05T16:00:26+02:00Sergi Rodriguez BoscaUpdate LR jet LM logic - ATLASRECTS-7689 This is meant to update the logic to solve one coverity error reported in ATLASRECTS-7689 This is meant to update the logic to solve one coverity error reported in ATLASRECTS-7689https://gitlab.cern.ch/atlas/athena/-/merge_requests/64938Fix for ATR-28066 : Temporarily re-add gSuperCellTowerMapper to gFEXDriver2023-08-11T19:39:27+02:00Sergi Rodriguez BoscaFix for ATR-28066 : Temporarily re-add gSuperCellTowerMapper to gFEXDriverThis MR is meant to fix the Run2 test error reported in ATR-28066.
It does not solve the real problem underneath.. It is meant to quickly restore the test - so @ctosciri will have more time to clean up the gFEXDriver algorithm.
Also dis...This MR is meant to fix the Run2 test error reported in ATR-28066.
It does not solve the real problem underneath.. It is meant to quickly restore the test - so @ctosciri will have more time to clean up the gFEXDriver algorithm.
Also discussed in https://gitlab.cern.ch/atlas/athena/-/merge_requests/64533#note_7007367https://gitlab.cern.ch/atlas/athena/-/merge_requests/64563[ATR-27970] setting the super cell container name consistently, fix CA merge ...2023-07-26T08:18:45+02:00Sergi Rodriguez Bosca[ATR-27970] setting the super cell container name consistently, fix CA merge error from jFexEmulatedTowerMaker DQThis is to solve the problem of trying to access the SCell container for Run2 data as described by @martindl in ATR-27970.
The option to choose if it is `SCell` or `EmulatedSCell` is now done in the corresponding cfg. Using the flags se...This is to solve the problem of trying to access the SCell container for Run2 data as described by @martindl in ATR-27970.
The option to choose if it is `SCell` or `EmulatedSCell` is now done in the corresponding cfg. Using the flags set at the main JO.
Since this affects also LAR code I will tag @damazio and @pavolhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/62548Update DQM webdisplays to include most recent gFEX monitoring histograms2023-04-25T10:28:21+02:00Bastian SchlagUpdate DQM webdisplays to include most recent gFEX monitoring histograms- Includes recently added gFEX monitoring histograms to DQM webdisplays
- Example: https://atlasdqm.cern.ch/webdisplay/test/385/physics_Main/run_440613/run/L1Calo/Phase1/gFexLRJets/- Includes recently added gFEX monitoring histograms to DQM webdisplays
- Example: https://atlasdqm.cern.ch/webdisplay/test/385/physics_Main/run_440613/run/L1Calo/Phase1/gFexLRJets/https://gitlab.cern.ch/atlas/athena/-/merge_requests/59052Adding try catch for the trigger menu access jFEX Decoders2022-12-07T15:43:26+01:00Sergi Rodriguez BoscaAdding try catch for the trigger menu access jFEX DecodersThis MR is to add a try-catch step in case the item are not accessible in the trigger menu.
Was requested here: ATR-26734This MR is to add a try-catch step in case the item are not accessible in the trigger menu.
Was requested here: ATR-26734https://gitlab.cern.ch/atlas/athena/-/merge_requests/58839Solving crash tier 0, jFEX decoders2022-12-01T19:17:58+01:00Sergi Rodriguez BoscaSolving crash tier 0, jFEX decodersThis MR is means to solve a Tier 0 crash when running some test (see ATR-26723).
I have added two firewalls, one that solves the problem mention in the JIRA, and other as a precaution to not attempt to access a vector when the size is lo...This MR is means to solve a Tier 0 crash when running some test (see ATR-26723).
I have added two firewalls, one that solves the problem mention in the JIRA, and other as a precaution to not attempt to access a vector when the size is lower than the expected to start decoding.
Adding @rbielskihttps://gitlab.cern.ch/atlas/athena/-/merge_requests/58573Masking jFEX decoding Warning2022-11-22T14:56:53+01:00Sergi Rodriguez BoscaMasking jFEX decoding WarningThis MR is meant to mask temporarily the warning that causes problems when decoding jFEX TOBs at Tier 0
Tagging @rbielskiThis MR is meant to mask temporarily the warning that causes problems when decoding jFEX TOBs at Tier 0
Tagging @rbielskihttps://gitlab.cern.ch/atlas/athena/-/merge_requests/56819Mask all TOBs with word zero2022-09-30T09:44:13+02:00Cecilia TosciriMask all TOBs with word zeroWith this MR, all the TOB words with value equal to zero found in the gFEX data frame are masked and not saved in the corresponding containers. This is meant to avoid an exception thrown in HLTSeeding, caused by the "invalid" TOBs with w...With this MR, all the TOB words with value equal to zero found in the gFEX data frame are masked and not saved in the corresponding containers. This is meant to avoid an exception thrown in HLTSeeding, caused by the "invalid" TOBs with word=0. The issue was reported and discussed in ATR-25495. Please note that this is a temporary fix, and we are discussing the best approach for propagating the information of "invalid" TOBs (for all Fexes), as they will ultimately need to be monitored as well.https://gitlab.cern.ch/atlas/athena/-/merge_requests/56348Update gFEX ByteStream2022-09-30T09:43:57+02:00Cecilia TosciriUpdate gFEX ByteStreamThis MR is to remove some remaining printings, as mentioned in ATR-25495 and requested in !56012.This MR is to remove some remaining printings, as mentioned in ATR-25495 and requested in !56012.Cecilia TosciriCecilia Toscirihttps://gitlab.cern.ch/atlas/athena/-/merge_requests/55295gFEX bytestream decoders2022-09-30T09:43:42+02:00Cecilia ToscirigFEX bytestream decodersWith this MR the gFEX bytestream decoder is implemented. The TOB words in the bytestream are used to fill the corresponding EDMs. Each EDM is inizialised with the energy scales taken directly from the L1Menu. Please refer to ATR-25495.With this MR the gFEX bytestream decoder is implemented. The TOB words in the bytestream are used to fill the corresponding EDMs. Each EDM is inizialised with the energy scales taken directly from the L1Menu. Please refer to ATR-25495.Cecilia TosciriCecilia Toscirihttps://gitlab.cern.ch/atlas/athena/-/merge_requests/53358Migration of RampMaker2022-05-18T11:35:53+02:00Florencia Luciana Castilloflorencia.luciana.castillo@cern.chMigration of RampMakerHi, This MR is meant to migrate L1CaloRampMaker to rel 22., it is taking the new condition algorithm of L1Calo. I changed some INFO messages to DEBUG in L1CaloCondAlg in order to avoid the noise in the log file. These changes are related...Hi, This MR is meant to migrate L1CaloRampMaker to rel 22., it is taking the new condition algorithm of L1Calo. I changed some INFO messages to DEBUG in L1CaloCondAlg in order to avoid the noise in the log file. These changes are related to two JIRA tickets: [ATR-24777](https://its.cern.ch/jira/browse/ATR-24777) and [ATR-25124](https://its.cern.ch/jira/browse/ATR-25124). Thanks.https://gitlab.cern.ch/atlas/athena/-/merge_requests/52686Adding jFEX decoding from BS data file2022-05-06T16:57:32+02:00Sergi Rodriguez BoscaAdding jFEX decoding from BS data fileThis MR is meant to create the necessary files and folders to store the jFEX ByteStream decoders/encoders.
This task is under development and the commented out printouts will eventually get removed but they are temporarily needed, since ...This MR is meant to create the necessary files and folders to store the jFEX ByteStream decoders/encoders.
This task is under development and the commented out printouts will eventually get removed but they are temporarily needed, since the data provided is a testing sample without any RoIs in it, thus when RoIs will be provided they will be needed.
Jira: ATR-25494https://gitlab.cern.ch/atlas/athena/-/merge_requests/50420IsCentralSeed Fix2022-02-23T03:43:28+01:00Nicholas LuongoIsCentralSeed FixThis change fixes a bug in the bitwise eFEX tau creation code. The algorithm searches for local maxima in towers and creates a TOB when one is found. However, the current code only checks a subset of the cells surrounding a candidate.
T...This change fixes a bug in the bitwise eFEX tau creation code. The algorithm searches for local maxima in towers and creates a TOB when one is found. However, the current code only checks a subset of the cells surrounding a candidate.
This has lead to duplicate HLT taus appearing as documented here: https://its.cern.ch/jira/browse/ATR-24908
Because this is enforcing stricter criteria on the creation of a tau TOB, we expect strictly fewer to be output. Therefore updates to the reference value for the trigP1 and trigAna tests are included.https://gitlab.cern.ch/atlas/athena/-/merge_requests/44135fixing line throwing FPE issues2021-06-05T03:02:51+02:00Alison Elliotfixing line throwing FPE issuesThis addresses the error in https://its.cern.ch/jira/browse/ATR-23562
One line was causing this error, and has had a safety put in, to avoid division by zero.This addresses the error in https://its.cern.ch/jira/browse/ATR-23562
One line was causing this error, and has had a safety put in, to avoid division by zero.https://gitlab.cern.ch/atlas/athena/-/merge_requests/41758TrigT1CaloFexPerf: Fix thread-safety checker warnings.2021-03-20T03:03:23+01:00Scott SnyderTrigT1CaloFexPerf: Fix thread-safety checker warnings.Rework to avoid using mutable members.Rework to avoid using mutable members.https://gitlab.cern.ch/atlas/athena/-/merge_requests/37875Include bcid in digit2021-02-08T09:48:39+01:00Denis Oliveira DamazioInclude bcid in digitIncluding the BCID correction in the Digitisation step. For the moment, storing in the RDO AND in the ESD and AOD the uncorrected container, just to perform validation studies.
@pavol might want to comment whether this leads to a bad dep...Including the BCID correction in the Digitisation step. For the moment, storing in the RDO AND in the ESD and AOD the uncorrected container, just to perform validation studies.
@pavol might want to comment whether this leads to a bad dependency (even though it is only a python one) between Lar code and Trigger code.
Just to check, I add @coulon and @kwhalenhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/66436start reading jFEX database values from September 20232023-10-17T11:08:13+02:00Paul Thompsonstart reading jFEX database values from September 2023The jFEX noise cut database was fixed in September 2023 so we use it from then to improve data-resimulation matching when tuning noise cuts in HI running.
This targets 23.0 - still a chance to make it to tier-0 monitoring before the 2023...The jFEX noise cut database was fixed in September 2023 so we use it from then to improve data-resimulation matching when tuning noise cuts in HI running.
This targets 23.0 - still a chance to make it to tier-0 monitoring before the 2023 data taking finishes.