athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2019-04-09T09:16:25+02:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/21012WIP: TrigL1CaloUpgrade: Update to the eFEX algorithm to match the latest isol...2019-04-09T09:16:25+02:00Philipp Sebastian OttWIP: TrigL1CaloUpgrade: Update to the eFEX algorithm to match the latest isolation and clustering studiesThe files 'TrigT1CaloBaseFex.cxx' and 'TrigT1CaloEFex.cxx' are updated
to match the latest isolation and clustering studies.
The major changes include:
-- The option to switch between an energy weighted cluster formation and
a c...The files 'TrigT1CaloBaseFex.cxx' and 'TrigT1CaloEFex.cxx' are updated
to match the latest isolation and clustering studies.
The major changes include:
-- The option to switch between an energy weighted cluster formation and
a cluster formation driven by the most energetic phi neighbour with respect
to the seed cell
-- The inclusion of additional isolation variables: Lateral width in the first
layer (wstot), hadronic isolation (RHad), and energy isolation for cells
along eta in the second layer (REta)https://gitlab.cern.ch/atlas/athena/-/merge_requests/43172WIP: Refactor eFEX TOBs and EDMs2021-06-11T21:22:57+02:00Nicholas LuongoWIP: Refactor eFEX TOBs and EDMsCreate separate eFEX TOB and EDM creation classes to allow for use outside the eFEX bitwise testing code. Build out tau EDM creation and testing.
Far from complete, this is currently intended for feedback on proposed structural changes.Create separate eFEX TOB and EDM creation classes to allow for use outside the eFEX bitwise testing code. Build out tau EDM creation and testing.
Far from complete, this is currently intended for feedback on proposed structural changes.https://gitlab.cern.ch/atlas/athena/-/merge_requests/38201WIP: Obsolete Fixes for supercell pedestal correction2020-11-23T16:15:19+01:00Ben CarlsonWIP: Obsolete Fixes for supercell pedestal correction- Change some default SC container names in MR37875
- Update some database paths for supercells
- Add the database path so that this line is not needed in the AMI tag:
`all:conddb.addFolder(\"LAR_OFL\",\"/LAR/ElecCalibMCSC/MinBias\")"`- Change some default SC container names in MR37875
- Update some database paths for supercells
- Add the database path so that this line is not needed in the AMI tag:
`all:conddb.addFolder(\"LAR_OFL\",\"/LAR/ElecCalibMCSC/MinBias\")"`https://gitlab.cern.ch/atlas/athena/-/merge_requests/38395WIP: Not needed. Pedestal correction fixes. Will not merge.2021-01-19T19:05:38+01:00Ben CarlsonWIP: Not needed. Pedestal correction fixes. Will not merge.- Change trigger sequence to match names from MR37875
- Include pavol's branch that allows us to run the pedestal correction on data like MC simulation.
- Include updated database paths
After some discussion, we decided that we do not ...- Change trigger sequence to match names from MR37875
- Include pavol's branch that allows us to run the pedestal correction on data like MC simulation.
- Include updated database paths
After some discussion, we decided that we do not need the changes in this merge request. Except for some sequence changes, which will be copied to a new MR.https://gitlab.cern.ch/atlas/athena/-/merge_requests/24835WIP:MET Algorithm update: storing gBlocks and combining algorithms with rho s...2019-07-19T13:41:07+02:00Ava Anne MyersWIP:MET Algorithm update: storing gBlocks and combining algorithms with rho subtractionhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/21139WIP: LargeR Sliding Window Jet Algorithm2019-04-09T09:06:27+02:00Sophio PataraiaWIP: LargeR Sliding Window Jet Algorithmas we have discussed I have pushed minor extension of Sliding Window Jet reconstruction algorithm/workflow, to call it twice once for small-R jet and once for large-R jet. Only different between two instances are Jet radius the rest is s...as we have discussed I have pushed minor extension of Sliding Window Jet reconstruction algorithm/workflow, to call it twice once for small-R jet and once for large-R jet. Only different between two instances are Jet radius the rest is same.
tagging @bcarlson @viveiros @ckaldero
Best regards,
Sophiehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/39542WIP: gFEX LUT Rho subtracted MET2021-02-04T15:44:05+01:00Ava Anne MyersWIP: gFEX LUT Rho subtracted MET- Add an algorithm where we change dynamic RMS to RMS computed using a LUT- Add an algorithm where we change dynamic RMS to RMS computed using a LUThttps://gitlab.cern.ch/atlas/athena/-/merge_requests/31331WIP: gFEX, jFEX, taus2020-03-20T19:59:31+01:00Ben CarlsonWIP: gFEX, jFEX, taushttps://gitlab.cern.ch/atlas/athena/-/merge_requests/22620WIP:fix on cpET2019-04-12T18:49:25+02:00Chiao-Ying LinWIP:fix on cpETThe CP ADC count was changed, and this is to correct the number for itThe CP ADC count was changed, and this is to correct the number for ithttps://gitlab.cern.ch/atlas/athena/-/merge_requests/20730WIP:convert L1 e/gamma trigger to tau2019-04-09T09:41:38+02:00Yu EsumiWIP:convert L1 e/gamma trigger to tauStill work in progress, will marge to 21.3Still work in progress, will marge to 21.3https://gitlab.cern.ch/atlas/athena/-/merge_requests/21120WIP: code cleaning, keeping all towers, and pathresolver for noise file2019-02-25T22:57:03+01:00Chiao-Ying LinWIP: code cleaning, keeping all towers, and pathresolver for noise fileThis is the update for Run3 L1Calo simulation:
1. remove redundant variables
2. keeping all towers although they are without energy deposit
3. Noise file is accessed by pathresolverThis is the update for Run3 L1Calo simulation:
1. remove redundant variables
2. keeping all towers although they are without energy deposit
3. Noise file is accessed by pathresolverhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/45151WIP: Adding jFEX taus, jFEX E/Gamma forward, gFEX large-R jets2021-10-25T14:42:56+02:00Ben CarlsonWIP: Adding jFEX taus, jFEX E/Gamma forward, gFEX large-R jetsATR-23847ATR-23847https://gitlab.cern.ch/atlas/athena/-/merge_requests/24459WIP:Add gBlocks to storegate and jets from gBlocks to AOD2019-07-19T15:27:22+02:00Eva Brottmann HansenWIP:Add gBlocks to storegate and jets from gBlocks to AODThis merge request constructs 3x3 blocks of towers (gBlocks), and saves them to storegate for transient access (with a change to the TriggerEDM they can be added to the AOD).
We then take the highest 4ET gBlocks per FPGA, and save th...This merge request constructs 3x3 blocks of towers (gBlocks), and saves them to storegate for transient access (with a change to the TriggerEDM they can be added to the AOD).
We then take the highest 4ET gBlocks per FPGA, and save them to the Run2 jet container for processing.
[1] https://indico.cern.ch/event/816565/contributions/3446614/attachments/1861601/3059710/Miller_gFEXStatusPlans_13Jun2019.pdf (slide 16)Eva Brottmann HansenEva Brottmann Hansenhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/34994WIP:Added jXERHO to the Lvl1 Run3 performace study outputs2020-07-23T16:39:53+02:00Bryan KortmanWIP:Added jXERHO to the Lvl1 Run3 performace study outputsAdded jXERHO to the Lvl1 Run3 performace study outputsAdded jXERHO to the Lvl1 Run3 performace study outputsJon BurrJon Burrhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/31138WIP:added also PUsub for LargeR jets2020-03-20T19:58:05+01:00Duc TaWIP:added also PUsub for LargeR jetsCopied the lines I used for the smallR PUsub jets and used them for LargeR PUsub jets
There is also the beginning of the code for the largeR jet mass in there, but it is not written out, yetCopied the lines I used for the smallR PUsub jets and used them for LargeR PUsub jets
There is also the beginning of the code for the largeR jet mass in there, but it is not written out, yethttps://gitlab.cern.ch/atlas/athena/-/merge_requests/22627Using wrong pileup average folder for BCID dependend offset correction2019-04-17T02:24:09+02:00Denis Oliveira DamazioUsing wrong pileup average folder for BCID dependend offset correctionThis MR fixes the fact that the corrections were not very effective thanks to the wrong folder (also, the folder was recently updated by @pavol). See the attached plots for the Initial (12) bunches and the final ones in MC simulation (ne...This MR fixes the fact that the corrections were not very effective thanks to the wrong folder (also, the folder was recently updated by @pavol). See the attached plots for the Initial (12) bunches and the final ones in MC simulation (need more events, maybe @bcarlson or @viveiros may help me to get a few more).
Denis
PS: [FinalBCIDs.EndCap.pdf](/uploads/7bf86b6a9d723dae3137422a99ba3b28/FinalBCIDs.EndCap.pdf)
[InitialBCIDs.pdf](/uploads/5fc0e617988c3aee98ae76cd42f38490/InitialBCIDs.pdf)
[InitialBCIDs.EndCap.pdf](/uploads/1fa64696d136c75cce1f19ab096d1bff/InitialBCIDs.EndCap.pdf)alBCIDs.pdf](/uploads/6d54dab7e76456a644805be426ff50ce/FinalBCIDs.pdf)
I believe the corrections are slightly over correcting.. But is much better than
before (not having any correction)..
Denishttps://gitlab.cern.ch/atlas/athena/-/merge_requests/46713urgent fix of tob scale for the eFEX taus2021-09-27T10:25:04+02:00Alison Ellioturgent fix of tob scale for the eFEX tausAs pointed out by @asonay , there were no Tau TOBs passing to L1Topo. This was found to be due to a recent change to use the internal firmware energy scale for calculations in the algorithms. This was not factored into the Taus, meaning ...As pointed out by @asonay , there were no Tau TOBs passing to L1Topo. This was found to be due to a recent change to use the internal firmware energy scale for calculations in the algorithms. This was not factored into the Taus, meaning their et values were 25x too small. With this merge, this has been fixed.
Additionally, as suggested by @jburr , the scaling was moved into the formTOBs classes, where the tob and xtob scales are stored in the headers.
This is an urgent fix, as the taus are needed for ongoing developments of the combined taus in L1Topo. @dzanzi .https://gitlab.cern.ch/atlas/athena/-/merge_requests/47874Urgent bug fix for the eFEX tau RoIs that cause isTOB to be incorrectly set t...2021-11-03T21:44:51+01:00Alison ElliotUrgent bug fix for the eFEX tau RoIs that cause isTOB to be incorrectly set to...Urgent bug fix for the eFEX tau RoIs that cause isTOB to be incorrectly set to false most of the time
There was a change in https://gitlab.cern.ch/atlas/athena/-/merge_requests/46375 with the final format of the eFEX TOB words. One smal...Urgent bug fix for the eFEX tau RoIs that cause isTOB to be incorrectly set to false most of the time
There was a change in https://gitlab.cern.ch/atlas/athena/-/merge_requests/46375 with the final format of the eFEX TOB words. One small change to the flag isTOB was missed. This caused an issue for L1Topo, as found and reported by @paulama . This actually should fix a longstanding issue in the eFEX Tau counts, as reported in https://its.cern.ch/jira/browse/ATR-24204 . Because this is critical, I am marking it as urgent.
Tagging @dzanzi @watsona @nicholashttps://gitlab.cern.ch/atlas/athena/-/merge_requests/47551Updating the jFex OutputCollection2021-10-26T15:44:21+02:00Sergi Rodriguez BoscaUpdating the jFex OutputCollectionThis MR is to update the jFexOutputCollection file. I changed all `new` pointers to `unique_ptr` pointers and with we will avoid memory leaks.This MR is to update the jFexOutputCollection file. I changed all `new` pointers to `unique_ptr` pointers and with we will avoid memory leaks.https://gitlab.cern.ch/atlas/athena/-/merge_requests/60082Updating the jFEX decorator with the masking and new variables2023-01-27T21:42:12+01:00Sergi Rodriguez BoscaUpdating the jFEX decorator with the masking and new variablesThis MR is meant to update the jFEX decorator.
- Now masking is applied to the SCells stored in the CaloCell container. One SCell masked will set its Et to 0
- Can be switched off with the Gaudi variable `SCellMasking` set to false
- ...This MR is meant to update the jFEX decorator.
- Now masking is applied to the SCells stored in the CaloCell container. One SCell masked will set its Et to 0
- Can be switched off with the Gaudi variable `SCellMasking` set to false
- Some modifications have been implemented to the decorator
- Now extra variables can be saved with setting the Gaudi variable `ExtraInfo` to true, default is false
- Two variables have been added `SCellEtMeV` and `TileEtMeV`, summer energy of Scells and Tile energy in MeV
- One variable (`emulated_jtowerEt`) is saved only and just only if the ReadHandleKey is `L1_jFexDataTowers`. This is done to save space in the derivations when the `L1_jFexEmulatedTowers` are written as well. This variables is the emulated/reconstructed **encoded** Et, summing up all the corresponding SCells for LAr or the tile et for Tile detector. It can be compared 1 to 1 with the `et_count` variable if all works fine as we expect