athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2019-01-28T13:52:40+01:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/20094SUSYTools: Update to autoconfigPRWTool2019-01-28T13:52:40+01:00Keisuke YoshiharaSUSYTools: Update to autoconfigPRWTooladditional options to autoconfigPRWTool for users
- RPV mode for special r-tags (r11036-r11038)
- Combined mode (for full-run2 dataset)
- Patch for Znunu metadata (MC16e)
@oabouzeiadditional options to autoconfigPRWTool for users
- RPV mode for special r-tags (r11036-r11038)
- Combined mode (for full-run2 dataset)
- Patch for Znunu metadata (MC16e)
@oabouzeihttps://gitlab.cern.ch/atlas/athena/-/merge_requests/20300Small bugfix in TrackJets overlap removal of SUSYTools2019-01-15T03:03:15+01:00Johannes Junggeburthjohannes.josef.junggeburth@cern.chSmall bugfix in TrackJets overlap removal of SUSYToolsHi @ykeisuke, @oabouzei,
happy new year first of all. During a chat with @pgadow, I noticed that the new feature of the track jet overlap removal has a small bug in it, since the dR is calcutaed via
```
dR^{2} = (eta1 - eta2)^{2} + ...Hi @ykeisuke, @oabouzei,
happy new year first of all. During a chat with @pgadow, I noticed that the new feature of the track jet overlap removal has a small bug in it, since the dR is calcutaed via
```
dR^{2} = (eta1 - eta2)^{2} + (phi1 -phi2)^{2};
```
if jet1 one has phi of pi + depsilon and the oher -phi-depsilon, then the equation above gives roughly 2pi. I also switched from using the auto loop to the iterators directly since this allows us to avoid pairing the jets twice.
I include @schae, @jgonski to this request to have a final pairs of eyes look at this small fix.
Cheers,
Johanneshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/20645SUSYTools: Update to e/gamma trigger SF strings and map file2019-01-29T03:02:55+01:00Keisuke YoshiharaSUSYTools: Update to e/gamma trigger SF strings and map file- update to the e/gamma map file (Consolidation_September2018_v1/map3.txt)
- update to e/gamma trigger strings (TRI_E_XXX and MULTI_L_XXX chains)
cc @oabouzei , @jmaurer , @dantrim- update to the e/gamma map file (Consolidation_September2018_v1/map3.txt)
- update to e/gamma trigger strings (TRI_E_XXX and MULTI_L_XXX chains)
cc @oabouzei , @jmaurer , @dantrimhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/20690SUSYTools: Workaround for Egamma ID bug (ATLSUSYSW-445)2019-02-08T22:37:03+01:00Hass AbouzeidSUSYTools: Workaround for Egamma ID bug (ATLSUSYSW-445)Due to an issue with some Egamma working points in certain pt/eta bins
a workaround is needed in order to guaruntee loose looser than medium, and
medium looser than tight. This is applied only for the default case
where the input bei...Due to an issue with some Egamma working points in certain pt/eta bins
a workaround is needed in order to guaruntee loose looser than medium, and
medium looser than tight. This is applied only for the default case
where the input being run over has the needed DFCommon variables in
the DAOD. SFs are not changed.
cc @ykeisukehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/21110SUSYTools: addressing ATLSUSYSW tickets2019-02-19T03:02:29+01:00Keisuke YoshiharaSUSYTools: addressing ATLSUSYSW tickets* fJVTtool name (ATLSUSYSW-411)
* tool name needs to be unique in BTagEffTool for charm tagging (ATLSUSYSW-427)
* high-pt Isolation WP threshold to be configurable
* fat jet calib/unc can be turned off if not needed by setting None(A...* fJVTtool name (ATLSUSYSW-411)
* tool name needs to be unique in BTagEffTool for charm tagging (ATLSUSYSW-427)
* high-pt Isolation WP threshold to be configurable
* fat jet calib/unc can be turned off if not needed by setting None(ATLSUSYSW-446)
* Jet.LargeRcollection: None
* Jet.LargeRuncConfig: None
* Jet.WtaggerConfig: None
* Jet.ZtaggerConfig: None
* PathResolverFindCalibDirectory to FindFile (ATLSUSYSW-448)
* autoconfigPRW (+ small cleanup)
* CrossSectionDB (+ small cleanup)
* swapped arguments in autoconfigurePRWTool (ATLSUSYSW-449)
* lepton (both muons and electrons) isolation fall-back WPs are no longer needed
* lepton isolation decorations are added back for the photons/electrons/muons (ATLSUSYSW-451)
* OriginalObjectLink was missing in GetJetSyst method (ATLSUSYSW-452)
* name change for the low-pt muon isolation WP (https://gitlab.cern.ch/atlas/athena/merge_requests/21162/)
* update to electron charge ID SFs (all Iso WPs are supported for MediumLLH and TightLLH)
@oabouzeihttps://gitlab.cern.ch/atlas/athena/-/merge_requests/21162Update isolation scale-factor recommendation for low-pt muons in SUSYTools2019-02-17T13:07:30+01:00Johannes Junggeburthjohannes.josef.junggeburth@cern.chUpdate isolation scale-factor recommendation for low-pt muons in SUSYToolsHi @ykeisuke and @oabouzei,
MCP has released its latest set of recommendations. One of the major changes in that round is that for isolation scale-factors the particle-id working point matters if people are using low-pt muons. For this ...Hi @ykeisuke and @oabouzei,
MCP has released its latest set of recommendations. One of the major changes in that round is that for isolation scale-factors the particle-id working point matters if people are using low-pt muons. For this one a different scale-factor map is loaded than for the others.
Cheers,
Johanneshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/21246SUSYTools: fix a typo in GetFatJets2019-02-20T03:02:39+01:00Keisuke YoshiharaSUSYTools: fix a typo in GetFatJetsfound a stupid typo to be fixed in GetFatJets
cc @oabouzeifound a stupid typo to be fixed in GetFatJets
cc @oabouzeihttps://gitlab.cern.ch/atlas/athena/-/merge_requests/21648SUSYTools: muon high-pt isolation configurable2019-03-15T15:48:34+01:00Keisuke YoshiharaSUSYTools: muon high-pt isolation configurable* New 2018 GRL (v102-pro22-04) is now deployed
* Muon reco/iso/SF is now fully supported down to 3GeV [(MCP twiki)](https://twiki.cern.ch/twiki/bin/view/AtlasProtected/MCPAnalysisWinterMC16#Setup_1_correct_data_for_sagitta)
* Muon iso...* New 2018 GRL (v102-pro22-04) is now deployed
* Muon reco/iso/SF is now fully supported down to 3GeV [(MCP twiki)](https://twiki.cern.ch/twiki/bin/view/AtlasProtected/MCPAnalysisWinterMC16#Setup_1_correct_data_for_sagitta)
* Muon isolation can be configurable for low-pt and high-pt muons (ATLSUSYSW-455)
* fJVT decision has to be propagated to the tool name (ATLSUSYSW-411)
* Fiducial eta cut should use EtaBE(2) for electrons and photons [(e/gamma twiki)](https://twiki.cern.ch/twiki/bin/view/AtlasProtected/EGammaIdentificationRun2#kinematicselectrons)
cc @oabouzeihttps://gitlab.cern.ch/atlas/athena/-/merge_requests/21691SUSYTools: OutputLevel can be set uniformly2019-03-15T15:49:30+01:00Keisuke YoshiharaSUSYTools: OutputLevel can be set uniformly* OutputLevel can be set uniformly for all CP tools (ATLSUSYSW-458)
cc @oabouzei* OutputLevel can be set uniformly for all CP tools (ATLSUSYSW-458)
cc @oabouzeihttps://gitlab.cern.ch/atlas/athena/-/merge_requests/21705Revert "Merge branch 'athena-my21.2-2019-03-06' into '21.2'"2019-03-07T14:57:31+01:00Nils Erik KrumnackRevert "Merge branch 'athena-my21.2-2019-03-06' into '21.2'"This reverts merge request !21691
That one broke stuff, so let's revert it.This reverts merge request !21691
That one broke stuff, so let's revert it.https://gitlab.cern.ch/atlas/athena/-/merge_requests/21841SUSYTools: period-dependent trigger SF for 2e172019-03-15T15:48:36+01:00Keisuke YoshiharaSUSYTools: period-dependent trigger SF for 2e17- as title says, period dependent trigger SF for 2e17 is finally added, following ([TrigGlobalEfficiencyToolExample](https://gitlab.cern.ch/atlas/athena/blob/21.2/Trigger/TrigAnalysis/TrigGlobalEfficiencyCorrection/examples/TrigGlobEffCo...- as title says, period dependent trigger SF for 2e17 is finally added, following ([TrigGlobalEfficiencyToolExample](https://gitlab.cern.ch/atlas/athena/blob/21.2/Trigger/TrigAnalysis/TrigGlobalEfficiencyCorrection/examples/TrigGlobEffCorrExample1.cxx#L165))
cc @oabouzei , @jmaurerhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/21934SUSYTools: Updates for trig uncertainties and pileup autoconfig2019-03-21T11:59:43+01:00Hass AbouzeidSUSYTools: Updates for trig uncertainties and pileup autoconfigUpdate of trig uncertainties: Previously, this was not done, resulting in the systematics for
electron single lepton triggers not having the proper systematics
applied in some cases. Adding this to the systematics classification
shoul...Update of trig uncertainties: Previously, this was not done, resulting in the systematics for
electron single lepton triggers not having the proper systematics
applied in some cases. Adding this to the systematics classification
should fix the issue.
Updates for pileup autoconfig: EL jobs no longer have metadata access during initialize. For the time being, a new property has been added for users to specify the mcChannel number manually of their samples to get around this. Appropriate ART tests have also been updated.
cc @ykeisukehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/22349SUSYTools: Update actualMu file for 2018 and workaround for ATLSUSYSW-4632019-04-04T03:03:15+02:00Hass AbouzeidSUSYTools: Update actualMu file for 2018 and workaround for ATLSUSYSW-463* Update 2018 actualMu file (ATLSUSYSW-466)
* Workaround for ATLSUSYSW-463 due to AF2 SF unavailability for triggers
cc @ykeisuke* Update 2018 actualMu file (ATLSUSYSW-466)
* Workaround for ATLSUSYSW-463 due to AF2 SF unavailability for triggers
cc @ykeisukehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/22759Adding Overlap Removal flag for PFlow jets that are muons2019-04-18T03:03:13+02:00Christopher YoungAdding Overlap Removal flag for PFlow jets that are muonsAdding Overlap Removal flag for PFlow jets that will remove jets that are actually from muon id tracks.
Full details of the bug and solution are in this merge request
https://gitlab.cern.ch/atlas/athena/merge_requests/22703Adding Overlap Removal flag for PFlow jets that will remove jets that are actually from muon id tracks.
Full details of the bug and solution are in this merge request
https://gitlab.cern.ch/atlas/athena/merge_requests/22703https://gitlab.cern.ch/atlas/athena/-/merge_requests/22855SUSYTools: turning ilumi2histo into a function2019-04-23T03:02:33+02:00Keisuke YoshiharaSUSYTools: turning ilumi2histo into a function- update to ilumi2histo.py
this doesn't affect SUSYTools when running any event processing, but it's a touch-up of a utility script (helpful for making cross-check plots)
cc @oabouzei , @whopkins- update to ilumi2histo.py
this doesn't affect SUSYTools when running any event processing, but it's a touch-up of a utility script (helpful for making cross-check plots)
cc @oabouzei , @whopkinshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/23333downgrade warning to INFO since it doesn't seem important2019-05-23T11:09:44+02:00Dan Guestdowngrade warning to INFO since it doesn't seem importantHaving spent a while trying to track down the meaning of this warning
```
ToolSvc.SUSYTools WARNING Your baseline tau - lep OR/Veto settings look suspicious! You have enabled tau-e/mu OR (cone based), but set (EleOLR,MuonOLR)=(0,0) i...Having spent a while trying to track down the meaning of this warning
```
ToolSvc.SUSYTools WARNING Your baseline tau - lep OR/Veto settings look suspicious! You have enabled tau-e/mu OR (cone based), but set (EleOLR,MuonOLR)=(0,0) in your config file! PLEASE CHECK!
```
I can only conclude that this isn't very important: quoting a few people I've asked, we have (@ykeisuke)
```
Just ignoring the warning or set tau-lep OR to false should eliminate the warning
```
and according to @jojungge
```
In principle, you buy the risk of fake-taus which are in fact electrons or muons. I've observed this as well in the XAMPPmultilep && XAMPPstau packages and ignored it quite successful
```
I don't think we should have warnings if the expert advice is to ignore them, so I'm changing it to `INFO`.https://gitlab.cern.ch/atlas/athena/-/merge_requests/23588SUSYTools: JET/MET recommendations2019-05-25T03:03:00+02:00Keisuke YoshiharaSUSYTools: JET/MET recommendations* IsPFlowCrackVetoCleaning flag to check the association of topoclusters in the crack region
* New JesCalibSeq configs for EMTopo (FullSim/AFII) and EMPFlow (FullSim/AFII)
* JVT WP is changed from "Medium" to "Default"
* Top/W/Z tagg...* IsPFlowCrackVetoCleaning flag to check the association of topoclusters in the crack region
* New JesCalibSeq configs for EMTopo (FullSim/AFII) and EMPFlow (FullSim/AFII)
* JVT WP is changed from "Medium" to "Default"
* Top/W/Z taggers for R21
* defaulting to SmoothedWZTaggers (3 variables) to be used with TCC jets
* defaulting to JSSWTopTaggerDNN (inclusive) to be used with LCTopo jets
* remove warning msg from inconsistency between tau-lepton OR and TauSelectionTool (https://gitlab.cern.ch/atlas/athena/merge_requests/23333)
* SUSYToolsTester cleanup
* atlas messaging
* jetInputType check for PFlow jets
cc @oabouzeihttps://gitlab.cern.ch/atlas/athena/-/merge_requests/23590SUSYTools: Updates for ECID SFs, ART tests2019-05-29T03:02:59+02:00Hass AbouzeidSUSYTools: Updates for ECID SFs, ART tests* Add new ART tests
* Use new rel21 ECID SFs
* Remove outdated/deprecated procID for cross-section queries (left commented out for reference purposes)
cc @ykeisuke* Add new ART tests
* Use new rel21 ECID SFs
* Remove outdated/deprecated procID for cross-section queries (left commented out for reference purposes)
cc @ykeisukehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/23698SUSYTools: extra protections for compressed EWK searches2019-05-29T03:02:54+02:00Julia Lynne GonskiSUSYTools: extra protections for compressed EWK searchesConsolidating various hacks and additions that we've made to SUSYTools for the compressed EWK analysis, for ease of eventual analysis preservation and combinations. Two extra protections are added to account for crashes that came up (jus...Consolidating various hacks and additions that we've made to SUSYTools for the compressed EWK analysis, for ease of eventual analysis preservation and combinations. Two extra protections are added to account for crashes that came up (justifications in line). We also have four updated cross section files that I've been adding by hand into our local SUSYTools, but unsure if these have been added to PMG and/or elsewhere and this is actually redundant.
Tagging @oabouzei, @ykeisuke, @jmiguens, @szambito, as well as @miholzbo and @jshahini who might know more about the cross section situation.
Thanks!https://gitlab.cern.ch/atlas/athena/-/merge_requests/23838SUSYTools: update to check-daod-stats.py2019-06-06T09:35:09+02:00Keisuke YoshiharaSUSYTools: update to check-daod-stats.py- update to check-daod-stats.py (ATLSUSYSW-476)
- Znunu patch is now expanded to all MC16 campaign
- remove auto where possible
@oabouzei- update to check-daod-stats.py (ATLSUSYSW-476)
- Znunu patch is now expanded to all MC16 campaign
- remove auto where possible
@oabouzei