athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2021-10-24T17:29:45+02:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/47051Add CA-based VolumeDebugger UserAction config2021-10-24T17:29:45+02:00Nicholas StylesAdd CA-based VolumeDebugger UserAction configAdd ```VolumeDebugger``` configurations, plus a few pre-defined options for volumes to run it on as ```PostIncludes```.
As always with configurations involving adding ```UserActions```, the configuration here is pretty complicated. In p...Add ```VolumeDebugger``` configurations, plus a few pre-defined options for volumes to run it on as ```PostIncludes```.
As always with configurations involving adding ```UserActions```, the configuration here is pretty complicated. In principle, it seems like this really ought to be possible to streamline, but whatever I tried didn't seem to work, so it people have specific suggestions I'm happy to try them.https://gitlab.cern.ch/atlas/athena/-/merge_requests/47040Properly define ITk volumes to G42021-10-11T21:43:36+02:00Tadej Novaktadej.novak@cern.chProperly define ITk volumes to G4ITk now uses `ITK` global envelope and not `IDET`. Try to migrate all the clients and add some handling to debugging tools.
/cc @jchapman @nstyles @mbandier @dellacquITk now uses `ITK` global envelope and not `IDET`. Try to migrate all the clients and add some handling to debugging tools.
/cc @jchapman @nstyles @mbandier @dellacquhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/47006Remove recAlgs.doTrigger flag2021-10-09T19:07:15+02:00Frank WinklmeierRemove recAlgs.doTrigger flagThe `recAlgs.doTrigger` flag is obsolete with the Run-3 trigger. Remove the flag (was already `False` by default) and all code referencing it. Also delete the now unused `TransientBS_DetFlags.py`.
Relates to ATR-22725. cc @rbielskiThe `recAlgs.doTrigger` flag is obsolete with the Run-3 trigger. Remove the flag (was already `False` by default) and all code referencing it. Also delete the now unused `TransientBS_DetFlags.py`.
Relates to ATR-22725. cc @rbielskihttps://gitlab.cern.ch/atlas/athena/-/merge_requests/47005adjust reference of test___LArPileUpTool_properties2021-10-09T19:05:03+02:00Walter Lampladjust reference of test___LArPileUpTool_propertiesFix the unit-test of Simulation/Digitization failing in the current master nightly.
cc @fwinklFix the unit-test of Simulation/Digitization failing in the current master nightly.
cc @fwinklhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/46997TrigConfigSvc: delete TrigConfigSvc service2021-10-09T19:07:21+02:00Frank WinklmeierTrigConfigSvc: delete TrigConfigSvc serviceAfter the removal of the legacy menu support and the migration of all
clients (e.g. using `xAODConfigSvc`), the `TrigConfigSvc` only
functioned as a wrapper to create the LVL1/HLTConfigSvc. This is no
longer needed as these services are ...After the removal of the legacy menu support and the migration of all
clients (e.g. using `xAODConfigSvc`), the `TrigConfigSvc` only
functioned as a wrapper to create the LVL1/HLTConfigSvc. This is no
longer needed as these services are created explicitly where needed.
Also delete obsolete `TrigConfigSvcConfig.py`.
Further cleanup and removal of the Run-2 compatibility code in `TriggerConfigGetter.py` will follow in a separate MR. For the moment, maintain the current functionality.
Relates to ATR-23102.https://gitlab.cern.ch/atlas/athena/-/merge_requests/46989Switched LArHitsTestTool to reading CaloDetDescrManager from the Detector Store2021-10-08T02:14:32+02:00Vakhtang TsulaiaSwitched LArHitsTestTool to reading CaloDetDescrManager from the Detector StoreThis patch is required for fixing failed ART test, which broke because of the
latest update in `LArHitsTestTool`. In the long term, though, we need to revisit
the `CaloDetDescrManager` usage patterns in Simulation in order to determine w...This patch is required for fixing failed ART test, which broke because of the
latest update in `LArHitsTestTool`. In the long term, though, we need to revisit
the `CaloDetDescrManager` usage patterns in Simulation in order to determine whether
it is really needed to construct it by the converter at initialization.
Fixes ATLASSIM-5432https://gitlab.cern.ch/atlas/athena/-/merge_requests/46950OverlayByteStreamUtils: Fix clang warning.2021-10-06T15:44:33+02:00Scott SnyderOverlayByteStreamUtils: Fix clang warning.Unused private data member.Unused private data member.https://gitlab.cern.ch/atlas/athena/-/merge_requests/46938G4AtlasUtilities: delete empty directory2021-10-05T21:43:07+02:00Frank WinklmeierG4AtlasUtilities: delete empty directoryDelete obsolete `G4AtlasUtilities` directory (only contained one obsolete `packagedoc.h` file).Delete obsolete `G4AtlasUtilities` directory (only contained one obsolete `packagedoc.h` file).https://gitlab.cern.ch/atlas/athena/-/merge_requests/46931Dropped GeoLArHit2021-10-05T15:44:07+02:00Vakhtang TsulaiaDropped GeoLArHitThe benefits coming from the usage of this class are rather questionable. On the other hand, it uses AthenaMT-unfriendly way of retrieving a pointer to the `CaloDetDescrManager` and caching it.
The clients of `GeoLArHit` had been sw...The benefits coming from the usage of this class are rather questionable. On the other hand, it uses AthenaMT-unfriendly way of retrieving a pointer to the `CaloDetDescrManager` and caching it.
The clients of `GeoLArHit` had been switched to the direct usage of `LArHit` and `CaloDetDescrManager` interfaces, and subsequently, the `GeoLArHit` class was dropped.
The migration of individual client classes were implemented in separate commits in order to facilitate the code review.https://gitlab.cern.ch/atlas/athena/-/merge_requests/46926RDOAnalysis: cmake fix2021-10-06T15:44:24+02:00Scott SnyderRDOAnalysis: cmake fixRemove reference to nonexistent root library Table.Remove reference to nonexistent root library Table.https://gitlab.cern.ch/atlas/athena/-/merge_requests/46869Fix trigger filter for data overlay2021-10-02T21:42:44+02:00Frank WinklmeierFix trigger filter for data overlayRewrite the `BSFilter` algorithm to use the `TrigDecisionTool` for
trigger-based event filtering on RAW. This ensure compatibility with
past and future data. Change the `--triggerBit` transform argument from
the CTP ID (240) to the CTP i...Rewrite the `BSFilter` algorithm to use the `TrigDecisionTool` for
trigger-based event filtering on RAW. This ensure compatibility with
past and future data. Change the `--triggerBit` transform argument from
the CTP ID (240) to the CTP item name ("L1_ZB"), which is guaranteed to
work also if the item ID changes.
Also apply some general code cleanups.
Closes ATLASSIM-5419.https://gitlab.cern.ch/atlas/athena/-/merge_requests/46863configs, bugfixes and patching of rdo identifiers to have reco running with f...2021-10-26T15:04:28+02:00Alexander Leopoldconfigs, bugfixes and patching of rdo identifiers to have reco running with full digi inputI am proposing here a fix to keep working with the current sim structures to have RDO identifiers after full digi being usable for reco. This way we can keep using the produced HITS files and keep working in R21, while it should be clean...I am proposing here a fix to keep working with the current sim structures to have RDO identifiers after full digi being usable for reco. This way we can keep using the produced HITS files and keep working in R21, while it should be cleaned up in master.
I ran on 500 single muons to check if the chi2 I get from the extension look good (so the `HGTD_Cluster` are in the right position after retrieving the RDOs), and that worked fine as far as I can tell. More in depth validation is still needed.
In addition, I am adding a couple of fixes to have everything running (similar to what was in [MR 46526](https://gitlab.cern.ch/atlas/athena/-/merge_requests/46526).
Tagging @tadej @ncalace @nstyles @cohm @dshope for feedback.Alexander LeopoldAlexander Leopoldhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/46839Fixes for the differences between CA vs old style tests2021-10-04T21:45:06+02:00Tulay Cuhadar DonszelmannFixes for the differences between CA vs old style testsFix a few differences observed during the comparison of fast chain test with CA-based and old style config. Some more differences still to be understood.
@jchapman, @golling, @lmijovicFix a few differences observed during the comparison of fast chain test with CA-based and old style config. Some more differences still to be understood.
@jchapman, @golling, @lmijovichttps://gitlab.cern.ch/atlas/athena/-/merge_requests/46809Basic tests for supported CA-based ISF simulators part 1 (FullG4MT_QS, PassBa...2021-10-04T15:44:16+02:00John Derek ChapmanBasic tests for supported CA-based ISF simulators part 1 (FullG4MT_QS, PassBackG4MT, ATLFASTIIMT)The output of jobs using the CA-based configuration for `FullG4MT_QS`, `PassBackG4MT` and `ATLFASTIIMT`
now matches the output of jobs using the old-style configuration. (Even though far fewer conditions folders are loaded.)
Tests have...The output of jobs using the CA-based configuration for `FullG4MT_QS`, `PassBackG4MT` and `ATLFASTIIMT`
now matches the output of jobs using the old-style configuration. (Even though far fewer conditions folders are loaded.)
Tests have been added for `ATLFASTIIF_G4MS`, `ATLFAST3MT` and `ATLFAST3MT_QS`, but these have not been activated yet.
This MR should go in after !46575 and !46808.https://gitlab.cern.ch/atlas/athena/-/merge_requests/46808Fix CA-based configuration when running FullG4MT2021-09-29T21:43:38+02:00John Derek ChapmanFix CA-based configuration when running FullG4MTFYI @tadej and @nstyles.FYI @tadej and @nstyles.https://gitlab.cern.ch/atlas/athena/-/merge_requests/46768Decoupling config option to run radiation damage simulation for planar and 3D...2021-10-28T21:45:29+02:00Tomas DadoDecoupling config option to run radiation damage simulation for planar and 3D sensors for pixelCurrently, setting `doRadiationDamage` flag to True in the digitization jobs tells the code to run the radiation damage simulation for both Planar and 3D pixel sensors. However, 3D sensors are outside of the tracking acceptance but they ...Currently, setting `doRadiationDamage` flag to True in the digitization jobs tells the code to run the radiation damage simulation for both Planar and 3D pixel sensors. However, 3D sensors are outside of the tracking acceptance but they take a significant portion of the computing time.
This MR allows to set the flag separately for Planar and 3D sensors that allows to run the radiation damage simulation for the Planar sensors for all physics analyses (and save time by not running the 3D radiation damage simulation) while having the option to run the 3D sensor radiation damage simulation for relevant pixel internal studies.
Both flags are set to `False` by default to be comaptible with the previous settings.
I also took the opportunity to change the rather vague `doRadiationDamage` flag to more concrete `doPixelPlanarRadiationDamage` (and `doPixel3DRadiationDamage`) flag.
To reproduce the behaviour of the previous JO configuration, once these changes are merged, one would need to change
```
digitizationFlags.doRadiationDamage.set_Value_and_Lock(True);
```
To
```
digitizationFlags.doPixelPlanarRadiationDamage.set_Value_and_Lock(True); digitizationFlags.doPixel3DRadiationDamage.set_Value_and_Lock(True);
```
Tagging @tadej @mbomben @stsuno @mkocian @battagl @mociduki @zmarshal
Keeping as draft to let the experts comment on the changeshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/46723Support Quasi-stable particle simulation in ComponentAccumulator-based Config...2021-09-28T21:43:51+02:00John Derek ChapmanSupport Quasi-stable particle simulation in ComponentAccumulator-based Configuration(Follows on from !46570.)
CA-based configuration changes to properly support FullG4MT_QS configuration.
Add test_RUN3Sym_FullG4MT_QS_ttbar_CAvsCG.sh ART test to confirm this.
This also removed the legacy MC12G4 configurations, which ar...(Follows on from !46570.)
CA-based configuration changes to properly support FullG4MT_QS configuration.
Add test_RUN3Sym_FullG4MT_QS_ttbar_CAvsCG.sh ART test to confirm this.
This also removed the legacy MC12G4 configurations, which are no longer supported.https://gitlab.cern.ch/atlas/athena/-/merge_requests/46720update the conditions tags and RDOs for reco jobs and fix the issue for...2021-09-27T21:43:48+02:00Ke Liupdate the conditions tags and RDOs for reco jobs and fix the issue for...update the conditions tags and RDOs for reco jobs and fix the issue for RDOAnalysis for sim+reco jobs.
This MR should fix the failed reco and simreco jobs except for single electron (10GeV) and ttbar.
Ping @goblirsc , @vcairo and @gfac...update the conditions tags and RDOs for reco jobs and fix the issue for RDOAnalysis for sim+reco jobs.
This MR should fix the failed reco and simreco jobs except for single electron (10GeV) and ttbar.
Ping @goblirsc , @vcairo and @gfacini .https://gitlab.cern.ch/atlas/athena/-/merge_requests/46689L1Topo: remove obsolete XML menu reading code2021-09-27T15:44:51+02:00Frank WinklmeierL1Topo: remove obsolete XML menu reading codeRemove all code and testing files related to the obsolete XML LVL1
format. Only JSON is supported in Run-3.
Relates to ATR-23102.Remove all code and testing files related to the obsolete XML LVL1
format. Only JSON is supported in Run-3.
Relates to ATR-23102.https://gitlab.cern.ch/atlas/athena/-/merge_requests/46642Support appending auxiliary inputs e.g. minbias samples2021-09-22T15:44:26+02:00Tadej Novaktadej.novak@cern.chSupport appending auxiliary inputs e.g. minbias samplesThe second part of Run 3 pile-up/beamspot handling support in transforms. We also need to provide different minimum bias inputs. This is achieved by using the `append` functionality of the `ArgumentParser`.
/cc @jchapman @mduehrss @tlar...The second part of Run 3 pile-up/beamspot handling support in transforms. We also need to provide different minimum bias inputs. This is achieved by using the `append` functionality of the `ArgumentParser`.
/cc @jchapman @mduehrss @tlari @tsulaia