athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2021-09-22T15:44:54+02:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/46632Update PDGHelpers.getPDGTABLE module to use functional.lru_cache2021-09-22T15:44:54+02:00John Derek ChapmanUpdate PDGHelpers.getPDGTABLE module to use functional.lru_cacheCaching the result of PDGHelpers.getPDGTABLE should ensure that a "clean" PDGTABLE.MeV
file is only retrieved once per job. This approach should also be compatible with
ComponentAccumulator-based configuration.Caching the result of PDGHelpers.getPDGTABLE should ensure that a "clean" PDGTABLE.MeV
file is only retrieved once per job. This approach should also be compatible with
ComponentAccumulator-based configuration.https://gitlab.cern.ch/atlas/athena/-/merge_requests/46616Sweeping !46600 from 22.0-mc20 to master.
Fix bug in MergeTruthJetsTool where...2021-09-22T15:43:32+02:00Atlas NightlybuildSweeping !46600 from 22.0-mc20 to master.
Fix bug in MergeTruthJetsTool where only the first event from each bunch-crossing was checked.Fix bug in MergeTruthJetsTool where only the first event from each bunch-crossing was checked.
See merge request atlas/athena!46600Fix bug in MergeTruthJetsTool where only the first event from each bunch-crossing was checked.
See merge request atlas/athena!46600https://gitlab.cern.ch/atlas/athena/-/merge_requests/46615Sweeping !46603 from 22.0-mc20 to master.
Enable updated TGC conditions for MC202021-09-22T15:42:43+02:00Atlas NightlybuildSweeping !46603 from 22.0-mc20 to master.
Enable updated TGC conditions for MC20Enable updated TGC conditions for MC20
See merge request atlas/athena!46603Enable updated TGC conditions for MC20
See merge request atlas/athena!46603https://gitlab.cern.ch/atlas/athena/-/merge_requests/46607Sweeping !46580 from 22.0-mc20 to master.
RecJobTransforms+SimuJobTransforms:...2021-09-22T15:45:29+02:00Atlas NightlybuildSweeping !46580 from 22.0-mc20 to master.
RecJobTransforms+SimuJobTransforms: Update the job skeleton logic that overwrites the file compression settingsRecJobTransforms+SimuJobTransforms: Update the job skeleton logic that overwrites the file compression settings
See merge request atlas/athena!46580RecJobTransforms+SimuJobTransforms: Update the job skeleton logic that overwrites the file compression settings
See merge request atlas/athena!46580https://gitlab.cern.ch/atlas/athena/-/merge_requests/46603Enable updated TGC conditions for MC202021-09-22T11:00:37+02:00Tadej Novaktadej.novak@cern.chEnable updated TGC conditions for MC20Enable updated TGC conditions for MC20 by default.
/cc @jchapman @pberta @rmazini @emoyse @elmsheus @demers @smwang @jferrandEnable updated TGC conditions for MC20 by default.
/cc @jchapman @pberta @rmazini @emoyse @elmsheus @demers @smwang @jferrandhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/46600Fix bug in MergeTruthJetsTool where only the first event from each bunch-cros...2021-09-22T11:01:15+02:00John Derek ChapmanFix bug in MergeTruthJetsTool where only the first event from each bunch-crossing was checked.This one is needed for the Presampled RDO production for the Run-2 Reprocessing.
Thanks to @dandoy for spotting this bug which had been lurking for 3 years!
FYI @tlari, @mduehrss, @tadej, @pberta, @rmazini, @emoyse, @elmsheusThis one is needed for the Presampled RDO production for the Run-2 Reprocessing.
Thanks to @dandoy for spotting this bug which had been lurking for 3 years!
FYI @tlari, @mduehrss, @tadej, @pberta, @rmazini, @emoyse, @elmsheushttps://gitlab.cern.ch/atlas/athena/-/merge_requests/46599Dropped LArIdManager2021-09-22T15:43:39+02:00Vakhtang TsulaiaDropped LArIdManagerThis class is being used by handful of clients only for retrieving various ID helpers.
These helpers can be directly retrieved from the Detector Store, hence `LArIdManager` can
be dropped.
Also dropped the converter for this class, and ...This class is being used by handful of clients only for retrieving various ID helpers.
These helpers can be directly retrieved from the Detector Store, hence `LArIdManager` can
be dropped.
Also dropped the converter for this class, and cleaned ref files.
This MR consists of two commits: the first one removes the `LArIdManager` class, its converter, and all references to them from `.h,.cxx` files. The second commit cleans ref files.https://gitlab.cern.ch/atlas/athena/-/merge_requests/46589TGC Digitization: Implementation of signal propagation time between the senso...2022-06-08T15:30:58+02:00Tadej Novaktadej.novak@cern.chTGC Digitization: Implementation of signal propagation time between the sensor edge and ASD (sweep from MC20)This is a manual sweep of !46540 due to some obscure (5 year old!) conflicts.
Original text:
Add the new db system to fix the missing timing calculation at the TGC_Digitization stage between the sensor edge and the ASD. TGC_Digitizatio...This is a manual sweep of !46540 due to some obscure (5 year old!) conflicts.
Original text:
Add the new db system to fix the missing timing calculation at the TGC_Digitization stage between the sensor edge and the ASD. TGC_Digitization retrive the information of the distance between the sensor edge and ASD from the condition db. Condition algorithm (TGCDigitASDposDbAlg) and condition object (TGCDigitASDposData) have been added to manage the condition data in AthenaMT. TGC_Digitization has been modified to use the new TGCDigitASDposDbAlg and TGCDigitASDposData and added the method to calculate of signal propagation time from sensor edge to the ASD. The compilation is fine, no errors or warnings. The test has been done locally.
/cc @jchapman @teramura @junpeihttps://gitlab.cern.ch/atlas/athena/-/merge_requests/46580RecJobTransforms+SimuJobTransforms: Update the job skeleton logic that overwr...2021-11-09T09:23:00+01:00Alaettin Serhan MeteRecJobTransforms+SimuJobTransforms: Update the job skeleton logic that overwrites the file compression settingsAs discussed in ATLASJT-421, some job skeletons have hooks that overwrite the output file compression settings. Any file that's produced w/ the `HITtoRDO`, `RAWtoESD`, `ESDtoAOD`, and `RAWtoALL` skeletons in conjunction with an output na...As discussed in ATLASJT-421, some job skeletons have hooks that overwrite the output file compression settings. Any file that's produced w/ the `HITtoRDO`, `RAWtoESD`, `ESDtoAOD`, and `RAWtoALL` skeletons in conjunction with an output name that contains `_000` and/or `tmp.` will have `ZLIB` compression (as opposed to `LZMA` for the `AOD`s etc). This causes some files that are produced by the production system to have wrong compression settings, e.g. `recon AOD`s. While this MR doesn't completely eliminate the issue, it fixes the problem mentioned in the ticket.
There'll be a separate MR for the CA-based configuration but that'll go to the master branch-only.
cc: @gemmeren, @elmsheus, @tadejhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/46575ComponentAccumulator-based configuration for the ReSimulation Workflow2021-09-29T21:42:41+02:00John Derek ChapmanComponentAccumulator-based configuration for the ReSimulation WorkflowBuilding on the changes in atlas/athena!42615. This merge request implements the
ReSimulation workflow in CA-based configuration.Building on the changes in atlas/athena!42615. This merge request implements the
ReSimulation workflow in CA-based configuration.https://gitlab.cern.ch/atlas/athena/-/merge_requests/46570Reading specialConfig metadata in CA-based configurations2021-11-16T17:11:19+01:00John Derek ChapmanReading specialConfig metadata in CA-based configurationsThis merge request re-implements the input file metadata-based specialConfigurations
for simulation and digitization used for SUSY and exotics samples.
They now share a single ConfigFlag: `flags.Input.SpecialConfiguration`
which is a di...This merge request re-implements the input file metadata-based specialConfigurations
for simulation and digitization used for SUSY and exotics samples.
They now share a single ConfigFlag: `flags.Input.SpecialConfiguration`
which is a dictionary filled automatically based on peeking at the input file
metadata via `MetaReader`. Any old-style preIncludes listed in the specialConfig metadata are
converted into the corresponding preInclude and postInclude functions.
Extra-hooks to execute these methods are added to the CA-based skeleton modules in the
`SimuJobTransforms` package.
Initially the methods themselves are contained in modules in the relevant
`G4Extensions` packages, but potentially these could be moved elsewhere in the future.
ART jobs comparing the output of CG- and CA-based configurations are also added. Support for Rhadrons jobs will be added in a separate MR.
As part of this work the CA-based configuration of the `PhysicsListSvc` was also cleaned-up.https://gitlab.cern.ch/atlas/athena/-/merge_requests/46565LArGeoCode+LArGeoRAL+LArG4Barrel+LArG4EC: Make VDetectorParameters const.2021-09-17T09:44:00+02:00Scott SnyderLArGeoCode+LArGeoRAL+LArG4Barrel+LArG4EC: Make VDetectorParameters const.Make uses of VDetectorParameters const.Make uses of VDetectorParameters const.https://gitlab.cern.ch/atlas/athena/-/merge_requests/46547Fix for TRTSensitiveDetector when using the G4GammaGeneralProcess2021-09-17T21:44:08+02:00John Derek ChapmanFix for TRTSensitiveDetector when using the G4GammaGeneralProcesshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/46544Updating code for ITk tracking geometry material map creation2021-09-21T21:42:49+02:00Noemi CalaceUpdating code for ITk tracking geometry material map creationSelf-explanatory name.Self-explanatory name.Noemi CalaceNoemi Calacehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/46540TGC Digitization: Implementation of signal propagation time between the senso...2021-10-04T09:32:41+02:00Tadej Novaktadej.novak@cern.chTGC Digitization: Implementation of signal propagation time between the sensor edge and ASDThis is a cleaned-up version of !46515 which does not change the output. A flag still needs to be added to toggle the functionality.
Add the new db system to fix the missing timing calculation at the TGC_Digitization stage between the s...This is a cleaned-up version of !46515 which does not change the output. A flag still needs to be added to toggle the functionality.
Add the new db system to fix the missing timing calculation at the TGC_Digitization stage between the sensor edge and the ASD. TGC_Digitization retrive the information of the distance between the sensor edge and ASD from the condition db. Condition algorithm (TGCDigitASDposDbAlg) and condition object (TGCDigitASDposData) have been added to manage the condition data in AthenaMT. TGC_Digitization has been modified to use the new TGCDigitASDposDbAlg and TGCDigitASDposData and added the method to calculate of signal propagation time from sensor edge to the ASD. The compilation is fine, no errors or warnings. The test has been done locally.
/cc @junpei @teramura @jchapman @jojunggehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/46537SLHC cleaning2021-09-21T15:52:25+02:00Thomas StreblerSLHC cleaningThis MR removes a lot of the SLHC customisations in InDet configurations which are superseded by the CA-based configs, required to run the ITk reconstruction. SLHC labels are also replaced with ITk when appropriate.
FYI @ncalace @nstyle...This MR removes a lot of the SLHC customisations in InDet configurations which are superseded by the CA-based configs, required to run the ITk reconstruction. SLHC labels are also replaced with ITk when appropriate.
FYI @ncalace @nstyles @pagessin @lgagnon @tadej @npettershttps://gitlab.cern.ch/atlas/athena/-/merge_requests/46519Make output POOL settings in CA-based config more flexible2021-09-16T21:42:43+02:00Tadej Novaktadej.novak@cern.chMake output POOL settings in CA-based config more flexibleMake output POOL settings in CA-based config more flexible. All temporary files now use lower compression (which I suppose is what we want). `TreeAutoFlush` can now be overridden for special cases (e.g. HITS filtering). Also HITS now def...Make output POOL settings in CA-based config more flexible. All temporary files now use lower compression (which I suppose is what we want). `TreeAutoFlush` can now be overridden for special cases (e.g. HITS filtering). Also HITS now default to `10` which is what is used in legacy config.
/cc @gemmeren @amete @jchapmanhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/46518Add CA-based skeletons for HITSMerge and RDOMerge2021-09-16T21:42:59+02:00Tadej Novaktadej.novak@cern.chAdd CA-based skeletons for HITSMerge and RDOMergeAdd CA-based skeletons for `HITSMerge` and `RDOMerge`. Also move `RDOMerge` under simulation domain.
This MR also adds common handling of the detector configuration for simulation transforms and fixes some import issues.
/cc @jchapman ...Add CA-based skeletons for `HITSMerge` and `RDOMerge`. Also move `RDOMerge` under simulation domain.
This MR also adds common handling of the detector configuration for simulation transforms and fixes some import issues.
/cc @jchapman @goetz @mhodgkinhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/46504Migrate SimEventFilter to be an AthReentrantAlgorithm2021-09-17T21:43:50+02:00John Derek ChapmanMigrate SimEventFilter to be an AthReentrantAlgorithmThis should allow the ReSimulation workflow to be run in AthenaMT in the future.This should allow the ReSimulation workflow to be run in AthenaMT in the future.https://gitlab.cern.ch/atlas/athena/-/merge_requests/4650122.0-cppcheck-TRT_PAI_Process2021-09-15T21:44:15+02:00Shaun Roe22.0-cppcheck-TRT_PAI_ProcessSolve cppcheck warnings: prefix increment instead of postfix, pass string argument by cont ref, ensure std::log argument is sane.Solve cppcheck warnings: prefix increment instead of postfix, pass string argument by cont ref, ensure std::log argument is sane.