athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2021-09-04T03:02:38+02:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/46250Fixes for RUN3 geometry and testbeam simulation2021-09-04T03:02:38+02:00Sanya SolodkovFixes for RUN3 geometry and testbeam simulationMinor updates in TileDetDescr due to change in geometry of crack scintillators for RUN3
Update in testbeam simulation jobOptions: allowed theta range increased from [-60,60] to [-70,70] degreesMinor updates in TileDetDescr due to change in geometry of crack scintillators for RUN3
Update in testbeam simulation jobOptions: allowed theta range increased from [-60,60] to [-70,70] degreeshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/46244ART tests for Cosmics TrackRecord creation and Cavern Background TrackRecord ...2021-09-03T03:04:33+02:00John Derek ChapmanART tests for Cosmics TrackRecord creation and Cavern Background TrackRecord conversion to HITSActivate ART tests for two further CA-based simulation configurations.Activate ART tests for two further CA-based simulation configurations.https://gitlab.cern.ch/atlas/athena/-/merge_requests/46234Pixel Luminosity Rings hits collection2021-10-14T17:35:56+02:00Deion Elgin FellersPixel Luminosity Rings hits collectionThis MR is introducing a PLRGeoModelXml package and several other changes necessary to integrate the PLR detector in with athena and produce a PLR specific hits collection via simulation.
The PLRGeoModelXml package is structured followi...This MR is introducing a PLRGeoModelXml package and several other changes necessary to integrate the PLR detector in with athena and produce a PLR specific hits collection via simulation.
The PLRGeoModelXml package is structured following the model of ITk pixel, strip, and BCMPrime. Because the PLR is using the same sensors as the ITkPixel, the PLRGeoModelXml package utilizes the PixelDetectorManager, PixelG4_SD, and PixelID packages to create a PLR hits collection that is similar but separate from the ITkPixel.
As this is the first time the PLR has been introduced to athena, there were also several PLR specific control flags that needed to be created and used.
Finally, I also integrated the PLR into the SiHitAnalysis code such that the analysis would produce a separate ntuple for the PLR.https://gitlab.cern.ch/atlas/athena/-/merge_requests/46202clean up unneeded volumes in SCT/ITkStrip physics region2021-09-02T03:03:16+02:00Nicholas Stylesclean up unneeded volumes in SCT/ITkStrip physics regionAs observed by @yyap in ATLASSIM-5357, some ITk volumes were being added to the SCT. Since we have now split the ```ITkStrip``` configuration from that of the ```SCT``` in ~master, we no longer need to cover both cases in a single physic...As observed by @yyap in ATLASSIM-5357, some ITk volumes were being added to the SCT. Since we have now split the ```ITkStrip``` configuration from that of the ```SCT``` in ~master, we no longer need to cover both cases in a single physics region, so this can be cleaned up.
FYI @kuhlhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/46195Change the location of the beam pipe top volume when assembly beam pipe is used2021-09-03T03:04:30+02:00Yee Chinn YapChange the location of the beam pipe top volume when assembly beam pipe is usedit's found in [ATLASSIM-3773](https://its.cern.ch/jira/browse/ATLASSIM-3773) that AssemblyBeamPipe mode does not work in fast sim as the location of the central beam pipe top volume has changed when implementing the beam pipe using assem...it's found in [ATLASSIM-3773](https://its.cern.ch/jira/browse/ATLASSIM-3773) that AssemblyBeamPipe mode does not work in fast sim as the location of the central beam pipe top volume has changed when implementing the beam pipe using assembly volume instead of the default union. @jchapman @mduehrsshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/46193TrigT1Muctpi: delete legacy Muctpi simulation2021-09-21T21:43:19+02:00Frank WinklmeierTrigT1Muctpi: delete legacy Muctpi simulationDelete the Run-1&2 legacy Muctpi simulation (`TrigT1Muctpi`) package. The existing `Trigger.enableL1MuonPhase1` flag now only drives the configuration of the
data decoding on Run-1&2 data. Remove the usage of this flag for the purposes o...Delete the Run-1&2 legacy Muctpi simulation (`TrigT1Muctpi`) package. The existing `Trigger.enableL1MuonPhase1` flag now only drives the configuration of the
data decoding on Run-1&2 data. Remove the usage of this flag for the purposes of the L1 simulation configuration. There should be no functional changes as this flag was set to `True` for the LVL1 simulation already.
cc @masato @rbielski @armbrust @dzanzi
Closes ATR-23763.https://gitlab.cern.ch/atlas/athena/-/merge_requests/46179Sweeping !46149 from master to 22.0-mc20.
MuonMDT_CnvTools: Use central defin...2021-08-31T10:49:29+02:00Atlas NightlybuildSweeping !46149 from master to 22.0-mc20.
MuonMDT_CnvTools: Use central definition of maxNTubesPerLayerMuonMDT_CnvTools: Use central definition of maxNTubesPerLayer
See merge request atlas/athena!46149MuonMDT_CnvTools: Use central definition of maxNTubesPerLayer
See merge request atlas/athena!46149https://gitlab.cern.ch/atlas/athena/-/merge_requests/46176Sweeping !46157 from master to 22.0-mc20.
Fix missing pile-up jets/particles ...2021-09-01T03:06:16+02:00Atlas NightlybuildSweeping !46157 from master to 22.0-mc20.
Fix missing pile-up jets/particles in pile-up presampling jobsFix missing pile-up jets/particles in pile-up presampling jobs
See merge request atlas/athena!46157Fix missing pile-up jets/particles in pile-up presampling jobs
See merge request atlas/athena!46157https://gitlab.cern.ch/atlas/athena/-/merge_requests/46175Sweeping !46129 from master to 21.3.
ATLFAST2: fudge energy ratio and eta ran...2021-09-03T03:05:54+02:00Atlas NightlybuildSweeping !46129 from master to 21.3.
ATLFAST2: fudge energy ratio and eta range, to avoid rare run-time crashesATLFAST2: fudge energy ratio and eta range, to avoid rare run-time crashes
See merge request atlas/athena!46129ATLFAST2: fudge energy ratio and eta range, to avoid rare run-time crashes
See merge request atlas/athena!46129https://gitlab.cern.ch/atlas/athena/-/merge_requests/46174Sweeping !46156 from master to 22.0-mc20.
Fix beamspot reweighting autoconfig...2021-09-01T03:06:07+02:00Atlas NightlybuildSweeping !46156 from master to 22.0-mc20.
Fix beamspot reweighting autoconfigurationFix beamspot reweighting autoconfiguration
See merge request atlas/athena!46156Fix beamspot reweighting autoconfiguration
See merge request atlas/athena!46156https://gitlab.cern.ch/atlas/athena/-/merge_requests/46163Add support for independent skipping of secondary events in DoubleEventSelector2021-10-29T21:42:56+02:00Tadej Novaktadej.novak@cern.chAdd support for independent skipping of secondary events in DoubleEventSelectorIn bulk production tests we realised that independent skipping of secondary events in overlay might be beneficial for production when HS hits are large (e.g. 10k events/file) but RDOs are smaller. At the moment only the whole HITS file c...In bulk production tests we realised that independent skipping of secondary events in overlay might be beneficial for production when HS hits are large (e.g. 10k events/file) but RDOs are smaller. At the moment only the whole HITS file can be processed at once.
A separate `--skipSecondaryEvents` argument is added which works in the following way:
- no flag -> same skipping as HS
- skipSecondaryEvents=0 -> disable skipping of RDOs
- skipSecondaryEvents=N -> independently skip N events in the first RDO file
Counters are independent for each selector (not really used anywhere at the moment). Helper tools skip both events at once (also not used for overlay).
Open questions:
- Should `skipSecondaryEvents` be global argument/flag but just not used in other workflows? For now it's overlay specific.
- Logging is a bit misleading as HITS are actually using the secondary selector but using the primary `skipEvents` argument.
- Seeking still needs to be updated but will probably come in a separate MR.
Fixes ATLASSIM-5376.
/cc @mnowak @gemmeren @jchapman @mduehrsshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/46160Update naming of Voxelization configuration tool, and set new defaults for ITk2021-09-02T03:04:29+02:00Nicholas StylesUpdate naming of Voxelization configuration tool, and set new defaults for ITkFollowing ATLITKSW-159, update tool settings to apply more appropriate voxelaization settings for ```ITk```, and rename the tool that is responsible for this to something a bit easier to understand.
FYI @jchapman @hhayward @tlari @mdueh...Following ATLITKSW-159, update tool settings to apply more appropriate voxelaization settings for ```ITk```, and rename the tool that is responsible for this to something a bit easier to understand.
FYI @jchapman @hhayward @tlari @mduehrss @tadej @npettershttps://gitlab.cern.ch/atlas/athena/-/merge_requests/46157Fix missing pile-up jets/particles in pile-up presampling jobs2021-08-31T15:20:25+02:00Tadej Novaktadej.novak@cern.chFix missing pile-up jets/particles in pile-up presampling jobsFix missing pile-up jets/particles in pile-up presampling jobs by explicitly adding a prefix to output containers after wildcarding was removed in !45568.
Needed for reprocessing so marking as ~urgent.
/cc @akraszna @jchapman @mduehrss...Fix missing pile-up jets/particles in pile-up presampling jobs by explicitly adding a prefix to output containers after wildcarding was removed in !45568.
Needed for reprocessing so marking as ~urgent.
/cc @akraszna @jchapman @mduehrss @elmsheus @emoysehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/46156Fix beamspot reweighting autoconfiguration2021-08-31T15:21:13+02:00Tadej Novaktadej.novak@cern.chFix beamspot reweighting autoconfigurationFix beamspot reweighting autoconfiguration. It should basically be enabled all the time except for pile-up presampling.
Needed for reprocessing so marking as ~urgent.
/cc @mduehrss @jchapman @elmsheus @emoyseFix beamspot reweighting autoconfiguration. It should basically be enabled all the time except for pile-up presampling.
Needed for reprocessing so marking as ~urgent.
/cc @mduehrss @jchapman @elmsheus @emoysehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/46149MuonMDT_CnvTools: Use central definition of maxNTubesPerLayer2021-08-31T03:07:23+02:00Johannes Junggeburthjohannes.josef.junggeburth@cern.chMuonMDT_CnvTools: Use central definition of maxNTubesPerLayerAddresses ATLASRECTS-5792Addresses ATLASRECTS-5792https://gitlab.cern.ch/atlas/athena/-/merge_requests/46129ATLFAST2: fudge energy ratio and eta range, to avoid rare run-time crashes2021-09-02T10:16:17+02:00Liza MijovicATLFAST2: fudge energy ratio and eta range, to avoid rare run-time crashesThis MR is to fix crashes in ART tests, as in [5372](https://its.cern.ch/jira/browse/ATLASSIM-5372)
ATLFAST2 gives a rare run-time crash when simulating photons close to the gap region. The ATLFAST2 is at the end of it's life, but we'll...This MR is to fix crashes in ART tests, as in [5372](https://its.cern.ch/jira/browse/ATLASSIM-5372)
ATLFAST2 gives a rare run-time crash when simulating photons close to the gap region. The ATLFAST2 is at the end of it's life, but we'll still want to use it a bit longer because of it's lower memory footprint. We therefore suggest to fudge the energy threshold and eta range as in this MR.
Committing the fix obo @mduehrss who proposed it.https://gitlab.cern.ch/atlas/athena/-/merge_requests/46041Digitization+EventOverlay: remove support of LVL1 XML configuration2021-08-25T03:06:11+02:00Frank WinklmeierDigitization+EventOverlay: remove support of LVL1 XML configurationWe no longer support XML-based trigger configurations. Although, very
likely these job options are not relevant anyways anymore.We no longer support XML-based trigger configurations. Although, very
likely these job options are not relevant anyways anymore.https://gitlab.cern.ch/atlas/athena/-/merge_requests/46040Frozen showers scripts aug20212021-10-13T16:31:07+02:00Alexander GlazovFrozen showers scripts aug2021Update frozen shower scripts to remove dependence on physh.
Note that several scripts require further updates due to other changes (to be done later in the year)Update frozen shower scripts to remove dependence on physh.
Note that several scripts require further updates due to other changes (to be done later in the year)https://gitlab.cern.ch/atlas/athena/-/merge_requests/45980LArHV: Rename getData() -> getDataSim().2021-08-22T03:03:33+02:00Scott SnyderLArHV: Rename getData() -> getDataSim().Rename the argumentless getData() methods of the HV managers to getDataSim,
to emphasize that they are for use only by simulation (since they don't
handle conditions changes).Rename the argumentless getData() methods of the HV managers to getDataSim,
to emphasize that they are for use only by simulation (since they don't
handle conditions changes).https://gitlab.cern.ch/atlas/athena/-/merge_requests/45954Merge branch '21.0_trtdEdxUpdate' into '21.0'2021-09-17T14:19:49+02:00Peter BertaMerge branch '21.0_trtdEdxUpdate' into '21.0'update TRT_ToT_dEdx to protect from crash
See merge request atlas/athena!45829
(cherry picked from commit a0a45414dfa7ce9029043fbb9b00593a91eae83e)
e22eb000 reduced some array lengths from 1800 to 1080
9eaaee59 protection for longer v...update TRT_ToT_dEdx to protect from crash
See merge request atlas/athena!45829
(cherry picked from commit a0a45414dfa7ce9029043fbb9b00593a91eae83e)
e22eb000 reduced some array lengths from 1800 to 1080
9eaaee59 protection for longer vectors present in newer DB tags