athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2022-12-22T15:42:00+01:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/59514Optimize the usage of barcodes2022-12-22T15:42:00+01:00Andrii VerbytskyiOptimize the usage of barcodes- Optimize the usage of barcodes
- Use std:: namespace for math functions
Tag @jchapman- Optimize the usage of barcodes
- Use std:: namespace for math functions
Tag @jchapmanhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/28360Order all ISF particles to allow MT validation2019-12-06T15:37:34+01:00Benjamin Michael WynneOrder all ISF particles to allow MT validationThe ISF particle broker has a default ordering behaviour that is unpredictable and hard to replicate.
To allow numerical comparisons of ISF results with ISF MT migrated components, introduce an ordering for all particles that is robus...The ISF particle broker has a default ordering behaviour that is unpredictable and hard to replicate.
To allow numerical comparisons of ISF results with ISF MT migrated components, introduce an ordering for all particles that is robust against changes to program flow - particle kinetic energy chosen for now.
Introduce a configurable ordering tool to SimKernelMT to enable comparison here.
When no tool is configured, the order is set to replicate FIFO behaviour, similar to this existing example:
https://acode-browser.usatlas.bnl.gov/lxr/source/athena/Simulation/ISF/ISF_Core/ISF_Services/src/ParticleBrokerDynamicOnReadIn.cxx#0382https://gitlab.cern.ch/atlas/athena/-/merge_requests/32416Ordered critical services creation2020-09-29T15:06:29+02:00Tomasz BoldOrdered critical services creationThis MR is an attempt to reduce number of "force" created services but at the same time allow ordering of that critical one. It is realy for review.
Tagging @wlampl @stelzer @jchapman @amete This MR is an attempt to reduce number of "force" created services but at the same time allow ordering of that critical one. It is realy for review.
Tagging @wlampl @stelzer @jchapman @amete https://gitlab.cern.ch/atlas/athena/-/merge_requests/29126Organize the Dcube input directory2020-01-28T03:04:29+01:00Tulay Cuhadar DonszelmannOrganize the Dcube input directoryhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/29124Organize the Dcube input directory & update xml files2019-12-21T03:02:34+01:00Tulay Cuhadar DonszelmannOrganize the Dcube input directory & update xml filesOrganize the Dcube input directory & update xml filesOrganize the Dcube input directory & update xml fileshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/34304Overlay: Add BCM new-style config + fix data overlay2020-07-03T03:05:29+02:00Tadej Novaktadej.novak@cern.chOverlay: Add BCM new-style config + fix data overlayThis ended-up a bigger MR than expected, but here we go. The goal was to add new-style config for BCM overlay. In the process data overlay for BCM has also been fixed (ATLASSIM-4622).
Some observations:
- BCM stores multiple BCIDs f...This ended-up a bigger MR than expected, but here we go. The goal was to add new-style config for BCM overlay. In the process data overlay for BCM has also been fixed (ATLASSIM-4622).
Some observations:
- BCM stores multiple BCIDs for data (5 in my tests), one for MC.
- The order of collections is not deterministic.
Changes:
- Map the channels to collections as direct loop is not possible.
- For data: find event BCID from data RDOs and use that one for overlay, do not store the rest if not required.
/cc @janovak @jchapmanhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/34305Overlay: add thread-safety checks for copy algorithms2020-07-02T03:04:37+02:00Tadej Novaktadej.novak@cern.chOverlay: add thread-safety checks for copy algorithmsAdd thread-safety checks for overlay copy algorithms + finalise migration to Gaudi properties.Add thread-safety checks for overlay copy algorithms + finalise migration to Gaudi properties.https://gitlab.cern.ch/atlas/athena/-/merge_requests/30743Overlay ART: only do diff-root for MT tests (ATLASSIM-4457)2020-03-01T03:02:30+01:00Tadej Novaktadej.novak@cern.chOverlay ART: only do diff-root for MT tests (ATLASSIM-4457)Overlay ART: only do diff-root for MT tests as pool tests are not reproducible due to ordering.
/cc @abasalae @jchapmanOverlay ART: only do diff-root for MT tests as pool tests are not reproducible due to ordering.
/cc @abasalae @jchapmanhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/28624Overlay as part of FastChain transform in 21.32020-01-28T03:04:30+01:00Martina JavurkovaOverlay as part of FastChain transform in 21.3RDO+RDO overlay is now implemented as part of FastChain transform. The same set of arguments can be used as for OverlayPool. It reads HITS from a hard-scatter (HS) file, performs the digitization and overlay the created HS RDO file by th...RDO+RDO overlay is now implemented as part of FastChain transform. The same set of arguments can be used as for OverlayPool. It reads HITS from a hard-scatter (HS) file, performs the digitization and overlay the created HS RDO file by the pile-up pre-mixed RDO file.https://gitlab.cern.ch/atlas/athena/-/merge_requests/57101OverlayByteStreamUtils: enable thread-checker2022-09-30T15:42:55+02:00Frank WinklmeierOverlayByteStreamUtils: enable thread-checkerIgnore checking of `ByteStreamMultipleOutputStreamCopyTool` as this code
has multiple issues and is not used anywhere.Ignore checking of `ByteStreamMultipleOutputStreamCopyTool` as this code
has multiple issues and is not used anywhere.https://gitlab.cern.ch/atlas/athena/-/merge_requests/46950OverlayByteStreamUtils: Fix clang warning.2021-10-06T15:44:33+02:00Scott SnyderOverlayByteStreamUtils: Fix clang warning.Unused private data member.Unused private data member.https://gitlab.cern.ch/atlas/athena/-/merge_requests/47725Overlay: cleanup trigger configuration2021-11-03T01:24:10+01:00Frank WinklmeierOverlay: cleanup trigger configurationRemove obsolete trigger configuration in overlay transforms:
- remove code to run trigger during digi (see also the equivalent change done for regular simulation in !47611)
- remove the (clearly copy&pasted) code to configure the L1 trig...Remove obsolete trigger configuration in overlay transforms:
- remove code to run trigger during digi (see also the equivalent change done for regular simulation in !47611)
- remove the (clearly copy&pasted) code to configure the L1 trigger as this feature is not used
cc @jchapman @tadej @tkharlamhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/50691OverlayConfiguration: Add PerfMonMT support to CA-based overlay jobs2022-02-23T21:43:42+01:00Alaettin Serhan MeteOverlayConfiguration: Add PerfMonMT support to CA-based overlay jobsThe title explains it. By default, we'll start getting the `fastmonmt` report at the end of CA-based digitization jobs, just like standard reconstruction etc.
cc: @tadej @jchapmanThe title explains it. By default, we'll start getting the `fastmonmt` report at the end of CA-based digitization jobs, just like standard reconstruction etc.
cc: @tadej @jchapmanhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/34319OverlayConfiguration: Increase test timeouts.2020-07-02T03:03:10+02:00Scott SnyderOverlayConfiguration: Increase test timeouts.Tests have been timing out frequently in debug builds.Tests have been timing out frequently in debug builds.https://gitlab.cern.ch/atlas/athena/-/merge_requests/43951OverlayConfiguration: Recognize --debug.2021-06-01T17:55:43+02:00Scott SnyderOverlayConfiguration: Recognize --debug.Handle --debug flag for new configuration jobs.Handle --debug flag for new configuration jobs.https://gitlab.cern.ch/atlas/athena/-/merge_requests/68656OverlayConfiguration: Reduce python dependencies.2024-02-07T18:00:58+01:00Scott SnyderOverlayConfiguration: Reduce python dependencies.Don't load configuration code for disabled detectors.Don't load configuration code for disabled detectors.https://gitlab.cern.ch/atlas/athena/-/merge_requests/55212OverlayConfiguration: Switch to using PerfMonMT in the legacy job skeleton fo...2022-07-19T17:33:00+02:00Alaettin Serhan MeteOverlayConfiguration: Switch to using PerfMonMT in the legacy job skeleton for OverlayThe title explains all. This should be a benign change that doesn't alter the output in anyway. It would be good to get this in before the bulk production is launched.
cc @jchapman @tadejThe title explains all. This should be a benign change that doesn't alter the output in anyway. It would be good to get this in before the bulk production is launched.
cc @jchapman @tadejAlaettin Serhan MeteAlaettin Serhan Metehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/67614OverlayConfiguration: Update legacy overlay RDO compression settings to match...2023-12-06T15:19:19+01:00Alaettin Serhan MeteOverlayConfiguration: Update legacy overlay RDO compression settings to match the new configurationThis addresses the inconsistency that is observed between the RDO compression settings for the new and the old-style Overlay configuration.
Closes ATLASSIM-7002
cc: @gemmeren @jchapman @tadejThis addresses the inconsistency that is observed between the RDO compression settings for the new and the old-style Overlay configuration.
Closes ATLASSIM-7002
cc: @gemmeren @jchapman @tadejhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/55381OverlayConfiguration: Update PerfMonMT output file name in legacy Overlay2022-07-25T17:09:45+02:00Alaettin Serhan MeteOverlayConfiguration: Update PerfMonMT output file name in legacy OverlayUpdating the name to be consistent with other workflow steps.Updating the name to be consistent with other workflow steps.Alaettin Serhan MeteAlaettin Serhan Metehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/52056OverlayCopyAlgs: EventInfo dependency workaround.2022-04-08T15:44:12+02:00Scott SnyderOverlayCopyAlgs: EventInfo dependency workaround.CopyMcEventCollection uses the GenEvent convertres, which have an
implicit dependency on xAOD::EventInfo. Add a dummy dependency
to this algorithm.
Should fix test failures seen in this package.
See ATLASSIM-5734.CopyMcEventCollection uses the GenEvent convertres, which have an
implicit dependency on xAOD::EventInfo. Add a dummy dependency
to this algorithm.
Should fix test failures seen in this package.
See ATLASSIM-5734.