athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2019-11-08T03:01:56+01:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/27774FastCaloSim: Fix cppcheck warning.2019-11-08T03:01:56+01:00Scott SnyderFastCaloSim: Fix cppcheck warning.- Uninitialized class member.- Uninitialized class member.https://gitlab.cern.ch/atlas/athena/-/merge_requests/52090FastCaloSim: cleaned up class hierarchy2022-04-13T21:43:30+02:00Vakhtang TsulaiaFastCaloSim: cleaned up class hierarchyDropped a redundant inheritance from `BasicCellBuilderTool`. Affected sub-classes:
* `EmptyCellBuilderTool`
* `AddNoiseCellBuilderTool`
CC @mduehrssDropped a redundant inheritance from `BasicCellBuilderTool`. Affected sub-classes:
* `EmptyCellBuilderTool`
* `AddNoiseCellBuilderTool`
CC @mduehrsshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/57530FastCaloSim: changed the access to CaloDetDescrManager2022-11-19T03:01:10+01:00Vakhtang TsulaiaFastCaloSim: changed the access to CaloDetDescrManagerSeveral clients in `FastCaloSim` used to either retrieve `CaloDetDescrManager` from `DetStore`,
or use the obsolete `CaloDetDescrManager::instance()`. Neither of these is compatible with
reading `CaloDetDescrManager` from Condition Store...Several clients in `FastCaloSim` used to either retrieve `CaloDetDescrManager` from `DetStore`,
or use the obsolete `CaloDetDescrManager::instance()`. Neither of these is compatible with
reading `CaloDetDescrManager` from Condition Store. However, given the complexity of the
clients, switching them to Condition Handles at this point would require a lot of
code refactoring.
Instead the following strategy has been implemented: the clients check at initialization
if the Detector Store contains the DD manager with the special key: `"CaloMgrFCS"`. The
first client which tries to access the manager builds it, and records into DS with this key,
so that the other clients can use it. Given this is done in simulation, the alignments don't
change through the job. Hence the usage of Condition Handles is not really required.https://gitlab.cern.ch/atlas/athena/-/merge_requests/42644FastCaloSim+CaloTools: Remove references to CaloNoiseTool.2021-04-17T03:03:48+02:00Scott SnyderFastCaloSim+CaloTools: Remove references to CaloNoiseTool.Remove vestigial references to CaloNoiseTool.
Fix a few typos in the printout during configuration.Remove vestigial references to CaloNoiseTool.
Fix a few typos in the printout during configuration.https://gitlab.cern.ch/atlas/athena/-/merge_requests/61879FastCaloSimCaloExtrapolation: Update configurable property syntax2023-03-28T22:14:47+02:00John Derek ChapmanFastCaloSimCaloExtrapolation: Update configurable property syntaxClean-up of syntax of `FastCaloSimCaloExtrapolation` class. No output change expected.Clean-up of syntax of `FastCaloSimCaloExtrapolation` class. No output change expected.https://gitlab.cern.ch/atlas/athena/-/merge_requests/67189FastCaloSim: CaloCellMakerTools - style clean-up, remove unused includes2023-11-17T15:44:26+01:00John Derek ChapmanFastCaloSim: CaloCellMakerTools - style clean-up, remove unused includesClean-up only - no logic changes.Clean-up only - no logic changes.https://gitlab.cern.ch/atlas/athena/-/merge_requests/58231FastCaloSimAthenaPool: Enable thread-safety checking.2022-11-09T15:44:24+01:00Scott SnyderFastCaloSimAthenaPool: Enable thread-safety checking.Enable thread-safety checking.Enable thread-safety checking.https://gitlab.cern.ch/atlas/athena/-/merge_requests/32558FastCaloSimAthenaPool: cmake fixes2020-05-03T03:02:46+02:00Scott SnyderFastCaloSimAthenaPool: cmake fixesDon't build the same sources into more than one library.Don't build the same sources into more than one library.https://gitlab.cern.ch/atlas/athena/-/merge_requests/28036FastCaloSim: Another pattern to ignore.2019-11-19T03:02:17+01:00Scott SnyderFastCaloSim: Another pattern to ignore.Fix test failure observed in master.Fix test failure observed in master.https://gitlab.cern.ch/atlas/athena/-/merge_requests/40338FastCaloSim: add mechanism to better clean up the AuxInfo in the simulation s...2021-05-19T13:49:39+02:00Michael Duehrssen-DeblingFastCaloSim: add mechanism to better clean up the AuxInfo in the simulation stateAdd a standard mechanism to cleanup AuxInfo in the simulation state of FastCaloSim. This should help to avoid memory leaks when parametrizations use AuxInfo objectsAdd a standard mechanism to cleanup AuxInfo in the simulation state of FastCaloSim. This should help to avoid memory leaks when parametrizations use AuxInfo objectshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/35745FastCaloSim: Add an option to initialize the GAN energy from the simulstate i...2020-09-10T03:03:56+02:00Michael Duehrssen-DeblingFastCaloSim: Add an option to initialize the GAN energy from the simulstate instead of always using EkinSo far the GAN simulation inside FastCaloSim was always initialized with Ekin. By allowing to use the simulstate, a more flexible energy correction and interpolation, including matching to the PCA energy simulation, is possibleSo far the GAN simulation inside FastCaloSim was always initialized with Ekin. By allowing to use the simulstate, a more flexible energy correction and interpolation, including matching to the PCA energy simulation, is possiblehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/20113FastCaloSim: Add a basic test for FastShowerCellBuilderTool.2018-12-27T03:02:19+01:00Scott SnyderFastCaloSim: Add a basic test for FastShowerCellBuilderTool.Add a basic test for FastShowerCellBuilderTool.Add a basic test for FastShowerCellBuilderTool.https://gitlab.cern.ch/atlas/athena/-/merge_requests/31111FastCaloGAN code2020-04-14T17:28:00+02:00Serena Palazzoserena.palazzo@cern.chFastCaloGAN codeThis merge request aims to include in the 21.0 branch the FastCaloGAN code. Tagging @mfauccig
Cheers,
SerenaThis merge request aims to include in the 21.0 branch the FastCaloGAN code. Tagging @mfauccig
Cheers,
Serenahttps://gitlab.cern.ch/atlas/athena/-/merge_requests/24567Extra SM mesons2019-08-24T03:03:29+02:00Miha Muskinjamiha.muskinja@cern.chExtra SM mesonsThis adds 11 additional D and B mesons to the Geant4 particle list for the purposes of the long lived Geant4 simulation.
Also modifies the GenParticleSimWhiteList algorithm to take as input a vector of white lists instead of only one ...This adds 11 additional D and B mesons to the Geant4 particle list for the purposes of the long lived Geant4 simulation.
Also modifies the GenParticleSimWhiteList algorithm to take as input a vector of white lists instead of only one white list. The purpose of this is that the 11 new mesons can be simply added with an additional white list instead of modifying the existing one (since they are optional).
Activated with
`SimulationJobOptions/preInclude.Mesons.py`https://gitlab.cern.ch/atlas/athena/-/merge_requests/56575ExtrapolationEngine: fix thread-checker warnings2022-09-14T15:42:58+02:00Frank WinklmeierExtrapolationEngine: fix thread-checker warningsThe `ExtrapolationEngine` was declared `ATLAS_NOT_THREAD_SAFE` due to the use of the unsafe `MaterialEffectsEngine` which used several `const_cast` to update the track parameters in `Trk::ExtrapolationCell`. This can be avoided by making...The `ExtrapolationEngine` was declared `ATLAS_NOT_THREAD_SAFE` due to the use of the unsafe `MaterialEffectsEngine` which used several `const_cast` to update the track parameters in `Trk::ExtrapolationCell`. This can be avoided by making those parameters non-const to begin with. Obviously, this doesn't make the code thread-safe. But now it is at least `const`-correct and passes the thread-checker.
Note that the legacy `ExtrapolationEngine` has only few clients and is superseded by the one from Acts.
cc @christos @ssnyder @pagessin @asalzbur for advice if this is the way we want to go.https://gitlab.cern.ch/atlas/athena/-/merge_requests/57962ExtraParticles+G4ExtraProcess: Enable thread-safety checking.2022-10-31T15:43:00+01:00Scott SnyderExtraParticles+G4ExtraProcess: Enable thread-safety checking.Enable thread-safety checking.Enable thread-safety checking.https://gitlab.cern.ch/atlas/athena/-/merge_requests/52823ExtraParticles: Fix ODR violation.2022-05-03T15:42:19+02:00Scott SnyderExtraParticles: Fix ODR violation.Move CustomParticle into a namespace.
There is another definition of CustomParticle in RHadrons.
Fixes warning in LTO build.Move CustomParticle into a namespace.
There is another definition of CustomParticle in RHadrons.
Fixes warning in LTO build.https://gitlab.cern.ch/atlas/athena/-/merge_requests/64022Externals Update, master branch (2023.06.29.)2023-07-01T09:42:02+02:00Attila KrasznahorkayExternals Update, master branch (2023.06.29.)Updated all projects to [atlasexternals-2.0.158](https://gitlab.cern.ch/atlas/atlasexternals/-/tags/2.0.158). The changes wrt. [atlasexternals-2.0.156](https://gitlab.cern.ch/atlas/atlasexternals/-/tags/2.0.156) are (https://gitlab.cern....Updated all projects to [atlasexternals-2.0.158](https://gitlab.cern.ch/atlas/atlasexternals/-/tags/2.0.158). The changes wrt. [atlasexternals-2.0.156](https://gitlab.cern.ch/atlas/atlasexternals/-/tags/2.0.156) are (https://gitlab.cern.ch/atlas/atlasexternals/-/compare/2.0.156...2.0.158):
- Updated `FindLhapdf.cmake` to set up the use of the ATLAS specific `LHAPATH` under all circumstances (pinging @ewelina);
* This was necessary to make sure that paths in `$LHAPATH` would be in the correct order in all of our projects. And now that `FindLhapdf.cmake` does this itself, I simplified the `Superchic_i` package a bit, which was previously extending `$LHAPATH` itself. (In as it turns out a fragile way.)
- Modernised the builds of [VecGeom](https://gitlab.cern.ch/VecGeom/VecGeom) and [Geant4](https://geant4.web.cern.ch/), and updated how they would be found by the offline code (thanks to @bmorgan);
* This will be important once we want to make use of [Celeritas](https://github.com/celeritas-project/celeritas) (or [AdePT](https://github.com/apt-sim/AdePT) :wink:);
- Introduced `C++20` fixes for: Geant4, GeoModel and Coin3D for ATLINFR-4959 (thanks to @elmsheus).
The changes are not completely trivial, so ~"full-build", ~"full-unit-tests" and ~"full-integration-tests" are all in effect! And the RC should plan on a CI node cleanup after merging this one in. :wink:https://gitlab.cern.ch/atlas/athena/-/merge_requests/61130Externals Update, master branch (2023.03.01)2023-03-02T21:42:31+01:00Marilena BandieramonteExternals Update, master branch (2023.03.01)Update externals version to 2.0.151.
This should fix: ATLASSIM-6403Update externals version to 2.0.151.
This should fix: ATLASSIM-6403https://gitlab.cern.ch/atlas/athena/-/merge_requests/49973Externals Update, master branch (2022.01.26.)2022-04-21T10:36:38+02:00Attila KrasznahorkayExternals Update, master branch (2022.01.26.)Updated all projects to [atlasexternals-2.0.126](https://gitlab.cern.ch/atlas/atlasexternals/-/tags/2.0.126). The list of changes wrt. [atlasexternals-2.0.125](https://gitlab.cern.ch/atlas/atlasexternals/-/tags/2.0.125) is the following ...Updated all projects to [atlasexternals-2.0.126](https://gitlab.cern.ch/atlas/atlasexternals/-/tags/2.0.126). The list of changes wrt. [atlasexternals-2.0.125](https://gitlab.cern.ch/atlas/atlasexternals/-/tags/2.0.125) is the following (https://gitlab.cern.ch/atlas/atlasexternals/-/compare/2.0.125...2.0.126):
- Added [lark](https://github.com/lark-parser/lark) `1.0.0` (a parsing toolkit for Python) to [PyModules](https://gitlab.cern.ch/atlas/atlasexternals/-/tree/master/External/PyModules) (thanks to @ponyisi);
- Introduced find-modules for [protobuf](https://github.com/protocolbuffers/protobuf), [boto3](https://github.com/boto/boto3), [botocore](https://github.com/boto/botocore), [jmespath](https://github.com/jmespath/jmespath.py) and [s3transfer](https://github.com/boto/s3transfer) in [AtlasLCG](https://gitlab.cern.ch/atlas/atlasexternals/-/tree/master/Build/AtlasLCG) (thanks to @sanchezj);
* Made `lcg_python_external_module(...)` a bit more robust in support of these new modules;
- Introduced a package for building [VecGeom](https://gitlab.cern.ch/VecGeom/VecGeom), and updated the [Geant4](https://gitlab.cern.ch/atlas/atlasexternals/-/tree/master/External/Geant4) build to use this build of [VecGeom](https://gitlab.cern.ch/atlas/atlasexternals/-/tree/master/External/VecGeom) itself (thanks to @mbandier and @bmorgan).
Because of the Geant4 update, this required both ~"full-build" and ~"full-unit-tests".