athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2019-12-04T17:24:25+01:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/28446Sweeping !28400 from 21.3 to 21.9.
Only call IdToFixedIdTool when needed2019-12-04T17:24:25+01:00Atlas NightlybuildSweeping !28400 from 21.3 to 21.9.
Only call IdToFixedIdTool when neededOnly call IdToFixedIdTool when needed
See merge request atlas/athena!28400Only call IdToFixedIdTool when needed
See merge request atlas/athena!28400https://gitlab.cern.ch/atlas/athena/-/merge_requests/28445Adds a debug stacking action with reproducible seeds2019-12-16T20:05:44+01:00Miha Muskinjamiha.muskinja@cern.chAdds a debug stacking action with reproducible seedsManual sweep of !27717 in master.
Tagging @jchapman. It seems that the location of the StackingAction changed to the auto sweep failed.Manual sweep of !27717 in master.
Tagging @jchapman. It seems that the location of the StackingAction changed to the auto sweep failed.https://gitlab.cern.ch/atlas/athena/-/merge_requests/28442Move overlay copy algs to a new OverlayCopyAlgs package2019-12-05T03:02:21+01:00Tadej Novaktadej.novak@cern.chMove overlay copy algs to a new OverlayCopyAlgs packageMove overlay copy algs to a new `OverlayCopyAlgs` package to try to cleanup `Event` namespace.
/cc @jchapmanMove overlay copy algs to a new `OverlayCopyAlgs` package to try to cleanup `Event` namespace.
/cc @jchapmanhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/28412Add Dcube checks to the tests2020-01-01T03:03:44+01:00Tulay Cuhadar DonszelmannAdd Dcube checks to the testsAdding Dcube checks to the FastChain tests. Probably will need another iteration for the proper input config.
Adding @jchapman, @vpascuzz and @tlari.Adding Dcube checks to the FastChain tests. Probably will need another iteration for the proper input config.
Adding @jchapman, @vpascuzz and @tlari.https://gitlab.cern.ch/atlas/athena/-/merge_requests/28400Only call IdToFixedIdTool when needed2020-01-01T03:03:50+01:00Nicolas KoehlerOnly call IdToFixedIdTool when neededHi,
this MR adds some checks to only call the `IdToFixedIdTool` when it is actually needed.
Furthermore, the `stations.v2.07.xml` gets fixed by removing `;` which lead to errors of the xml expression evaluator. And the asymmetric versio...Hi,
this MR adds some checks to only call the `IdToFixedIdTool` when it is actually needed.
Furthermore, the `stations.v2.07.xml` gets fixed by removing `;` which lead to errors of the xml expression evaluator. And the asymmetric version of `stations.v2.07.xml` is added to the repository.
Best, Nicohttps://gitlab.cern.ch/atlas/athena/-/merge_requests/28371Fix typo in test_AtlasG4_CavernBg_EVNT2TR.sh SimCoreTests ART script2020-01-01T03:02:30+01:00John Derek ChapmanFix typo in test_AtlasG4_CavernBg_EVNT2TR.sh SimCoreTests ART scriptFixing typo pointed out in ATLASSIM-4367.Fixing typo pointed out in ATLASSIM-4367.https://gitlab.cern.ch/atlas/athena/-/merge_requests/28365RadiationMapsMaker: added maps of mass fractions for all natural elements2020-01-28T03:04:30+01:00Sven MenkeRadiationMapsMaker: added maps of mass fractions for all natural elementseach grid point will collect the density- and step-length-weighted mass-fraction of the encountered elements. This gives the effective atomic composition of materials in each grid point. The first and last element to track is configurabl...each grid point will collect the density- and step-length-weighted mass-fraction of the encountered elements. This gives the effective atomic composition of materials in each grid point. The first and last element to track is configurable - by default all natural elements ( 1 <= Z <= 92 ) are enabled.
Example output in the service area of LAr from a geantino scan in the barrel:
H: 0.00525763
C: 0.162227
N: 0.0470331
O: 0.0583856
F: 0.0808482
Si: 0.000496895
Ar: 0.000285226
Mn: 0.000496895
Fe: 0.0486957
Cu: 0.596274https://gitlab.cern.ch/atlas/athena/-/merge_requests/28360Order all ISF particles to allow MT validation2019-12-06T15:37:34+01:00Benjamin Michael WynneOrder all ISF particles to allow MT validationThe ISF particle broker has a default ordering behaviour that is unpredictable and hard to replicate.
To allow numerical comparisons of ISF results with ISF MT migrated components, introduce an ordering for all particles that is robus...The ISF particle broker has a default ordering behaviour that is unpredictable and hard to replicate.
To allow numerical comparisons of ISF results with ISF MT migrated components, introduce an ordering for all particles that is robust against changes to program flow - particle kinetic energy chosen for now.
Introduce a configurable ordering tool to SimKernelMT to enable comparison here.
When no tool is configured, the order is set to replicate FIFO behaviour, similar to this existing example:
https://acode-browser.usatlas.bnl.gov/lxr/source/athena/Simulation/ISF/ISF_Core/ISF_Services/src/ParticleBrokerDynamicOnReadIn.cxx#0382https://gitlab.cern.ch/atlas/athena/-/merge_requests/28355Fix ATR-206162019-11-30T03:02:08+01:00Tulay Cuhadar DonszelmannFix ATR-20616Switching off the trigger for the ESDtoAOD as well (not only RAWtoESD)
@jchapman, @tlari and @vpascuzzSwitching off the trigger for the ESDtoAOD as well (not only RAWtoESD)
@jchapman, @tlari and @vpascuzzhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/28344Python3 syntax fixes2019-11-29T03:02:31+01:00John Derek ChapmanPython3 syntax fixesPython 3 syntax fixes for the `AthenaConfiguration` and `MuonConfig` packages. Further fixes for new-style configuration tests which write out pickle files, plus some fixes to old-style configuration code in the `Database/AthenaPOOL/Athe...Python 3 syntax fixes for the `AthenaConfiguration` and `MuonConfig` packages. Further fixes for new-style configuration tests which write out pickle files, plus some fixes to old-style configuration code in the `Database/AthenaPOOL/AthenaPoolCnvSvc`,`Database/AthenaPOOL/AthenaPoolCnvSvc`, `Database/AthenaPOOL/OutputStreamAthenaPool` and `Event/ByteStreamCnvSvc` packages.https://gitlab.cern.ch/atlas/athena/-/merge_requests/28324Fix for Fast Chain ART test problem in ATLASRECTS-52082019-11-28T03:02:30+01:00Nicholas StylesFix for Fast Chain ART test problem in ATLASRECTS-5208Fix for ART test problem in ATLASRECTS-5208; fully disable NN clustering for fast chain test using fast digi
Closes ATLASRECTS-5208Fix for ART test problem in ATLASRECTS-5208; fully disable NN clustering for fast chain test using fast digi
Closes ATLASRECTS-5208https://gitlab.cern.ch/atlas/athena/-/merge_requests/28284Replaced AthFile with MetaReader in ISF_Example package2019-11-28T03:02:34+01:00Dan Andrei CiubotaruReplaced AthFile with MetaReader in ISF_Example packageThis MR replaces the old tool used to read infile metadata, InputFilePeeker, with the newer tool MetaReader.This MR replaces the old tool used to read infile metadata, InputFilePeeker, with the newer tool MetaReader.ATLAS RobotATLAS Robothttps://gitlab.cern.ch/atlas/athena/-/merge_requests/28276Sweeping !28174 from 21.3 to 21.9.
Add new stations.xml for the NSW Run3 layout2019-11-27T18:39:26+01:00Atlas NightlybuildSweeping !28174 from 21.3 to 21.9.
Add new stations.xml for the NSW Run3 layoutAdd new stations.xml for the NSW Run3 layout
See merge request atlas/athena!28174Add new stations.xml for the NSW Run3 layout
See merge request atlas/athena!28174https://gitlab.cern.ch/atlas/athena/-/merge_requests/28275Sweeping !28174 from 21.3 to master.
Add new stations.xml for the NSW Run3 la...2019-11-27T03:02:12+01:00Atlas NightlybuildSweeping !28174 from 21.3 to master.
Add new stations.xml for the NSW Run3 layoutAdd new stations.xml for the NSW Run3 layout
See merge request atlas/athena!28174Add new stations.xml for the NSW Run3 layout
See merge request atlas/athena!28174https://gitlab.cern.ch/atlas/athena/-/merge_requests/28257Merge 21.0.104 into 21.32020-01-01T03:03:50+01:00John Derek ChapmanMerge 21.0.104 into 21.3This merge request merges nearly all the changes that were made to the 21.0 branch between the release
[release/21.0.104](https://gitlab.cern.ch/atlas/athena/tags/release/21.0.104) and the previous release
[release/21.0.103](https://gitl...This merge request merges nearly all the changes that were made to the 21.0 branch between the release
[release/21.0.104](https://gitlab.cern.ch/atlas/athena/tags/release/21.0.104) and the previous release
[release/21.0.103](https://gitlab.cern.ch/atlas/athena/tags/release/21.0.103).
Below is a full list of merge requests that were accepted between these two tags:
* !28169 : Towards TRT EC alignment
* !28146 : Add unit test and CSC channel hash translators - (Not swept)
* !28136 : Manual Sweep of !28102 from 21.3 to 21.0: Fix regression test for test_AtlasG4_CavernBg_EVNT2TR.sh (ATLASSIM-4346)
* !28077 : correcting misleading comments in configuration
* !27939 : PROCTools: Update CI Simulation Tests
* !27909 : Change HNLFlags for December DRAW_RPVLL processing (ATLDHNL-19)
* !27864 : Fast calo sim weighted hits
* !27629 : TRT Level 1 Alignment
* !28030 : Revert "Merge branch '21.0-test-remove-NnPixelClusterSplitter' into '21.0'"
* !27787 : remove unused NN cluster splitting options from workflow
* !27849 : Removing incompatible ART tests from 21.0 - (Not swept)
* !27711 : TileMonitoring: Add possibility to ignore DMU errors in Tile monitoring
* !27773 : Tighten the requirement of particles subject to quasi-stable sim
* !27717 : Adds a debug stacking action with reproducible seeds
* !27681 : Sweeping !27452 from 21.2 to 21.0.
* !27673 : Protecting HepMCTruthReader against null signal vertex
* !27248 : Adds Wiener Filter weights for luminosity <mu>=90.
* !27511 : Add configuration for merging EVNT_TR files
* !27343 : Adding two new problems to bad channel list - DMU BC offset (i.e. +/-25ns...
Link to the full diff between [release/21.0.104](https://gitlab.cern.ch/atlas/athena/tags/release/21.0.104) and
[release/21.0.103](https://gitlab.cern.ch/atlas/athena/tags/release/21.0.103)
is available at
https://gitlab.cern.ch/atlas/athena/compare/release/21.0.103...release/21.0.104https://gitlab.cern.ch/atlas/athena/-/merge_requests/28252Use only diff-root in regression test. Fixes ATLASSIM-43462020-01-01T03:03:51+01:00Artem BasalaevUse only diff-root in regression test. Fixes ATLASSIM-4346Use only diff-root in regression test. Fixes ATLASSIM-4346. Mentioning @jchapmanUse only diff-root in regression test. Fixes ATLASSIM-4346. Mentioning @jchapmanhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/28250Python3 sytnax fixes for G4AtlasTools package2019-11-27T03:02:33+01:00John Derek ChapmanPython3 sytnax fixes for G4AtlasTools packagehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/28248Fix for G4AtlasFieldServices_test.py syntax for python 32019-11-27T03:02:10+01:00John Derek ChapmanFix for G4AtlasFieldServices_test.py syntax for python 3Updated `ComponentAccumulator` configuration tests which dump the configuration
to a pickle file. In python3 the output file needs to be explicitly opened in binary mode.
I.e.
```f = open('configdump.pkl','wb')```
rather than
```...Updated `ComponentAccumulator` configuration tests which dump the configuration
to a pickle file. In python3 the output file needs to be explicitly opened in binary mode.
I.e.
```f = open('configdump.pkl','wb')```
rather than
```f = open('configdump.pkl','w')```https://gitlab.cern.ch/atlas/athena/-/merge_requests/28233Migrate MuonGMJobProperties to ConfigFlags2019-11-28T03:02:01+01:00John Derek ChapmanMigrate MuonGMJobProperties to ConfigFlagshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/28226AFP_G4_SD+AFP_DBTools+AFP_ByteStream2RawCnv: Fix clang warnings.2019-11-25T03:02:04+01:00Scott SnyderAFP_G4_SD+AFP_DBTools+AFP_ByteStream2RawCnv: Fix clang warnings.clang warnings:
- unused private data members.
- missing override keywordsclang warnings:
- unused private data members.
- missing override keywords