athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2023-07-28T21:07:59+02:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/64682Update EntryLayerFilter.h: remove unused include2023-07-28T21:07:59+02:00Andrii VerbytskyiUpdate EntryLayerFilter.h: remove unused includeUpdate EntryLayerFilter.h: remove unused includeUpdate EntryLayerFilter.h: remove unused includehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/45768TrkDetDescrTools, etc: Migrate LayerMaterialProvider to use CondHandle.2021-08-14T21:44:56+02:00Scott SnyderTrkDetDescrTools, etc: Migrate LayerMaterialProvider to use CondHandle.Update LayerMaterialProvider to use MT conditions access to retrieve
LayerMaterialMap. Should help with ATLASRECTS-6559.Update LayerMaterialProvider to use MT conditions access to retrieve
LayerMaterialMap. Should help with ATLASRECTS-6559.https://gitlab.cern.ch/atlas/athena/-/merge_requests/33903TrigT1RPChardware+MuonG4SD: cmake fixes2020-06-18T21:13:48+02:00Scott SnyderTrigT1RPChardware+MuonG4SD: cmake fixesDon't build the same source into more than one library.
Remove useless library.Don't build the same source into more than one library.
Remove useless library.https://gitlab.cern.ch/atlas/athena/-/merge_requests/53952Tracking overlay updates for the RDOtoRDOTrigger step2022-06-03T20:45:13+02:00William Axel LeightTracking overlay updates for the RDOtoRDOTrigger stepThe converters need to be updated for the case in which both the input and output collections start with Bkg_, currently only foresees for the RDOtoRDOTrigger step. The configuration is also updated to load the EventCnvSuperTool and set...The converters need to be updated for the case in which both the input and output collections start with Bkg_, currently only foresees for the RDOtoRDOTrigger step. The configuration is also updated to load the EventCnvSuperTool and set its trackOverlay flag for RDOtoRDOTrigger.https://gitlab.cern.ch/atlas/athena/-/merge_requests/26375Test trt sensitive detector2019-11-12T16:40:11+01:00Liangliang HanTest trt sensitive detectorIn the branch, I tested the class `TRTSensitiveDetector` in the package `InnerDetector/InDetG4/TRT_G4_SD`. The following is how I did.
1. My test code `TRTSensitiveDetector_gtest.cxx` is placed in the `test` folder. And it is for testin...In the branch, I tested the class `TRTSensitiveDetector` in the package `InnerDetector/InDetG4/TRT_G4_SD`. The following is how I did.
1. My test code `TRTSensitiveDetector_gtest.cxx` is placed in the `test` folder. And it is for testing the class `TRTSensitiveDetector`.
2. I created the jobOption file `optionForTest.txt`, which is placed in the share folder.
3. In oder to add my test classes as friends of the tested classes, I add several lines for that.
4. Of course, I add some lines in the CMakeLists.txt for compiling my test code, using google test frame work, and so on.
5. I create 3 files and put them into the folder `Simulation/G4Atlas/G4AtlasTools/G4AtlasTools`. The 1st file is `DerivedG4SensitiveDetectorTestSetting.h`, where I define a function for setting G4-objects to G4Step object. The 2nd file is `G4MyPhysicalVolume.h`, where I define a class called `G4MyPhysicalVolume` that is derived from `G4VPhysicalVolume`. The 3rd file is `G4MyProcess.h`, where I define a class called `G4MyProcess` that is derived from `G4VProcess`.
6. It is worth mentioning that I use different TEST_F to test different member functions of the tested class.https://gitlab.cern.ch/atlas/athena/-/merge_requests/26377Test sct sensor sd2019-11-12T16:40:17+01:00Liangliang HanTest sct sensor sdIn the branch, I tested two classes, which are `SctSensorSD` and `SctSensor_CTB`. And they are all in the package `InnerDetector/InDetG4/SCT_G4_SD`. Here is how I did.
1. I put my test codes in the `test` folder. And they are `SctSensor...In the branch, I tested two classes, which are `SctSensorSD` and `SctSensor_CTB`. And they are all in the package `InnerDetector/InDetG4/SCT_G4_SD`. Here is how I did.
1. I put my test codes in the `test` folder. And they are `SctSensorSD_gtest.cxx` and `SctSensor_CTB_gtest.cxx` for respectively testing the classes `SctSensorSD` and `SctSensor_CTB`.
2. I created the jobOption file `optionForTest.txt`, which is placed in the share folder.
3. In oder to add my test classes as friends of the tested classes, I add several lines for that.
4. Of course, I add some lines in the CMakeLists.txt for compiling my test code, using google test frame work, and so on.
5. I create 3 files and put them into the folder `Simulation/G4Atlas/G4AtlasTools/G4AtlasTools`. The 1st file is `DerivedG4SensitiveDetectorTestSetting.h`, where I define a function for setting G4-objects to G4Step object. The 2nd file is `G4MyPhysicalVolume.h`, where I define a class called `G4MyPhysicalVolume` that is derived from `G4VPhysicalVolume`. The 3rd file is `G4MyProcess.h`, where I define a class called `G4MyProcess` that is derived from `G4VProcess`.
6. It is worth mentioning that I use different TEST_F to test different member functions of the tested class.https://gitlab.cern.ch/atlas/athena/-/merge_requests/26374Test pixel sensor sd2019-11-12T16:40:01+01:00Liangliang HanTest pixel sensor sdIn the branch, I tested the class `PixelSensorSD` in the package `InnerDetector/InDetG4/PixelG4_SD`. How I did is as follows.
1. I put my test code `PixelSensorSD_gtest.cxx` in the `test` folder. And it is for testing the class `PixelSe...In the branch, I tested the class `PixelSensorSD` in the package `InnerDetector/InDetG4/PixelG4_SD`. How I did is as follows.
1. I put my test code `PixelSensorSD_gtest.cxx` in the `test` folder. And it is for testing the class `PixelSensorSD`.
2. I created the jobOption file `optionForTest.txt`, which is placed in the share folder.
3. In oder to add my test classes as friends of the tested classes, I add several lines for that.
4. Of course, I add some lines in the CMakeLists.txt for compiling my test code, using google test frame work, and so on.
5. I create 3 files and put them into the folder `Simulation/G4Atlas/G4AtlasTools/G4AtlasTools`. The 1st file is `DerivedG4SensitiveDetectorTestSetting.h`, where I define a function for setting G4-objects to G4Step object. The 2nd file is `G4MyPhysicalVolume.h`, where I define a class called `G4MyPhysicalVolume` that is derived from `G4VPhysicalVolume`. The 3rd file is `G4MyProcess.h`, where I define a class called `G4MyProcess` that is derived from `G4VProcess`.
6. It is worth mentioning that I use different TEST_F to test different member functions of the tested class.https://gitlab.cern.ch/atlas/athena/-/merge_requests/61558Test merge request to probe CI behaviour - do not merge/review/etc2023-03-20T20:12:53+01:00Nicholas StylesTest merge request to probe CI behaviour - do not merge/review/etcAs above - toggling a setting to see that the CI tests run correctly and the labels get added, etcAs above - toggling a setting to see that the CI tests run correctly and the labels get added, etchttps://gitlab.cern.ch/atlas/athena/-/merge_requests/26367Test lucid sensitive detector2019-11-12T16:39:09+01:00Liangliang HanTest lucid sensitive detectorIn this branch, I tested the class(`LUCID_SensitiveDetector`) in the package `ForwardDetectors/LUCID/LUCID_G4_SD`. Here is what I did about the package.
1. My test code `LUCID_SensitiveDetector_gtest.cxx` is put in the test folder. it i...In this branch, I tested the class(`LUCID_SensitiveDetector`) in the package `ForwardDetectors/LUCID/LUCID_G4_SD`. Here is what I did about the package.
1. My test code `LUCID_SensitiveDetector_gtest.cxx` is put in the test folder. it is for testing the class(`LUCID_SensitiveDetector`).
2. I created the jobOption file `optionForTest.txt`, which is placed in the share folder.
3. In oder to add my test classes as friends of the tested classes, I add several lines for that.
4. Of course, I add some lines in the CMakeLists.txt for compiling my test code, using google test frame work, and so on.
5. I create 3 files and put them into the folder `Simulation/G4Atlas/G4AtlasTools/G4AtlasTools`. The 1st file is `DerivedG4SensitiveDetectorTestSetting.h`, where I define a function for setting G4-objects to G4Step object. The 2nd file is `G4MyPhysicalVolume.h`, where I define a class called `G4MyPhysicalVolume` that is derived from `G4VPhysicalVolume`. The 3rd file is `G4MyProcess.h`, where I define a class called `G4MyProcess` that is derived from `G4VProcess`.https://gitlab.cern.ch/atlas/athena/-/merge_requests/31561Test classes TileGeoG4SD and TileGeoG4CalibSD2020-06-30T02:30:34+02:00Liangliang HanTest classes TileGeoG4SD and TileGeoG4CalibSDIn the branch, I will test the classes `TileGeoG4SD` and `TileGeoG4CalibSD`. Here is how I did about my testing strategy.
1. I put my test codes in the `test` folder. And the nomenclature is like `CLASSNAME_gtest.cxx` for testing the ...In the branch, I will test the classes `TileGeoG4SD` and `TileGeoG4CalibSD`. Here is how I did about my testing strategy.
1. I put my test codes in the `test` folder. And the nomenclature is like `CLASSNAME_gtest.cxx` for testing the class `CLASSNAME`.
2. I created the jobOption file `optionForTest.txt`, which is placed in the `share` folder.
3. In oder to add my test classes as friends of the tested classes, I add several lines for that in the file `CLASSNAME_gtest.h`.
4. Of course, I add some lines in the `CMakeLists.txt` for compiling my test code, using google test frame work, and so on.
5. I create 3 files and put them into the folder `Simulation/G4Atlas/G4AtlasTools/G4AtlasTools`. The 1st file is `DerivedG4SensitiveDetectorTestSetting.h`, where I define a function for setting G4-objects to G4Step object. The 2nd file is `G4MyPhysicalVolume.h`, where I define a class called `G4MyPhysicalVolume` that is derived from `G4VPhysicalVolume`. The 3rd file is `G4MyProcess.h`, where I define a class called `G4MyProcess` that is derived from `G4VProcess`.
6. Also, I created a file called `DerivedG4SensitiveDetector.h` in the folder `Simulation/G4Atlas/G4AtlasTools/G4AtlasTools`, which is intended to define a class inheriting from a abstract class `G4VSensitiveDetector`. Then I can use the derived class in my test codes.
7. In addition, I created files called `DerivedISvcLocator.h` and `DerivedITileCalculator.h` where two classes are defined with inheriting respectively class `SvcLocator` and class `ITileCalculator`.
8. It is worth mentioning that I use different TEST_F to test different member functions of the tested class.https://gitlab.cern.ch/atlas/athena/-/merge_requests/26373Test blm sensor sd2019-11-12T16:39:46+01:00Liangliang HanTest blm sensor sdIn this branch, I tested the class `BLMSensorSD` in the package `InnerDetector/InDetG4/BLM_G4_SD`. Here is how I did.
1. I place my test code `BLMSensorSD_gtest.cxx` in the `test` folder. And it is for testing the class `BLMSensorSD`.
...In this branch, I tested the class `BLMSensorSD` in the package `InnerDetector/InDetG4/BLM_G4_SD`. Here is how I did.
1. I place my test code `BLMSensorSD_gtest.cxx` in the `test` folder. And it is for testing the class `BLMSensorSD`.
2. I created the jobOption file `optionForTest.txt`, which is placed in the share folder.
3. In oder to add my test classes as friends of the tested classes, I add several lines for that.
4. Of course, I add some lines in the CMakeLists.txt for compiling my test code, using google test frame work, and so on.
5. I create 3 files and put them into the folder `Simulation/G4Atlas/G4AtlasTools/G4AtlasTools`. The 1st file is `DerivedG4SensitiveDetectorTestSetting.h`, where I define a function for setting G4-objects to G4Step object. The 2nd file is `G4MyPhysicalVolume.h`, where I define a class called `G4MyPhysicalVolume` that is derived from `G4VPhysicalVolume`. The 3rd file is `G4MyProcess.h`, where I define a class called `G4MyProcess` that is derived from `G4VProcess`.
6. It is worth mentioning that I use different TEST_F to test different member functions of the tested class.https://gitlab.cern.ch/atlas/athena/-/merge_requests/26372Test bcm sensor sd2021-01-18T15:32:48+01:00Liangliang HanTest bcm sensor sdIn the branch, I tested the class called `BCMSensorSD` in the package `InnerDetector/InDetG4/BCM_G4_SD`. Here is how I did.
1. I place my test code `BCMSensorSD_gtest.cxx` in the `test` folder. Apparently, it is for testing the class `BC...In the branch, I tested the class called `BCMSensorSD` in the package `InnerDetector/InDetG4/BCM_G4_SD`. Here is how I did.
1. I place my test code `BCMSensorSD_gtest.cxx` in the `test` folder. Apparently, it is for testing the class `BCMSensorSD`.
2. I created the jobOption file `optionForTest.txt`, which is placed in the share folder.
3. In oder to add my test classes as friends of the tested classes, I add several lines for that.
4. Of course, I add some lines in the CMakeLists.txt for compiling my test code, using google test frame work, and so on.
5. I create 3 files and put them into the folder `Simulation/G4Atlas/G4AtlasTools/G4AtlasTools`. The 1st file is `DerivedG4SensitiveDetectorTestSetting.h`, where I define a function for setting G4-objects to G4Step object. The 2nd file is `G4MyPhysicalVolume.h`, where I define a class called `G4MyPhysicalVolume` that is derived from `G4VPhysicalVolume`. The 3rd file is `G4MyProcess.h`, where I define a class called `G4MyProcess` that is derived from `G4VProcess`.
6. It is worth mentioning that I use different TEST_F to test different member functions of the tested class.https://gitlab.cern.ch/atlas/athena/-/merge_requests/26368Test alfa sensitive detector2019-11-12T16:39:20+01:00Liangliang HanTest alfa sensitive detectorIn the branch, I tested the class called `ALFA_SensitiveDetector` in the package `ForwardDetectors/ALFA/ALFA_G4_SD`. Here
is what I did about the package.
1. I put my test code `ALFA_SensitiveDetector_gtest.cxx` in the `test` folder. A...In the branch, I tested the class called `ALFA_SensitiveDetector` in the package `ForwardDetectors/ALFA/ALFA_G4_SD`. Here
is what I did about the package.
1. I put my test code `ALFA_SensitiveDetector_gtest.cxx` in the `test` folder. And it is for testing the class `ALFA_SensitiveDetector`.
2. I created the jobOption file `optionForTest.txt`, which is placed in the share folder.
3. In oder to add my test classes as friends of the tested classes, I add several lines for that.
4. Of course, I add some lines in the CMakeLists.txt for compiling my test code, using google test frame work, and so on.
5. I create 3 files and put them into the folder `Simulation/G4Atlas/G4AtlasTools/G4AtlasTools`. The 1st file is `DerivedG4SensitiveDetectorTestSetting.h`, where I define a function for setting G4-objects to G4Step object. The 2nd file is `G4MyPhysicalVolume.h`, where I define a class called `G4MyPhysicalVolume` that is derived from `G4VPhysicalVolume`. The 3rd file is `G4MyProcess.h`, where I define a class called `G4MyProcess` that is derived from `G4VProcess`.
6. It is worth mentioning that I use different TEST_F to test different member functions of the tested class.https://gitlab.cern.ch/atlas/athena/-/merge_requests/26369Test afp sensitive detector2019-11-12T16:39:29+01:00Liangliang HanTest afp sensitive detectorIn this branch, I tested 3 classes, which are respectively `AFP_SensitiveDetector`, `AFP_SiDSensitiveDetector` and `AFP_TDSensitiveDetector`. And they are all in the package `ForwardDetectors/AFP/AFP_G4_SD`. Here is what I did.
1. My te...In this branch, I tested 3 classes, which are respectively `AFP_SensitiveDetector`, `AFP_SiDSensitiveDetector` and `AFP_TDSensitiveDetector`. And they are all in the package `ForwardDetectors/AFP/AFP_G4_SD`. Here is what I did.
1. My test codes are placed in the `test` folder, and they are `AFP_SensitiveDetector_gtest.cxx`, `AFP_SiDSensitiveDetector_gtest.cxx` and `AFP_TDSensitiveDetector_gtest.cxx` for respectively testing `AFP_SensitiveDetector , `AFP_SiDSensitiveDetector` and `AFP_TDSensitiveDetector`.
2. I created the jobOption file `optionForTest.txt`, which is placed in the share folder.
3. In oder to add my test classes as friends of the tested classes, I add several lines for that.
4. Of course, I add some lines in the CMakeLists.txt for compiling my test code, using google test frame work, and so on.
5. I create 3 files and put them into the folder `Simulation/G4Atlas/G4AtlasTools/G4AtlasTools`. The 1st file is `DerivedG4SensitiveDetectorTestSetting.h`, where I define a function for setting G4-objects to G4Step object. The 2nd file is `G4MyPhysicalVolume.h`, where I define a class called `G4MyPhysicalVolume` that is derived from `G4VPhysicalVolume`. The 3rd file is `G4MyProcess.h`, where I define a class called `G4MyProcess` that is derived from `G4VProcess`.
6. It is worth mentioning that I use different TEST_F to test different member functions of the tested class.https://gitlab.cern.ch/atlas/athena/-/merge_requests/34029tauRecTools+LArG4FastSimulation: cmake fixes2020-06-24T23:05:23+02:00Scott SnydertauRecTools+LArG4FastSimulation: cmake fixesLibrary dependency fixes.Library dependency fixes.https://gitlab.cern.ch/atlas/athena/-/merge_requests/56154tauRecTools: fix conditional decoration in TauIDVarCalculator2022-09-02T16:05:10+02:00Bertrand Martin Dit LatourtauRecTools: fix conditional decoration in TauIDVarCalculatorHello,
As reported in ATLASRECTS-7186, there is a decoration that is only added onto certain taus (those with at least 1 track).
This causes trouble downstream, when making derivations.
This MR adds a dummy decoration for 0-prong taus.
...Hello,
As reported in ATLASRECTS-7186, there is a decoration that is only added onto certain taus (those with at least 1 track).
This causes trouble downstream, when making derivations.
This MR adds a dummy decoration for 0-prong taus.
Fortunately, this variable is no longer used in R22, it is deprecated, so it won't have any consequence.
But it's too late to phase it out.
Technically, it may be considered as violating frozen T0 policy as it alters the AOD content for 0p taus, but as the variable is not used at all in R22, I hope it won't be an issue.
Cheers,
BertrandBertrand Martin Dit LatourBertrand Martin Dit Latourhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/54741Sweeping !54734 from master to 22.0.
MuonG4SD: fix thread-checker warning2022-07-01T11:53:32+02:00Atlas NightlybuildSweeping !54734 from master to 22.0.
MuonG4SD: fix thread-checker warningMuonG4SD: fix thread-checker warning
See merge request atlas/athena!54734MuonG4SD: fix thread-checker warning
See merge request atlas/athena!54734https://gitlab.cern.ch/atlas/athena/-/merge_requests/46179Sweeping !46149 from master to 22.0-mc20.
MuonMDT_CnvTools: Use central defin...2021-08-31T10:49:29+02:00Atlas NightlybuildSweeping !46149 from master to 22.0-mc20.
MuonMDT_CnvTools: Use central definition of maxNTubesPerLayerMuonMDT_CnvTools: Use central definition of maxNTubesPerLayer
See merge request atlas/athena!46149MuonMDT_CnvTools: Use central definition of maxNTubesPerLayer
See merge request atlas/athena!46149https://gitlab.cern.ch/atlas/athena/-/merge_requests/30635Sweeping !30345 from 21.0 to master.
Add new package CaloSamplingFractionAnal...2020-02-26T14:15:47+01:00Atlas NightlybuildSweeping !30345 from 21.0 to master.
Add new package CaloSamplingFractionAnalysis for calorimeter sampling fraction extractionAdd new package CaloSamplingFractionAnalysis for calorimeter sampling fraction extraction
See merge request atlas/athena!30345Add new package CaloSamplingFractionAnalysis for calorimeter sampling fraction extraction
See merge request atlas/athena!30345https://gitlab.cern.ch/atlas/athena/-/merge_requests/24732Sweeping !24567 from 21.0 to master.
Extra SM mesons2019-08-26T13:27:37+02:00Atlas NightlybuildSweeping !24567 from 21.0 to master.
Extra SM mesonsExtra SM mesons
See merge request atlas/athena!24567Extra SM mesons
See merge request atlas/athena!24567