athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2022-11-28T12:01:10+01:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/58768G4UserActions: suppress thread-checker warnings2022-11-28T12:01:10+01:00Frank WinklmeierG4UserActions: suppress thread-checker warningsThe `G4UserAction` interface only provides access to a constant track.
So there is no way to avoid the `const_cast`.The `G4UserAction` interface only provides access to a constant track.
So there is no way to avoid the `const_cast`.https://gitlab.cern.ch/atlas/athena/-/merge_requests/58691Draft: Replace the substr() with resize as cppcheck suggests2022-11-27T18:38:34+01:00Andrii VerbytskyiDraft: Replace the substr() with resize as cppcheck suggestsReplace the substr() with resize as cppcheck suggests
Atg @sroe @fwinkelReplace the substr() with resize as cppcheck suggests
Atg @sroe @fwinkelhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/58203Draft: First steps to optimize MC in digitalization2022-11-24T21:11:31+01:00Andrii VerbytskyiDraft: First steps to optimize MC in digitalizationTHIS IS A DRAFT!
But it is nice to check if it compiles in CI.
First steps to optimize MC in digitalization
@jchapmanTHIS IS A DRAFT!
But it is nice to check if it compiles in CI.
First steps to optimize MC in digitalization
@jchapmanhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/58594G4UserActions: Fix cppcheck warnings.2022-11-23T22:18:26+01:00Scott SnyderG4UserActions: Fix cppcheck warnings.Fix cppcheck warnings.Fix cppcheck warnings.https://gitlab.cern.ch/atlas/athena/-/merge_requests/55892Draft: Make mis-configured ItemList an ERROR rather than WARNING2022-11-23T21:18:50+01:00Peter Van GemmerenDraft: Make mis-configured ItemList an ERROR rather than WARNINGAs discussed in Jira: ATEAM-851 this MR will cause an ERROR for mis-configured ItemLists.
However it does _not_ yet modify ~5 clients that use versioned types, as in the very past this may have been ok.As discussed in Jira: ATEAM-851 this MR will cause an ERROR for mis-configured ItemLists.
However it does _not_ yet modify ~5 clients that use versioned types, as in the very past this may have been ok.Peter Van GemmerenPeter Van Gemmerenhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/58613Add script for running tracking on pileup RDO files2022-11-22T22:40:34+01:00William Axel LeightAdd script for running tracking on pileup RDO filesThis script runs ID tracking on pileup RDO files to create tracks that are to be used when running track overlay. The tracks and associated PRDs are saved into the RDO file.This script runs ID tracking on pileup RDO files to create tracks that are to be used when running track overlay. The tracks and associated PRDs are saved into the RDO file.https://gitlab.cern.ch/atlas/athena/-/merge_requests/56982Adding two ART tests for Track-overlay2022-11-22T13:46:13+01:00Martina JavurkovaAdding two ART tests for Track-overlayAdding two ART tests running Track-overlay in FastChain for mc20 and mc21.Adding two ART tests running Track-overlay in FastChain for mc20 and mc21.https://gitlab.cern.ch/atlas/athena/-/merge_requests/58522Draft: Reduce the number of calls to HepMC::barcode2022-11-21T18:34:43+01:00Andrii VerbytskyiDraft: Reduce the number of calls to HepMC::barcodeReduce the number of calls to HepMC::barcode
Tag @jchapmanReduce the number of calls to HepMC::barcode
Tag @jchapmanhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/58503Draft: Simulation/ISF/ISF_FatrasTools : manual port of changes in MR56730 to 222022-11-18T17:52:24+01:00Liza MijovicDraft: Simulation/ISF/ISF_FatrasTools : manual port of changes in MR56730 to 22MR !56730 made useful updates to ISF_FatrasTools in master. These should be in 22.0 too . This MR ports the MR56730 diff to 22.0 . It does not need to be swept to master.MR !56730 made useful updates to ISF_FatrasTools in master. These should be in 22.0 too . This MR ports the MR56730 diff to 22.0 . It does not need to be swept to master.https://gitlab.cern.ch/atlas/athena/-/merge_requests/58192Attempt to optimize filtering2022-11-18T16:53:22+01:00Andrii VerbytskyiAttempt to optimize filteringAttempt to optimize filtering and avoid barcodes.
@jchapman ,
what do you think?
See https://gitlab.cern.ch/atlas/athena/-/merge_requests/58504Attempt to optimize filtering and avoid barcodes.
@jchapman ,
what do you think?
See https://gitlab.cern.ch/atlas/athena/-/merge_requests/58504https://gitlab.cern.ch/atlas/athena/-/merge_requests/58425ISFTruthIncident: const fix2022-11-17T11:25:57+01:00Frank WinklmeierISFTruthIncident: const fixUse `as_const` to avoid thread-checker warning.Use `as_const` to avoid thread-checker warning.https://gitlab.cern.ch/atlas/athena/-/merge_requests/58373Modification of V2.3 processing to work well with all clients2022-11-14T17:23:39+01:00Iurii BordulevModification of V2.3 processing to work well with all clientsThe previous merge contained algorithms for HanOutputFile
of version 2 (V2.3.1) formation. This code was modified
in this merge request. All the clients now work similarly
well with V1 and V2 HanOutputFiles.The previous merge contained algorithms for HanOutputFile
of version 2 (V2.3.1) formation. This code was modified
in this merge request. All the clients now work similarly
well with V1 and V2 HanOutputFiles.Peter OnyisiPeter Onyisihttps://gitlab.cern.ch/atlas/athena/-/merge_requests/58289New NVSI calibration2022-11-10T21:58:23+01:00Vadim KostyukhinNew NVSI calibrationUse new 2-track calibration file in NVSIUse new 2-track calibration file in NVSIhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/58286New NVSI calibration2022-11-10T14:47:09+01:00Vadim KostyukhinNew NVSI calibrationUse news 2-track vertices calibration fileUse news 2-track vertices calibration filehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/58106Update NVSI example algorithm2022-11-04T19:55:57+01:00Vadim KostyukhinUpdate NVSI example algorithm1) Make NVSI example algorithm reentrant
2) Add CA script for the example algorithm1) Make NVSI example algorithm reentrant
2) Add CA script for the example algorithmhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/58006Draft: TrackStateOnSurface change FitQualityOnSurface to Value2022-11-03T16:18:55+01:00Christos Anastopouloschristos.anastopoulos@cern.chDraft: TrackStateOnSurface change FitQualityOnSurface to ValueThis is the 1st (?) continuation of !58002 .
- Store the FitQualityOnSurface in the TSOS as a value (rather than ptr)This is the 1st (?) continuation of !58002 .
- Store the FitQualityOnSurface in the TSOS as a value (rather than ptr)https://gitlab.cern.ch/atlas/athena/-/merge_requests/57795Update ISFTruthIncident_test unit test to be compatible with HepMC32022-10-25T02:39:51+02:00John Derek ChapmanUpdate ISFTruthIncident_test unit test to be compatible with HepMC3Fixes ATLASSIM-6084Fixes ATLASSIM-6084https://gitlab.cern.ch/atlas/athena/-/merge_requests/57679New sim flag for agdd2022-10-20T09:57:43+02:00Joseph BoudreauNew sim flag for agddA new flag to manually disable AGDD input is introduced. This is to facilitate transition to the new Detector Description. The default behaviour is unchanged.A new flag to manually disable AGDD input is introduced. This is to facilitate transition to the new Detector Description. The default behaviour is unchanged.https://gitlab.cern.ch/atlas/athena/-/merge_requests/57049Draft: sweep FCS MPT Run3 developments to master2022-10-14T20:10:43+02:00Thomas Michael CarterDraft: sweep FCS MPT Run3 developments to masterSweep of https://gitlab.cern.ch/atlas/athena/-/merge_requests/54822 and related MRs to master.Sweep of https://gitlab.cern.ch/atlas/athena/-/merge_requests/54822 and related MRs to master.Thomas Michael CarterThomas Michael Carterhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/52324Draft: PLR Digitization Implementation2022-10-07T10:46:23+02:00Deion Elgin FellersDraft: PLR Digitization ImplementationThis MR sets up the digitization for the Pixel Luminosity Rings (PLR) detector.
Because the PLR is made from the same pixel modules that are in ITkPixel, it utilizes the same digitization algorithms as well. Here we are just configuring...This MR sets up the digitization for the Pixel Luminosity Rings (PLR) detector.
Because the PLR is made from the same pixel modules that are in ITkPixel, it utilizes the same digitization algorithms as well. Here we are just configuring the pixel digitization algorithms differently for the PLR such that they use the `PLR_ID` identifier scheme, use the "PLR" instantiation of the `PixelDetectorManager`, and also access PLR specific data and settings.
I have also implemented the RDO analysis code for the PLR (`PLR_RDOAnalysis`) which outputs a simple root file filled with PLR RDO data.
In the attached images, you can see the content of the `RDOAnalysis` root file, the ToT distribution of the PLR RDOs, the global x-y scatter plot of PLR RDOs, and the global z-r scatter plot of ITkPixel and PLR RDOs (you can see the PLR at |z| = 2250 mm and r = 100 mm).
![Screen_Shot_2022-04-17_at_6.54.50_PM](/uploads/8b583d877667034f63a34db1f3f39e83/Screen_Shot_2022-04-17_at_6.54.50_PM.png)
![Screen_Shot_2022-04-17_at_7.44.29_PM](/uploads/81eba5608a4c6029a3f4314da4214f21/Screen_Shot_2022-04-17_at_7.44.29_PM.png)
![Screen_Shot_2022-04-17_at_6.47.26_PM](/uploads/e0aec2c9abff03b293c6317ad28fcaa0/Screen_Shot_2022-04-17_at_6.47.26_PM.png)
![Screen_Shot_2022-04-17_at_6.50.51_PM](/uploads/605646a0cf4f7b398830f4559e80c57e/Screen_Shot_2022-04-17_at_6.50.51_PM.png)