athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2020-11-23T12:49:56+01:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/32152WIP: Migration of the AthSimulation project to HepMC3, part II2020-11-23T12:49:56+01:00Andrii VerbytskyiWIP: Migration of the AthSimulation project to HepMC3, part IIActual utilization of HepMC3.Actual utilization of HepMC3.https://gitlab.cern.ch/atlas/athena/-/merge_requests/36214WIP: Migration of all codes to HepMC32020-11-23T12:50:34+01:00Andrii VerbytskyiWIP: Migration of all codes to HepMC3WIP: Migration of all codes to HepMC3WIP: Migration of all codes to HepMC3https://gitlab.cern.ch/atlas/athena/-/merge_requests/32202WIP: Migration of the AnalysisBase project to HepMC3, part II2020-11-26T14:29:49+01:00Andrii VerbytskyiWIP: Migration of the AnalysisBase project to HepMC3, part IIActual usage of HepMC3Actual usage of HepMC3https://gitlab.cern.ch/atlas/athena/-/merge_requests/38595Avoid DB configuration dependency in InDetGMFlags2020-11-28T04:59:51+01:00Peter OnyisiAvoid DB configuration dependency in InDetGMFlagsTry to address ATR-22390, ATLASRECTS-5778Try to address ATR-22390, ATLASRECTS-5778https://gitlab.cern.ch/atlas/athena/-/merge_requests/38940G fex met2020-12-07T20:41:22+01:00Ava Anne MyersG fex metAdded variant of Rho+RMS algorithm in which RMS is pulled from LUT rather than calculated in-timeAdded variant of Rho+RMS algorithm in which RMS is pulled from LUT rather than calculated in-timehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/3906221.0 add tfcs energy interpolation histogram2020-12-10T20:02:05+01:00Benedict Tobias Winter21.0 add tfcs energy interpolation histogramAdd functionality to determine the total energy to be deposited for a particle in FastCaloSim based on histograms that serve as lookup tables. Planned use case is for low energy hadrons.Add functionality to determine the total energy to be deposited for a particle in FastCaloSim based on histograms that serve as lookup tables. Planned use case is for low energy hadrons.https://gitlab.cern.ch/atlas/athena/-/merge_requests/27463WIP: Allow 21.0 branch to read HepMcParticleLink_p3-based persistent classes2021-01-06T15:59:20+01:00John Derek ChapmanWIP: Allow 21.0 branch to read HepMcParticleLink_p3-based persistent classesFor compatibility with ~"21.3" after !27145 is merged.For compatibility with ~"21.3" after !27145 is merged.https://gitlab.cern.ch/atlas/athena/-/merge_requests/27467WIP: Allow 21.0-mc16dbranch to read HepMcParticleLink_p3-based persistent cla...2021-01-06T15:59:23+01:00John Derek ChapmanWIP: Allow 21.0-mc16dbranch to read HepMcParticleLink_p3-based persistent classesFor compatibility with ~"21.3" after !27145 is merged.For compatibility with ~"21.3" after !27145 is merged.https://gitlab.cern.ch/atlas/athena/-/merge_requests/28533WIP: FastCaloSim Gaussian Correlated Fluctuations2021-01-25T12:34:33+01:00Sean Joseph GasiorowskiWIP: FastCaloSim Gaussian Correlated FluctuationsIncludes changes necessary for running correlated fluctuations in FastCaloSim with the Gaussian method. This is largely contained in, e.g., the class TFCSVoxelHistoLateralCovarianceFluctuations, which draws weights using a set of input h...Includes changes necessary for running correlated fluctuations in FastCaloSim with the Gaussian method. This is largely contained in, e.g., the class TFCSVoxelHistoLateralCovarianceFluctuations, which draws weights using a set of input histograms/a covariance matrix and applies them on top of simulated hits.https://gitlab.cern.ch/atlas/athena/-/merge_requests/39925Draft: Hepmc3 nightly fixes 22012021 part 22021-01-31T19:37:12+01:00Andrii VerbytskyiDraft: Hepmc3 nightly fixes 22012021 part 2In this MR:
- Edit meIn this MR:
- Edit mehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/40472Draft: Hepmc3 nightly fixes 09022021 part 12021-02-09T15:02:15+01:00Andrii VerbytskyiDraft: Hepmc3 nightly fixes 09022021 part 1In this MR:
- Eliminate some warnings, mostly unused variablesIn this MR:
- Eliminate some warnings, mostly unused variableshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/40943Add flag for running LengthIntegrator UserAction2021-02-23T14:21:46+01:00Nicholas StylesAdd flag for running LengthIntegrator UserActionAdd a way to configure the LengthIntegrator UserAction to be added to simulation jobs, for material checks. Add an option to run with this flag to TestITk.py
@jchapman @tadej is this new Sim flag OK for you?Add a way to configure the LengthIntegrator UserAction to be added to simulation jobs, for material checks. Add an option to run with this flag to TestITk.py
@jchapman @tadej is this new Sim flag OK for you?https://gitlab.cern.ch/atlas/athena/-/merge_requests/41085Allowing SiHitAnalysis to handle HGTD_Hits2021-02-25T22:39:28+01:00Noemi CalaceAllowing SiHitAnalysis to handle HGTD_HitsSelf-explanatory name. I have also updated the post-include file `postInclude.SiHitAnalysis.py ` so that people can produce the validation file running the sim job.
FYI: @cohm, @lshan, @dshope, @nstyles, @tadejSelf-explanatory name. I have also updated the post-include file `postInclude.SiHitAnalysis.py ` so that people can produce the validation file running the sim job.
FYI: @cohm, @lshan, @dshope, @nstyles, @tadejNoemi CalaceNoemi Calacehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/26955WIP: Fix Dictionary creation error noted in !266602021-03-01T17:36:29+01:00John Derek ChapmanWIP: Fix Dictionary creation error noted in !26660https://gitlab.cern.ch/atlas/athena/-/merge_requests/27145WIP:Update transient HepMcParticleLink to use unsigned int for eventIndex2021-03-01T19:17:31+01:00John Derek ChapmanWIP:Update transient HepMcParticleLink to use unsigned int for eventIndexhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/27466WIP: Allow 21.0-mc16a branch to read HepMcParticleLink_p3-based persistent cl...2021-03-02T12:54:39+01:00John Derek ChapmanWIP: Allow 21.0-mc16a branch to read HepMcParticleLink_p3-based persistent classesFor compatibility with ~"21.3" after !27145 is merged.For compatibility with ~"21.3" after !27145 is merged.https://gitlab.cern.ch/atlas/athena/-/merge_requests/27498WIP:Update transient HepMcParticleLink to use unsigned int for eventIndex2021-03-02T13:20:43+01:00John Derek ChapmanWIP:Update transient HepMcParticleLink to use unsigned int for eventIndexhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/40263WIP:Acts Fatras2021-03-16T16:15:43+01:00Yi Fei HanWIP:Acts FatrasIncludes the interface to let us run acts-fatras in Athena with Sim_tfIncludes the interface to let us run acts-fatras in Athena with Sim_tfYi Fei HanYi Fei Hanhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/37913WIP: add radiation damage effects in fast pixel digitization2021-03-22T18:41:43+01:00Tommaso LariWIP: add radiation damage effects in fast pixel digitizationAdd radiation damage effects as a scaling in the charge in the fast pixel digitization, before comparing to threshold values (so pixel cells or entire clusters might be lost). The scaling factors are derived from full digitization or mea...Add radiation damage effects as a scaling in the charge in the fast pixel digitization, before comparing to threshold values (so pixel cells or entire clusters might be lost). The scaling factors are derived from full digitization or measurements, values for end of 2017, end of run2, and a couple end of run3 scenarios are available. The default is no radiation damage though, it can be changed from job option. Also revising the charge to TOT conversion and the amount of energy loss fluctuations. The default position smearing is changed so that cluster size and other observable are very close to previous output.
I previously opened [this merge request](https://gitlab.cern.ch/atlas/athena/-/merge_requests/28731) but somehow messed up when implementing the comments from the reviewers - I got errors in pushing to git and could not figure out why. So I started from scratch. All comments in the previous MR are addressed in this version, so I hope it will get through relatively easily. Sorry for the mess.https://gitlab.cern.ch/atlas/athena/-/merge_requests/41168Draft: Radiation damage digitisation updates2021-04-05T20:12:24+02:00Tomas DadoDraft: Radiation damage digitisation updatesI opened this MR to start a discussion about potential speed up of the code.
The MR brings two things:
* A minor speed up by factoring out the HepMC links calculation form the loops (this was probably done by the compiler anyway) and a...I opened this MR to start a discussion about potential speed up of the code.
The MR brings two things:
* A minor speed up by factoring out the HepMC links calculation form the loops (this was probably done by the compiler anyway) and also adding a simple speed up by skipping loops where the ramo potentials for electrons and holes were set to 0 and the iduced charge was thus zero as well. The second part actually changes the digitisation output - probably due to floating point precision or some random numbers, but this impact only radiation code and the changes are tiny (0.1%).
* The second part of the MR is the main point for discussion. It adds two cutoff values that can be set via JO file. The allow to skip some loops and thus significanctly reduce the reunning time, however, they also impact the result. The cutoff values are for ramo potential diffence (induced charge), these are rather safe but gain only a bit of CPU time since they do not really skip loops just the expensive part of the chanrge addition. The other cut simply skips the digitisation if the deposited energy is smaller than the cutoff - this is obviously more dangerous but also gains huge speed up. E.g. I tested a setup where the number of charges was reduced by 1-1.5% and gained a speed of around 30%. By default, both of the cutoff values are set to -1 so no cut is applied. Note that this also adds small CPU processing time since the condition has to be evaluated in the loops and by default it will always return false.
After a discusion in yesterdays radiation damage meeting it was agree that the changes are ok (reminderL by default this will _not_ apply any cut).
Cheers,
Tomas
cc @tadej @bnachman