athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2024-03-04T19:49:44+01:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/69460main-coverity-TRT_G4_SD2024-03-04T19:49:44+01:00Shaun Roemain-coverity-TRT_G4_SD[minor] coverity defect : unchecked dynamic_cast; in this context, can be static_cast.
This is purely code quality cleanup with no implied bug, so targeting main.[minor] coverity defect : unchecked dynamic_cast; in this context, can be static_cast.
This is purely code quality cleanup with no implied bug, so targeting main.https://gitlab.cern.ch/atlas/athena/-/merge_requests/6938623.0 ZDC_SimuDigitization add BRAN (cherry-pick of !69155)2024-03-04T11:53:06+01:00Chad Stephen Lantz23.0 ZDC_SimuDigitization add BRAN (cherry-pick of !69155)Added digitization of the BRAN module in the ZDC simulationAdded digitization of the BRAN module in the ZDC simulationhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/69155Add BRAN module digitization2024-03-04T11:53:06+01:00Chad Stephen LantzAdd BRAN module digitizationAdded digitization of the BRAN module in the ZDC simulationAdded digitization of the BRAN module in the ZDC simulationhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/694302024-03-01: merge of 24.0 into main2024-03-02T09:05:27+01:00Tadej Novaktadej.novak@cern.ch2024-03-01: merge of 24.0 into mainThis sweep contains the following MRs:
* !69411 Moving several chains to Physics after menu sign off ~Trigger, ~TriggerMenu
* !69407 confTool: speedup in case ignoreDefaults is not used ~Core
* !69415 add EventSelector to DataHeader s...This sweep contains the following MRs:
* !69411 Moving several chains to Physics after menu sign off ~Trigger, ~TriggerMenu
* !69407 confTool: speedup in case ignoreDefaults is not used ~Core
* !69415 add EventSelector to DataHeader store.retrieve ~Database
* !69414 LArCellRec: remove legacy configuration ~LAr, ~Simulation
* !69397 ATR-28888 -- Reimplement End-of-Event processing in HLT ~JetEtmiss, ~Trigger, ~TriggerMenu
* !69398 updates to trigJetMonitor, monGroups and additions to express stream ~DQ, ~JetEtmiss, ~Trigger, ~TriggerJet, ~TriggerMenu
* !69191 Update PEB DarkJet chains ~Trigger, ~TriggerMenu, ~changes-trigger-counts
* !69394 AthenaCommon+AthenaConfiguration: speedup gatherProps ~Core
* !69399 ATR-28836 - ATR-28871 - Assorted Menu actions for Displaced Jet signature ~Trigger, ~TriggerMenu, ~changes-trigger-counts
* !69324 Use dict lookup to find CF sequence in HLT Menu ~Trigger, ~TriggerMenu
* !69392 Move HH->bbtautau chains with tau preselections into physics; upgrade to bgn2 for all chains. ~JetEtmiss, ~Trigger, ~TriggerJet, ~TriggerMenu, ~changes-trigger-counts
* !68756 InDetTrig: replace access to ConfigSettings with ConfigFlags. ~JetEtmiss, ~Trigger, ~TriggerID, ~TriggerMenu, ~TriggerMinBias
* !68976 Restructure core Digitization packages ~Calorimeter, ~Core, ~DQ, ~Digitization, ~Egamma, ~ForwardDetectors, ~HGTD, ~ITk, ~InnerDetector, ~JetEtmiss, ~LAr, ~MuonSpectrometer, ~Overlay, ~Reconstruction, ~Simulation, ~Tau, ~Tile, ~Tools, ~Trigger
* !69295 Make InDetTimeCollection recording optional for ID raw data providers ~InnerDetector
* !69306 improve efex EmulatedTower building, including new debugging output. ~L1Calo, ~Trigger
* !69376 Allow DigitizationTests ART jobs to find 24.0-specific reference files (ATLASSIM-7095) ~Digitization, ~Simulation
* !69381 TriggerMenuMT: uncomment MBTSA/C triggers in L1 menus for pp and HI and uncomment corresponding HLT streamers in P1_run3_v1 menu ~Trigger, ~TriggerMenu
* !69238 Only book some LAr DT monitoring histograms if in the online environment. ~DQ, ~LAr, ~Trigger
* !69365 ATR-28873: support more workflows with container jobs in Trig_reco_tf.py ~Trigger
* !69359 Fix to turn on and off the 2 sigma ringer correction ~Trigger
* !69351 TrigP1Test: update debug stream test ~Trigger
* !69362 Adding the removal of CPS for BeeX chains (ATR-19501) ~Trigger, ~TriggerMenu
* !69345 TriggerMenuMT: merge EmptyMenuSequence[CA] ~Trigger, ~TriggerMenu
* !69346 Move remaining TrigInDetValidation test to CA ~Trigger
* !69348 Update TrigTransform Readme ~Trigger
* !69369 Also count the first hit associated to a truth particle. ~InnerDetector
* !69368 Fix decoration type clash for isSplit. ~Derivation, ~InnerDetector
* !69243 Remove legacy DigitizationFlags jobproperties module ~Digitization, ~Simulation
* !69335 AthSimulation CMake Fixes, 24.0 branch (2024.02.28.) ~Build
* !69317 MuonRdoToPrepData - Disable seeded decoding when trigger is offline ~MuonSpectrometer
* !69329 confTool: add ignoreOrder command line option ~Core
* !69310 Insert the correct GN2 tagger date string to complete the monitoring update as... ~DQ, ~Trigger
* !69297 Adding TRT Straw Status to the calibration chain ~InnerDetector
* !69274 trackless b-tagging ART test in 24.0 ~Analysis, ~BTagging, ~JetEtmiss
* !69323 TrigGlobalEfficiencyCorrectionTool: Fix FPE ~Trigger
* !69325 compareFlatTrees: Avoid canvas update if a branch fails ~Core
* !69328 MuonRecRTT: Fix typo in mkdir command ~MuonSpectrometerhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/69243Remove legacy DigitizationFlags jobproperties module2024-03-01T20:36:13+01:00John Derek ChapmanRemove legacy DigitizationFlags jobproperties moduleThere should be no remaining clients of this module in active CI tests and unit tests, so it should be safe to remove now.There should be no remaining clients of this module in active CI tests and unit tests, so it should be safe to remove now.https://gitlab.cern.ch/atlas/athena/-/merge_requests/69376Allow DigitizationTests ART jobs to find 24.0-specific reference files (ATLAS...2024-03-01T20:36:13+01:00John Derek ChapmanAllow DigitizationTests ART jobs to find 24.0-specific reference files (ATLASSIM-7095)This update is necessary for the comparisons against fixed reference files in 24.0 to work properly.
The script is only used in Digitization ART jobs so will not affect the CI output.This update is necessary for the comparisons against fixed reference files in 24.0 to work properly.
The script is only used in Digitization ART jobs so will not affect the CI output.https://gitlab.cern.ch/atlas/athena/-/merge_requests/68976Restructure core Digitization packages2024-03-01T20:36:13+01:00John Derek ChapmanRestructure core Digitization packages```
Simulation/Digitization -> Simulation/Digitization/DigitizationConfig
Simulation/G4Utilities/MCTruthSimAlgs -> Simulation/Digitization/MCTruthSimAlgs
```
Perhaps also move the following in a follow-up MR?
```
Control/PileUpComps -> S...```
Simulation/Digitization -> Simulation/Digitization/DigitizationConfig
Simulation/G4Utilities/MCTruthSimAlgs -> Simulation/Digitization/MCTruthSimAlgs
```
Perhaps also move the following in a follow-up MR?
```
Control/PileUpComps -> Simulation/Digitization/PileUpComps
Control/PileUpTools -> Simulation/Digitization/PileUpTools
```https://gitlab.cern.ch/atlas/athena/-/merge_requests/69414LArCellRec: remove legacy configuration2024-03-01T20:36:12+01:00Frank WinklmeierLArCellRec: remove legacy configurationRemove legacy job options, unused tests and update link dependencies. Also deleted unused tests that have been disabled 5 years ago.
cc @wlampl @ssnyder
Relates to ATLASRECTS-7896.Remove legacy job options, unused tests and update link dependencies. Also deleted unused tests that have been disabled 5 years ago.
cc @wlampl @ssnyder
Relates to ATLASRECTS-7896.https://gitlab.cern.ch/atlas/athena/-/merge_requests/69203Draft: HepMcParticleLink: Testing the adaption to GenParticle::id2024-02-29T14:08:28+01:00John Derek ChapmanDraft: HepMcParticleLink: Testing the adaption to GenParticle::idFollows !69076Follows !69076https://gitlab.cern.ch/atlas/athena/-/merge_requests/69354Quirks: Fix cppcheck warnings.2024-02-29T07:16:37+01:00Scott SnyderQuirks: Fix cppcheck warnings.Prefer to initialize class members in an initialization list.
Delete copy/assignment for class that manages memory.
Add abort() calls after G4Exception(), which is missing a [[noreturn]]
declaration.Prefer to initialize class members in an initialization list.
Delete copy/assignment for class that manages memory.
Add abort() calls after G4Exception(), which is missing a [[noreturn]]
declaration.https://gitlab.cern.ch/atlas/athena/-/merge_requests/69355HGTD_G4_SD: cmake fix2024-02-29T07:15:38+01:00Scott SnyderHGTD_G4_SD: cmake fixMissing GeoModel dependencies.
Closes HGTD_G4_SD-20240228Missing GeoModel dependencies.
Closes HGTD_G4_SD-20240228https://gitlab.cern.ch/atlas/athena/-/merge_requests/693202024-02-28: merge of 24.0 into main2024-02-28T15:08:53+01:00Tadej Novaktadej.novak@cern.ch2024-02-28: merge of 24.0 into mainThis sweep contains the following MRs:
* !69302 Uncomment Larnoiseburst chains, fix BGRP typo ~Trigger, ~TriggerMenu
* !69305 Replacing L1BTAG-MU5VFjJ50 with L1BTAG-MU5VFjJ80. ATR-24698 ~Trigger, ~TriggerMenu, ~changes-trigger-counts
...This sweep contains the following MRs:
* !69302 Uncomment Larnoiseburst chains, fix BGRP typo ~Trigger, ~TriggerMenu
* !69305 Replacing L1BTAG-MU5VFjJ50 with L1BTAG-MU5VFjJ80. ATR-24698 ~Trigger, ~TriggerMenu, ~changes-trigger-counts
* !69275 ATR-28571: Extend Trig_reco_tf.py functionality to allow athenaHLT running with legacy release inside a container ~Trigger
* !69106 AthenaConfiguration: remove global ConfigFlags instance ~Core, ~Derivation, ~Generators, ~Overlay, ~Reconstruction, ~Simulation, ~Tools, ~Trigger, ~TriggerMenu
* !69245 Removed obsolete DIPS, JetFitter and SV1 taggers and added spaceholders to... ~DQ, ~Trigger
* !69286 Fixup SiliconHitsTruthRelink ~Simulation
* !69296 CaloRingerAlgs: delete legacy job options ~CaloRinger, ~Reconstruction
* !69278 MuonRecRTT: Prevent cross-talk of Reco_tf runs ~MuonSpectrometer
* !69281 Minor fix for SimConfigFlags when running outside of ISF ~Simulation
* !69233 Inner Detector alignment monitoring (Run3) new npixhits_per_track_barrel histogram ~DQ, ~InnerDetector
* !69282 fix LArConditions2Ntuple.py, remove its legacy counterpart ~LAr
* !69277 delete LArConditionsCommon_H8_jobOptions.py and remaining (dysfunctional) clients ~LAr
* !69283 TrkVertexSeedFinderTools: run unit tests in their own directory ~Tracking
* !69168 TrigValTools: remove support of setting flags in legacy jobs ~Trigger
* !69291 B-physics trigger: move HLT_mu4_ivarloose_2mu3noL1_L1BPH-7M14-0DR25-MU5VFMU3VF chain from Dev_pp_run3_v1 to Physics_pp_run3_v1 (ATR-28868) ~Trigger, ~TriggerMenu
* !69293 L1CaloFEXSim: remove legacy job options and update unit tests ~L1Calo, ~Trigger
* !69284 ATR-28443 moving H->Z->qq/vv chains to Physics from Dev ~Trigger, ~TriggerMenu
* !69273 TriggerMenuMT+TriggerJobOpts: cleanup usage of CFElements ~Trigger, ~TriggerMenu
* !69201 maxmultfilter now filters jets depending on eta ~JetEtmiss, ~Trigger, ~TriggerJet, ~TriggerMenu, ~changes-trigger-counts
* !69249 Clean up legacy configs in JetTagging ~Analysis, ~BTagging, ~DQ, ~Derivation, ~JetEtmiss, ~Trigger
* !69248 Clean up legacy configs in PhysValMonitoring ~Analysis, ~JetEtmiss, ~Tau, ~Trigger
* !69244 TriggerMenuMT: remove caching of pebSequenceCfg ~Trigger, ~TriggerMenu
* !69220 Add L1BTAG-MU3VjJ40 seeded muon + bjet chains and the corresponding validation support chains to physics ~Trigger, ~TriggerMenu, ~changes-trigger-counts
* !69270 WorkflowTestRunner: Add ability for detailed comparison ~Tools
* !69173 AthenaConfiguration: delete OldFlags2NewFlags ~Core
* !69268 TrfTestsART: Fix configuration of serial merge tests ~Tools
* !68913 Improve implementation of flags cloneAndReplace ~ACTS, ~Core, ~Tracking
* !69257 update trig section of TauCP monitoring ~DQ, ~Reconstruction
* !69242 MagFieldUtils: delete legacy job options ~Magnetshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/69281Minor fix for SimConfigFlags when running outside of ISF2024-02-28T07:26:38+01:00John Derek ChapmanMinor fix for SimConfigFlags when running outside of ISFProducing calibration hits with G4AtlasAlg should be allowed when quasi-stable particle simulation is activated.
This does not affect production configurations, but could affect testing in the future.Producing calibration hits with G4AtlasAlg should be allowed when quasi-stable particle simulation is activated.
This does not affect production configurations, but could affect testing in the future.https://gitlab.cern.ch/atlas/athena/-/merge_requests/69286Fixup SiliconHitsTruthRelink2024-02-28T07:26:38+01:00John Derek ChapmanFixup SiliconHitsTruthRelinkSiHit constructor should take the updated HepMcParticleLink as an argument rather than the updated barcode for robustness.
Should not change the output currently.SiHit constructor should take the updated HepMcParticleLink as an argument rather than the updated barcode for robustness.
Should not change the output currently.https://gitlab.cern.ch/atlas/athena/-/merge_requests/69106AthenaConfiguration: remove global ConfigFlags instance2024-02-28T07:26:38+01:00Frank WinklmeierAthenaConfiguration: remove global ConfigFlags instanceRemove the global `ConfigFlags` instance and the safe-guards to delete the instance manually from the various skeletons and drivers.
There are still quite a few references to [import ConfigFlags](https://acode-browser1.usatlas.bnl.gov/l...Remove the global `ConfigFlags` instance and the safe-guards to delete the instance manually from the various skeletons and drivers.
There are still quite a few references to [import ConfigFlags](https://acode-browser1.usatlas.bnl.gov/lxr/search?!v=24.0&_filestring=.py&_string=import+ConfigFlags&_casesensitive=1) in our repository. But likely these are all unused legacy job options.
Requires: !69145 !69129 !69173
cc @tadejhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/67918R4 sTgcReadoutGeomTool - Adding Wiregroup Design2024-02-27T18:24:53+01:00Ishan Kiritbhai VyasR4 sTgcReadoutGeomTool - Adding Wiregroup Design@alainb @pscholer @jojungge
New MR to add Wiregroup to sTgcReadoutGeomTool, similar to strips.@alainb @pscholer @jojungge
New MR to add Wiregroup to sTgcReadoutGeomTool, similar to strips.https://gitlab.cern.ch/atlas/athena/-/merge_requests/692692024-02-27: merge of 24.0 into main2024-02-27T17:31:26+01:00Tadej Novaktadej.novak@cern.ch2024-02-27: merge of 24.0 into mainThis sweep contains the following MRs:
* !69232 ATR-28838 Remaining MET chains duplication clean up - HLT / ATR-28563 A Phase I L1Topo LLP Trigger ~Trigger, ~TriggerMenu, ~changes-trigger-counts
* !69237 Monitoring Improvement: use gen...This sweep contains the following MRs:
* !69232 ATR-28838 Remaining MET chains duplication clean up - HLT / ATR-28563 A Phase I L1Topo LLP Trigger ~Trigger, ~TriggerMenu, ~changes-trigger-counts
* !69237 Monitoring Improvement: use generic fillers for TProfile2D so that they support bin labels and bin extension ~Core, ~DQ
* !69192 AthenaPoolTest: migrate AthenaPoolTest and InDetRawData to CA and cleanup ~Test
* !69239 LumiBlockComps: delete obsolete files ~DQ
* !69241 Remove legacy job options from TGC_Digitization package ~Digitization, ~MuonSpectrometer
* !69234 main-coverity-TRT_CalibTools ~InnerDetector
* !68959 Cleanup transform setup of legacy config + TAG format ~Analysis, ~Calorimeter, ~Derivation, ~LAr, ~Overlay, ~Reconstruction, ~Simulation, ~Tools, ~Trigger
* !68848 Update ASG test files for DAOD_PHYS ~Analysis, ~CPAlgorithms, ~Core
* !69155 Add BRAN module digitization ~Digitization, ~ForwardDetectors, ~Simulation
* !69148 IOVDbTestAlg: migrate tests to CA ~Test
* !69211 B-physics trigger: move bBmux_BdmuDstarX trigger chains from Dev_pp_run3_v1 to Physics_pp_run3_v1 (ATR-27341) ~Trigger, ~TriggerMenu
* !69219 Fix offline tau distributions in the Tau Trigger Monitoring ~DQ, ~Tau, ~Trigger
* !67694 InDetTrigRecAlgs - remove obsolete package ~InnerDetector, ~Trigger, ~TriggerID
* !69198 Increase eta range for track selection ~Trigger
* !69013 DumpGeo: migrate it to CA and add a filter to dump DetectorManagers ~EventDisplay, ~Geometry
* !69215 LArConditionsTest: remove POOL catalog on test re-run ~LArhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/68956Cleanup final legacy overlay leftovers2024-02-27T16:21:43+01:00Tadej Novaktadej.novak@cern.chCleanup final legacy overlay leftoversCleanup final legacy overlay leftovers.
/cc @jchapman @mbandier @schaarscCleanup final legacy overlay leftovers.
/cc @jchapman @mbandier @schaarschttps://gitlab.cern.ch/atlas/athena/-/merge_requests/68959Cleanup transform setup of legacy config + TAG format2024-02-27T09:34:05+01:00Tadej Novaktadej.novak@cern.chCleanup transform setup of legacy config + TAG formatThis MR cleans up transform infrastructure in preparation for `--CA` being default:
- remove default skeleton
- cleanup references to legacy skeletons (main target of this MR)
- cleanup obsolete transform steps
- cleanup TAG format
...This MR cleans up transform infrastructure in preparation for `--CA` being default:
- remove default skeleton
- cleanup references to legacy skeletons (main target of this MR)
- cleanup obsolete transform steps
- cleanup TAG format
/cc @jchapman @nstyles @jcatmore @fwinkl @jdandoy @christos @wlamplhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/68858Support of RDO inputs to FPGATrackSim chain2024-02-27T09:08:37+01:00Ioannis MaznasSupport of RDO inputs to FPGATrackSim chainThis is just an extension of !68164 to support RDO input files.
Tagging: @jahreda @tbold
related to EFTRACK-326This is just an extension of !68164 to support RDO input files.
Tagging: @jahreda @tbold
related to EFTRACK-326