athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2024-02-19T17:32:25+01:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/69003MuonSensitiveDetectorsR4 - Merge GeoModel in the configuration2024-02-19T17:32:25+01:00Johannes Junggeburthjohannes.josef.junggeburth@cern.chMuonSensitiveDetectorsR4 - Merge GeoModel in the configurationPresence of the MuonReadoutGeometry is required
Tagging: @boudreauPresence of the MuonReadoutGeometry is required
Tagging: @boudreauhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/68987DigitizationTests(MT) Fixes to failing tests. ATLASSIM-70592024-02-18T19:45:23+01:00John Derek ChapmanDigitizationTests(MT) Fixes to failing tests. ATLASSIM-7059Fixes for some failing DigitizationTests(MT) ART scripts.
Tagging @zhubacekFixes for some failing DigitizationTests(MT) ART scripts.
Tagging @zhubacekhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/68974Remove more obsolete Simulation code2024-02-17T19:10:10+01:00John Derek ChapmanRemove more obsolete Simulation codeDrop obsolete packages:
```
Simulation/SimulationJobOptions
Simulation/ISF/ISF_Example
```
Clear up of more obsolete code (including some C++!) from the DigitizationTests package.Drop obsolete packages:
```
Simulation/SimulationJobOptions
Simulation/ISF/ISF_Example
```
Clear up of more obsolete code (including some C++!) from the DigitizationTests package.https://gitlab.cern.ch/atlas/athena/-/merge_requests/68909Remove legacy Tile Digitization configuration2024-02-15T20:24:57+01:00John Derek ChapmanRemove legacy Tile Digitization configurationRemove legacy Tile Digitization configurationRemove legacy Tile Digitization configurationhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/68908Removal of most legacy LArDigitization configuration2024-02-15T20:20:29+01:00John Derek ChapmanRemoval of most legacy LArDigitization configurationRemoval of most legacy LArDigitization configuration. Leaving LArDigitizationFlags for now.Removal of most legacy LArDigitization configuration. Leaving LArDigitizationFlags for now.https://gitlab.cern.ch/atlas/athena/-/merge_requests/66434MuonDigitization - Remove legacy configuration2024-02-15T19:16:52+01:00Johannes Junggeburthjohannes.josef.junggeburth@cern.chMuonDigitization - Remove legacy configurationRemove legacy digitization configuration for muons.Remove legacy digitization configuration for muons.https://gitlab.cern.ch/atlas/athena/-/merge_requests/68887ISF_FatrasToolsG4: Fix cppcheck warnings.2024-02-15T18:45:06+01:00Scott SnyderISF_FatrasToolsG4: Fix cppcheck warnings.Potentially uninitialized variable.Potentially uninitialized variable.https://gitlab.cern.ch/atlas/athena/-/merge_requests/68888ISF_FatrasInterfaces: Fix cppcheck warning.2024-02-15T18:44:26+01:00Scott SnyderISF_FatrasInterfaces: Fix cppcheck warning.Pass objects by const reference, not by value.Pass objects by const reference, not by value.https://gitlab.cern.ch/atlas/athena/-/merge_requests/66215Alter ComponentAccumulator addPublicTool function to return the name of the t...2024-02-15T12:24:05+01:00John Derek ChapmanAlter ComponentAccumulator addPublicTool function to return the name of the tool being added.Allows calls to `addPublicTool` and `getPublicTool` to be chained removing the
need to refer to specific tool names in configuration functions.
Follows !60946 - new syntax used in `ISF_MainConfig.py` module.
Tagging @wlampl, @fwinkl, @...Allows calls to `addPublicTool` and `getPublicTool` to be chained removing the
need to refer to specific tool names in configuration functions.
Follows !60946 - new syntax used in `ISF_MainConfig.py` module.
Tagging @wlampl, @fwinkl, @tadej, @tstreble and @tbold for comments on the tweak to `ComponentAccumulator`.https://gitlab.cern.ch/atlas/athena/-/merge_requests/68796Remove more legacy digitization configuration2024-02-15T11:50:40+01:00John Derek ChapmanRemove more legacy digitization configurationCalls to `Digi_tf.py`and `RDOMerge_tf.py`without the `--CA`option will fail.
This removes most legacy digitization configuration without overlapping with !66434.Calls to `Digi_tf.py`and `RDOMerge_tf.py`without the `--CA`option will fail.
This removes most legacy digitization configuration without overlapping with !66434.https://gitlab.cern.ch/atlas/athena/-/merge_requests/68638Add BRAN to ZDC geometry description2024-02-15T01:50:12+01:00Chad Stephen LantzAdd BRAN to ZDC geometry descriptionInclude the Run3 BRAN in the ZDC geometryInclude the Run3 BRAN in the ZDC geometryhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/68442Remove legacy sim config main2024-02-14T21:18:57+01:00John Derek ChapmanRemove legacy sim config mainWIP
Testing removal of legacy configuration for simulation, HITS merging and HITS filtering.
After the clean-up there are a number of package containing only unused code (no clients in CA-configuration):
- LArCalorimeter/LArG4/LArG4Fast...WIP
Testing removal of legacy configuration for simulation, HITS merging and HITS filtering.
After the clean-up there are a number of package containing only unused code (no clients in CA-configuration):
- LArCalorimeter/LArG4/LArG4FastSimSvc
- LArCalorimeter/LArGeoModel/LArGeoH62004Algs
- MuonSpectrometer/MuonG4/NSW_Sim
- Simulation/G4Extensions/G4HitFilter
- Simulation/G4Utilities/G4ProfilingTools
- Simulation/ISF/ISF_Geant4/ISF_Geant4CommonServices
- Simulation/ISF/ISF_Tracking/ISF_TrackingTools
- TileCalorimeter/TileG4/TileAncillary/DeadMaterial
- TileCalorimeter/TileG4/TileAncillary/CombinedScintillator
- TileCalorimeter/TileG4/TileAncillary/LarCrate
- TileCalorimeter/TileG4/TileAncillary/PhantomCalorimeter
These should be followed up separately to see if they still need to remain in the release.https://gitlab.cern.ch/atlas/athena/-/merge_requests/68833DigitizationTests ART: Drop obsolete test_Digi_tf_mc15_2015_heavy_ion.sh job ...2024-02-14T18:43:16+01:00John Derek ChapmanDigitizationTests ART: Drop obsolete test_Digi_tf_mc15_2015_heavy_ion.sh job (ATLASSIM-7059)This MR just removes an obsolete ART script - it will have no effect on the CI output.
Tagging @zhubacekThis MR just removes an obsolete ART script - it will have no effect on the CI output.
Tagging @zhubacekhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/68867MdtSensitiveDetectorsR4 --- Fix BMG cut tubes2024-02-14T18:07:15+01:00Johannes Junggeburthjohannes.josef.junggeburth@cern.chMdtSensitiveDetectorsR4 --- Fix BMG cut tubesIn the old implementation the tube extraction was ending up in non-existent BMG tubes and the correction mechanism was doomed from the beginning.
Tagging: @goblirscIn the old implementation the tube extraction was ending up in non-existent BMG tubes and the correction mechanism was doomed from the beginning.
Tagging: @goblirschttps://gitlab.cern.ch/atlas/athena/-/merge_requests/68873Fix RDOMerge_tf.py syntax in mc23 presampling tests (ATLASSIM-7084)2024-02-14T18:04:16+01:00John Derek ChapmanFix RDOMerge_tf.py syntax in mc23 presampling tests (ATLASSIM-7084)Fix RDOMerge_tf.py syntax in mc23 presampling tests (ATLASSIM-7084)
This merge request only affects ART scripts, so will not change CI test outputs.Fix RDOMerge_tf.py syntax in mc23 presampling tests (ATLASSIM-7084)
This merge request only affects ART scripts, so will not change CI test outputs.https://gitlab.cern.ch/atlas/athena/-/merge_requests/68164First working version of matrix merging2024-02-14T11:25:34+01:00Jahred Adelmanjahreda@gmail.comFirst working version of matrix mergingWe recently merged code to run matrix generation. This MR allows the files to be merged. The next step is to use the files to make fit constants! Tagging @tboldWe recently merged code to run matrix generation. This MR allows the files to be merged. The next step is to use the files to make fit constants! Tagging @tboldhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/68627Updating FastChain ART tests2024-02-13T20:16:16+01:00Martina JavurkovaUpdating FastChain ART testsSmall fix in config flags in FastChain legacy-based skeleton
All FastChain ART tests were updated:
* MC20a tests deleted (due to failures and obsolescence - they can be added after they are fixed)
* Updates made to MC21a tests
* NTUP...Small fix in config flags in FastChain legacy-based skeleton
All FastChain ART tests were updated:
* MC20a tests deleted (due to failures and obsolescence - they can be added after they are fixed)
* Updates made to MC21a tests
* NTUP step fixed
* Legacy-based tests deleted
* New tests running Hybrid-overlay with ML-based decision (whether an event will be reconstructed by MC- or Track-overlay) added
* Hybrid-overlap test (test_MC21a_ATLFAST3F_G4MS_HybridOverlay_ttbar_CA.sh): with a predefined threshold of 0.74201
* MC-overlay 2 test (test_MC21a_ATLFAST3F_G4MS_MCOverlay2_ttbar_CA.sh): with the threshold set to 0.1 (should provide the same physics results as the test with MC-overlap)
* Track-overlap test 2 (test_MC21a_ATLFAST3F_G4MS_TrackOverlay2_ttbar_CA.sh): with the threshold set to 0.95 (should provide the same physics results as the test with Track-overlap)
cc @jchapman, @tadejhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/68790Removal of legacy DAOD config - part 22024-02-13T18:31:13+01:00James CatmoreRemoval of legacy DAOD config - part 2ATLASG-2592
ATLASG-2593
ATLASG-2594
ATLASG-2595
ATLASG-2596
ATLASG-2597
ATLASG-2598
ATLASG-2599
This MR removes specific obsolete legacy job options for DAOD formats. In some cases they have been replaced with CA versions, in other case...ATLASG-2592
ATLASG-2593
ATLASG-2594
ATLASG-2595
ATLASG-2596
ATLASG-2597
ATLASG-2598
ATLASG-2599
This MR removes specific obsolete legacy job options for DAOD formats. In some cases they have been replaced with CA versions, in other cases not. Those which are still needed will have to be migrated at a later date. Many will not need to be replaced due to the transition to the new analysis model (PHYS/PHYSLITE)https://gitlab.cern.ch/atlas/athena/-/merge_requests/68788SimCoreTests(MT), ISF_Validation(MT): Fixes for ART scripts2024-02-13T16:54:42+01:00John Derek ChapmanSimCoreTests(MT), ISF_Validation(MT): Fixes for ART scriptsThe changes in this MR should fix most ART jobs which showed errors after the clean-up of legacy configuration jobs.
Tagging @zhubacekThe changes in this MR should fix most ART jobs which showed errors after the clean-up of legacy configuration jobs.
Tagging @zhubacekhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/68807FPGATrackSimConfTools: Fix cppcheck warning.2024-02-13T01:45:55+01:00Scott SnyderFPGATrackSimConfTools: Fix cppcheck warning.Spuriouos copy in range-for.Spuriouos copy in range-for.