athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2023-05-04T21:11:12+02:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/62712Draft: First steps to split barcode into origin and id2023-05-04T21:11:12+02:00Andrii VerbytskyiDraft: First steps to split barcode into origin and idDraft: First steps to split barcode into origin and idDraft: First steps to split barcode into origin and idhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/62285Draft: Reduce the usage of barcodes in TruthSvc2023-07-22T22:03:31+02:00Andrii VerbytskyiDraft: Reduce the usage of barcodes in TruthSvcReduce the usage of barcodes in TruthSvc.
Tag @jchapman @pclarkReduce the usage of barcodes in TruthSvc.
Tag @jchapman @pclarkhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/62225Draft: Cleanup in ISFTruthIncident2023-04-11T19:58:30+02:00Andrii VerbytskyiDraft: Cleanup in ISFTruthIncidentCleanup in ISFTruthIncident.
Hi @jchapman, some attention from you is needed here concerning the original code. Not sure it was useful from the first place.Cleanup in ISFTruthIncident.
Hi @jchapman, some attention from you is needed here concerning the original code. Not sure it was useful from the first place.https://gitlab.cern.ch/atlas/athena/-/merge_requests/62222Draft: Replace outdated code with STL2023-07-22T20:31:09+02:00Andrii VerbytskyiDraft: Replace outdated code with STLReplace outdated code with STL. Not to be merged!Replace outdated code with STL. Not to be merged!https://gitlab.cern.ch/atlas/athena/-/merge_requests/62221Draft: Optimization in Simulation2023-06-06T16:29:38+02:00Andrii VerbytskyiDraft: Optimization in SimulationOptimization in SimulationOptimization in Simulationhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/61839Draft: ISF_PunchThroughTools - Adjust PCA to reinclude all PCA mode2023-04-04T14:23:18+02:00Firdaus Soberifirdaus.soberi@cern.chDraft: ISF_PunchThroughTools - Adjust PCA to reinclude all PCA modeCurrent ISF_PunchThroughTools (MR https://gitlab.cern.ch/atlas/athena/-/merge_requests/61679) allows the PCA parametrization to be split based on different eta regions (or PIDs). <br/>
However, all-PCA option is not included.
This MR in...Current ISF_PunchThroughTools (MR https://gitlab.cern.ch/atlas/athena/-/merge_requests/61679) allows the PCA parametrization to be split based on different eta regions (or PIDs). <br/>
However, all-PCA option is not included.
This MR introduces JO option to pick all-eta PCA for the punch through simulation. <br/>
(target branch 23.0)
<br/> @tqiuhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/61678Draft: ISF_PunchThroughTools - Adjust PCA to accept splitting by pdgId and et...2023-03-20T17:08:26+01:00Firdaus Soberifirdaus.soberi@cern.chDraft: ISF_PunchThroughTools - Adjust PCA to accept splitting by pdgId and eta groupingsAdd the capability for the punch through PCA to accept splitting based on pdgId and eta groups, this is to separate several PCA contributions from protons/neutrons that have distinct energy and eta distribution characteristics than the o...Add the capability for the punch through PCA to accept splitting based on pdgId and eta groups, this is to separate several PCA contributions from protons/neutrons that have distinct energy and eta distribution characteristics than the other punch-through particles.
Tagging @tqiu<br/>
(for target branch 23.0)https://gitlab.cern.ch/atlas/athena/-/merge_requests/60896Draft: Simplerplinks22023-04-11T19:56:32+02:00Andrii VerbytskyiDraft: Simplerplinks2Try to find out how may places need an explicit constructor with particlesTry to find out how may places need an explicit constructor with particleshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/60401Annealing for robust fit2023-06-14T23:51:26+02:00Vadim KostyukhinAnnealing for robust fitUse small annealing in vertex fits with robust option depending on the fit iteration number.
This should speed up convergence and help to avoid fake minima.Use small annealing in vertex fits with robust option depending on the fit iteration number.
This should speed up convergence and help to avoid fake minima.https://gitlab.cern.ch/atlas/athena/-/merge_requests/60345Fix for running Sim_tf.py and Digi_tf.py in AthenaMP with legacy configuration2023-02-08T13:05:52+01:00John Derek ChapmanFix for running Sim_tf.py and Digi_tf.py in AthenaMP with legacy configurationThe changes in !60269 assume that `theApp._opts.evtMax` is always set in job transform jobs. This does not seem to be the case for legacy configuration `Sim_tf.py` and `Digi_tf.py` jobs at least. This merge request switches to using `the...The changes in !60269 assume that `theApp._opts.evtMax` is always set in job transform jobs. This does not seem to be the case for legacy configuration `Sim_tf.py` and `Digi_tf.py` jobs at least. This merge request switches to using `theApp.EvtMax` instead, which is set more reliably.
This should fix ATLASSIM-6367.
Tagging @maszyman, @tsulaia, @tadejhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/60218Draft: Remove the vertex weights used in a wrong way2023-03-17T17:32:18+01:00Andrii VerbytskyiDraft: Remove the vertex weights used in a wrong wayRemove the vertex weights used in a wrong way
Tag @jchapmanRemove the vertex weights used in a wrong way
Tag @jchapmanhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/59806Digi CA config for alternative MergeMcEvent2023-01-31T10:48:08+01:00Thomas StreblerDigi CA config for alternative MergeMcEventAdded CA configs for alternative MergeMcEvent modes. Also removes `ExpectLowPtMinBiasBackgroundCollection` and `ExpectHighPtMinBiasBackgroundCollection` for legacy config, as the arguments do not appear to exist any more.
Relevant for A...Added CA configs for alternative MergeMcEvent modes. Also removes `ExpectLowPtMinBiasBackgroundCollection` and `ExpectHighPtMinBiasBackgroundCollection` for legacy config, as the arguments do not appear to exist any more.
Relevant for ATLSWUPGR-167
Unfortunately the `NewMerge` config does not run
```
StandardInTimeO... ERROR WriteHandle already valid??
StandardInTimeO... ERROR PileUpComps/src/PileUpToolsAlg.cxx:89 (StatusCode PileUpToolsAlg::execute()): code FAILURE: puToolHandle->prepareEvent(Gaudi::Hive::currentContext(), eventsToProcessByTool[&(*puToolHandle)])
```
but merging the config regardless to have it available for debugging.
FYI @jchapmanhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/59650Draft: Should be faster fastcalosim2023-04-13T17:23:54+02:00Andrii VerbytskyiDraft: Should be faster fastcalosimShould be faster fastcalosim. Do not merge. Draft.
Tag @jchapman
To be discussed if this is needed.Should be faster fastcalosim. Do not merge. Draft.
Tag @jchapman
To be discussed if this is needed.https://gitlab.cern.ch/atlas/athena/-/merge_requests/59630Draft: Create a new global instance for legacy usage of CA-based ConfigFlags2023-03-09T10:17:54+01:00Tadej Novaktadej.novak@cern.chDraft: Create a new global instance for legacy usage of CA-based ConfigFlagsCreate a new global instance for legacy usage of CA-based `ConfigFlags`. The goal is to move away from the default global instance but keep one for legacy usage (where global state is expected anyways).
The API has not changed, just a n...Create a new global instance for legacy usage of CA-based `ConfigFlags`. The goal is to move away from the default global instance but keep one for legacy usage (where global state is expected anyways).
The API has not changed, just a new `globalConfigFlags` alias is now available.
/cc @jchapman, @fwinkl, @wlampl, @christos, @mhodgkin, @jcatmore, @nstyles, @tstreblehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/59134Use double for vertex weights2022-12-10T16:03:41+01:00Andrii VerbytskyiUse double for vertex weightsUse double for vertex weights.
Tag @jchapmanUse double for vertex weights.
Tag @jchapmanhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/58907Draft: Add the Voxel Density Optimization to the postInclude.G4Optimizations ...2023-07-05T10:04:27+02:00Marilena BandieramonteDraft: Add the Voxel Density Optimization to the postInclude.G4Optimizations script for Run3https://gitlab.cern.ch/atlas/athena/-/merge_requests/58869Validation muon tracking geometry developments ValiMTG_dev2023-05-05T10:47:31+02:00Oliver RiegerValidation muon tracking geometry developments ValiMTG_devSoftware developments to update the GeantFollowingMS package for Run3 analysis.
ATLASRECTS-7296Software developments to update the GeantFollowingMS package for Run3 analysis.
ATLASRECTS-7296https://gitlab.cern.ch/atlas/athena/-/merge_requests/58809Draft: Dropped IFastCaloSimGeometryHelper interface2022-11-29T08:41:43+01:00Vakhtang TsulaiaDraft: Dropped IFastCaloSimGeometryHelper interfaceMinor code cleanup. Dropped apparently redundant `FastCaloSimGeometryHelper` interfaceMinor code cleanup. Dropped apparently redundant `FastCaloSimGeometryHelper` interfacehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/58691Draft: Replace the substr() with resize as cppcheck suggests2022-11-27T18:38:34+01:00Andrii VerbytskyiDraft: Replace the substr() with resize as cppcheck suggestsReplace the substr() with resize as cppcheck suggests
Atg @sroe @fwinkelReplace the substr() with resize as cppcheck suggests
Atg @sroe @fwinkelhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/58594G4UserActions: Fix cppcheck warnings.2022-11-23T22:18:26+01:00Scott SnyderG4UserActions: Fix cppcheck warnings.Fix cppcheck warnings.Fix cppcheck warnings.