athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2024-02-13T18:31:13+01:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/68790Removal of legacy DAOD config - part 22024-02-13T18:31:13+01:00James CatmoreRemoval of legacy DAOD config - part 2ATLASG-2592
ATLASG-2593
ATLASG-2594
ATLASG-2595
ATLASG-2596
ATLASG-2597
ATLASG-2598
ATLASG-2599
This MR removes specific obsolete legacy job options for DAOD formats. In some cases they have been replaced with CA versions, in other case...ATLASG-2592
ATLASG-2593
ATLASG-2594
ATLASG-2595
ATLASG-2596
ATLASG-2597
ATLASG-2598
ATLASG-2599
This MR removes specific obsolete legacy job options for DAOD formats. In some cases they have been replaced with CA versions, in other cases not. Those which are still needed will have to be migrated at a later date. Many will not need to be replaced due to the transition to the new analysis model (PHYS/PHYSLITE)https://gitlab.cern.ch/atlas/athena/-/merge_requests/68788SimCoreTests(MT), ISF_Validation(MT): Fixes for ART scripts2024-02-13T16:54:42+01:00John Derek ChapmanSimCoreTests(MT), ISF_Validation(MT): Fixes for ART scriptsThe changes in this MR should fix most ART jobs which showed errors after the clean-up of legacy configuration jobs.
Tagging @zhubacekThe changes in this MR should fix most ART jobs which showed errors after the clean-up of legacy configuration jobs.
Tagging @zhubacekhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/68774Remove legacy skeletons for HITtoRDO and RDOMerge2024-02-14T16:10:27+01:00John Derek ChapmanRemove legacy skeletons for HITtoRDO and RDOMergeThis is the next step in clean-up the legacy digitization configuration.
Calls to `Digi_tf.py`and `RDOMerge_tf.py`without the `--CA`option will fail.
Tagging @tadej, @nstyles, @jcatmoreThis is the next step in clean-up the legacy digitization configuration.
Calls to `Digi_tf.py`and `RDOMerge_tf.py`without the `--CA`option will fail.
Tagging @tadej, @nstyles, @jcatmorehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/68771DigitizationTests ART: Fixes for regression tests2024-02-12T17:45:59+01:00John Derek ChapmanDigitizationTests ART: Fixes for regression testsSome output comparisons to previous nightlies were failing due to typos in the `art.py compare grid` syntax, mostly due to missing variable definitions. These should all be fixed now.
`Simulation/Tests/DigitizationTests/test/test_Digi_t...Some output comparisons to previous nightlies were failing due to typos in the `art.py compare grid` syntax, mostly due to missing variable definitions. These should all be fixed now.
`Simulation/Tests/DigitizationTests/test/test_Digi_tf_RUN2_2018_ttbar.sh` will take one additional nightly for the regression test to pass as there the issue was that the output file was not being saved, rather than an issue with the regression test command-line.
Also added `Simulation/Tests/DigitizationTests/test/test_Digi_tf_RUN2_2015_heavy_ion_hijing.sh` which will replace
`Simulation/Tests/DigitizationTests/test/test_Digi_tf_mc15_2015_heavy_ion.sh`.
Part of the work for ATLASSIM-7059https://gitlab.cern.ch/atlas/athena/-/merge_requests/68758MuonTrackingGeometry fix memory bugs2024-03-28T16:33:29+01:00Johannes Junggeburthjohannes.josef.junggeburth@cern.chMuonTrackingGeometry fix memory bugsRework the memory management of the muon tracking geometry and the Geo -> Trk::Volume converter. Cone clean up etc. Few bug fixes.
Validation tests perfromed on simulation Run2 & Run 3
![image](/uploads/a6228ba4e68dfa1ae2c86416e850e7...Rework the memory management of the muon tracking geometry and the Geo -> Trk::Volume converter. Cone clean up etc. Few bug fixes.
Validation tests perfromed on simulation Run2 & Run 3
![image](/uploads/a6228ba4e68dfa1ae2c86416e850e73c/image.png)
![image](/uploads/2ea2da76b97d84b97364d60fff524b30/image.png)
![image](/uploads/11c1818a9a4511ba42503932d9f32bdf/image.png)
![image](/uploads/cc765f3ff84e76aed07300dae506493a/image.png)
![image](/uploads/edc265d2f6d791370dcddfced77be744/image.png)
Further 250k data events from DRAW_ZMUMU have been reprocessed
![image](/uploads/ddac5de860349f24cb60a48d5be657b4/image.png)
![image](/uploads/ba8ba82ebaeb84eb2fa3a36a1c7cb07a/image.png)
![image](/uploads/4846fdd866a27bb8ec1db75caac31e90/image.png)
![image](/uploads/5efd30d930e56420e452877f78ac413d/image.png)
![image](/uploads/4ccb61e8b448e6de80732baf284fc6bb/image.png)
Tagging @todorova, @pscholer, @zyan, @nstyles, @jcatmore, @jchapman, @kluit
Closes ATLASRECTS-7876
The full plot bock is attached to the JIRA ticket because the file size limit there is larger than herehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/68750DigitizationTests Fix regression tests and run 25 events per job by default2024-02-10T13:27:48+01:00John Derek ChapmanDigitizationTests Fix regression tests and run 25 events per job by defaultChanges for ATLASSIM-7059Changes for ATLASSIM-7059https://gitlab.cern.ch/atlas/athena/-/merge_requests/68746RUN2 2015 Heavy Ion MC Campaign Configuration2024-02-10T10:12:23+01:00John Derek ChapmanRUN2 2015 Heavy Ion MC Campaign ConfigurationAdding missing ComponentAccumulator-based configuration for 2015 Heavy Ion run.
Part of work for ATLASSIM-7059
Tagging @tadej, @zhubacekAdding missing ComponentAccumulator-based configuration for 2015 Heavy Ion run.
Part of work for ATLASSIM-7059
Tagging @tadej, @zhubacekhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/68723Introduce Campaign-style configurations for existing Run1 Sim and Digi jobs2024-02-09T15:36:19+01:00John Derek ChapmanIntroduce Campaign-style configurations for existing Run1 Sim and Digi jobsIntroduce Campaign-style configurations for existing Run1 Sim and Digi jobs to simplify configuration.Introduce Campaign-style configurations for existing Run1 Sim and Digi jobs to simplify configuration.https://gitlab.cern.ch/atlas/athena/-/merge_requests/68714MuonConfiguration - Auto detect whether the R4 style or legacy geometry are l...2024-02-12T19:39:16+01:00Johannes Junggeburthjohannes.josef.junggeburth@cern.chMuonConfiguration - Auto detect whether the R4 style or legacy geometry are loadedHi everybody,
if a SQLite file is parsed as Geometry input, it's checked whether the geometry was made with the new R4 style MuonPlugin (cf. https://gitlab.cern.ch/atlas/geomodelatlas/GeoModelATLAS/-/merge_requests/124). The Muon geomet...Hi everybody,
if a SQLite file is parsed as Geometry input, it's checked whether the geometry was made with the new R4 style MuonPlugin (cf. https://gitlab.cern.ch/atlas/geomodelatlas/GeoModelATLAS/-/merge_requests/124). The Muon geometry configuration flag is then set accordingly. Rename the `useGeoModelXml` flag into `usePhaseIIGeoSetup`
Tagging: @emoyse, @boudreau, @tadejhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/68698Fixes for DigitizationTests ART jobs (ATLASSIM-7076)2024-02-08T19:42:48+01:00John Derek ChapmanFixes for DigitizationTests ART jobs (ATLASSIM-7076)Some variables in the DigitizationTests scripts had not been renamed properly. This caused ATLASSIM-7076.
Fixed this instance, plus a few other non-serious ones.
Tagging @zhubacekSome variables in the DigitizationTests scripts had not been renamed properly. This caused ATLASSIM-7076.
Fixed this instance, plus a few other non-serious ones.
Tagging @zhubacekhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/68692RpcGeoModelR4 - Use the stripLayer frame as reference to express the RE2024-02-20T16:48:59+01:00Johannes Junggeburthjohannes.josef.junggeburth@cern.chRpcGeoModelR4 - Use the stripLayer frame as reference to express the RE* Take the stripLayer as reference plane to calculate the sizes of the active area -> project the plane to the center of the gasGap. Almost perfect agreement for the positive spectrometer side.
* Update the naming of the WRPC table
Tagg...* Take the stripLayer as reference plane to calculate the sizes of the active area -> project the plane to the center of the gasGap. Almost perfect agreement for the positive spectrometer side.
* Update the naming of the WRPC table
Tagging: @smerianohttps://gitlab.cern.ch/atlas/athena/-/merge_requests/68676DigitizationTests: Remove old versions of Run1/Run2 of scripts (ATLASSIM-7059)2024-02-10T13:57:35+01:00John Derek ChapmanDigitizationTests: Remove old versions of Run1/Run2 of scripts (ATLASSIM-7059)Changes for ATLASSIM-7059Changes for ATLASSIM-7059https://gitlab.cern.ch/atlas/athena/-/merge_requests/68675DigitizationTests: Add standardardised name versions of RUN1/RUN2 digitizatio...2024-02-08T11:44:27+01:00John Derek ChapmanDigitizationTests: Add standardardised name versions of RUN1/RUN2 digitization ART jobs (ATLASSIM-7059)Part of the changes for (ATLASSIM-7059)Part of the changes for (ATLASSIM-7059)https://gitlab.cern.ch/atlas/athena/-/merge_requests/68673DigitizationTestsMT drop tests named mc20 (ATLASSIM-7059)2024-02-10T15:12:46+01:00John Derek ChapmanDigitizationTestsMT drop tests named mc20 (ATLASSIM-7059)Dropping a couple of non-standard named jobs.Dropping a couple of non-standard named jobs.https://gitlab.cern.ch/atlas/athena/-/merge_requests/68672DigitizationTestsMT: Standardising script names (ATLASSIM-7059)2024-02-08T11:35:34+01:00John Derek ChapmanDigitizationTestsMT: Standardising script names (ATLASSIM-7059)```
renamed: test_Digi_tf_mc20e_MP_SharedWriter_NoParallelComp_reproducibility.sh -> test_Digi_tf_RUN2_2018_MP_ttbar_haredWriter_NoParallelComp_reproducibility.sh
renamed: test_Digi_tf_mc20e_MP_SharedWriter_reproducibility.sh -> te...```
renamed: test_Digi_tf_mc20e_MP_SharedWriter_NoParallelComp_reproducibility.sh -> test_Digi_tf_RUN2_2018_MP_ttbar_haredWriter_NoParallelComp_reproducibility.sh
renamed: test_Digi_tf_mc20e_MP_SharedWriter_reproducibility.sh -> test_Digi_tf_RUN2_2018_MP_ttbar_SharedWriter_reproducibility.sh
renamed: test_Digi_tf_mc20e_MP_presampling_reproducibility.sh -> test_Digi_tf_RUN2_2018_MP_presampling_reproducibility.sh
renamed: test_Digi_tf_mc20e_MP_reproducibility.sh -> test_Digi_tf_RUN2_2018_MP_ttbar_reproducibility.sh
copied: test_Digi_tf_mc20_ttbar_no_pileup_MT.sh -> test_Digi_tf_RUN2_2018_ttbar_no_pileup_MT.sh
copied: test_Digi_tf_mc20_ttbar_no_pileup_MT_1thread.sh -> test_Digi_tf_RUN2_2018_ttbar_no_pileup_MT_1thread.sh
renamed: test_Digi_tf_mc23a_presampling_variable.sh -> test_Digi_tf_mc23a_MP_presampling_variable.sh
renamed: test_Digi_tf_mc23d_presampling_variable.sh -> test_Digi_tf_mc23d_MP_presampling_variable.sh
```
Part of changes for ATLASSIM-7059.
Tagging @zhubacekhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/68658remove 'oracle' option from indirectOpen2024-02-09T09:46:40+01:00Walter Lamplremove 'oracle' option from indirectOpenThe 'oracle' parameter of AtlCoolLib.indirectOpen turns out to be a bit misleading: Its original intention was 'no DBRelease' while most people nowadays rather understand 'no frontier'. Moreover, the underlying if-else logic looks wrong ...The 'oracle' parameter of AtlCoolLib.indirectOpen turns out to be a bit misleading: Its original intention was 'no DBRelease' while most people nowadays rather understand 'no frontier'. Moreover, the underlying if-else logic looks wrong to me.
IMHO that best way forward is to remove the option entirly. This MR does this and adjust (hopefully) all clients.
Moreover: Introduce a cache in MagFieldUtils to avoid multiple DB lookups.https://gitlab.cern.ch/atlas/athena/-/merge_requests/68656OverlayConfiguration: Reduce python dependencies.2024-02-07T18:00:58+01:00Scott SnyderOverlayConfiguration: Reduce python dependencies.Don't load configuration code for disabled detectors.Don't load configuration code for disabled detectors.https://gitlab.cern.ch/atlas/athena/-/merge_requests/68651Fix mc23 presampling ART tests2024-02-07T16:30:33+01:00Tadej Novaktadej.novak@cern.chFix mc23 presampling ART testsFix MC23 presampling ART tests - there was a typo in file paths.
/cc @jchapman @zhubacekFix MC23 presampling ART tests - there was a typo in file paths.
/cc @jchapman @zhubacekhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/68648New DD configuration: introduced an overrider for the standard path to SQLite...2024-02-08T15:04:32+01:00Vakhtang TsulaiaNew DD configuration: introduced an overrider for the standard path to SQLite Geometry DBIntroduced a new command-line argument for job transforms `--geometrySQLiteFullPath` to override
the standard path to the SQLite Geometry Database. If this argument is used then GeoModelSvc
switches to the initialization of geometry from...Introduced a new command-line argument for job transforms `--geometrySQLiteFullPath` to override
the standard path to the SQLite Geometry Database. If this argument is used then GeoModelSvc
switches to the initialization of geometry from SQLite and takes the SQLite database path from
the override instead of trying to find the file in the standard location
CC @sroe @nstyles @tadej @jojungge @boudreauhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/68647Adding MC23a and MC23d Presampling test jobs2024-02-07T14:16:38+01:00John Derek ChapmanAdding MC23a and MC23d Presampling test jobsTagging @tadejTagging @tadej