athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2024-01-30T10:24:57+01:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/68410Cleanup list/set property migration2024-01-30T10:24:57+01:00Frank WinklmeierCleanup list/set property migrationFollow-up to Gaudi v38 update (!66880) for properties that changed from
`list` to `set`. Assign values as `set` instead of relying on the
implicit conversion.Follow-up to Gaudi v38 update (!66880) for properties that changed from
`list` to `set`. Assign values as `set` instead of relying on the
implicit conversion.https://gitlab.cern.ch/atlas/athena/-/merge_requests/68421ZDC_SimEvent: Fix cppcheck warnings.2024-01-30T10:13:26+01:00Scott SnyderZDC_SimEvent: Fix cppcheck warnings.Prefer to initialize class members by an initialization list.Prefer to initialize class members by an initialization list.https://gitlab.cern.ch/atlas/athena/-/merge_requests/68360Fix test_RUN3_AF3InputParamFiles.sh ART job2024-01-29T14:11:36+01:00John Derek ChapmanFix test_RUN3_AF3InputParamFiles.sh ART jobThe test was accidentally overwriting the output of CA-based simulation with the output of legacy config simulation.The test was accidentally overwriting the output of CA-based simulation with the output of legacy config simulation.https://gitlab.cern.ch/atlas/athena/-/merge_requests/49890Update ISF_Validation tests (part 4: cosmics simulation)2024-01-29T13:33:56+01:00John Derek ChapmanUpdate ISF_Validation tests (part 4: cosmics simulation)This merge request follows from !49527 and focuses on updating the Cosmic-ray simulation ART jobs.
Part of the fixes for ATLASSIM-5526.This merge request follows from !49527 and focuses on updating the Cosmic-ray simulation ART jobs.
Part of the fixes for ATLASSIM-5526.https://gitlab.cern.ch/atlas/athena/-/merge_requests/68398Tracking: Do not use global config flags2024-01-29T10:56:47+01:00Tadej Novaktadej.novak@cern.chTracking: Do not use global config flagsDo not use global config flags in `Tracking` tests and scripts.
/cc @ncalaceDo not use global config flags in `Tracking` tests and scripts.
/cc @ncalacehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/68365RpcSensitiveDetectorsR4 - Fix double phi association2024-01-26T17:24:54+01:00Johannes Junggeburthjohannes.josef.junggeburth@cern.chRpcSensitiveDetectorsR4 - Fix double phi associationhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/68337Convert Tile run type configuration flag from string into enum2024-01-26T17:20:50+01:00Siarhei HarkushaConvert Tile run type configuration flag from string into enumTile run type configuration flag has been converted from string into enum.
Tile timing type configuration flag has been removed since
it can be deduced from run type.
The clients have been udpated accordingly.Tile run type configuration flag has been converted from string into enum.
Tile timing type configuration flag has been removed since
it can be deduced from run type.
The clients have been udpated accordingly.https://gitlab.cern.ch/atlas/athena/-/merge_requests/67707MicroMegas Readout Test for the new GeoModel infrastructure2024-01-26T08:23:00+01:00Spyridon MerianosMicroMegas Readout Test for the new GeoModel infrastructureAdd test routine to validate new readout geometry against the legacy one.Add test routine to validate new readout geometry against the legacy one.https://gitlab.cern.ch/atlas/athena/-/merge_requests/68274Further clean-up of configurations with AFII in the name2024-01-23T13:49:03+01:00John Derek ChapmanFurther clean-up of configurations with AFII in the nameRemaining occurrances of `AFII` in the configuration have been replaced with `ATLFAST_` where they are still used as part of ATLFAST3 configuration.
`AFIIEnvelopeDefSvc` has been renamed to `ATLFAST_EnvelopeDefSvc`.
Components named `A...Remaining occurrances of `AFII` in the configuration have been replaced with `ATLFAST_` where they are still used as part of ATLFAST3 configuration.
`AFIIEnvelopeDefSvc` has been renamed to `ATLFAST_EnvelopeDefSvc`.
Components named `AFII_QS` have been merged with their non-`QS` equivalents. Quasi-stable particle-related configuration is handled using flags now rather than by using separate configuration methods producing components with different names.
Remove remaing instances of `LongLived` (when refering to quasi-stable particles) in the configuration.
Tagging @jbeirer, @zhangr, @cyoung, @rwang, @fatsai, @mbandier, @schaarschttps://gitlab.cern.ch/atlas/athena/-/merge_requests/68260main-coverity-ISF_FastCaloSimEvent2024-01-23T09:32:14+01:00Shaun Roemain-coverity-ISF_FastCaloSimEventSolves coverity defect 19719: possible dereference of null ptr after check. Small header tidy also.Solves coverity defect 19719: possible dereference of null ptr after check. Small header tidy also.https://gitlab.cern.ch/atlas/athena/-/merge_requests/68259Clean-up misleading component configuration names in Simulation2024-01-22T17:04:33+01:00John Derek ChapmanClean-up misleading component configuration names in Simulation1. Drop `LongLivedInputConverter`- "LongLived" was a misleading name as this version of the `InputConverter` was intended for jobs running quasi-stable particle simulation. The required configuration changes can more easily be achieved b...1. Drop `LongLivedInputConverter`- "LongLived" was a misleading name as this version of the `InputConverter` was intended for jobs running quasi-stable particle simulation. The required configuration changes can more easily be achieved by checking the Simulator flags rather than having a separate configuration method.
2. Drop `ISF_LongLivedGeant4Tool` - just use a properly configured version of `ISF_FullGeant4Tool` everywhere.
3. Drop `AFII_QS_Geant4Tool` - just use a properly configured version of `ISF_AFIIGeant4Tool` everywhere.https://gitlab.cern.ch/atlas/athena/-/merge_requests/68247CppCheck/clang-tidy : Avoid copies pass by ref2024-01-22T09:52:28+01:00Christos Anastopouloschristos.anastopoulos@cern.chCppCheck/clang-tidy : Avoid copies pass by refCppCheck/clang-tidy : Avoid copies pass by refCppCheck/clang-tidy : Avoid copies pass by refhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/682342024-01-19: merge of 23.0 into main2024-01-19T13:19:17+01:00Walter Lampl2024-01-19: merge of 23.0 into mainThis sweep contains the following MRs:
* !67996 23.0 zdc simulation hooks ATLASSIM-6751 ~Digitization, ~SimulationThis sweep contains the following MRs:
* !67996 23.0 zdc simulation hooks ATLASSIM-6751 ~Digitization, ~Simulationhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/68224IOVDbSvc: delete obsolete and unused legacy job option fragments2024-01-19T11:00:01+01:00Frank WinklmeierIOVDbSvc: delete obsolete and unused legacy job option fragmentsDelete obsolete and unused legacy job option fragments.Delete obsolete and unused legacy job option fragments.https://gitlab.cern.ch/atlas/athena/-/merge_requests/6799623.0 zdc simulation hooks ATLASSIM-67512024-01-19T09:50:26+01:00Chad Stephen Lantz23.0 zdc simulation hooks ATLASSIM-6751Updates simulation hooks to use new ZDC_SD classesUpdates simulation hooks to use new ZDC_SD classeshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/68190Enable phierror in G4Follower2024-01-18T17:03:24+01:00Matous VozakEnable phierror in G4FollowerMatous VozakMatous Vozakhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/68201ISF_FastCaloSimEvent: Fix test failure in dbg build.2024-01-18T12:05:47+01:00Scott SnyderISF_FastCaloSimEvent: Fix test failure in dbg build.TFCSSimulationState::Print was printing all arms of a union holding
a number of fundamental types.
However, if one tries to access a something of bool type that holds something
other than 0 or 1, then we'll get a warning from the UB san...TFCSSimulationState::Print was printing all arms of a union holding
a number of fundamental types.
However, if one tries to access a something of bool type that holds something
other than 0 or 1, then we'll get a warning from the UB sanitizer.
Further, if we print it as a char, it may well be non-printable, which
can screw up a terminal.
So don't print as bool or char.https://gitlab.cern.ch/atlas/athena/-/merge_requests/681802024-01-16: merge of 23.0 into main2024-01-17T09:52:52+01:00Walter Lampl2024-01-16: merge of 23.0 into mainThis sweep contains the following MRs:
* !68084 Update CalibrationRun Sim flag to allow the possibility of producing CaloCalibrationHits in the ZDC ~LAr, ~Simulation
* !68079 Revert bug in charge mirror AF3 code, and add missing copywr...This sweep contains the following MRs:
* !68084 Update CalibrationRun Sim flag to allow the possibility of producing CaloCalibrationHits in the ZDC ~LAr, ~Simulation
* !68079 Revert bug in charge mirror AF3 code, and add missing copywrite statements ~Simulation
* !67485 Add DRAW selection for L1Calo jet performance studies (DATREP-309) ~Analysis, ~Reconstruction, ~Tools
Conflicts:
* Reco_tf.py (two positional arguments added)
* LArG4SDToolConfig.py and G4AtlasAlgConfig.py: renaming of ConfigFlags -> flags
* Copyright year (23/24) in 7 files under ISF_FastCaloSimEventhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/68079Revert bug in charge mirror AF3 code, and add missing copywrite statements2024-01-16T15:35:07+01:00Christopher YoungRevert bug in charge mirror AF3 code, and add missing copywrite statementsIn https://gitlab.cern.ch/atlas/athena/-/merge_requests/63562 a bug was accidentally introduced that changed the mirroring behavior for particles of different charge. This MR reverts this change. It also adds some missing Copywrite state...In https://gitlab.cern.ch/atlas/athena/-/merge_requests/63562 a bug was accidentally introduced that changed the mirroring behavior for particles of different charge. This MR reverts this change. It also adds some missing Copywrite statements from that previous MR. (For files changed in the previous request 2023 is used, while for the file fixed in this MR 2024 is used).
NOTE: this bug is in 23.0 and therefore this MR targets this release. The bug is not present in main. THIS MR SHOULD NOT BE SWEPT TO MAIN.
Many thanks to @tstreble and @jbeirer for finding this bug.https://gitlab.cern.ch/atlas/athena/-/merge_requests/68084Update CalibrationRun Sim flag to allow the possibility of producing CaloCali...2024-01-16T15:35:07+01:00John Derek ChapmanUpdate CalibrationRun Sim flag to allow the possibility of producing CaloCalibrationHits in the ZDCPreparatory changes for !67996. This merge request updates `simFlags.CalibrationRun` and `flags.Sim.CalibrationRun` syntax to allow for the possibility of producing CaloCalibrationHits in the ZDC.
Tagging @mbandier, @schaarsc, @clantzPreparatory changes for !67996. This merge request updates `simFlags.CalibrationRun` and `flags.Sim.CalibrationRun` syntax to allow for the possibility of producing CaloCalibrationHits in the ZDC.
Tagging @mbandier, @schaarsc, @clantz