athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2024-03-28T21:09:21+01:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/70204Draft: sTgcReadoutElement - Fixing wireGroup Positions2024-03-28T21:09:21+01:00Ishan Kiritbhai VyasDraft: sTgcReadoutElement - Fixing wireGroup Positions- Changing localChannelPosition function in the readout element to replicate the R3 wireGroup positions.
- Fixing the beam line radius
@alainb @jojungge @pscholer- Changing localChannelPosition function in the readout element to replicate the R3 wireGroup positions.
- Fixing the beam line radius
@alainb @jojungge @pscholerhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/70172PadDesign - Fixing sTgc Pad Positions2024-03-28T16:08:54+01:00Ishan Kiritbhai VyasPadDesign - Fixing sTgc Pad Positions- Pad Corners Aligned.
- Adding frameOffset parameter in Geometry Tool to correct beamline radius until we find a fix.
- Modifying the globalChannelPosition function in the readout element to correct last half-strip position in gasgap la...- Pad Corners Aligned.
- Adding frameOffset parameter in Geometry Tool to correct beamline radius until we find a fix.
- Modifying the globalChannelPosition function in the readout element to correct last half-strip position in gasgap layers
- Fixing minor errors and bugs
@alainb @jojungge @pscholerhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/70164Add CA-based configuration for the FastIDKiller2024-03-28T16:41:23+01:00John Derek ChapmanAdd CA-based configuration for the FastIDKillerInitial version of FastIDKiller configuration - can be expanded as required.
Needed for egamma studies.Initial version of FastIDKiller configuration - can be expanded as required.
Needed for egamma studies.https://gitlab.cern.ch/atlas/athena/-/merge_requests/70146Draft: Improve consistency of InDetSimEventTPCnv behaviour.2024-03-27T09:46:05+01:00John Derek ChapmanDraft: Improve consistency of InDetSimEventTPCnv behaviour.In recent updates to HepMcParticleLink, it was observed that the behaviour of `TRT_HitCollectionCnv_p4` and `SiHitCollectionCnv_p3`
differed from the behaviour of TP converter classes using `HepMcParticleLinkCnv_p2` directly.
This merge...In recent updates to HepMcParticleLink, it was observed that the behaviour of `TRT_HitCollectionCnv_p4` and `SiHitCollectionCnv_p3`
differed from the behaviour of TP converter classes using `HepMcParticleLinkCnv_p2` directly.
This merge request attempts to make the behaviour of `SiHitCollectionCnv_p3/4`and `TRT_HitCollectionCnv_p4/5`
consistent with `HepMcParticleLinkCnv_p2/3`.
Relates to ATLASSIM-6999.https://gitlab.cern.ch/atlas/athena/-/merge_requests/70137[ATR-29000] Enable supercell output for Run 4 MC-MC overlay2024-03-27T10:52:15+01:00Tim Martin[ATR-29000] Enable supercell output for Run 4 MC-MC overlayFollows on from !68314
Applies the same change (`== Run 3` -> `>= Run 3`) also to the Overlay workflow.
cc @damazio, @pavolFollows on from !68314
Applies the same change (`== Run 3` -> `>= Run 3`) also to the Overlay workflow.
cc @damazio, @pavolhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/701292024-03-26: merge of 24.0 into main2024-03-28T10:55:02+01:00Edward Moyse2024-03-26: merge of 24.0 into mainThis sweep contains the following MRs:
* !70090 ATR-28985 Trigger request for Multijet TLA ~Trigger, ~TriggerMenu
* !70113 MuonDQA: remove references to Run-2 monitoring config ~DQ, ~MuonSpectrometer
* !70115 LArMonitoring: delete leg...This sweep contains the following MRs:
* !70090 ATR-28985 Trigger request for Multijet TLA ~Trigger, ~TriggerMenu
* !70113 MuonDQA: remove references to Run-2 monitoring config ~DQ, ~MuonSpectrometer
* !70115 LArMonitoring: delete legacy job options ~DQ, ~LAr
* !70117 Pixel Calibration - adding getters and fixing typos ~InnerDetector
* !70112 ZdcMonitoring: cleanup references to legacy config ~ForwardDetectors
* !70109 Fix CMake warning in AthSimulation builds. ~Build
* !69914 Bug fix to generation of links between neutral FE and muons ~JetEtmiss, ~Reconstruction, ~Run2-DataReco-output-changed, ~Run2-MCReco-output-changed, ~Run3-DataReco-output-changed, ~Run3-MCReco-output-changed, ~Tools, ~frozen-tier0-violating
* !70100 Added maxParallelismExtra setting to AvalancheSchedulerSvcCfg ~Trigger
* !70096 Avoid duplicate streamer chain blocks ~Trigger, ~TriggerMenu
* !70108 Remove nullptr initialiser that causes a crashing ~Simulation
* !70048 Adding more test chains for delayed jets ~Trigger, ~TriggerMenu, ~changes-trigger-counts
* !70102 AthenaCommon: refactor --profile-python option ~Core
* !70097 remove legacy python config files form Calorimeter/CaloCnv ~Calorimeter
* !70095 ZDC reconstruction ART script, testing on ZDCCalib data ~ForwardDetectors
* !70092 remove obsolete config files from LArEventTest ~LAr
* !70091 remove obsolete config files from LArCondAthenaPool and LArDetMgrDetDescrCnv ~LAr
* !70089 remove obsolete config-files from LArByteStream ~LAr, ~Simulation
* !70074 AFP monitoring update code style ~DQ, ~ForwardDetectors
* !70069 Fix for the multi-threaded event service configuration ~Tools
* !70036 sTGC raw data monitoring: fix problem with shifter occupancy plots ~DQ, ~MuonSpectrometer
* !70060 Update eFexByteStreamTool.cxx - write multislice tobs as xtobs (since only... ~L1Calo, ~Trigger
* !70057 L1calo monitoring improvements ~Core, ~DQ, ~L1Calo, ~Trigger
* !70035 Update gfex parameters in trigger menu ~L1Calo, ~Trigger, ~TriggerMenu, ~changes-trigger-counts
* !69759 Monitoring of alternative L1 eTAU simulation ~DQ, ~Tau, ~Trigger
* !70030 ATR-28968: Reduce INFO messages from central trigger configuration code ~ACTS, ~Core, ~Tracking, ~Trigger
* !70011 fix failing DataQualityConfigurations tests in dbg build ~DQ
* !70045 CaloSamplingFractionAnalysis: delete legacy job options ~Simulation
* !69994 offline DQ for MMG trigger ~DQ, ~MuonSpectrometer
* !70073 fix StepName ~JetEtmiss, ~Trigger, ~TriggerJet, ~TriggerMenu
* !70061 IDTrig: do not switch on TRT with ITk, deal with InDet/ITk eta dependant cuts ~Trigger, ~TriggerID
* !70068 Run the TIDA Tier0 monitoring correctly ~Trigger
* !70042 pT filter for groomed jets before moment calculation ~JetEtmiss, ~Reconstruction
* !70044 adding missing et conversion factor for KFMET definition for Ph1Topo ~Trigger, ~TriggerMenu
* !70046 DumpGeo: delete legacy job options ~Geometry
* !69953 New efficiency DQ criteria for HLTmuon hanconfig ~DQ
* !70022 clean out legacy config code from LArCalorimeter/LArClusterRec ~LArhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/70108Remove nullptr initialiser that causes a crashing2024-03-26T14:38:23+01:00Rui ZhangRemove nullptr initialiser that causes a crashingRemove nullptr initialiser that causes a crashing when setting SetInterOpNumThreads/SetIntraOpNumThreads Subsequent merge of [!69945 (merged)](https://gitlab.cern.ch/atlas/athena/-/merge_requests/69945 "Prevent ONNX from spawning additio...Remove nullptr initialiser that causes a crashing when setting SetInterOpNumThreads/SetIntraOpNumThreads Subsequent merge of [!69945 (merged)](https://gitlab.cern.ch/atlas/athena/-/merge_requests/69945 "Prevent ONNX from spawning additional threads").
```plaintext
Prevent ONNX from spawning additional threads in the FastCaloSim implementation.
Should fix ATLASSIM-7146 (and potentially ATLASSIM-7031 ?)
```
fyi @zhangr @jchapmanhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/70106Draft: ActsGeometryContext - Non const access2024-03-27T08:20:11+01:00Johannes Junggeburthjohannes.josef.junggeburth@cern.chDraft: ActsGeometryContext - Non const accesshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/70099Clean-up of MDTSimHit.h2024-03-26T14:12:38+01:00John Derek ChapmanClean-up of MDTSimHit.hWas previously part of !69655, which had to be reverted while other changes
are debugged. This part is still safe to go in though.
It allows deformations to be applied to an already created MDTSimHit instance.Was previously part of !69655, which had to be reverted while other changes
are debugged. This part is still safe to go in though.
It allows deformations to be applied to an already created MDTSimHit instance.https://gitlab.cern.ch/atlas/athena/-/merge_requests/70098Extend TRT_HitCollectionCnv unit tests2024-03-26T14:15:27+01:00John Derek ChapmanExtend TRT_HitCollectionCnv unit testsThis merge request extends the TRT_HitCollectionCnv unit tests to examine the level of compression achieved in the persistent versions.This merge request extends the TRT_HitCollectionCnv unit tests to examine the level of compression achieved in the persistent versions.https://gitlab.cern.ch/atlas/athena/-/merge_requests/70089remove obsolete config-files from LArByteStream2024-03-26T14:38:23+01:00Walter Lamplremove obsolete config-files from LArByteStreamThe title says it all..The title says it all..https://gitlab.cern.ch/atlas/athena/-/merge_requests/70082LArByteStrean+LArCondAthenaPool: remove legacy job options2024-03-25T14:01:59+01:00Frank WinklmeierLArByteStrean+LArCondAthenaPool: remove legacy job optionshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/70080Clean-up of TrackRecord header ahead of further updates2024-03-26T14:16:07+01:00John Derek ChapmanClean-up of TrackRecord header ahead of further updatesCleaning up the TrackRecord header in preparation to migrate it from
being based on truth barcodes to be-based on truth status and id.
Most changes relate to renaming `GetBarCode()` to the more standard `barcode()` and `SetBarCode()` to...Cleaning up the TrackRecord header in preparation to migrate it from
being based on truth barcodes to be-based on truth status and id.
Most changes relate to renaming `GetBarCode()` to the more standard `barcode()` and `SetBarCode()` to `SetBarcode()`.
I may make a follow-up MR further standardising method names, but I prefer to get the current changes in first.https://gitlab.cern.ch/atlas/athena/-/merge_requests/70077Revert merge request !69655 (ATLSWUPGR-242)2024-03-25T14:46:45+01:00John Derek ChapmanRevert merge request !69655 (ATLSWUPGR-242)Merge request !69655 causes unintended output changes in some ART tests: ATLSWUPGR-242
Therefore reverting for now to allow me to do some further testing/tweaking of the changes before reintroducing them.Merge request !69655 causes unintended output changes in some ART tests: ATLSWUPGR-242
Therefore reverting for now to allow me to do some further testing/tweaking of the changes before reintroducing them.https://gitlab.cern.ch/atlas/athena/-/merge_requests/70063Extend SiHitCollectionCnv unit tests2024-03-25T14:49:56+01:00John Derek ChapmanExtend SiHitCollectionCnv unit testsThis merge request extends the SiHitCollectionCnv unit tests to monitor the level
of compression seen in the persistent formats and check the behaviour for SiHits caused by
delta-rays (i.e. no valid truth link).This merge request extends the SiHitCollectionCnv unit tests to monitor the level
of compression seen in the persistent formats and check the behaviour for SiHits caused by
delta-rays (i.e. no valid truth link).https://gitlab.cern.ch/atlas/athena/-/merge_requests/70056Draft: Extend unit tests for HepMcParticleLink and SiHitCollectionCnv_pX.2024-03-25T18:35:35+01:00John Derek ChapmanDraft: Extend unit tests for HepMcParticleLink and SiHitCollectionCnv_pX.https://gitlab.cern.ch/atlas/athena/-/merge_requests/70050TRTProcessingOf(Barrel/Endcap)Hits clean-up of error message2024-03-22T14:20:24+01:00John Derek ChapmanTRTProcessingOf(Barrel/Endcap)Hits clean-up of error messageVery minor tweak to error message syntax.
NB these classes do not depend on Athena, so it is beyond the scope of this merge request to convert the messages to use the Athena message service.Very minor tweak to error message syntax.
NB these classes do not depend on Athena, so it is beyond the scope of this merge request to convert the messages to use the Athena message service.https://gitlab.cern.ch/atlas/athena/-/merge_requests/70047More test chains for delayed jets2024-03-22T13:20:55+01:00Lucas BezioMore test chains for delayed jetsAs discussed on [ATR-28836](https://its.cern.ch/jira/browse/ATR-28836), more test chains are added. Some are requiring 2jets to be delayed aiming to reduce the rate even with low pt threshold. Copies of the test chains with upper limit o...As discussed on [ATR-28836](https://its.cern.ch/jira/browse/ATR-28836), more test chains are added. Some are requiring 2jets to be delayed aiming to reduce the rate even with low pt threshold. Copies of the test chains with upper limit on timing are also added.https://gitlab.cern.ch/atlas/athena/-/merge_requests/70045CaloSamplingFractionAnalysis: delete legacy job options2024-03-26T14:38:24+01:00Frank WinklmeierCaloSamplingFractionAnalysis: delete legacy job optionshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/700262024-03-21: merge of 24.0 into main2024-03-22T08:46:02+01:00Frank Winklmeier2024-03-21: merge of 24.0 into mainThis sweep contains the following MRs:
* !70032 fix for ATR-29037 - No such flag: minTRTonTrk ~Trigger, ~TriggerID
* !70018 Fix issue with incomplete hashing in HLT Nav conversion ~Trigger
* !70014 AthenaPython: delete copy_file and ...This sweep contains the following MRs:
* !70032 fix for ATR-29037 - No such flag: minTRTonTrk ~Trigger, ~TriggerID
* !70018 Fix issue with incomplete hashing in HLT Nav conversion ~Trigger
* !70014 AthenaPython: delete copy_file and read_file utilities ~Core
* !69991 LArCafJobs: delete legacy config referencing RecExConfig ~LAr
* !69714 MuonConfig: drop RPC cabling map override ~MuonSpectrometer, ~Run3-MCReco-output-changed, ~Tools
* !70015 TrigPSC+TrigServices: set ConcurrencyFlags::numProcs ~Core, ~Trigger
* !69969 ID trigger: dynamic creation of flags ~Trigger, ~TriggerID
* !70001 L1calo efex tau bdt add max and min thresholds ~L1Calo, ~Trigger
* !69992 Remove HLT_e5_lhvloose_bBeeM6000_L1BKeePrimary from T0 monitoring ~Trigger, ~TriggerMenu
* !69865 More fixes for !68913: hasFlag and iterators ~Core
* !69996 Fixes for wrong stream assignment VBFDelayed -> PhysicsStream ~Trigger, ~TriggerMenu
* !69833 AFP ToF monitoring new hist + bugfix ~DQ, ~ForwardDetectors
* !69984 Fix physval memory leak, ATLASDQ-1136 ~DQ
* !69988 TBDetDescrAlg: delete legacy config and cleanup ~TestBeam
* !69987 ForwardTransport[Svc]: delete legacy configuration ~ForwardDetectors
* !69958 Adding versioning in ZDC calibration files via parameter for TDirectory name ~ForwardDetectors
* !69796 fixes some details of the task, container names and updates file to be used. ~DQ, ~LAr
* !69945 Prevent ONNX from spawning additional threads ~Simulation
* !69930 ZDC CA synchronized with Tier0 version ~ForwardDetectors
* !69886 StoreGate: add SG::HiveMgrSvc::setNumProcs helper ~Core
* !68579 AFT-702: Add heterogeneous input support for GN2 ~Analysis, ~BTagging, ~JetEtmiss
* !69899 Fix LAr CAF jobs ~LAr
* !69857 CA-based script to populate the LAr Bad Feb database ~LAr
* !69981 AFP_GeoModel+Digitization: delete legacy job options ~Digitization, ~ForwardDetectors
* !69949 Protect possible rare FPEs in trigger ~Tracking
* !69963 gFEX pileup threshold update ~EDM, ~JetEtmiss, ~L1Calo, ~Trigger
* !69917 ZdcRec: delete legacy configuration ~ForwardDetectors
* !69967 NTUPtoNTUPCore: delete unused package ~Analysis
* !69971 ForwardRec: delete legacy job options ~ForwardDetectors
* !69966 LArL1Sim: delete legacy job options ~LAr
* !69959 Remove custom JetSuper Roi zedHalfWidth ~JetEtmiss, ~Trigger, ~TriggerID
* !69970 Disable ONNXRuntime CUDA Support, 24.0 branch (2024.03.20.) ~Build
* !69939 ATR-28870: add hh4b GN2 80% chain to physics ~Trigger, ~TriggerMenu, ~changes-trigger-counts