athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2024-03-27T18:20:29+01:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/68368Draft: Add possiblity to use Geant4 transport instead of ATLAS tracking tools...2024-03-27T18:20:29+01:00Joshua Falco Beirerjoshua.beirer@cern.chDraft: Add possiblity to use Geant4 transport instead of ATLAS tracking tools in FCS in G4https://gitlab.cern.ch/atlas/athena/-/merge_requests/70082LArByteStrean+LArCondAthenaPool: remove legacy job options2024-03-25T14:01:59+01:00Frank WinklmeierLArByteStrean+LArCondAthenaPool: remove legacy job optionshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/70047More test chains for delayed jets2024-03-22T13:20:55+01:00Lucas BezioMore test chains for delayed jetsAs discussed on [ATR-28836](https://its.cern.ch/jira/browse/ATR-28836), more test chains are added. Some are requiring 2jets to be delayed aiming to reduce the rate even with low pt threshold. Copies of the test chains with upper limit o...As discussed on [ATR-28836](https://its.cern.ch/jira/browse/ATR-28836), more test chains are added. Some are requiring 2jets to be delayed aiming to reduce the rate even with low pt threshold. Copies of the test chains with upper limit on timing are also added.https://gitlab.cern.ch/atlas/athena/-/merge_requests/69228Updating LAr EM NTuple creation to CA based configuration2024-02-26T13:13:58+01:00Mustafa Andre SchmidtUpdating LAr EM NTuple creation to CA based configurationThe configuration script for the LAr EM NTuple creation as well as the README file was changed to be compatible with the new CA-based configuration.The configuration script for the LAr EM NTuple creation as well as the README file was changed to be compatible with the new CA-based configuration.https://gitlab.cern.ch/atlas/athena/-/merge_requests/69154gFEX: fix bug in gTower class2024-02-22T22:06:42+01:00Cecilia ToscirigFEX: fix bug in gTower classWith this MR, a bug found in `gTower::getFWID` is fixed. This assigns the correct energy to some gTowers in the forward region, that were previously swapped. Consequently, this solves some mismatches found in the hw vs sw comparison for ...With this MR, a bug found in `gTower::getFWID` is fixed. This assigns the correct energy to some gTowers in the forward region, that were previously swapped. Consequently, this solves some mismatches found in the hw vs sw comparison for small-R jets and also improves results for large-R jets and MET quantities.https://gitlab.cern.ch/atlas/athena/-/merge_requests/69149Fix bug in gTower class2024-02-22T21:07:56+01:00Cecilia TosciriFix bug in gTower classWith this MR, a bug found in `gTower::getFWID` is fixed. This assigns the correct energy to some gTowers in the forward region, that were previously swapped. Consequently, this solves some mismatches found in the hw vs sw comparison for ...With this MR, a bug found in `gTower::getFWID` is fixed. This assigns the correct energy to some gTowers in the forward region, that were previously swapped. Consequently, this solves some mismatches found in the hw vs sw comparison for small-R jets and also improves results for large-R jets and MET quantities.https://gitlab.cern.ch/atlas/athena/-/merge_requests/68774Remove legacy skeletons for HITtoRDO and RDOMerge2024-02-14T16:10:27+01:00John Derek ChapmanRemove legacy skeletons for HITtoRDO and RDOMergeThis is the next step in clean-up the legacy digitization configuration.
Calls to `Digi_tf.py`and `RDOMerge_tf.py`without the `--CA`option will fail.
Tagging @tadej, @nstyles, @jcatmoreThis is the next step in clean-up the legacy digitization configuration.
Calls to `Digi_tf.py`and `RDOMerge_tf.py`without the `--CA`option will fail.
Tagging @tadej, @nstyles, @jcatmorehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/64858Draft: New configuration for G4DebuggingTools.2024-02-13T09:28:48+01:00Walter HopkinsDraft: New configuration for G4DebuggingTools.Updating G4DebuggingTools to use new-style configuration.Updating G4DebuggingTools to use new-style configuration.https://gitlab.cern.ch/atlas/athena/-/merge_requests/68256Draft: Adding an example JO showing how to use the new Pythia8 UserHook2024-02-01T08:18:09+01:00Safa Gaidsafa.gaid@cern.chDraft: Adding an example JO showing how to use the new Pythia8 UserHookI added an example JO that shows how to use the new Pythia8 UserHook mergingDJRs.I added an example JO that shows how to use the new Pythia8 UserHook mergingDJRs.https://gitlab.cern.ch/atlas/athena/-/merge_requests/66216Draft: Adding ONNX compatability to FastCaloSim2024-01-11T13:27:22+01:00Henry Day-HallDraft: Adding ONNX compatability to FastCaloSimThis is a dupe of https://gitlab.cern.ch/atlas/athena/-/merge_requests/63562 with 2 changes;
- Should work with either version of onnxruntime
- The unit test seem to have stopped timing out (true in my local tests...)
Taking a look at t...This is a dupe of https://gitlab.cern.ch/atlas/athena/-/merge_requests/63562 with 2 changes;
- Should work with either version of onnxruntime
- The unit test seem to have stopped timing out (true in my local tests...)
Taking a look at the unit tests here.https://gitlab.cern.ch/atlas/athena/-/merge_requests/67998Draft: Testing CI output2024-01-11T13:26:09+01:00Henry Day-HallDraft: Testing CI outputGot some really odd CI results locally from changes that should be no-op. Testing them here.Got some really odd CI results locally from changes that should be no-op. Testing them here.https://gitlab.cern.ch/atlas/athena/-/merge_requests/68004Adding ONNX compatability to FastCaloSim2024-01-08T16:17:58+01:00Henry Day-HallAdding ONNX compatability to FastCaloSimSpiritual successor to https://gitlab.cern.ch/atlas/athena/-/merge_requests/66216
Which is itself a variant on https://gitlab.cern.ch/atlas/athena/-/merge_requests/63562.
Look to https://gitlab.cern.ch/atlas/athena/-/merge_requests/6356...Spiritual successor to https://gitlab.cern.ch/atlas/athena/-/merge_requests/66216
Which is itself a variant on https://gitlab.cern.ch/atlas/athena/-/merge_requests/63562.
Look to https://gitlab.cern.ch/atlas/athena/-/merge_requests/63562 for the best documentation.
This is a slightly abbreviated version of the above MR's because there is a problem somewhere in the changes to `TFCSPredicExtrapWeights.cxx`. This problem caused the CI to fail. The problem is quite specific, it mostly doesn't show up. TO reproduce it outside the CI, you can run the 23.0 branch (which already has the changes, because it has less CI on it);
```
asetup Athena,23.0,latest && \
ATHENA_CORE_NUMBER=0 Sim_tf.py --AMIConfig a913 --inputEVNTFile /cvmfs/atlas-nightlies.cern.ch/repo/data/data-art/CampaignInputs/mc23/EVNT/mc23_13p6TeV.601229.PhPy8EG_A14_ttbar_hdamp258p75_SingleLep.evgen.EVNT.e8514/EVNT.32288062._002040.pool.root.1 --outputHITSFile myHITS.pool.root --imf False --maxEvents 20
```
So I took out the changes to `TFCSPredictExtrapWeights.cxx`, that now only runs on lwtnn. This MR only changes the net in `TFCEGANEtaSlice.cxx` so that it may run on lwtnn or ONNX. This bit seems to work just fine.
As I'm leaving, I won't be able to interact with gitlab. I'm still happy to help, if there is anything you'd like to ask; henrydayhall@protonmail.comJoshua Falco Beirerjoshua.beirer@cern.chJoshua Falco Beirerjoshua.beirer@cern.chhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/6495023.0 zdc mc update ATLASSIM-67512023-11-14T22:50:39+01:00Chad Stephen Lantz23.0 zdc mc update ATLASSIM-6751This is a complete overhaul of the ZDC simulation packages. Due to the scope of the changes it was infeasible to break this into smaller pieces.This is a complete overhaul of the ZDC simulation packages. Due to the scope of the changes it was infeasible to break this into smaller pieces.Chad Stephen LantzChad Stephen Lantzhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/64505Draft: Migrate creation and propagation metadata tools to a single tool with ...2023-11-03T10:24:18+01:00Maciej Pawel SzymanskiDraft: Migrate creation and propagation metadata tools to a single tool with two modesThis MR is to work on migrating pairs of tools used to create and propagate metadata with a single tool (per domain) with two modes.
The scope of this MR concerns _core_ tools, i.e. `EventStreamInfo`, `EventFormat`, and `FileMetaData`.
...This MR is to work on migrating pairs of tools used to create and propagate metadata with a single tool (per domain) with two modes.
The scope of this MR concerns _core_ tools, i.e. `EventStreamInfo`, `EventFormat`, and `FileMetaData`.
/cc @gemmeren @ametehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/66456LArG4FastSimulation: Fix cppcheck warning.2023-10-13T17:25:10+02:00Scott SnyderLArG4FastSimulation: Fix cppcheck warning.Redundant string conversion.Redundant string conversion.https://gitlab.cern.ch/atlas/athena/-/merge_requests/66374Adding in protection for a crash when dumping or converting GenEvent/HepMC3...2023-10-12T17:11:40+02:00R D SchafferAdding in protection for a crash when dumping or converting GenEvent/HepMC3...Adding in protection for a crash when dumping or converting GenEvent/HepMC3 events - problem is accessing the GenVertex position, sometimes gives segFault.
When investigating [AGENE-1803](https://its.cern.ch/jira/browse/AGENE-1803), I f...Adding in protection for a crash when dumping or converting GenEvent/HepMC3 events - problem is accessing the GenVertex position, sometimes gives segFault.
When investigating [AGENE-1803](https://its.cern.ch/jira/browse/AGENE-1803), I found that dumping EVNT events or converting them to xAODTruth would crash. These updates add in protection, but doesn't not solve the problem which seems to be in HepMC3. For this I made [AGENE-2231](https://its.cern.ch/jira/browse/AGENE-2231). Please refer to this for more details.R D SchafferR D Schafferhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/64539Draft: Replace boost with STL, please do not review, will not be merged in th...2023-10-10T13:25:31+02:00Andrii VerbytskyiDraft: Replace boost with STL, please do not review, will not be merged in the present state.Replace boost with STLReplace boost with STLhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/65942Draft: Use barcode() template in the TruthUtils2023-10-03T14:46:01+02:00Andrii VerbytskyiDraft: Use barcode() template in the TruthUtilsUse barcode() template in the TruthUtils
@pclark @jchapman
An experimental MR.Use barcode() template in the TruthUtils
@pclark @jchapman
An experimental MR.https://gitlab.cern.ch/atlas/athena/-/merge_requests/65924Draft: Drop int specialization from the HepMCHelpers2023-09-26T22:11:43+02:00Andrii VerbytskyiDraft: Drop int specialization from the HepMCHelpersDrop int specialization from the HepMCHelpers
@pclark @jchapmanDrop int specialization from the HepMCHelpers
@pclark @jchapmanhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/659442023-09-20: merge of 23.0 into main2023-09-24T22:05:09+02:00Vakhtang Tsulaia2023-09-20: merge of 23.0 into mainConflicts:
* `DataQuality/dqm_algorithms/src/TRTWeightedAverage.cxx`
Kept the ~main version
* `Reconstruction/Jet/JetMonitoring/python/JetMonitoringStandard.py`
Kept the ~"23.0" version. CC @cdelitzs (!65911)
* `Trigger/TriggerCommon/Tri...Conflicts:
* `DataQuality/dqm_algorithms/src/TRTWeightedAverage.cxx`
Kept the ~main version
* `Reconstruction/Jet/JetMonitoring/python/JetMonitoringStandard.py`
Kept the ~"23.0" version. CC @cdelitzs (!65911)
* `Trigger/TriggerCommon/TriggerJobOpts/python/TriggerConfigFlags.py`
Manual merge. Combined lambda with the help message for the `Trigger.Jet.pflowCalibKey` flag. CC @cantel (!65831)
This sweep contains the following MRs:
* !65938 TRT config updates are merged from 'main' into '23.0' (resubmission of 65926) ~DQ
* !65931 ZDC: implement EventInfo flags in case of LUCROD decoding failure, and update to ZdcRecConfig ~ForwardDetectors
* !63562 Adding cross compatability between onnx and lwtnn as a library for NNs ~Simulation
* !65752 Updates to RPD/Centroid Analysis and ZdcNtuple for Heavy Ions ~ForwardDetectors
* !65925 merging new Algo for TRT (and few changes on config) from 'main' into '23.0' ~DQ
* !65911 Configure correct jet collections for monitoring in HI and UPC mode ~Core, ~DQ, ~JetEtmiss, ~Reconstruction, ~Tile
* !65831 Trigger Jet: Add HI UPC pflow calibration configs (ATR-22067) ~JetEtmiss, ~Reconstruction, ~Trigger, ~TriggerMenu, ~changes-trigger-counts
* !65881 Heavy Ion : Disable out-of-time pileup topo cluster cut ~Reconstruction