athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2019-03-18T14:46:42+01:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/21804Tau trigger: dR combo hypo (ATR-19359) [CLONE]2019-03-18T14:46:42+01:00Daniele ZanziTau trigger: dR combo hypo (ATR-19359) [CLONE]Clone of MR https://gitlab.cern.ch/atlas/athena/merge_requests/21566
in which the squash of the commits failsClone of MR https://gitlab.cern.ch/atlas/athena/merge_requests/21566
in which the squash of the commits failshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/21875TrigAlgorithms: Enable static thread checker2019-03-15T15:43:27+01:00Frank WinklmeierTrigAlgorithms: Enable static thread checkerEnable the static thread-safety checker for most of the `Trigger/TrigAlgorithms` packages and apply the relevant (trivial) fixes. The following packages still need to be done:
```
TrigT2CaloTileMon
TrigT2CaloJet
TrigT2CaloEgamma
TrigT2Ca...Enable the static thread-safety checker for most of the `Trigger/TrigAlgorithms` packages and apply the relevant (trivial) fixes. The following packages still need to be done:
```
TrigT2CaloTileMon
TrigT2CaloJet
TrigT2CaloEgamma
TrigT2CaloCosmic
TrigHIRec
TrigT2CaloCommon
TrigT2CaloTau
```https://gitlab.cern.ch/atlas/athena/-/merge_requests/21909WIP: Tau track sequence dev2019-06-21T15:43:24+02:00Edson Carquin LopezWIP: Tau track sequence devHello,
I'm creating this MR in order to trigger the discussion on the TrackSequence steps of the tau trigger which is ongoing in JIRA https://its.cern.ch/jira/browse/ATR-17399.
This MR should be merged after !21249.
Cheers,
Edson
Ta...Hello,
I'm creating this MR in order to trigger the discussion on the TrackSequence steps of the tau trigger which is ongoing in JIRA https://its.cern.ch/jira/browse/ATR-17399.
This MR should be merged after !21249.
Cheers,
Edson
Tagging the relevant people here: @fpastore @tbold @mvozak @zgrout @martindl @guindonhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/21936Tau trigger: fix for dR hypo (ATR-19359)2019-03-20T02:16:28+01:00Daniele ZanziTau trigger: fix for dR hypo (ATR-19359)follow up from MR https://gitlab.cern.ch/atlas/athena/merge_requests/21804
To fix a bug in the input TEs for the hypofollow up from MR https://gitlab.cern.ch/atlas/athena/merge_requests/21804
To fix a bug in the input TEs for the hypohttps://gitlab.cern.ch/atlas/athena/-/merge_requests/21961Sweeping !21804 from 21.3 to 21.9.
Tau trigger: dR combo hypo (ATR-19359) [CL...2019-03-16T21:08:56+01:00Atlas NightlybuildSweeping !21804 from 21.3 to 21.9.
Tau trigger: dR combo hypo (ATR-19359) [CLONE]Tau trigger: dR combo hypo (ATR-19359) [CLONE]
See merge request atlas/athena!21804Tau trigger: dR combo hypo (ATR-19359) [CLONE]
See merge request atlas/athena!21804https://gitlab.cern.ch/atlas/athena/-/merge_requests/21982Revert "Merge branch 'remove_old_calo' into 'master'"2019-03-18T14:11:46+01:00Frank WinklmeierRevert "Merge branch 'remove_old_calo' into 'master'"This reverts merge request !21910
Causes ATR-19546This reverts merge request !21910
Causes ATR-19546https://gitlab.cern.ch/atlas/athena/-/merge_requests/22007Sweeping !21936 from 21.3 to 21.9.
Tau trigger: fix for dR hypo (ATR-19359)2019-03-20T02:16:18+01:00Atlas NightlybuildSweeping !21936 from 21.3 to 21.9.
Tau trigger: fix for dR hypo (ATR-19359)Tau trigger: fix for dR hypo (ATR-19359)
See merge request atlas/athena!21936Tau trigger: fix for dR hypo (ATR-19359)
See merge request atlas/athena!21936https://gitlab.cern.ch/atlas/athena/-/merge_requests/22014TrigTauRecMerged: const fixes2019-03-21T03:02:28+01:00Frank WinklmeierTrigTauRecMerged: const fixes`const` fixes to avoid static thread checker warnings`const` fixes to avoid static thread checker warningshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/22019Replace InputFilePeeker with the new tool: MetaReader2019-04-11T14:00:34+02:00Dan Andrei CiubotaruReplace InputFilePeeker with the new tool: MetaReaderThis is our implementation of a new tool used to extract metadata from pool and bs files. It is more efficient than the actual implementation using AthFile but it required a considerable number of changes.
All the modification were care...This is our implementation of a new tool used to extract metadata from pool and bs files. It is more efficient than the actual implementation using AthFile but it required a considerable number of changes.
All the modification were carefully tested on our local setup.
We keep as comments the previous implementation and the test cases we used for our internal testing. These comments will be deleted in next Athena release.ATLAS RobotATLAS Robothttps://gitlab.cern.ch/atlas/athena/-/merge_requests/22038TrigTauRec: Fix compilation warnings.2019-03-20T09:21:41+01:00Scott SnyderTrigTauRec: Fix compilation warnings.Local static variables should also be const.Local static variables should also be const.https://gitlab.cern.ch/atlas/athena/-/merge_requests/22039Tau trigger dR bug fix (ATR-19359)2019-03-21T13:59:15+01:00Daniele ZanziTau trigger dR bug fix (ATR-19359)Fix to dR Fex/Hypo in tau triggerFix to dR Fex/Hypo in tau triggerhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/22068Sweeping !22039 from 21.3 to 21.9.
Tau trigger dR bug fix (ATR-19359)2019-03-21T13:59:06+01:00Atlas NightlybuildSweeping !22039 from 21.3 to 21.9.
Tau trigger dR bug fix (ATR-19359)Tau trigger dR bug fix (ATR-19359)
See merge request atlas/athena!22039Tau trigger dR bug fix (ATR-19359)
See merge request atlas/athena!22039https://gitlab.cern.ch/atlas/athena/-/merge_requests/22087Rec ex reco test tau reco march20192019-03-27T03:02:21+01:00Mark HodgkinsonRec ex reco test tau reco march2019Add new ART tests for tau reco from ESDAdd new ART tests for tau reco from ESDhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/22105tauRecTools: Fix handling of neutral pions and kaons in TauTruthMatching2019-03-23T03:02:36+01:00David KirchmeiertauRecTools: Fix handling of neutral pions and kaons in TauTruthMatchingThis MR fixes the truth tau logic for unstable decay products, in particular neutral pions and kaons.
This was initially reported here: https://its.cern.ch/jira/browse/ATLTAU-1624
Pinging @cgrefe, @stsuno, @martindl, @adbailey and @fscu...This MR fixes the truth tau logic for unstable decay products, in particular neutral pions and kaons.
This was initially reported here: https://its.cern.ch/jira/browse/ATLTAU-1624
Pinging @cgrefe, @stsuno, @martindl, @adbailey and @fscutti fyi.https://gitlab.cern.ch/atlas/athena/-/merge_requests/22197Porting RNN tau ID to master2019-04-04T03:02:45+02:00Bertrand Martin Dit LatourPorting RNN tau ID to masterHello,
This MR ports the RNN tau ID code to master. The reference code comes from 21.1 (now 21.3), which has the trigger functionalities used in 2018 tau triggers (0-prong network that is not used for offline taus).
The tuning files are...Hello,
This MR ports the RNN tau ID code to master. The reference code comes from 21.1 (now 21.3), which has the trigger functionalities used in 2018 tau triggers (0-prong network that is not used for offline taus).
The tuning files are the final ones, while 21.0 currently has the preliminary tunes which are then overwritten via an AODFix while making derivations.
For master, it makes sense to use the final tuning directly.
This MR had to touch some JetTagging packages, because they had a local copy of a few source/header files of the lwtnn package (version 2.0), while version 2.8 is now is master, which created some conflict.
Now, JetTagging points to the AtlasExternals library. Tagging @guirriec .
This MR will probably violate the frozen T0 policy because we now schedule the RNN tau ID in the tau reconstruction, which adds a couple of scores as well as some working points (the tau EDM has been updated accordingly).
Tagging @cdeutsch , @fscutti , @adbailey , @cgrefe , @stsuno , @guindon , @carquin . Adding the 'Trigger' label for information, a trigger-specific MR will follow.
Cheers,
Bertrandhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/22227Fix ERROR messages of eflowRec/run_ESDStandardReco.py and tauRec/run_tau_stan...2019-03-30T03:02:17+01:00Susumu OdaFix ERROR messages of eflowRec/run_ESDStandardReco.py and tauRec/run_tau_standalone.py (ATLASRECTS-4688)Fix ERROR messages of eflowRec/run_ESDStandardReco.py and tauRec/run_tau_standalone.py with `--threads 1`.
https://its.cern.ch/jira/browse/ATLASRECTS-4688Fix ERROR messages of eflowRec/run_ESDStandardReco.py and tauRec/run_tau_standalone.py with `--threads 1`.
https://its.cern.ch/jira/browse/ATLASRECTS-4688https://gitlab.cern.ch/atlas/athena/-/merge_requests/22316Add tau trigger chains seeded by Run3 L1TAU to monitoring2019-04-04T19:42:09+02:00Bertrand Martin Dit LatourAdd tau trigger chains seeded by Run3 L1TAU to monitoringHello,
This MR adds to the offline monitoring a couple of tau trigger chains seeded by Run3 L1TAU items (ATR-19610).
The HLT monitoring should work out of the box.
More work will be needed to support Run3 L1 TAU objects (container n...Hello,
This MR adds to the offline monitoring a couple of tau trigger chains seeded by Run3 L1TAU items (ATR-19610).
The HLT monitoring should work out of the box.
More work will be needed to support Run3 L1 TAU objects (container name, ET and isolation variables, ...).
This will be in another iteration.
Cheers,
Bertrandhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/22359Remove some tools from ToolSvc2019-04-04T03:02:18+02:00Walter LamplRemove some tools from ToolSvcI found that many (>100) tools attached to the ToolSvc but never attached to a public ToolHandle. Instead a tool with the same name is often attached to a PrivateToolHandle. This MR removes some of them. Many more to come.I found that many (>100) tools attached to the ToolSvc but never attached to a public ToolHandle. Instead a tool with the same name is often attached to a PrivateToolHandle. This MR removes some of them. Many more to come.https://gitlab.cern.ch/atlas/athena/-/merge_requests/22374Update packages:TrigTauHypo from upstream/21.3 to upstream/master via pseudo...2019-04-09T03:02:13+02:00Bertrand Martin Dit LatourUpdate packages:TrigTauHypo from upstream/21.3 to upstream/master via pseudo-mergeHello,
This MR is a pseudomerge of the TrigTauHypo package from 21.3 to master.
All this code is legacy Run2 code that won't be used for Run3 other than for validation.
So, cleanup was made on a best effort basis (now using ATH_MSG macr...Hello,
This MR is a pseudomerge of the TrigTauHypo package from 21.3 to master.
All this code is legacy Run2 code that won't be used for Run3 other than for validation.
So, cleanup was made on a best effort basis (now using ATH_MSG macros, ...), but no tremendous effort was spent otherwise. Some features no longer supported were dropped (like likelihood tau ID).
Now that RNN Tau ID is available in master (!22197), I take this opportunity to re-enable the monitoring of RNN inputs in TrigTauRec (overall code indentation fixing as a bonus).
The MR was generated with:
```
git-package-pseudomerge.py --packages Trigger/TrigHypothesis/TrigTauHypo --source upstream/21.3 --target upstream/master --stage 2
```
The outcome of `test_physics_pp_v7_primaries_build.sh` looks good, and for ctests,
```
13 - TrigUpgradeTest_egamma_run_data_ctest (Failed)
23 - TrigUpgradeTest_runMenuTest_ctest (Failed)
```
Trying to find out why test 23 failed.
Cheers,
Bertrandhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/22381Sweeping !22316 from 21.3 to 21.9.
Add tau trigger chains seeded by Run3 L1TA...2019-04-04T19:42:09+02:00Atlas NightlybuildSweeping !22316 from 21.3 to 21.9.
Add tau trigger chains seeded by Run3 L1TAU to monitoringAdd tau trigger chains seeded by Run3 L1TAU to monitoring
See merge request atlas/athena!22316Add tau trigger chains seeded by Run3 L1TAU to monitoring
See merge request atlas/athena!22316