athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2022-09-16T16:26:25+02:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/56622Add new links between global FE and CP Objects2022-09-16T16:26:25+02:00Mark HodgkinsonAdd new links between global FE and CP ObjectsThis MR fixes a bug in the MET reconstruction - currently for example it takes a link from an electron to FE and looks up the FE index. Then it assumes that index is valid in the global FE container - that assumption is invalid. The MR f...This MR fixes a bug in the MET reconstruction - currently for example it takes a link from an electron to FE and looks up the FE index. Then it assumes that index is valid in the global FE container - that assumption is invalid. The MR fixes this by creating new links between global FE and electron/photon/muon/taus and then updates the MET c++ code to use these links.
Configuration is added to remove these new global links, and associated variables, from the AOD/ESD - the global FE are not written to either ESD or AOD, so any associated decorations related to this would be useless.
This MR should not violate FT0V in that the AOD contents will not change. The ESD contents, which includes MET, will change because the MET output changes. Therefore eventually when this goes to master it is expected the MET content in PHYS and PHYSLite will change @jcatmore. Can you provide an example Reco_tf command I can use to check if any additional derivation specific config changes are required (this will be the case, if neither RecExCommon nor RecoSteering are used - we would find MET crashes when it does not find these new global links)? Given we don't run derivations in 22.0, I would propose to address this in a separate MR for master once this sweeps there.
Cheers,
Markhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/56154tauRecTools: fix conditional decoration in TauIDVarCalculator2022-09-02T16:05:10+02:00Bertrand Martin Dit LatourtauRecTools: fix conditional decoration in TauIDVarCalculatorHello,
As reported in ATLASRECTS-7186, there is a decoration that is only added onto certain taus (those with at least 1 track).
This causes trouble downstream, when making derivations.
This MR adds a dummy decoration for 0-prong taus.
...Hello,
As reported in ATLASRECTS-7186, there is a decoration that is only added onto certain taus (those with at least 1 track).
This causes trouble downstream, when making derivations.
This MR adds a dummy decoration for 0-prong taus.
Fortunately, this variable is no longer used in R22, it is deprecated, so it won't have any consequence.
But it's too late to phase it out.
Technically, it may be considered as violating frozen T0 policy as it alters the AOD content for 0p taus, but as the variable is not used at all in R22, I hope it won't be an issue.
Cheers,
BertrandBertrand Martin Dit LatourBertrand Martin Dit Latourhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/51268Draft: Add tau precision tracking step (newJO)2022-08-29T15:15:38+02:00Edson Carquin LopezDraft: Add tau precision tracking step (newJO)Implementation of tau trigger precision tracking for the new JO configuration pinging @iriu @ademaria @gipezzulImplementation of tau trigger precision tracking for the new JO configuration pinging @iriu @ademaria @gipezzulhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/55990MM offline DQ - plit PBC in 2 FEB in occupancy plots2022-08-18T21:35:15+02:00Michela BigliettiMM offline DQ - plit PBC in 2 FEB in occupancy plots- split PBC in 2 FEBs in occupancy histograms
- some cleanup
tagging DQ convenors: @sara @ytakubo- split PBC in 2 FEBs in occupancy histograms
- some cleanup
tagging DQ convenors: @sara @ytakubohttps://gitlab.cern.ch/atlas/athena/-/merge_requests/55989ATR-25904: fixed the RUN3_ROI_OVERFLOW_SHIFT and m_OverflowPerRoIMask to 122022-08-18T21:21:19+02:00Patrick Karl CzodrowskiATR-25904: fixed the RUN3_ROI_OVERFLOW_SHIFT and m_OverflowPerRoIMask to 12Fixing the bit shifts as described in ATR-25904Fixing the bit shifts as described in ATR-25904Patrick Karl CzodrowskiPatrick Karl Czodrowskihttps://gitlab.cern.ch/atlas/athena/-/merge_requests/55606Draft: 21.22022-08-15T06:14:15+02:00Lianyou ShanDraft: 21.2Reconstruct taus on AOD and identify with RNN during producing derivation, only in R21.2, with possible muon overlap removed. Mainly DiTauRec, DerivationFrameworkTau.Reconstruct taus on AOD and identify with RNN during producing derivation, only in R21.2, with possible muon overlap removed. Mainly DiTauRec, DerivationFrameworkTau.Lianyou ShanLianyou Shanhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/55667Fixes for TruthJet writing during Gen_tf.py jobs2022-08-11T15:18:53+02:00John Derek ChapmanFixes for TruthJet writing during Gen_tf.py jobsIt was observed that despite being created during generation jobs `xAOD::JetContainer` objects for Truth jets were not being written out to the EVNT file. After some debugging a number of issues were identified and are fixed in this merg...It was observed that despite being created during generation jobs `xAOD::JetContainer` objects for Truth jets were not being written out to the EVNT file. After some debugging a number of issues were identified and are fixed in this merge request.
Update syntax for adding Truth `xAOD::JetContainer` objects to `StreamEVGEN`.
Block loading dictionaries which are not present in `AthGeneration` or `AthSimulation` during `xAOD::JetContainer` writing.John Derek ChapmanJohn Derek Chapmanhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/55747Draft: Daily "22.0 to master" sweep: 09/08/222022-08-11T09:23:00+02:00Adam Edward BartonDraft: Daily "22.0 to master" sweep: 09/08/22Used the new scripts - no conflictsUsed the new scripts - no conflictsAdam Edward BartonAdam Edward Bartonhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/55697Daily "22.0 to master" sweep: 05/08/222022-08-08T08:12:01+02:00Vakhtang TsulaiaDaily "22.0 to master" sweep: 05/08/22The only conflict was in two `version.txt` filesThe only conflict was in two `version.txt` fileshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/55139efex input data bytestream decoder2022-07-20T16:56:51+02:00Will Buttingerefex input data bytestream decoderFollows lead of https://gitlab.cern.ch/atlas/athena/-/merge_requests/53185 by pulling in code from online repo.
This MR depends on the completion of the EDM @ https://gitlab.cern.ch/atlas/athena/-/merge_requests/55015Follows lead of https://gitlab.cern.ch/atlas/athena/-/merge_requests/53185 by pulling in code from online repo.
This MR depends on the completion of the EDM @ https://gitlab.cern.ch/atlas/athena/-/merge_requests/55015Will ButtingerWill Buttingerhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/55158Update JetInputs DQ web display config to add missing plots2022-07-17T16:22:48+02:00Lee SawyerUpdate JetInputs DQ web display config to add missing plotsUpdate to the collisions_run.config files for JetInputs:
- Added missing EM Cluster Ave E and Occ maps for some thresholds and regions.
- Added expert plots in EM folders to better match plots for all clusters.
Fixes some of the issues ...Update to the collisions_run.config files for JetInputs:
- Added missing EM Cluster Ave E and Occ maps for some thresholds and regions.
- Added expert plots in EM folders to better match plots for all clusters.
Fixes some of the issues noted in https://its.cern.ch/jira/browse/ATLLARSWDPQ-419
Merge to R22 for ongoing DQ monitoring.Lee SawyerLee Sawyerhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/54263Draft: changing sTGC TDO tag2022-06-15T03:18:02+02:00Constantin HeideggerDraft: changing sTGC TDO tagChanging the yet still hard-coded tag for the sTGC TDO conditions folder using same constant values as for MM as discussed by mail. Tagging @pscholer @chchau @jojungge @rosatiChanging the yet still hard-coded tag for the sTGC TDO conditions folder using same constant values as for MM as discussed by mail. Tagging @pscholer @chchau @jojungge @rosatihttps://gitlab.cern.ch/atlas/athena/-/merge_requests/54090r22 JetTagging: fix_tow_Run32022-06-10T23:06:05+02:00Alessandro Lapertosar22 JetTagging: fix_tow_Run3Fixes for b-tagging DQ towards Run 3 data taking:
- remove reference to tagger name in cxx (easier to change tagger)
- temporary skip pre-selection for early runs (avoid empty plots in low statistics runs)
- additional plots for PV and t...Fixes for b-tagging DQ towards Run 3 data taking:
- remove reference to tagger name in cxx (easier to change tagger)
- temporary skip pre-selection for early runs (avoid empty plots in low statistics runs)
- additional plots for PV and tracks multiplicity divided by <mu> (reduce pile up effect on runs with different <mu>)
Test Webdisplay: https://atlasdqm.cern.ch/webdisplay/test/56/physics_Main/run_348885/run/JetTagging/https://gitlab.cern.ch/atlas/athena/-/merge_requests/53488Master flip tagger implementation hl2022-06-08T17:31:26+02:00Angela Maria BurgerMaster flip tagger implementation hlImplement the flip version of the High-Level b-taggers in Rel.22Implement the flip version of the High-Level b-taggers in Rel.22https://gitlab.cern.ch/atlas/athena/-/merge_requests/54037Add mu3 thresholds and HLT_2mu3 (ATR-23494)2022-06-08T13:08:17+02:00Kunihiro NaganoAdd mu3 thresholds and HLT_2mu3 (ATR-23494)- Add "3GeV" thresholds in TrigMuonHypoConfig
- Add a chain HLT_2mu3_L12MU3V in Dev menu- Add "3GeV" thresholds in TrigMuonHypoConfig
- Add a chain HLT_2mu3_L12MU3V in Dev menuhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/53952Tracking overlay updates for the RDOtoRDOTrigger step2022-06-03T20:45:13+02:00William Axel LeightTracking overlay updates for the RDOtoRDOTrigger stepThe converters need to be updated for the case in which both the input and output collections start with Bkg_, currently only foresees for the RDOtoRDOTrigger step. The configuration is also updated to load the EventCnvSuperTool and set...The converters need to be updated for the case in which both the input and output collections start with Bkg_, currently only foresees for the RDOtoRDOTrigger step. The configuration is also updated to load the EventCnvSuperTool and set its trackOverlay flag for RDOtoRDOTrigger.https://gitlab.cern.ch/atlas/athena/-/merge_requests/51110Draft: TauTrig, adding HLT tau PrecisionMVA reconstruction tools scheduling ...2022-06-02T22:28:36+02:00Antonio De MariaDraft: TauTrig, adding HLT tau PrecisionMVA reconstruction tools scheduling using ComponentAccumulatorpinging @tbold, @martindl, @iriu, @gipezzul and @carquin
Main links for more information:
* https://indico.cern.ch/event/1134111/contributions/4760376/attachments/2402100/4108241/Tau_JobOptions_04032021.pdf
* https://gitlab.cern.ch/atl...pinging @tbold, @martindl, @iriu, @gipezzul and @carquin
Main links for more information:
* https://indico.cern.ch/event/1134111/contributions/4760376/attachments/2402100/4108241/Tau_JobOptions_04032021.pdf
* https://gitlab.cern.ch/atlas/athena/-/blob/master/Reconstruction/tauRec/python/TauToolHolder.py
Note :
* can only check qualitatively running "test_trig_data_newJO_build.py" -> no error raising from this new added piece of code
* more quantitative/definitive checks will come after PrecisionTracking part will migrated to new job optionshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/53294ctau seeding2022-06-02T14:49:23+02:00Nicola Orlandonicola.orlando@cern.chctau seedingImplementation of ctau HLT seeding based on L1Topo ctau multiplicity class.
The implementation is just a draft, need to check
- Granularity of the used coordinates and pTs
- Is overall this as expected for HLT? @rbielski
#ATR-25307, r...Implementation of ctau HLT seeding based on L1Topo ctau multiplicity class.
The implementation is just a draft, need to check
- Granularity of the used coordinates and pTs
- Is overall this as expected for HLT? @rbielski
#ATR-25307, related to open issue here ATR-25462 (isolation cut is currently hard coded in the L1Topo sim)
@asonay @paulama @iriu @jmharrishttps://gitlab.cern.ch/atlas/athena/-/merge_requests/53693Add gXENC and gXERHO TOBs to the L1Topo simulation2022-06-01T21:55:33+02:00Paula Martinez SuarezAdd gXENC and gXERHO TOBs to the L1Topo simulation- Add gXENC and gXERHO TOBs to the L1Topo simulation.
- Enable the corresponding multiplicity algorithms.
- Other fixes: change histogram range for eEm and eTau isolation thresholds.
Tagging @orlando @iriu @asonay @jmharris.- Add gXENC and gXERHO TOBs to the L1Topo simulation.
- Enable the corresponding multiplicity algorithms.
- Other fixes: change histogram range for eEm and eTau isolation thresholds.
Tagging @orlando @iriu @asonay @jmharris.https://gitlab.cern.ch/atlas/athena/-/merge_requests/53648Switch to GSF by default for electron chains inside the TrigEgammaMatchingTool2022-05-25T17:16:50+02:00Edmar Egidio Purcino De SouzaSwitch to GSF by default for electron chains inside the TrigEgammaMatchingToolThis MR is to fix the electron keys inside the TrigEgammaMatchingTool, setting the GSF key as default for electrons.
This discussion is being done in ATR-25223 .
ping: @cjmeyer , @jodafons , @safarzad , @fernando and @jlieberm .This MR is to fix the electron keys inside the TrigEgammaMatchingTool, setting the GSF key as default for electrons.
This discussion is being done in ATR-25223 .
ping: @cjmeyer , @jodafons , @safarzad , @fernando and @jlieberm .Edmar Egidio Purcino De SouzaEdmar Egidio Purcino De Souza