athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2024-03-22T13:20:55+01:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/70047More test chains for delayed jets2024-03-22T13:20:55+01:00Lucas BezioMore test chains for delayed jetsAs discussed on [ATR-28836](https://its.cern.ch/jira/browse/ATR-28836), more test chains are added. Some are requiring 2jets to be delayed aiming to reduce the rate even with low pt threshold. Copies of the test chains with upper limit o...As discussed on [ATR-28836](https://its.cern.ch/jira/browse/ATR-28836), more test chains are added. Some are requiring 2jets to be delayed aiming to reduce the rate even with low pt threshold. Copies of the test chains with upper limit on timing are also added.https://gitlab.cern.ch/atlas/athena/-/merge_requests/70028Add TauTrig collection in 24.0 for Trigger validation during 2024 ramp-up period2024-03-27T07:32:08+01:00Antonio De MariaAdd TauTrig collection in 24.0 for Trigger validation during 2024 ramp-up periodThis MR is meant to add HLT tau containers + L1 Phase 1 containers in PHYS for branch 24.0
These additional containers will be needed for the validation of the Phase-1 tau triggers during 2024 ramp-up period
Tagging @smwang, @slai, @gi...This MR is meant to add HLT tau containers + L1 Phase 1 containers in PHYS for branch 24.0
These additional containers will be needed for the validation of the Phase-1 tau triggers during 2024 ramp-up period
Tagging @smwang, @slai, @gipezzul, @martindl, @jbeaucam, @mashamim, @sshaw and @khoohttps://gitlab.cern.ch/atlas/athena/-/merge_requests/69340Draft: TriggerMenuMT: centralize AccumulatorCache for steps and disable deepcopy2024-03-13T12:03:59+01:00Frank WinklmeierDraft: TriggerMenuMT: centralize AccumulatorCache for steps and disable deepcopyThis is a (for the moment) experimental change to the menu generation that should be discussed amongst experts and in a trigger core SW meeting.
Move the `AccumulatorCache` to the `getStep` method and remove it from the signature-specif...This is a (for the moment) experimental change to the menu generation that should be discussed amongst experts and in a trigger core SW meeting.
Move the `AccumulatorCache` to the `getStep` method and remove it from the signature-specific files. The actual change to review is in `ChainConfigurationBase.py` .
In addition, do not `deepcopy` the result of the sequence configuration (`ChainStep`) as it is not being re-used or modified afterwards. This was also the behavior of the original `RecoFragmentsPool` before it was migrated to `AccumulatorCache`. The deepcopy can be enabled again by setting `Trigger.fastMenuGeneration=False`.
**Reduces the menu generation time of Dev_pp_run3_v1 by a factor 2**. It does however introduce (harmless) changes in the order of some of the `HypoTools` and `InputMakerInputDecisions` properties. In case we decide to move forward with this we would definitely want to add an ART test that checks the configuration is equivalent with/without `fastMenuGeneration` (see this recent [confTool improvement](https://gitlab.cern.ch/atlas/athena/-/merge_requests/69329 "confTool: add ignoreOrder command line option")).
E.g. in the HI menu, the following properties change order (many more in the pp menu):
```plaintext
IM_EFMuMSReco_RoI.InputMakerInputDecisions
IM_L2MuCombReco.InputMakerInputDecisions
SPCountHypoAlg.HypoTools
TrigHIFwdGapHypoAlg.HypoTools
TrigL2MuCBHypoAlg.HypoTools
TrigL2MufastHypoAlg.HypoTools
TrigMuonEFCombinerHypoAlg.HypoTools
TrigMuonEFMSonlyHypo_RoI.HypoTools
```
cc @tbold @fpastore @tamartin
Relates to [ATR-26996](https://its.cern.ch/jira/browse/ATR-26996).https://gitlab.cern.ch/atlas/athena/-/merge_requests/69228Updating LAr EM NTuple creation to CA based configuration2024-02-26T13:13:58+01:00Mustafa Andre SchmidtUpdating LAr EM NTuple creation to CA based configurationThe configuration script for the LAr EM NTuple creation as well as the README file was changed to be compatible with the new CA-based configuration.The configuration script for the LAr EM NTuple creation as well as the README file was changed to be compatible with the new CA-based configuration.https://gitlab.cern.ch/atlas/athena/-/merge_requests/69205Protect possible rare FPEs2024-03-19T18:09:08+01:00Vadim KostyukhinProtect possible rare FPEsAdd some protection in an attempt to avoid rare FPEs observed in trigger ATLASRECTS-7659Add some protection in an attempt to avoid rare FPEs observed in trigger ATLASRECTS-7659https://gitlab.cern.ch/atlas/athena/-/merge_requests/69154gFEX: fix bug in gTower class2024-02-22T22:06:42+01:00Cecilia ToscirigFEX: fix bug in gTower classWith this MR, a bug found in `gTower::getFWID` is fixed. This assigns the correct energy to some gTowers in the forward region, that were previously swapped. Consequently, this solves some mismatches found in the hw vs sw comparison for ...With this MR, a bug found in `gTower::getFWID` is fixed. This assigns the correct energy to some gTowers in the forward region, that were previously swapped. Consequently, this solves some mismatches found in the hw vs sw comparison for small-R jets and also improves results for large-R jets and MET quantities.https://gitlab.cern.ch/atlas/athena/-/merge_requests/69149Fix bug in gTower class2024-02-22T21:07:56+01:00Cecilia TosciriFix bug in gTower classWith this MR, a bug found in `gTower::getFWID` is fixed. This assigns the correct energy to some gTowers in the forward region, that were previously swapped. Consequently, this solves some mismatches found in the hw vs sw comparison for ...With this MR, a bug found in `gTower::getFWID` is fixed. This assigns the correct energy to some gTowers in the forward region, that were previously swapped. Consequently, this solves some mismatches found in the hw vs sw comparison for small-R jets and also improves results for large-R jets and MET quantities.https://gitlab.cern.ch/atlas/athena/-/merge_requests/69095Draft: Move FTagEventSF to standalone analysis config2024-03-08T02:18:58+01:00Thomas StreblerDraft: Move FTagEventSF to standalone analysis configBuilt on top of !69002
Use similar config to JVT analysis config, to be able to define overlap removal dependency in the same wayBuilt on top of !69002
Use similar config to JVT analysis config, to be able to define overlap removal dependency in the same wayhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/67428Draft: tauRecoTools additional cleanup2023-12-05T14:10:46+01:00Antonio De MariaDraft: tauRecoTools additional cleanuphttps://gitlab.cern.ch/atlas/athena/-/merge_requests/66360Draft: add DiTau BDT score to TauCP list of variables available for derivations2023-11-27T13:16:14+01:00Antonio De MariaDraft: add DiTau BDT score to TauCP list of variables available for derivationsTagging @martindlTagging @martindlhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/66322Draft: Test if the unique association between the Vtx and Trks for Tau TJVA c...2023-10-07T11:24:23+02:00Qichen Dongqichen.dong@cern.chDraft: Test if the unique association between the Vtx and Trks for Tau TJVA changes Reco outputTest if the unique association between the Vtx and Trks for Tau TJVA changes Reco outputTest if the unique association between the Vtx and Trks for Tau TJVA changes Reco outputQichen Dongqichen.dong@cern.chQichen Dongqichen.dong@cern.chhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/65886Draft: use Flags instead of hard-coded values in DiTauRec builder2023-09-26T12:51:13+02:00Antonio De MariaDraft: use Flags instead of hard-coded values in DiTauRec builderhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/65836Draft: Update of Ditaumasstools for lfv2023-09-15T17:52:29+02:00Kieran Robert AmosDraft: Update of Ditaumasstools for lfvApplies various fixes to the lepton flavour violating version of the DiTauMassTool.
Increases the default N of sigmas with which to vary the MET to 5.
Allows to adjust the beam energy (default 6500 GeV).
Adds the option to retry th...Applies various fixes to the lepton flavour violating version of the DiTauMassTool.
Increases the default N of sigmas with which to vary the MET to 5.
Allows to adjust the beam energy (default 6500 GeV).
Adds the option to retry the fit with the other lepton ordering in the fully leptonic case (default true).https://gitlab.cern.ch/atlas/athena/-/merge_requests/65708Draft: starting to add DiTauRecTools folder for DiTau identification2023-09-13T23:20:16+02:00Antonio De MariaDraft: starting to add DiTauRecTools folder for DiTau identificationhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/65225Extend BuildTruthTau to decorate Tau with prod/decay vertex2023-08-25T09:54:44+02:00Antonio De MariaExtend BuildTruthTau to decorate Tau with prod/decay vertexThis MR is meant to add the Truth tau decay/production vertex information among the info available in the TruthTau container.
If it's possible (and time) allows, this MR should go in for the imminent PHYS production.
For long term (next...This MR is meant to add the Truth tau decay/production vertex information among the info available in the TruthTau container.
If it's possible (and time) allows, this MR should go in for the imminent PHYS production.
For long term (next PHYS production) we plan also to add the four-momentum of the tau decay products as this is needed/requested to run the TauSpinner algorithm used by some ATLAS analyses for tau spin related studies
Tagging @dta, @sineadf and @martindlhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/65154Draft: Fix ATR-280842023-12-27T16:36:31+01:00Edson Carquin LopezDraft: Fix ATR-28084Closes ATR-28084Closes ATR-28084https://gitlab.cern.ch/atlas/athena/-/merge_requests/64947Draft: Fix EtaPtFilter to avoid some missing parent links for leptons2023-08-11T10:18:04+02:00R D SchafferDraft: Fix EtaPtFilter to avoid some missing parent links for leptonsThis is a continuation of [!64793](https://gitlab.cern.ch/atlas/athena/-/merge_requests/64793#note_7000903).
This implements the missing truth filtering via EtaPtFilter. This is done only for the CA Hits to AOD production, i.e. it remai...This is a continuation of [!64793](https://gitlab.cern.ch/atlas/athena/-/merge_requests/64793#note_7000903).
This implements the missing truth filtering via EtaPtFilter. This is done only for the CA Hits to AOD production, i.e. it remains commented out in jobOpts. This uses the TruthParticleBuilder which was used in the past to go from GenEvent to TruthEvent - which is not xAOD formatted one. It also performed as a first step the filtering of the truth in a GenEvent to GenEvent step. Only the filtering is not done. This reduces the AOD by a few percent due to truth reduction. This MR also fixes a problem in the filtering where the parent child links can be lost for leptons with eta > 5.5. Note that dumpTruth.py was slighting changed to be more coherent in way one passes the CA arguments.
Pinging @zmarshal, @jchapman, @jcatmoreR D SchafferR D Schafferhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/64749Draft: Updates in MCTruthClassifier to avoid explicit barcode usage2023-08-09T14:07:02+02:00Andrii VerbytskyiDraft: Updates in MCTruthClassifier to avoid explicit barcode usage- Updates in MCTruthClassifier to avoid explicit barcode usage
- Use shared pointers in the interface
@jchapman- Updates in MCTruthClassifier to avoid explicit barcode usage
- Use shared pointers in the interface
@jchapmanhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/64489Draft: Unification of truthutils2023-07-24T17:49:42+02:00Andrii VerbytskyiDraft: Unification of truthutils- use the `isZeroEnergyPhoton` and function
- added comments to the `HepMCHelpers.h`
- Changed `MenuTruthThinning_isBSM` according to https://its.cern.ch/jira/browse/ATLASG-2550- use the `isZeroEnergyPhoton` and function
- added comments to the `HepMCHelpers.h`
- Changed `MenuTruthThinning_isBSM` according to https://its.cern.ch/jira/browse/ATLASG-2550https://gitlab.cern.ch/atlas/athena/-/merge_requests/63874Use MC:: namespace instead of MC::PID:: namespace.2023-06-27T11:40:18+02:00Andrii VerbytskyiUse MC:: namespace instead of MC::PID:: namespace.Use MC:: namespace instead of MC::PID:: namespace.
@jchapmanUse MC:: namespace instead of MC::PID:: namespace.
@jchapman