athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2024-03-28T15:45:48+01:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/69957save only ditaus with 2 subjets candidates2024-03-28T15:45:48+01:00Antonio De Mariasave only ditaus with 2 subjets candidatesThis MR is meant to remove the 1 subject + 1 electron/muon selection to save a ditau object, keeping only ditaus with >= 1 subjet. The collimated 1 electron/muon + 1 tau is already covered by the Tau Ele OLR and Tau Muon OLR collections....This MR is meant to remove the 1 subject + 1 electron/muon selection to save a ditau object, keeping only ditaus with >= 1 subjet. The collimated 1 electron/muon + 1 tau is already covered by the Tau Ele OLR and Tau Muon OLR collections.
Tagging @martindl and @ntamirhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/69859ConfigBlocks: update how options are set and remove make functions2024-03-22T08:30:18+01:00Joseph Earl LambertConfigBlocks: update how options are set and remove make functionsAll configurable parameters are now options.
Added features to each block and `ConfigFactory` so that
all of the options can be set at the same time as the block is
created in the same way as the make functions.
Removed all make functi...All configurable parameters are now options.
Added features to each block and `ConfigFactory` so that
all of the options can be set at the same time as the block is
created in the same way as the make functions.
Removed all make functions that only act to set arguments since this
can be done without any extra code now.
Code using the `TextConfig`, `ConfigFactory` or the block configuration using classes
should be unaffected. Code that calls the make functions that where removed
will need to be update (makeSomeConfig -> SomeBlock and no longer pass the seq).
To create the block and set all options using the factory:
```
from AnalysisAlgorithmsConfig.ConfigFactory import ConfigFactory
config = ConfigFactory()
...
configSeq += config.makeConfig('GeneratorLevelAnalysis',
saveCutBookkeepers=True,
runNumber=284500)
```
Can also pass some this way and then set others individually like before.
To create the block and set all options using the blocks:
```
from AsgAnalysisAlgorithms.AsgAnalysisConfig import GeneratorAnalysisBlock
configSeq.append( GeneratorAnalysisBlock(
saveCutBookkeepers=True,
runNumber=284500) )
```https://gitlab.cern.ch/atlas/athena/-/merge_requests/69157Draft: Remove wrong defined "RNNEleScoreSigTrans" variable (xAOD change)2024-02-27T08:10:03+01:00Antonio De MariaDraft: Remove wrong defined "RNNEleScoreSigTrans" variable (xAOD change)This MR is meant to remove "RNNEleScoreSigTrans" variable in xAODs since this is a variable derived from buggy flattening procedure. This should be substituted by "RNNEleScoreSigTrans_v1". The drop of "RNNEleScoreSigTrans" from PHYS and ...This MR is meant to remove "RNNEleScoreSigTrans" variable in xAODs since this is a variable derived from buggy flattening procedure. This should be substituted by "RNNEleScoreSigTrans_v1". The drop of "RNNEleScoreSigTrans" from PHYS and PHYSLITE was already done previously (https://gitlab.cern.ch/atlas/athena/-/merge_requests/66089), so the only change expect here is at xAOD level
Also, given this change, the following flags won't be defined anymore:
* IsTauFlag.EleRNNLoose
* IsTauFlag.EleRNNMedium
* IsTauFlag.EleRNNTighthttps://gitlab.cern.ch/atlas/athena/-/merge_requests/69062Draft: Try to use templates in the MCtruthClassifier to avoid declatrations o...2024-03-21T23:15:45+01:00Andrii VerbytskyiDraft: Try to use templates in the MCtruthClassifier to avoid declatrations of multiple functionsTry to use templates in the MCtruthClassifier to avoid declatrations of multiple functionsTry to use templates in the MCtruthClassifier to avoid declatrations of multiple functionshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/68664Draft: Implementation of ONNX model score computation and decoration for Taus...2024-03-28T11:42:23+01:00Nadav Michael TamirDraft: Implementation of ONNX model score computation and decoration for Taus (GNTau)Add tools and wrappers to run ONNX-based models for Tau objects. Details can be found in [FTag software meeting presentation](https://indico.cern.ch/event/1378241/contributions/5792680/attachments/2794403/4874167/GNTau_ftagSW.pdf), but i...Add tools and wrappers to run ONNX-based models for Tau objects. Details can be found in [FTag software meeting presentation](https://indico.cern.ch/event/1378241/contributions/5792680/attachments/2794403/4874167/GNTau_ftagSW.pdf), but in short: a new class and tool are added to tauRecTools along with some new variable calculator functionalities to run model inference and decorate TauJets and TauTracks, and DerivationFrameworkTau + tauRec are modified to call the tools and decorate the DAOD TauJets (if one also decorates the DeepSetID at the moment).https://gitlab.cern.ch/atlas/athena/-/merge_requests/69513Use config flags in analysis config2024-03-28T13:34:35+01:00Tadej Novaktadej.novak@cern.chUse config flags in analysis configMake config flags the main way to steer analysis config. This will help people working on analysis and Athena to feel at home and prevent accumulation of arguments of the `ConfigAccumulator`.
The naming is not fixed, I will probably als...Make config flags the main way to steer analysis config. This will help people working on analysis and Athena to feel at home and prevent accumulation of arguments of the `ConfigAccumulator`.
The naming is not fixed, I will probably also convert more items to flags. This is mainly to start the discussion and freeze the API as soon asp possible. I will probably then break this into multiple MRs.
Also some core flags should be renamed (see https://its.cern.ch/jira/browse/ATEAM-964).
Tagging @krumnack, @jolamber, @gwatts, @ekourlit for core AMG. Also tagging interested parties @ravinab, @omajersk, @tstreble, @khoo, @jchapman.