athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2019-03-05T03:02:15+01:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/21590TileGeoG4Calib: Remove calls to MT-unsafe set_do_checks.2019-03-05T03:02:15+01:00Scott SnyderTileGeoG4Calib: Remove calls to MT-unsafe set_do_checks.Remove calls to MT-unsafe set_do_checks.Remove calls to MT-unsafe set_do_checks.https://gitlab.cern.ch/atlas/athena/-/merge_requests/21666TileGeoModel: Remove set_do_checks() calls.2019-03-15T15:41:56+01:00Scott SnyderTileGeoModel: Remove set_do_checks() calls.Remove MT-unsafe calls to set_do_checks().Remove MT-unsafe calls to set_do_checks().https://gitlab.cern.ch/atlas/athena/-/merge_requests/21665Fix Tile simulation in AthenaMT (ATLASSIM-4053)2019-03-15T15:42:43+01:00Siarhei HarkushaFix Tile simulation in AthenaMT (ATLASSIM-4053)MT-unsafe mutable variable to keep granularity in time
for hits has been removed as private member in TileG4SDCalc.
Now it is calcuated and passed directly to clients.MT-unsafe mutable variable to keep granularity in time
for hits has been removed as private member in TileG4SDCalc.
Now it is calcuated and passed directly to clients.https://gitlab.cern.ch/atlas/athena/-/merge_requests/21606Migrate Tile Digi to use IAtRNGSvc for AthenaMT2019-03-15T15:44:48+01:00Hass AbouzeidMigrate Tile Digi to use IAtRNGSvc for AthenaMTChanging the method in which random numbers are retrieved for the Tile
Sim code in order for reproducible output when running in
AthenaMT.
cc @jchapman
Marking as WIP until folks are reasonably happy.Changing the method in which random numbers are retrieved for the Tile
Sim code in order for reproducible output when running in
AthenaMT.
cc @jchapman
Marking as WIP until folks are reasonably happy.https://gitlab.cern.ch/atlas/athena/-/merge_requests/21618TileCalibAlgs: Migration of package to use private tools2019-03-15T15:45:09+01:00Tigran MkrtchyanTileCalibAlgs: Migration of package to use private toolsTileCalibAlgs package is now using private tools instead of public ones.
jobOptions_TileCalibRec.py has been modified for compatibility.TileCalibAlgs package is now using private tools instead of public ones.
jobOptions_TileCalibRec.py has been modified for compatibility.https://gitlab.cern.ch/atlas/athena/-/merge_requests/21777TileRec: Fix clang compilation warnings.2019-03-15T15:46:10+01:00Scott SnyderTileRec: Fix clang compilation warnings.clang warnings: braces in initialization.clang warnings: braces in initialization.https://gitlab.cern.ch/atlas/athena/-/merge_requests/21870clean up warnings in AthDerivation2019-03-15T15:49:24+01:00Nils Erik Krumnackclean up warnings in AthDerivationI went through and cleaned up a large number of the warnings in the AthDerivation build. The only warnings remaining are the ones that require some restructuring, or some closer look to make sure they aren't pointing to actual mistakes....I went through and cleaned up a large number of the warnings in the AthDerivation build. The only warnings remaining are the ones that require some restructuring, or some closer look to make sure they aren't pointing to actual mistakes. Somebody should probably lean on the domain experts to fix those remaining warnings.
I broke this up into a large number of commits, one per package, to make it easier to sweep between releases if we ever need to; as such please don't squash the commits. Also, in most cases I purposely only commented out old code instead of removing it, to leave it for the domain experts to decide whether that code should go or not.
cc @egramsta, @guirriec, @boeriu, @akraszna, @ksurulizhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/21914Refactor TileCoolMgr python class2019-03-19T03:02:08+01:00Walter LamplRefactor TileCoolMgr python classSplit TileCoolMgr into a class-definition that is compatible with run-3 style configuration flags and a separate file for backward-compatiblity
Triggered by the discussion on !21428.Split TileCoolMgr into a class-definition that is compatible with run-3 style configuration flags and a separate file for backward-compatiblity
Triggered by the discussion on !21428.https://gitlab.cern.ch/atlas/athena/-/merge_requests/21971TileIdentifier: Enable thread-safety static checker.2019-03-19T03:02:26+01:00Scott SnyderTileIdentifier: Enable thread-safety static checker.Enable thread-safety static checker.Enable thread-safety static checker.https://gitlab.cern.ch/atlas/athena/-/merge_requests/22000TileRawUtils: Fix gcc9 warnings.2019-03-20T03:02:12+01:00Scott SnyderTileRawUtils: Fix gcc9 warnings.In C++11, implicit declarations of copy and assignment are deprecated if the
class has a user defined destructor or copy or assignment. gcc9 now warns
about this by default.
Adjust to avoid the warning.In C++11, implicit declarations of copy and assignment are deprecated if the
class has a user defined destructor or copy or assignment. gcc9 now warns
about this by default.
Adjust to avoid the warning.https://gitlab.cern.ch/atlas/athena/-/merge_requests/21995Fix const correctness in Tile containers2019-03-21T03:02:21+01:00Siarhei HarkushaFix const correctness in Tile containersSome methods of Tile containers, which allow modifying
the contents of containers, violate the const correctness.
Tile convertors have been migrated to use mutable Tile containers.
Methods of Tile containers, which violate the const cor...Some methods of Tile containers, which allow modifying
the contents of containers, violate the const correctness.
Tile convertors have been migrated to use mutable Tile containers.
Methods of Tile containers, which violate the const correctness
have been removed.https://gitlab.cern.ch/atlas/athena/-/merge_requests/22057TileMonitoring: Migrate monitoring Tile time with jets for Run 32019-03-23T03:02:27+01:00Siarhei HarkushaTileMonitoring: Migrate monitoring Tile time with jets for Run 3New TileJetMonitorAlgorithm algorithm has been added
to monitor Tile time with jets for run 3.
Functionality has just been copied from TileJetMonTool.
New TileJetMonitorAlgorithm python module has been added
to configure this algorithm ...New TileJetMonitorAlgorithm algorithm has been added
to monitor Tile time with jets for run 3.
Functionality has just been copied from TileJetMonTool.
New TileJetMonitorAlgorithm python module has been added
to configure this algorithm in new JO style.
New TileMonitoringCfgHelper module has been added
with helper functions which may be usefull for configuring
future Tile monitoring algorithm also.https://gitlab.cern.ch/atlas/athena/-/merge_requests/22121Merge 21.0.95 into 21.3 branch2019-03-28T18:03:15+01:00John Derek ChapmanMerge 21.0.95 into 21.3 branchThis merge request merges the changes that went into the ~"21.0" branch between the [release/21.0.94](https://gitlab.cern.ch/atlas/athena/tags/release/21.0.94) and
[release/21.0.95](https://gitlab.cern.ch/atlas/athena/tags/release/21.0....This merge request merges the changes that went into the ~"21.0" branch between the [release/21.0.94](https://gitlab.cern.ch/atlas/athena/tags/release/21.0.94) and
[release/21.0.95](https://gitlab.cern.ch/atlas/athena/tags/release/21.0.95) tags into the ~"21.3" branch.
MRs in https://gitlab.cern.ch/atlas/athena/tags/nightly/21.0/2019-02-13T2159, accepted since https://gitlab.cern.ch/atlas/athena/tags/nightly/21.0/2019-03-20T2159 :
* !21887 : 21.0-FastCaloSim: Adding function LoadFCalGeometryFromFiles to CaloGeometryFromFile
* !21917 : Updating to the latest version of FastCaloSimV2 parametrization file
* !21963 : Add protection for rounding errors
* !21859 : Fix failure on invalid LumiAccounting data (affected 301915 and 301918)
* !21828 : xAOD::EventInfo conversion fix in PileUpEventLoopMgr (ATLASSIM-4081)
* !21598 : R-Hadron Mass Updates
* !21660 : Patch preInclude.Qball.py to work-around missing specialConfiguration metadata
* !21682 : User action that dumps all volumes and classifies them.
* !21699 : Fix for TrigAnalysisTest test test_mc_ntup_physval_grid.sh
* !21722 : 21.0-FastCaloSim: Removing LoadFCalGeometryFromFiles function
* !21764 : Added more histograms as a function of initial step vol/process/material
* !21768 : Protection for empty GenEvents in BeamEffectsAlg::patchSignalProcessVertex(...)
* !21114 : DerivationFrameworkInDet: Fixes DOAD_IDTIDE derivation format
* !21646 : Patch Simulation RunTier0Test job, so that it works in AthSimulation builds
* !20467 : Optimization of CPU time of FastCaloSimV2 (ATLASSIM-3980)
* !21400 : Tier0Tests: Add versioning for overlay background RDO samples
* !21412 : Add new tests to TrigAnalysisTest ART tests
* !21422 : Fixes for Qball simulation configuration
* !21465 : replaces parameterized_sin with parameterized_sincos ~"changes\-fullsim\-output"
* !21492 : MC overlay ART updates (21.0 branch)
* !21520 : Sweeping !21432 from 21.3 to 21.0.
* !21539 : 21.0-ART_test-InDetPhysValMonitoring
* !21577 : 2018PbPb overlay config update
* !21587 : 21.0 SimulationJobOptions: Fix in postInclude.HijingPars.py to get output streams from correct locations
* !20214 : PixelRadDamDigitization: Algorithm for interpolation of irraditaed E fields
* !21336 : Tilecal new laser unpack 2019 02 19
* !21349 : Sweeping !21299 from 21.3 to 21.0.
* !21374 : Sweeping !21326 from 21.3 to 21.0.
* !21460 : RadiationMapsMaker: added flux for >100 keV neutrons and charged hadrons
* !21256 : Sweeping !21226 from master to 21.0.
* !21221 : TileJetMonTool: update of the tool
* !21163 : 21.0-ISF_FastCaloSim: Adding TFCSCenterPositionCalculation to the simulation chain
* !21074 : Switch off AthSimulation ART-build tests for unsupported Simulation configurations
The full diff between [release/21.0.95](https://gitlab.cern.ch/atlas/athena/tags/release/21.0.95) and
[release/21.0.94](https://gitlab.cern.ch/atlas/athena/tags/release/21.0.94) is available at https://gitlab.cern.ch/atlas/athena/compare/release/21.0.94...release/21.0.95
7d996a63https://gitlab.cern.ch/atlas/athena/-/merge_requests/21327Removes AthFilterSeq from the sequence structure2019-03-31T19:35:11+02:00Miha Muskinjamiha.muskinja@cern.chRemoves AthFilterSeq from the sequence structureRemoves AthFilterSeq because it is likely not needed, as discussed in Core SW meeting: https://indico.cern.ch/event/800566/. This would simplify the sequence structure and allow for further optimization in the future.
Some JOs were us...Removes AthFilterSeq because it is likely not needed, as discussed in Core SW meeting: https://indico.cern.ch/event/800566/. This would simplify the sequence structure and allow for further optimization in the future.
Some JOs were using AthFilterSeq, presumably for filtering. I have moved those filters in AthMasterSeq. Authors of the JOs could create a new sequence and place it at the top of AthMasterSeq if that is really necessary. We wanted to avoid having such a sequence by default because it would be empty in most cases.
Changes are as follows:
- remove AthFilterSeq,
- change AthMasterSeq to prompt,
- set IgnoreFilterPassed=True in AthAlgSeq,
https://gitlab.cern.ch/atlas/athena/-/merge_requests/22294TileByteStream: Update reference files.2019-04-02T03:02:02+02:00Scott SnyderTileByteStream: Update reference files.Fix test failures in master.Fix test failures in master.https://gitlab.cern.ch/atlas/athena/-/merge_requests/22300Remove usage of AlgErrorAuditor2019-04-03T03:02:10+02:00Frank WinklmeierRemove usage of AlgErrorAuditorWith the new error reporting policy decided in a recent [reconstruction meeting](https://indico.cern.ch/event/808941),
the `AlgErrorAuditor` is now obsolete. Remove its usage and the relevant
reconstruction flag (`rec.abortOnErrorMessag...With the new error reporting policy decided in a recent [reconstruction meeting](https://indico.cern.ch/event/808941),
the `AlgErrorAuditor` is now obsolete. Remove its usage and the relevant
reconstruction flag (`rec.abortOnErrorMessage`). The latter was a misnomer to being with as the job did not abort on any ERROR message but rather
only on error messages that violated the error reporting policy.
cc @mhodgkin @goetz @leggetthttps://gitlab.cern.ch/atlas/athena/-/merge_requests/22359Remove some tools from ToolSvc2019-04-04T03:02:18+02:00Walter LamplRemove some tools from ToolSvcI found that many (>100) tools attached to the ToolSvc but never attached to a public ToolHandle. Instead a tool with the same name is often attached to a PrivateToolHandle. This MR removes some of them. Many more to come.I found that many (>100) tools attached to the ToolSvc but never attached to a public ToolHandle. Instead a tool with the same name is often attached to a PrivateToolHandle. This MR removes some of them. Many more to come.https://gitlab.cern.ch/atlas/athena/-/merge_requests/21336Tilecal new laser unpack 2019 02 192019-04-04T09:56:29+02:00Henric WilkensTilecal new laser unpack 2019 02 19Added decoding of the timeout bits for QDC (bit 31) and TDC (bit 30) from the laserbox filter&slama delay word.
QDC and TDC timeout status added to the LaserObject.
QDC timeout bit used to reject event in the h3000 N-tuple fillingAdded decoding of the timeout bits for QDC (bit 31) and TDC (bit 30) from the laserbox filter&slama delay word.
QDC and TDC timeout status added to the LaserObject.
QDC timeout bit used to reject event in the h3000 N-tuple fillinghttps://gitlab.cern.ch/atlas/athena/-/merge_requests/21221TileJetMonTool: update of the tool2019-04-04T09:56:30+02:00Vojtech PleskotTileJetMonTool: update of the toolUpdate of the jet and event cleaning in TileJetMonTool.
As a test, I've run RunTier0Tests.py --r2a. All the tests there passed.Update of the jet and event cleaning in TileJetMonTool.
As a test, I've run RunTier0Tests.py --r2a. All the tests there passed.https://gitlab.cern.ch/atlas/athena/-/merge_requests/22502TileRecAlgs: Make Tile digits filter algorithm reentrant2019-04-10T03:02:13+02:00Siarhei HarkushaTileRecAlgs: Make Tile digits filter algorithm reentrant