athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2024-02-26T13:13:58+01:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/69228Updating LAr EM NTuple creation to CA based configuration2024-02-26T13:13:58+01:00Mustafa Andre SchmidtUpdating LAr EM NTuple creation to CA based configurationThe configuration script for the LAr EM NTuple creation as well as the README file was changed to be compatible with the new CA-based configuration.The configuration script for the LAr EM NTuple creation as well as the README file was changed to be compatible with the new CA-based configuration.https://gitlab.cern.ch/atlas/athena/-/merge_requests/69154gFEX: fix bug in gTower class2024-02-22T22:06:42+01:00Cecilia ToscirigFEX: fix bug in gTower classWith this MR, a bug found in `gTower::getFWID` is fixed. This assigns the correct energy to some gTowers in the forward region, that were previously swapped. Consequently, this solves some mismatches found in the hw vs sw comparison for ...With this MR, a bug found in `gTower::getFWID` is fixed. This assigns the correct energy to some gTowers in the forward region, that were previously swapped. Consequently, this solves some mismatches found in the hw vs sw comparison for small-R jets and also improves results for large-R jets and MET quantities.https://gitlab.cern.ch/atlas/athena/-/merge_requests/69149Fix bug in gTower class2024-02-22T21:07:56+01:00Cecilia TosciriFix bug in gTower classWith this MR, a bug found in `gTower::getFWID` is fixed. This assigns the correct energy to some gTowers in the forward region, that were previously swapped. Consequently, this solves some mismatches found in the hw vs sw comparison for ...With this MR, a bug found in `gTower::getFWID` is fixed. This assigns the correct energy to some gTowers in the forward region, that were previously swapped. Consequently, this solves some mismatches found in the hw vs sw comparison for small-R jets and also improves results for large-R jets and MET quantities.https://gitlab.cern.ch/atlas/athena/-/merge_requests/68662TileRecEx+TileConfiguration+TileConditions: Add Tile D3PD CA-based configuration2024-02-07T19:12:37+01:00Siarhei HarkushaTileRecEx+TileConfiguration+TileConditions: Add Tile D3PD CA-based configurationTile D3PD new-style (CA-based) configuration has been added.
Tile run type has been updated to check if it is bigain type.
Tile cabling service configuration has been updated to create it always,
since it is actually used implicitly in...Tile D3PD new-style (CA-based) configuration has been added.
Tile run type has been updated to check if it is bigain type.
Tile cabling service configuration has been updated to create it always,
since it is actually used implicitly in many places behind the scene.
Test for Tile D3PD CA-based configuration has been added.https://gitlab.cern.ch/atlas/athena/-/merge_requests/67086TileROD_Decoder fixes for the issue related to time not being stored in Tile ...2023-11-14T17:44:52+01:00Denis Oliveira DamazioTileROD_Decoder fixes for the issue related to time not being stored in Tile CellsFor the appreciation of @solodkov. Fix TileROD_Decoder to enable TPCnv for HLTCalo unpacked cells. Discussed in ATR-27663. (I created another one to avoid mixing with LAr changes).
Yet another MR with Sacha suggestionsFor the appreciation of @solodkov. Fix TileROD_Decoder to enable TPCnv for HLTCalo unpacked cells. Discussed in ATR-27663. (I created another one to avoid mixing with LAr changes).
Yet another MR with Sacha suggestionshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/66971Draft: Fix TileROD_Decoder to enable TPCnv for HLTCalo unpacked cells2023-11-13T22:55:04+01:00Denis Oliveira DamazioDraft: Fix TileROD_Decoder to enable TPCnv for HLTCalo unpacked cellsFor the appreciation of @solodkov.
Fix TileROD_Decoder to enable TPCnv for HLTCalo unpacked cells.
Discussed in ATR-27663.
(I created another one to avoid mixing with LAr changes)For the appreciation of @solodkov.
Fix TileROD_Decoder to enable TPCnv for HLTCalo unpacked cells.
Discussed in ATR-27663.
(I created another one to avoid mixing with LAr changes)https://gitlab.cern.ch/atlas/athena/-/merge_requests/66970Draft: Fix TileROD_Decoder to enable TPCnv for HLTCalo unpacked cells2023-11-08T16:11:46+01:00Denis Oliveira DamazioDraft: Fix TileROD_Decoder to enable TPCnv for HLTCalo unpacked cellsFor the appreciation of @solodkov.
Fix TileROD_Decoder to enable TPCnv for HLTCalo unpacked cells.
Discussed in ATR-27663.For the appreciation of @solodkov.
Fix TileROD_Decoder to enable TPCnv for HLTCalo unpacked cells.
Discussed in ATR-27663.https://gitlab.cern.ch/atlas/athena/-/merge_requests/659442023-09-20: merge of 23.0 into main2023-09-24T22:05:09+02:00Vakhtang Tsulaia2023-09-20: merge of 23.0 into mainConflicts:
* `DataQuality/dqm_algorithms/src/TRTWeightedAverage.cxx`
Kept the ~main version
* `Reconstruction/Jet/JetMonitoring/python/JetMonitoringStandard.py`
Kept the ~"23.0" version. CC @cdelitzs (!65911)
* `Trigger/TriggerCommon/Tri...Conflicts:
* `DataQuality/dqm_algorithms/src/TRTWeightedAverage.cxx`
Kept the ~main version
* `Reconstruction/Jet/JetMonitoring/python/JetMonitoringStandard.py`
Kept the ~"23.0" version. CC @cdelitzs (!65911)
* `Trigger/TriggerCommon/TriggerJobOpts/python/TriggerConfigFlags.py`
Manual merge. Combined lambda with the help message for the `Trigger.Jet.pflowCalibKey` flag. CC @cantel (!65831)
This sweep contains the following MRs:
* !65938 TRT config updates are merged from 'main' into '23.0' (resubmission of 65926) ~DQ
* !65931 ZDC: implement EventInfo flags in case of LUCROD decoding failure, and update to ZdcRecConfig ~ForwardDetectors
* !63562 Adding cross compatability between onnx and lwtnn as a library for NNs ~Simulation
* !65752 Updates to RPD/Centroid Analysis and ZdcNtuple for Heavy Ions ~ForwardDetectors
* !65925 merging new Algo for TRT (and few changes on config) from 'main' into '23.0' ~DQ
* !65911 Configure correct jet collections for monitoring in HI and UPC mode ~Core, ~DQ, ~JetEtmiss, ~Reconstruction, ~Tile
* !65831 Trigger Jet: Add HI UPC pflow calibration configs (ATR-22067) ~JetEtmiss, ~Reconstruction, ~Trigger, ~TriggerMenu, ~changes-trigger-counts
* !65881 Heavy Ion : Disable out-of-time pileup topo cluster cut ~Reconstructionhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/62222Draft: Replace outdated code with STL2023-07-22T20:31:09+02:00Andrii VerbytskyiDraft: Replace outdated code with STLReplace outdated code with STL. Not to be merged!Replace outdated code with STL. Not to be merged!https://gitlab.cern.ch/atlas/athena/-/merge_requests/6420123.0-coverity-TileMonitoring2023-07-10T13:09:46+02:00Shaun Roe23.0-coverity-TileMonitoringtrap possible out-of-bounds accesstrap possible out-of-bounds accesshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/64065Set FRONTIER as default database server instead of ORACLE in all TileCal pyth...2023-06-30T23:44:35+02:00Sanya SolodkovSet FRONTIER as default database server instead of ORACLE in all TileCal python scriptsUpdating all python scripts which works with COOL DB - set FRONTIER as default database serverUpdating all python scripts which works with COOL DB - set FRONTIER as default database serverhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/61754Draft: Remove boost from TileConditions 12023-04-11T10:47:18+02:00Andrii VerbytskyiDraft: Remove boost from TileConditions 1Remove boost from TileConditions
Tag @sroeRemove boost from TileConditions
Tag @sroehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/61765Draft: Remove boost from TileConditions 22023-04-09T01:04:51+02:00Andrii VerbytskyiDraft: Remove boost from TileConditions 2Remove boost from TileConditions
Tag @sroeRemove boost from TileConditions
Tag @sroehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/61426TileTBAANtuple::Updated to use Felix and legacy containers2023-03-10T12:15:54+01:00Arya AikotTileTBAANtuple::Updated to use Felix and legacy containersTileTBAANtuple is modified to use digits and RawChannels stored in Felix and Legacy containers.
TileTBAANtuple is modified to use RawChannels reconstructed from Fit method and Optimal Filtering for FELIX.TileTBAANtuple is modified to use digits and RawChannels stored in Felix and Legacy containers.
TileTBAANtuple is modified to use RawChannels reconstructed from Fit method and Optimal Filtering for FELIX.Luca FioriniLuca Fiorinihttps://gitlab.cern.ch/atlas/athena/-/merge_requests/60202TileTBDump:Upadate unpacking of Tile digits received via FELIX2023-02-08T19:50:54+01:00Arya AikotTileTBDump:Upadate unpacking of Tile digits received via FELIXTileTBDump has been updated to detect and unpack FELIX fragments.TileTBDump has been updated to detect and unpack FELIX fragments.Luca FioriniArya AikotLuca Fiorinihttps://gitlab.cern.ch/atlas/athena/-/merge_requests/59967Load more high-pt minbias is NumberOfHighPtMinBias is set too low2023-01-21T01:18:44+01:00Beojan Stanislausbeojan.stanislaus@cern.chLoad more high-pt minbias is NumberOfHighPtMinBias is set too lowShould solve issue raised in !59957Should solve issue raised in !59957https://gitlab.cern.ch/atlas/athena/-/merge_requests/58853Daily "22.0 to master" sweep: 29/11/222022-12-01T00:54:36+01:00Vakhtang TsulaiaDaily "22.0 to master" sweep: 29/11/22One merge conflict originated from !58752. As [discussed](https://gitlab.cern.ch/atlas/athena/-/merge_requests/58752#note_6236591) with @pavol on this MR, the commit was excluded from the sweep. A manual sweep will be made later on.One merge conflict originated from !58752. As [discussed](https://gitlab.cern.ch/atlas/athena/-/merge_requests/58752#note_6236591) with @pavol on this MR, the commit was excluded from the sweep. A manual sweep will be made later on.https://gitlab.cern.ch/atlas/athena/-/merge_requests/56996Sweeping !56863 from master to 22.0.
Convert TileHid2RESrcID into conditions ...2022-09-28T19:18:27+02:00Atlas NightlybuildSweeping !56863 from master to 22.0.
Convert TileHid2RESrcID into conditions object for HLT (ATLASRECTS-7291, ATR-21656)Convert TileHid2RESrcID into conditions object for HLT (ATLASRECTS-7291, ATR-21656)
See merge request atlas/athena!56863Convert TileHid2RESrcID into conditions object for HLT (ATLASRECTS-7291, ATR-21656)
See merge request atlas/athena!56863https://gitlab.cern.ch/atlas/athena/-/merge_requests/56287TrackingVolumeManipulator rm const_cast rm and UNSAFE annotations2022-08-29T14:49:38+02:00Christos Anastopouloschristos.anastopoulos@cern.chTrackingVolumeManipulator rm const_cast rm and UNSAFE annotationsThis is the 1st followup of [https://gitlab.cern.ch/atlas/athena/-/merge_requests/56242]
Since in that one we finally avoid creating everything ``const``.
Now we are able to actually "manipulate" things without ``const_cast`` for a chan...This is the 1st followup of [https://gitlab.cern.ch/atlas/athena/-/merge_requests/56242]
Since in that one we finally avoid creating everything ``const``.
Now we are able to actually "manipulate" things without ``const_cast`` for a change ...
One has to look only on the following commit and any commits after that one until the previous MR is merged
(https://gitlab.cern.ch/ATLAS-EGamma/athena/-/commit/cb90a633d968213901ee12e75213da5bdfca920e)
The true purpose / magic is the TrackingVolumeManipulator
[https://gitlab.cern.ch/ATLAS-EGamma/athena/-/blob/cb90a633d968213901ee12e75213da5bdfca920e/Tracking/TrkDetDescr/TrkGeometry/src/TrackingVolumeManipulator.cxx]
that now becomes ``THREAD_SAFE``
ping @fwinkl
There are one "syntactical" question I had on combining ``span`` and ``shared_ptr`` etc ...
[https://gitlab.cern.ch/ATLAS-EGamma/athena/-/commit/cb90a633d968213901ee12e75213da5bdfca920e#b51f2e516d5d4115cfd59335f80f04135e81d609_66_68]
ping @ssnyder
with whom I discussed them.
A mock perhaps easier to parse .
[https://godbolt.org/z/MdzEjaYMG] (scroll around line 500)Christos Anastopouloschristos.anastopoulos@cern.chChristos Anastopouloschristos.anastopoulos@cern.chhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/56293TrackingVolumeHelper, TrackingVolumeCreator now can pass thread safety2022-08-29T14:49:30+02:00Christos Anastopouloschristos.anastopoulos@cern.chTrackingVolumeHelper, TrackingVolumeCreator now can pass thread safetyThis one is the 2nd follow-up after cleaning up TrkDetDescr for const correctnes.
The previous installments are :
- https://gitlab.cern.ch/atlas/athena/-/merge_requests/56242 -> removal of un-nneeded const
- https://gitlab.cern.ch/atla...This one is the 2nd follow-up after cleaning up TrkDetDescr for const correctnes.
The previous installments are :
- https://gitlab.cern.ch/atlas/athena/-/merge_requests/56242 -> removal of un-nneeded const
- https://gitlab.cern.ch/atlas/athena/-/merge_requests/56287 -> since volumes are not created as const from the start. Now we can manipulate them. TrackingManipulator becomes safe.
Here TrackingVolumeHelper and TrackingVolumeCreator are becoming ``THREAD_SAFE``
For now looks huge as it contains the other 2 . So look only at the last commit
(https://gitlab.cern.ch/ATLAS-EGamma/athena/-/commit/16b510383fb4b24cc7b6e551fcf1099a35276352)
Splitting things as we go as I understand people have issues going through the MRs if they are large.
But if we want to be able to have these safe we had to start from un-needed const ...
ping @ssnyder and @fwinkl to know that this also could be coming.Christos Anastopouloschristos.anastopoulos@cern.chChristos Anastopouloschristos.anastopoulos@cern.ch