athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2024-02-08T10:20:24+01:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/68630ATR-28761 Removal of remaining legacy combined items - J, XE2024-02-08T10:20:24+01:00Zhongyukun Xuzhongyukun.xu@cern.chATR-28761 Removal of remaining legacy combined items - J, XETo replace legacy combined items with Phase-1 and clean upTo replace legacy combined items with Phase-1 and clean uphttps://gitlab.cern.ch/atlas/athena/-/merge_requests/68440Debug stream recovery, Fix to trig reco2024-01-30T16:14:17+01:00Jennifer Rachel CurranDebug stream recovery, Fix to trig recoBug fix to previous MR: !67981, add condition before executing dbgPosRun on output BS file (after stream selection) in trigRecoExe.py to prevent failures when condition is not met.
@wiedenma @markBug fix to previous MR: !67981, add condition before executing dbgPosRun on output BS file (after stream selection) in trigRecoExe.py to prevent failures when condition is not met.
@wiedenma @markhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/68407LAr DT monitoring updates2024-01-30T14:16:53+01:00Ellis KayLAr DT monitoring updatesUpdate the LAr digital trigger monitoring code. Mainly fixing the python in order to reflect changes that were made before christmas (speeding up the .cxx)Update the LAr digital trigger monitoring code. Mainly fixing the python in order to reflect changes that were made before christmas (speeding up the .cxx)https://gitlab.cern.ch/atlas/athena/-/merge_requests/68265ATR-28678 - L1 Jet items legacy removal2024-02-06T22:42:30+01:00Marco RimoldiATR-28678 - L1 Jet items legacy removalThis MR is removing the some L1 Jet items legacy and replacing by the new Phase 1 trigger.
https://its.cern.ch/jira/browse/ATR-28678
- Follow-up from https://gitlab.cern.ch/atlas/athena/-/merge_requests/68248. Moving the multi-b-jet TL...This MR is removing the some L1 Jet items legacy and replacing by the new Phase 1 trigger.
https://its.cern.ch/jira/browse/ATR-28678
- Follow-up from https://gitlab.cern.ch/atlas/athena/-/merge_requests/68248. Moving the multi-b-jet TLA dev chain (https://its.cern.ch/jira/browse/ATR-23002) to Phase1 Items. cc @cantelMarco RimoldiMarco Rimoldihttps://gitlab.cern.ch/atlas/athena/-/merge_requests/68198add L1jJ160 seed since L1J100 is a legacy2024-01-18T13:34:39+01:00Tatiana Ovsiannikovaadd L1jJ160 seed since L1J100 is a legacyA small addition to Calratio triggers for next data tacking:
* Add L1jJ160 seed since L1J100 is a legacy.
* Keep L1J100 for comparison.A small addition to Calratio triggers for next data tacking:
* Add L1jJ160 seed since L1J100 is a legacy.
* Keep L1J100 for comparison.https://gitlab.cern.ch/atlas/athena/-/merge_requests/68188Moving DiPhoton TLA L1Topo Items from MC to Physics L1 Menu2024-02-02T19:44:06+01:00Marco MontellaMoving DiPhoton TLA L1Topo Items from MC to Physics L1 MenuMoving the following L1Topo algorithm to Physics L1 Menu ahead of firmware compilation:
L1_2DR15-0M30-2eEM12L, L1_13DR25-25M70-2eEM12L
Current destination is Board Topo2, FPGA 1, clock 0.
----
Tagging @rgugel for supervisionMoving the following L1Topo algorithm to Physics L1 Menu ahead of firmware compilation:
L1_2DR15-0M30-2eEM12L, L1_13DR25-25M70-2eEM12L
Current destination is Board Topo2, FPGA 1, clock 0.
----
Tagging @rgugel for supervisionhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/68177test new chains for VBF HZy with invisible decay trigger ATR-284432024-01-16T16:21:11+01:00Qiuping Shentest new chains for VBF HZy with invisible decay trigger ATR-28443The merge request aims to add test chains of VBF HZy with invisible decay for ATR-28443.
We investigated dedicated triggers for VBFH HZy. The weighted PS rate and efficiency are evaluated and shown in the table. We need to know the leve...The merge request aims to add test chains of VBF HZy with invisible decay for ATR-28443.
We investigated dedicated triggers for VBFH HZy. The weighted PS rate and efficiency are evaluated and shown in the table. We need to know the level of the unique rate and cost for these under-studied triggers.![VBFH_Trig_efficiency](/uploads/af7ccf16ed81ab6fe0d23baf979b64fa/VBFH_Trig_efficiency.jpg)Qiuping ShenQiuping Shenhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/68161ATR-28667 - Implementation of L1Topo ZeroBias Algorithm2024-02-05T10:10:02+01:00Marco MontellaATR-28667 - Implementation of L1Topo ZeroBias AlgorithmDraft MR tracking the development of the ZeroBias Topo algorithm.
As of Jan 15, the MR only contains a skeleton C++ ZeroBiasAlg class that does nothing beyond initialisation and definition of the relevant parameters. The class was defin...Draft MR tracking the development of the ZeroBias Topo algorithm.
As of Jan 15, the MR only contains a skeleton C++ ZeroBiasAlg class that does nothing beyond initialisation and definition of the relevant parameters. The class was defined inheriting from CountingAlg, based on the eEmMultiplicity example.
> An alternative pathway would have been to define the ZeroBiasAlg class in the python configuration inheriting from MultiplicityAlgo, following the examples in [TopoAlgos.py](https://acode-browser1.usatlas.bnl.gov/lxr/source/athena/Trigger/TriggerCommon/TriggerMenuMT/python/L1/Base/TopoAlgos.py#0226). If this alternative solution is in fact preferable I can easily switch.
Assuming the C++ path is correct, should the algorithm be instantiated and the parameters initialised in [TopoAlgoDefMultiplicity.py](https://acode-browser1.usatlas.bnl.gov/lxr/source/athena/Trigger/TriggerCommon/TriggerMenuMT/python/L1/Config/TopoAlgoDefMultiplicity.py)?
---
Tagging @astruebi @lidiaz @rgugel @jajimene (and @mark)https://gitlab.cern.ch/atlas/athena/-/merge_requests/67981Debug Stream, Addition of New Histograms and Fixes to the transform2024-01-30T13:28:50+01:00Jennifer Rachel CurranDebug Stream, Addition of New Histograms and Fixes to the transformNew python file added that creates an empty file with the BSFile structure and changes to trigRecoExe to accommodate the additional function and to rename the empty BSFile to RAW.pool.root if no events are selected for the chosen streams...New python file added that creates an empty file with the BSFile structure and changes to trigRecoExe to accommodate the additional function and to rename the empty BSFile to RAW.pool.root if no events are selected for the chosen streams. This prevents failures at T0 when events are actually just rejected by the HLT and/or stream selection when running the TriggerTransform for debug recovery.
Addition of two new trees in HIST_DEBUGSTREAMMON.ntup.root to display :
1. The output of running the postRun step debug stream analysis on BS file that contains events after the streamSelection
2. The differences between the Pre and Post debug stream analysis steps that required the addition of new function to add the Tree and histograms that show the difference in the Pre/Pos histograms in dbgAnalysis
An existing function in dbgAnalysis was modified to add in the HLT_accepted_events histogram to HIST_DEBUGSTREAMMON.ntup.root. Some additions to trigRecoExe to accommodate these changes were made.
@wiedenma @mark ATR-26595https://gitlab.cern.ch/atlas/athena/-/merge_requests/67876Add Calratio trigger algorithm to the 23.0 for the MC production request2023-12-15T16:13:17+01:00Tatiana OvsiannikovaAdd Calratio trigger algorithm to the 23.0 for the MC production requestthe new Run3 calratio triggers
See merge request atlas/athena!66963
I just cherry peaking it from the mainthe new Run3 calratio triggers
See merge request atlas/athena!66963
I just cherry peaking it from the mainhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/67862TrigConfData, TrigConfIO: update of the L1CTPFiles structure to add CTPX swit...2023-12-20T09:33:00+01:00Ondrej PencTrigConfData, TrigConfIO: update of the L1CTPFiles structure to add CTPX switch matrix.This extends the L1CTPFiles structure with the CTPX switch matrix and updates/adds associated functions.
Tested in the L1CT lab in initialL1CT and ATLAS partitions.
Important for data taking, should be tested at P1 on the week from 15 Ja...This extends the L1CTPFiles structure with the CTPX switch matrix and updates/adds associated functions.
Tested in the L1CT lab in initialL1CT and ATLAS partitions.
Important for data taking, should be tested at P1 on the week from 15 Jan 2024.https://gitlab.cern.ch/atlas/athena/-/merge_requests/67716TrigValTools: don't check file existence when running unit tests2023-12-11T10:16:28+01:00Bertrand Martin Dit LatourTrigValTools: don't check file existence when running unit testsHello,
As realised in !67637, trigger tests using `RootMergeStep` are failing when running unit tests.
Currently, in `dry_run` mode (unit tests), the script looks for files that don't exist and returns an error.
Cheers,
BertrandHello,
As realised in !67637, trigger tests using `RootMergeStep` are failing when running unit tests.
Currently, in `dry_run` mode (unit tests), the script looks for files that don't exist and returns an error.
Cheers,
Bertrandhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/67628Make Input.RunNumber, Input.LumiBlockNumber and Input.TimeStamp in plural as ...2024-01-08T15:56:19+01:00Tadej Novaktadej.novak@cern.chMake Input.RunNumber, Input.LumiBlockNumber and Input.TimeStamp in plural as they are used as listMake `Input.RunNumber`, `Input.LumiBlockNumber` and `Input.TimeStamp` in plural as they are used as list.
The validation of the type will be implemented in a separate MR.
This also fixes run number argument parsing in reco and MC chann...Make `Input.RunNumber`, `Input.LumiBlockNumber` and `Input.TimeStamp` in plural as they are used as list.
The validation of the type will be implemented in a separate MR.
This also fixes run number argument parsing in reco and MC channel number handling in some derivation code as it was used incorrectly.
/cc @jchapman @nstyles @jcatmore @fwinklhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/67595TriggerMenuMT: disable menu DOT files and increase unit test timeout2023-12-05T16:42:28+01:00Frank WinklmeierTriggerMenuMT: disable menu DOT files and increase unit test timeoutDisable the generation of DOT files in the CA tests that became too slow and produces
too large of an output.
Also temporarily increase CA unit test timeout.
Relates to ATR-28608.
cc @fpastoreDisable the generation of DOT files in the CA tests that became too slow and produces
too large of an output.
Also temporarily increase CA unit test timeout.
Relates to ATR-28608.
cc @fpastorehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/67142Adding Test L1 Items to MC Menu For Rate Estimate - DiPhoton TLA2023-11-16T11:25:17+01:00Marco MontellaAdding Test L1 Items to MC Menu For Rate Estimate - DiPhoton TLANew Items:
Symmetric Items:
```
L1_2DR15_0M30-2eEM12L
L1_13DR25-25M70-2eEM12L
```
Asymmetric Items:
```
L1_2DR15_0M30-eEM12LeEM9L
L1_13DR25-25M70-eEM12LeEM9L
```
And corresponding HLT items in the Dev Menu.
----
Tagging @khoo...New Items:
Symmetric Items:
```
L1_2DR15_0M30-2eEM12L
L1_13DR25-25M70-2eEM12L
```
Asymmetric Items:
```
L1_2DR15_0M30-eEM12LeEM9L
L1_13DR25-25M70-eEM12LeEM9L
```
And corresponding HLT items in the Dev Menu.
----
Tagging @khoo , @sshaw , @lidiaz , @astruebihttps://gitlab.cern.ch/atlas/athena/-/merge_requests/67128ATR-28412 test chains for DPJ VBF run32023-11-17T07:53:52+01:00Zhongyukun Xuzhongyukun.xu@cern.chATR-28412 test chains for DPJ VBF run3new triggers including lower VBF inclusive, VBF+msonly, VBF+nscan.
Under validationnew triggers including lower VBF inclusive, VBF+msonly, VBF+nscan.
Under validationZhongyukun Xuzhongyukun.xu@cern.chZhongyukun Xuzhongyukun.xu@cern.chhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/67072Update TrigEgammaEmulationTool2023-11-16T17:10:19+01:00Micael Verissimo De AraujoUpdate TrigEgammaEmulationToolThis merge request aims to integrate the trigger menu chain configuration with the `TrigEgammaEmulatorTool`.
As the Emulator is currently disabled, this MR series is crucial to make it operational. @eegidiop is aware of these developmen...This merge request aims to integrate the trigger menu chain configuration with the `TrigEgammaEmulatorTool`.
As the Emulator is currently disabled, this MR series is crucial to make it operational. @eegidiop is aware of these developments, and it's essential that this MR is approved and merged as soon as possible to proceed with obtaining a useful version of the Emulator on the egamma side.
ping, @eegidiop, @efurtado, @jodafons, @jliebermhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/66880Update to Gaudi v382024-01-30T12:16:59+01:00Frank WinklmeierUpdate to Gaudi v38Update athena projects to [Gaudi v38r0](https://gitlab.cern.ch/gaudi/Gaudi/-/releases/v38r0).
The main braking change is that in Gaudi v38, `std::unordered_set` properties are now represented as python `set` instead of `list`. This most...Update athena projects to [Gaudi v38r0](https://gitlab.cern.ch/gaudi/Gaudi/-/releases/v38r0).
The main braking change is that in Gaudi v38, `std::unordered_set` properties are now represented as python `set` instead of `list`. This mostly affects `CondInputLoader.Load` and the Algorithm's `ExtraInputs/Outputs` property. For details see https://gitlab.cern.ch/gaudi/Gaudi/-/merge_requests/1503 but in practice it means that code like
```py
MyAlg.ExtraInputs += ['foo']
```
has been updated to
```py
MyAlg.ExtraInputs.add('foo')
```
For the moment only `std::unordered_set` is mapped to a Python `set`. Regular `std::set` remains as Python `list` to maintain insertion order.
For backwards compatibility, we allow implicit conversion from `list`, i.e. the following still works:
```py
MyAlg.ExtraInputs = ['foo'] # implicitly converted to {'foo'}
```
In addition some minor `const` interface changes in `DataHandle` that propagate to our `VarHandleKey`.
cc @leggetthttps://gitlab.cern.ch/atlas/athena/-/merge_requests/66556Add L1_eEM15_EMPTY to heavy ion menu2023-10-19T10:51:12+02:00Varsha SenthilkumarAdd L1_eEM15_EMPTY to heavy ion menuhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/66551adding new UPC EB chains and ID calib chain for HI2023-10-19T10:51:12+02:00Agnieszka Ewa Ogrodnikadding new UPC EB chains and ID calib chain for HIThis MR adds three new EB chains for UPC following as well as new chain for ID calib, ATR-28393
Tagging @jkremer @lidiaz @astruebi @shanisch @tnobe @vsenthil @qhu @angeramiThis MR adds three new EB chains for UPC following as well as new chain for ID calib, ATR-28393
Tagging @jkremer @lidiaz @astruebi @shanisch @tnobe @vsenthil @qhu @angerami