athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2024-03-29T11:03:07+01:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/70140distinguish two steps with different name in muComb (ATR-29040)2024-03-29T11:03:07+01:00Francesca Pastoredistinguish two steps with different name in muComb (ATR-29040)https://gitlab.cern.ch/atlas/athena/-/merge_requests/70101Fix FPGASim workflow test to use input RDO from CVMFS2024-03-27T19:37:25+01:00Tomasz BoldFix FPGASim workflow test to use input RDO from CVMFSCloses EFTRACK-504
This MR improves FPGASim testing scriptCloses EFTRACK-504
This MR improves FPGASim testing scripthttps://gitlab.cern.ch/atlas/athena/-/merge_requests/70032fix for ATR-29037 - No such flag: minTRTonTrk2024-03-21T19:59:47+01:00Jiri Masikfix for ATR-29037 - No such flag: minTRTonTrkquick fix for ATR-29037 - No such flag: minTRTonTrkquick fix for ATR-29037 - No such flag: minTRTonTrkhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/69911TrigT2CaloEgamma: fix FPE2024-03-20T08:15:46+01:00Bertrand Martin Dit LatourTrigT2CaloEgamma: fix FPEHello,
This MR is fixing a FPE introduced in !67310 (ATR-28988).
Marking as urgent as the FPE is showing up in many trigger ART tests.
Cheers,
BertrandHello,
This MR is fixing a FPE introduced in !67310 (ATR-28988).
Marking as urgent as the FPE is showing up in many trigger ART tests.
Cheers,
Bertrandhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/69882TrigEFMissingET: add missing ROOT find package call2024-03-20T15:24:32+01:00Frank WinklmeierTrigEFMissingET: add missing ROOT find package callAdd missing `ROOT` find package call to fix [CPack installation warning](http://atlas-computing.web.cern.ch/atlas-computing/links/distDirectory/gitwww/PRODUCTIONWebArea/ardoc_web_area24064BE9G13AthenaOpt/ARDOC_Log_2024-03-17T2101/ardoc_c...Add missing `ROOT` find package call to fix [CPack installation warning](http://atlas-computing.web.cern.ch/atlas-computing/links/distDirectory/gitwww/PRODUCTIONWebArea/ardoc_web_area24064BE9G13AthenaOpt/ARDOC_Log_2024-03-17T2101/ardoc_cpack_combined.html#pb1083).https://gitlab.cern.ch/atlas/athena/-/merge_requests/69661added ZBTopo to L1excluded thresholds (ATR-28938)2024-03-08T23:01:52+01:00Francesca Pastoreadded ZBTopo to L1excluded thresholds (ATR-28938)fix for trigger operation, see e-log: https://atlasop.cern.ch/elisa/display/536933 and related JIRA
tagging @shanischfix for trigger operation, see e-log: https://atlasop.cern.ch/elisa/display/536933 and related JIRA
tagging @shanischhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/69563Fix for error "No TOBs found passing the threshold NSWMon" (ATR-28915)2024-03-06T19:09:12+01:00Francesca PastoreFix for error "No TOBs found passing the threshold NSWMon" (ATR-28915)added NSWMon as excluded L1 thresholds in HLTSeeding
@sfrancesadded NSWMon as excluded L1 thresholds in HLTSeeding
@sfranceshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/69513Use config flags in analysis config2024-03-28T13:34:35+01:00Tadej Novaktadej.novak@cern.chUse config flags in analysis configMake config flags the main way to steer analysis config. This will help people working on analysis and Athena to feel at home and prevent accumulation of arguments of the `ConfigAccumulator`.
The naming is not fixed, I will probably als...Make config flags the main way to steer analysis config. This will help people working on analysis and Athena to feel at home and prevent accumulation of arguments of the `ConfigAccumulator`.
The naming is not fixed, I will probably also convert more items to flags. This is mainly to start the discussion and freeze the API as soon asp possible. I will probably then break this into multiple MRs.
Also some core flags should be renamed (see https://its.cern.ch/jira/browse/ATEAM-964).
Tagging @krumnack, @jolamber, @gwatts, @ekourlit for core AMG. Also tagging interested parties @ravinab, @omajersk, @tstreble, @khoo, @jchapman.https://gitlab.cern.ch/atlas/athena/-/merge_requests/69399ATR-28836 - ATR-28871 - Assorted Menu actions for Delayed Jet signature2024-03-04T13:13:36+01:00Marco MontellaATR-28836 - ATR-28871 - Assorted Menu actions for Delayed Jet signatureAdded Mongroup to delayed jet triggers and added reference chains for delayed jet signature in Dev Menu
*Edited to indicate the trigger signature more precisely -- unfortunately too late for the commit.*Added Mongroup to delayed jet triggers and added reference chains for delayed jet signature in Dev Menu
*Edited to indicate the trigger signature more precisely -- unfortunately too late for the commit.*https://gitlab.cern.ch/atlas/athena/-/merge_requests/69397ATR-28888 -- Reimplement End-of-Event processing in HLT2024-03-01T20:36:12+01:00Teng Jian KhooATR-28888 -- Reimplement End-of-Event processing in HLTWe operate LAr noise burst detection and MET trigger reconstruction for monitoring in events accepted by the HLT. This sequence was lost in the CA menu generation refactoring, so reintroducing it here.
It fits more naturally in `Generat...We operate LAr noise burst detection and MET trigger reconstruction for monitoring in events accepted by the HLT. This sequence was lost in the CA menu generation refactoring, so reintroducing it here.
It fits more naturally in `GenerateMenuMT.py` than where it was previously in `HLTCFConfig.py`. Arguably even more apt [here](https://acode-browser1.usatlas.bnl.gov/lxr/source/athena/Trigger/TriggerCommon/TriggerJobOpts/python/TriggerConfig.py#0669) in `TriggerConfig.py` c.f. an old TODO note, but that option would require us to separately extract the `chainDicts`.
Sequence doesn't seem to be added correctly to `HLTFinalizeSeq` currently, needs more debugging.https://gitlab.cern.ch/atlas/athena/-/merge_requests/69390Adding the old calratio triggers to the Physics Menu2024-03-06T00:27:10+01:00Tatiana OvsiannikovaAdding the old calratio triggers to the Physics Menureverse naming of the calratio algorithm (calrtold->calratio, calratio->calratiovar) and move old calratio chains with additional emf cut for CPU reduction to the Physics Menu
- High ET chain
- 'HLT_j30_CLEANllp_momemfrac006_calratio_L1j...reverse naming of the calratio algorithm (calrtold->calratio, calratio->calratiovar) and move old calratio chains with additional emf cut for CPU reduction to the Physics Menu
- High ET chain
- 'HLT_j30_CLEANllp_momemfrac006_calratio_L1jJ160'
- 'HLT_j30_CLEANllp_momemfrac006_calratiormbib_L1jJ160'
- Calratio backup for jJ160
- 'HLT_j30_CLEANllp_momemfrac006_calratio_L1eTAU140'
- 'HLT_j30_CLEANllp_momemfrac006_calratiormbib_L1eTAU140'
- 'HLT_j30_CLEANllp_momemfrac006_calratio_L1eTAU80'
- 'HLT_j30_CLEANllp_momemfrac006_calratiormbib_L1eTAU80'
- Calratio LLP-NoMATCH analogs
- 'HLT_j30_CLEANllp_momemfrac006_calratio_L1eTAU40HT'
- 'HLT_j30_CLEANllp_momemfrac006_calratiormbib_L1eTAU40HT'
- 'HLT_j30_CLEANllp_momemfrac006_calratio_L1eTAU60HM'
- 'HLT_j30_CLEANllp_momemfrac006_calratiormbib_L1eTAU60HM'
- Calratio support chains
- 'HLT_j30_CLEANllp_momemfrac006_calratio_L1TAU40_EMPTY'
- 'HLT_j30_CLEANllp_momemfrac006_calratiormbib_L1TAU40_EMPTY'
- 'HLT_j30_CLEANllp_momemfrac006_calratio_L1TAU40_UNPAIRED_ISO'
- 'HLT_j30_CLEANllp_momemfrac006_calratiormbib_L1TAU40_UNPAIRED_ISO'
- new version of triggers with pileup recalculation, should be prescaled
- 'HLT_j30_CLEANllp_momemfrac012_calratiovar_roiftf_preselj20emf12_L1jJ160'https://gitlab.cern.ch/atlas/athena/-/merge_requests/68932TriggerMenuMT: add menu consistency checks for CA menus2024-02-15T18:42:30+01:00Frank WinklmeierTriggerMenuMT: add menu consistency checks for CA menus@mark noticed that we are missing the consistency checks in the CA menu generation. That's why the failures
seen in ATR-28793 were only visible in the few remaining legacy tests.
Requires https://gitlab.cern.ch/atlas/athena/-/merge_req...@mark noticed that we are missing the consistency checks in the CA menu generation. That's why the failures
seen in ATR-28793 were only visible in the few remaining legacy tests.
Requires https://gitlab.cern.ch/atlas/athena/-/merge_requests/68860 to be merged first.https://gitlab.cern.ch/atlas/athena/-/merge_requests/68927Fix CA flag modifications2024-02-15T17:01:47+01:00Mark SuttonFix CA flag modificationsWas still using old ConfigFlags for the LRT CA job configuration
Addresses ATR-28802Was still using old ConfigFlags for the LRT CA job configuration
Addresses ATR-28802https://gitlab.cern.ch/atlas/athena/-/merge_requests/68860Physics Menu cleanup of legacy tau+x chains and fixed a typo in group name2024-02-15T16:57:08+01:00Gianantonio Pezzullog.pezzullo@yale.eduPhysics Menu cleanup of legacy tau+x chains and fixed a typo in group namePhysics Menu cleanup of legacy tau+x chains, moving them to the MC Menu: ATR-28791
Fixed typo in chains' group field: ATR-28784Physics Menu cleanup of legacy tau+x chains, moving them to the MC Menu: ATR-28791
Fixed typo in chains' group field: ATR-28784https://gitlab.cern.ch/atlas/athena/-/merge_requests/68839Debug recovery, updates for trigRecoExe, dbgAnalysis and dbgEventInfo2024-02-14T18:15:18+01:00Jennifer Rachel CurranDebug recovery, updates for trigRecoExe, dbgAnalysis and dbgEventInfoUpdate to check if the number of status words is not zero in dbgEventInfo.py to ensure crashes don't occur when recovered events have no status word.
Removal of the functions getPrePosdif_branch and getPrePosdiff from dbgAnalysis.py (a...Update to check if the number of status words is not zero in dbgEventInfo.py to ensure crashes don't occur when recovered events have no status word.
Removal of the functions getPrePosdif_branch and getPrePosdiff from dbgAnalysis.py (and where they are called in trigRecoExe.py) as this step is being added to the script that reads the values in the root files for the debug recovery web application so is not needed here.
ATR-26595
@mark @wiedenmahttps://gitlab.cern.ch/atlas/athena/-/merge_requests/68827TrigAnalysisTest: move CI test to CA2024-02-15T20:33:44+01:00Bertrand Martin Dit LatourTrigAnalysisTest: move CI test to CAHello,
This MR is migrating to CA the MC trigger test used in the CI.
The addition of `--preInclude "all:Campaigns.MC23c"` will be done later, as it is expected to change the trigger counts.
Marking as urgent as it blocks the removal of...Hello,
This MR is migrating to CA the MC trigger test used in the CI.
The addition of `--preInclude "all:Campaigns.MC23c"` will be done later, as it is expected to change the trigger counts.
Marking as urgent as it blocks the removal of RecExCommon in !68693.
A follow up MR will migrate the other tests in this package.
Tagging @fwinkl .
Cheers,
Bertrandhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/68819Adjustment for the calratio triggers to adress high rate2024-02-16T18:54:00+01:00Tatiana OvsiannikovaAdjustment for the calratio triggers to adress high rate- bring back old calratio triggers for comparison with new triggers
- make some adjustment to the new triggers to fix high rates
- add triggers with bib removal as well
-- HLT_j20_CLEANllp_momemfrac006_calratiormbib_roiftf_preselj20emf6...- bring back old calratio triggers for comparison with new triggers
- make some adjustment to the new triggers to fix high rates
- add triggers with bib removal as well
-- HLT_j20_CLEANllp_momemfrac006_calratiormbib_roiftf_preselj20emf6_L1jJ160
-- HLT_j20_CLEANllp_momemfrac006_calratiormbib_roiftf_preselj20emf6_L1eTAU60_EMPTY
-- HLT_j20_CLEANllp_momemfrac006_calratiormbib_roiftf_preselj20emf6_L1eTAU60_UNPAIRED_ISO
-- HLT_j20_CLEANllp_momemfrac006_calratiormbib_roiftf_preselj20emf6_L1eTAU40HT
-- HLT_j20_CLEANllp_momemfrac006_calratiormbib_roiftf_preselj20emf6_L1eTAU60HM
-- HLT_j20_CLEANllp_momemfrac006_calratiormbib_roiftf_preselj20emf6_L1eTAU140
- add few more chains for emf preselection comparison:
- HLT_j20_CLEANllp_momemfrac024_calratio_roiftf_preselj20emf24_L1TAU60
- HLT_j20_CLEANllp_momemfrac012_calratio_roiftf_preselj20emf12_L1T
- HLT_j30_CLEANllp_momemfrac006_calrtold_L1TAU60https://gitlab.cern.ch/atlas/athena/-/merge_requests/68719Fix for failing nightly tests2024-02-09T10:18:21+01:00Lidija ZivkovicFix for failing nightly testsThis is fixing failure in [nightly](https://test-atrvshft.web.cern.ch/test-atrvshft/ART_monitor/Monitor/Build/2024-02-07T2101/main_Athena_x86_64-el9-gcc13-opt/TriggerTest/trig_data_v1PhysP1lowMu_build)This is fixing failure in [nightly](https://test-atrvshft.web.cern.ch/test-atrvshft/ART_monitor/Monitor/Build/2024-02-07T2101/main_Athena_x86_64-el9-gcc13-opt/TriggerTest/trig_data_v1PhysP1lowMu_build)https://gitlab.cern.ch/atlas/athena/-/merge_requests/68702ATR-28264 - migrating HI Jets to CA2024-02-09T13:25:35+01:00Martin RybarATR-28264 - migrating HI Jets to CA* Migration of the HI jet trigger to CA (ATR-28264)
* Removing non-CA configuration
* Fix for ATR-28041
* Tagging @asmaga and @kciesla as HI trigger coordinators and @stapiaar as software coordinator
* CA version tested against non-CA wi...* Migration of the HI jet trigger to CA (ATR-28264)
* Removing non-CA configuration
* Fix for ATR-28041
* Tagging @asmaga and @kciesla as HI trigger coordinators and @stapiaar as software coordinator
* CA version tested against non-CA with the same trigger counts seen
* CA version tested with the full HI menu (test_trig_mc_v1DevHI_newJO_build.py)https://gitlab.cern.ch/atlas/athena/-/merge_requests/68630ATR-28761 Removal of remaining legacy combined items - J, XE2024-02-08T10:20:24+01:00Zhongyukun Xuzhongyukun.xu@cern.chATR-28761 Removal of remaining legacy combined items - J, XETo replace legacy combined items with Phase-1 and clean upTo replace legacy combined items with Phase-1 and clean up