athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2024-03-27T07:32:08+01:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/70028Add TauTrig collection in 24.0 for Trigger validation during 2024 ramp-up period2024-03-27T07:32:08+01:00Antonio De MariaAdd TauTrig collection in 24.0 for Trigger validation during 2024 ramp-up periodThis MR is meant to add HLT tau containers + L1 Phase 1 containers in PHYS for branch 24.0
These additional containers will be needed for the validation of the Phase-1 tau triggers during 2024 ramp-up period
Tagging @smwang, @slai, @gi...This MR is meant to add HLT tau containers + L1 Phase 1 containers in PHYS for branch 24.0
These additional containers will be needed for the validation of the Phase-1 tau triggers during 2024 ramp-up period
Tagging @smwang, @slai, @gipezzul, @martindl, @jbeaucam, @mashamim, @sshaw and @khoohttps://gitlab.cern.ch/atlas/athena/-/merge_requests/69990Add unit test for FPGATrackSim and fix workflow for analysis on wrapper file2024-03-22T14:46:18+01:00Ioannis MaznasAdd unit test for FPGATrackSim and fix workflow for analysis on wrapper file1. This should fix the errors on `FPGATrackSimAnalysisConfig.py` (related to unit test failure) when running with wrapper input.
2. Also added a test for analysis with rdo input.
tagging @jahreda @tbold1. This should fix the errors on `FPGATrackSimAnalysisConfig.py` (related to unit test failure) when running with wrapper input.
2. Also added a test for analysis with rdo input.
tagging @jahreda @tboldhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/70047More test chains for delayed jets2024-03-22T13:20:55+01:00Lucas BezioMore test chains for delayed jetsAs discussed on [ATR-28836](https://its.cern.ch/jira/browse/ATR-28836), more test chains are added. Some are requiring 2jets to be delayed aiming to reduce the rate even with low pt threshold. Copies of the test chains with upper limit o...As discussed on [ATR-28836](https://its.cern.ch/jira/browse/ATR-28836), more test chains are added. Some are requiring 2jets to be delayed aiming to reduce the rate even with low pt threshold. Copies of the test chains with upper limit on timing are also added.https://gitlab.cern.ch/atlas/athena/-/merge_requests/69972TrigEFMissingET CMake Fixes, main branch (2024.03.20.)2024-03-20T15:24:56+01:00Attila KrasznahorkayTrigEFMissingET CMake Fixes, main branch (2024.03.20.)This is to undo a mistake introduced in !69806, and to fix another issue that was present in the code for even longer.
- Since the shared library still needs ROOT, it has to be found explicitly by the code.
- To make sure that the co...This is to undo a mistake introduced in !69806, and to fix another issue that was present in the code for even longer.
- Since the shared library still needs ROOT, it has to be found explicitly by the code.
- To make sure that the component library would see the [LWTNN](https://github.com/lwtnn/lwtnn) headers reliably, `${LWTNN_INCLUDE_DIRS}` also needs to be used.
The reason I noticed these mistakes is because of the "serious warnings" in the latest nightlies.
https://bigpanda.cern.ch/nview/?nightly=main_Athena_x86_64-el9-gcc13-opt
![image](/uploads/e0908bc1f653f0f135c80032b903351c/image.png)
Something that the shifters should've really picked up on... :frowning:https://gitlab.cern.ch/atlas/athena/-/merge_requests/69205Protect possible rare FPEs2024-03-19T18:09:08+01:00Vadim KostyukhinProtect possible rare FPEsAdd some protection in an attempt to avoid rare FPEs observed in trigger ATLASRECTS-7659Add some protection in an attempt to avoid rare FPEs observed in trigger ATLASRECTS-7659https://gitlab.cern.ch/atlas/athena/-/merge_requests/69340Draft: TriggerMenuMT: centralize AccumulatorCache for steps and disable deepcopy2024-03-13T12:03:59+01:00Frank WinklmeierDraft: TriggerMenuMT: centralize AccumulatorCache for steps and disable deepcopyThis is a (for the moment) experimental change to the menu generation that should be discussed amongst experts and in a trigger core SW meeting.
Move the `AccumulatorCache` to the `getStep` method and remove it from the signature-specif...This is a (for the moment) experimental change to the menu generation that should be discussed amongst experts and in a trigger core SW meeting.
Move the `AccumulatorCache` to the `getStep` method and remove it from the signature-specific files. The actual change to review is in `ChainConfigurationBase.py` .
In addition, do not `deepcopy` the result of the sequence configuration (`ChainStep`) as it is not being re-used or modified afterwards. This was also the behavior of the original `RecoFragmentsPool` before it was migrated to `AccumulatorCache`. The deepcopy can be enabled again by setting `Trigger.fastMenuGeneration=False`.
**Reduces the menu generation time of Dev_pp_run3_v1 by a factor 2**. It does however introduce (harmless) changes in the order of some of the `HypoTools` and `InputMakerInputDecisions` properties. In case we decide to move forward with this we would definitely want to add an ART test that checks the configuration is equivalent with/without `fastMenuGeneration` (see this recent [confTool improvement](https://gitlab.cern.ch/atlas/athena/-/merge_requests/69329 "confTool: add ignoreOrder command line option")).
E.g. in the HI menu, the following properties change order (many more in the pp menu):
```plaintext
IM_EFMuMSReco_RoI.InputMakerInputDecisions
IM_L2MuCombReco.InputMakerInputDecisions
SPCountHypoAlg.HypoTools
TrigHIFwdGapHypoAlg.HypoTools
TrigL2MuCBHypoAlg.HypoTools
TrigL2MufastHypoAlg.HypoTools
TrigMuonEFCombinerHypoAlg.HypoTools
TrigMuonEFMSonlyHypo_RoI.HypoTools
```
cc @tbold @fpastore @tamartin
Relates to [ATR-26996](https://its.cern.ch/jira/browse/ATR-26996).https://gitlab.cern.ch/atlas/athena/-/merge_requests/69667Move FPGATrackSim inputs away from EOS2024-03-12T12:04:46+01:00Jahred Adelmanjahreda@gmail.comMove FPGATrackSim inputs away from EOSWe have two files using EOS; we aren't ready to move them to CVMFS, but this is a solution we've used elsewhere. Fix for https://its.cern.ch/jira/browse/EFTRACK-494. Tagging @tbold.We have two files using EOS; we aren't ready to move them to CVMFS, but this is a solution we've used elsewhere. Fix for https://its.cern.ch/jira/browse/EFTRACK-494. Tagging @tbold.https://gitlab.cern.ch/atlas/athena/-/merge_requests/69095Draft: Move FTagEventSF to standalone analysis config2024-03-08T02:18:58+01:00Thomas StreblerDraft: Move FTagEventSF to standalone analysis configBuilt on top of !69002
Use similar config to JVT analysis config, to be able to define overlap removal dependency in the same wayBuilt on top of !69002
Use similar config to JVT analysis config, to be able to define overlap removal dependency in the same wayhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/59680Draft: Implement asynchronous I/O in HltEventLoopMgr2024-03-04T15:51:43+01:00Rafal Bielskirafal.bielski@cern.chDraft: Implement asynchronous I/O in HltEventLoopMgrChange the implementation of the main event loop in HLT from synchronous jumping between input handling and output handling on one thread to independent asynchronous I/O threads.
The threading / synchronisation boilerplate code is put i...Change the implementation of the main event loop in HLT from synchronous jumping between input handling and output handling on one thread to independent asynchronous I/O threads.
The threading / synchronisation boilerplate code is put into a separate header file and is now shared by three threads in the HltEventLoopMgr: the timeout monitoring thread (almost no change to its implementation) and the new input and output handling threads. The main thread of the application only starts the three loop threads and sleeps until the end of the event loop.
Like before this MR, the input and output parts of the HltEventLoopMgr (previously on the main thread, now in separate threads) still don't do much work. They only define, prepare and schedule a TBB Task which is then executed by TBB worker threads. This keeps the CPU cost of the HltEventLoopMgr threads at near zero, and all the work is done by the pool of TBB worker threads, which is more natural and predictable in performance profiling. The only functional change in this MR is that the TBB tasks for I/O handling are now launched asynchronously and don't block each other. Previously, we could not fill a free Gaudi Scheduler slot while waiting for a finished event, and similarly could not pop a finished event from the Gaudi Scheduler while waiting for a new event from input source.
The new implementation required a somewhat significant change in error handling. Since the input and output handling are now asynchronous, the concept of "draining all Scheduler slots" mid-run and then continuing to fill them again isn't so trivially possible. Implementing such behaviour would require the output thread to "pause" the input thread and then after clearing all slots, "resume" it. With the experience of 2022 P1 operations I can say the drain-all-slots procedure wasn't really needed in the first place. If things go wrong on the framework side, it is fine to exit the event loop with a failure and restart the entire process from scratch. This will now happen in a wider range of errors (most of which have never been encountered in practice) which previously attempted the "drain all slots and continue" approach.
Jira: ATR-26285
FYI @fwinkl, @wiedenma, @mark
Simplified call diagrams (skipping the start/end of loop conditions):
**before this MR:**
<img src="/uploads/dda223b50afc2a91520e5f53de7f3ecf/HltEventLoopMgr-sync-io.png" height="150" />
**after this MR:**
<img src="/uploads/7222b092b2cd738028bb798dfa6c0320/HltEventLoopMgr-async-io.png" height="150" />https://gitlab.cern.ch/atlas/athena/-/merge_requests/69105eFexTowerBuilder: handle invalid codes and add debugging functionality2024-02-29T13:44:53+01:00Will ButtingereFexTowerBuilder: handle invalid codes and add debugging functionalityInvalid codes from supercell readout (flagged by provenance&0x40) need to be flagged with code 1022 in the output to be properly emulated.
This MR also adds some debugging functionality to this algorithm.Invalid codes from supercell readout (flagged by provenance&0x40) need to be flagged with code 1022 in the output to be properly emulated.
This MR also adds some debugging functionality to this algorithm.https://gitlab.cern.ch/atlas/athena/-/merge_requests/69208b+tau triggers for HH->bbtt, ATR-281982024-02-27T16:40:02+01:00Muhammad Alhroobb+tau triggers for HH->bbtt, ATR-28198Edited Physics_pp_run3-v1 and Dev_pp_run3-v1 Menus for the benefit of JIRA ATR-28198
HLT_tau25_mediumRNN_tracktwoMVA_probe_j65c_020jvt_j40c_020jvt_j25c_020jvt_j20c_020jvt_SHARED_j20c_020jvt_bgn185_pf_ftf_presel3c20XX1c20bg85_L1jJ85p0ETA...Edited Physics_pp_run3-v1 and Dev_pp_run3-v1 Menus for the benefit of JIRA ATR-28198
HLT_tau25_mediumRNN_tracktwoMVA_probe_j65c_020jvt_j40c_020jvt_j25c_020jvt_j20c_020jvt_SHARED_j20c_020jvt_bgn185_pf_ftf_presel3c20XX1c20bg85_L1jJ85p0ETA21_3jJ40p0ETA25
HLT_tau25_mediumRNN_tracktwoMVA_probe_j65c_020jvt_j40c_020jvt_j25c_020jvt_j20c_020jvt_SHARED_j20c_020jvt_bgn185_pf_ftf_presel3c20XX1c20bg85_L1jJ85p0ETA21_3jJ40p0ETA25https://gitlab.cern.ch/atlas/athena/-/merge_requests/68889Draft:Cleanup after legacy removal2024-02-27T13:23:05+01:00Damiano VannicolaDraft:Cleanup after legacy removalCloses ATR-28783Closes ATR-28783https://gitlab.cern.ch/atlas/athena/-/merge_requests/69228Updating LAr EM NTuple creation to CA based configuration2024-02-26T13:13:58+01:00Mustafa Andre SchmidtUpdating LAr EM NTuple creation to CA based configurationThe configuration script for the LAr EM NTuple creation as well as the README file was changed to be compatible with the new CA-based configuration.The configuration script for the LAr EM NTuple creation as well as the README file was changed to be compatible with the new CA-based configuration.https://gitlab.cern.ch/atlas/athena/-/merge_requests/69154gFEX: fix bug in gTower class2024-02-22T22:06:42+01:00Cecilia ToscirigFEX: fix bug in gTower classWith this MR, a bug found in `gTower::getFWID` is fixed. This assigns the correct energy to some gTowers in the forward region, that were previously swapped. Consequently, this solves some mismatches found in the hw vs sw comparison for ...With this MR, a bug found in `gTower::getFWID` is fixed. This assigns the correct energy to some gTowers in the forward region, that were previously swapped. Consequently, this solves some mismatches found in the hw vs sw comparison for small-R jets and also improves results for large-R jets and MET quantities.https://gitlab.cern.ch/atlas/athena/-/merge_requests/69149Fix bug in gTower class2024-02-22T21:07:56+01:00Cecilia TosciriFix bug in gTower classWith this MR, a bug found in `gTower::getFWID` is fixed. This assigns the correct energy to some gTowers in the forward region, that were previously swapped. Consequently, this solves some mismatches found in the hw vs sw comparison for ...With this MR, a bug found in `gTower::getFWID` is fixed. This assigns the correct energy to some gTowers in the forward region, that were previously swapped. Consequently, this solves some mismatches found in the hw vs sw comparison for small-R jets and also improves results for large-R jets and MET quantities.https://gitlab.cern.ch/atlas/athena/-/merge_requests/69128Delayed jets, additional chains, ATR-288362024-02-22T12:27:39+01:00Leon BozianuDelayed jets, additional chains, ATR-28836Closes ATR-28836, includes 6 new HLT chains for delayed jet studies.Closes ATR-28836, includes 6 new HLT chains for delayed jet studies.https://gitlab.cern.ch/atlas/athena/-/merge_requests/69010Add some actual 2D efficiencies and the completed error calculation2024-02-20T16:58:17+01:00Mark SuttonAdd some actual 2D efficiencies and the completed error calculationThe full implementation for the error calculation was not implemented,
This fixes that and adds two new sets of efficiencies, one of eta vs_pt
and one for d0 vs pt.The full implementation for the error calculation was not implemented,
This fixes that and adds two new sets of efficiencies, one of eta vs_pt
and one for d0 vs pt.https://gitlab.cern.ch/atlas/athena/-/merge_requests/68997Convert types for input arguments2024-02-19T16:13:08+01:00Mark SuttonConvert types for input argumentsThe python command line options apparently all get converted to strings, so we have to convert them to numerical types by hand.
Should be both main and 24.0 - needed for both
Potentially addresses ATR-28830The python command line options apparently all get converted to strings, so we have to convert them to numerical types by hand.
Should be both main and 24.0 - needed for both
Potentially addresses ATR-28830https://gitlab.cern.ch/atlas/athena/-/merge_requests/68931Remove uneccessary failure in PrescaleTool2024-02-16T10:53:23+01:00Mark SuttonRemove uneccessary failure in PrescaleToolThe PrescaleTool reports an ERROR if there is only one chain in a coherent prescale set.
This is not needed, since a single chain would by definition be coherent with itself and so this check is not needed.
The only consequence of this...The PrescaleTool reports an ERROR if there is only one chain in a coherent prescale set.
This is not needed, since a single chain would by definition be coherent with itself and so this check is not needed.
The only consequence of this change should be that some jobs that previously failed, when they did not have to, would now no longer fail.https://gitlab.cern.ch/atlas/athena/-/merge_requests/68465Draft: Adding new HH4b DIPZ chains to the Dev menu2024-02-15T15:42:58+01:00Mohammed Aboelelamo.abdellrazekk@cern.chDraft: Adding new HH4b DIPZ chains to the Dev menuIn order to see the effect of DIPZ on different stages in the main and preselection stages in HH4b chains, we add new sets of DIPZ chains each with a different configuration for the main/preselection to aid in performance comparison.
Pa...In order to see the effect of DIPZ on different stages in the main and preselection stages in HH4b chains, we add new sets of DIPZ chains each with a different configuration for the main/preselection to aid in performance comparison.
Passed the runTrigART.py tests successfully.
Tagging @miochoa @dguest @kleney @jlsmith @cpollard @khoo @lbeemste @lshiMohammed Aboelelamo.abdellrazekk@cern.chMohammed Aboelelamo.abdellrazekk@cern.ch