athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2023-09-27T08:41:34+02:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/66035fix photon trigger container for Heavy_ions2023-09-27T08:41:34+02:00Sebastian Tapia Arayafix photon trigger container for Heavy_ionsIn Heavy-Ion trigger setup, ion, the HLT CaloEMClusters containers for electrons and photons were merged into one losing information of individual objects links.
This MR creates a new container for each object, electron, and photon. Cr...In Heavy-Ion trigger setup, ion, the HLT CaloEMClusters containers for electrons and photons were merged into one losing information of individual objects links.
This MR creates a new container for each object, electron, and photon. Creating new Keys and modifying the EDM.
Tagging HI trigger coordinator @asmaga @jkremer, HI Conveners @mrybar @angerami @qhuhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/65995TrigEgamma:Moving precision electron to ca2023-10-06T15:54:32+02:00Debottam Bakshi GuptaTrigEgamma:Moving precision electron to caMoving final step of electron signature to CA (linking the jira ATR-26736 created for this)Moving final step of electron signature to CA (linking the jira ATR-26736 created for this)https://gitlab.cern.ch/atlas/athena/-/merge_requests/65950Add `pixCLnoToT` to `HLT_SpacePointCounts` container2023-09-24T16:52:49+02:00Krzysztof Cieslakrzysztof.marcin.ciesla@cern.chAdd `pixCLnoToT` to `HLT_SpacePointCounts` container!64190 added new counter in `TrigCountSpacePoints` tool -- `pixCLnoToT`. However, the new counter was not propagated further into `HLT_SpacePointCounts` container (i.e. for DQ monitoring). This MR fixes this.
CC: @tbold!64190 added new counter in `TrigCountSpacePoints` tool -- `pixCLnoToT`. However, the new counter was not propagated further into `HLT_SpacePointCounts` container (i.e. for DQ monitoring). This MR fixes this.
CC: @tboldhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/65945Adding HLT_AntiKt4EMPFlowJets_jes_ftf jets to the EDM (ATR-22067)2023-09-24T16:52:50+02:00Martin RybarAdding HLT_AntiKt4EMPFlowJets_jes_ftf jets to the EDM (ATR-22067)Adding HLT_AntiKt4EMPFlowJets_jes_ftf jets to the EDM (ATR-22067)
- this follows MR! 65831 by @cantel
- standard HI tests are Ok
- offline reconstruction without problems
tagging @begilber @asmaga and @jkremerAdding HLT_AntiKt4EMPFlowJets_jes_ftf jets to the EDM (ATR-22067)
- this follows MR! 65831 by @cantel
- standard HI tests are Ok
- offline reconstruction without problems
tagging @begilber @asmaga and @jkremerhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/63374Fix HLT tau EDM2023-05-31T12:06:22+02:00Edson Carquin LopezFix HLT tau EDMRelates to ATR-27607, pinging @tamartin @martindlRelates to ATR-27607, pinging @tamartin @martindlhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/63343Updating view name in tau trigger EDM2023-05-31T12:06:22+02:00Edson Carquin LopezUpdating view name in tau trigger EDMThis fix the HLT_TopoCaloClustersLC collection needed for monitoring tau and caloclusters, problem was introduced in !63042 and reported in ATR-27607This fix the HLT_TopoCaloClustersLC collection needed for monitoring tau and caloclusters, problem was introduced in !63042 and reported in ATR-27607https://gitlab.cern.ch/atlas/athena/-/merge_requests/62454ATR-27162 > Expansion of TLA EDM for 2023 Data Taking2023-04-26T13:07:05+02:00Marco MontellaATR-27162 > Expansion of TLA EDM for 2023 Data TakingThis MR adds the following container to the PhysicsTLA EDM:
```
HLT_CaloEMClusters_Photon
HLT_IDTrack_FS_FTF
HLT_IDVertex_FS
L1_eEMRoI
```This MR adds the following container to the PhysicsTLA EDM:
```
HLT_CaloEMClusters_Photon
HLT_IDTrack_FS_FTF
HLT_IDVertex_FS
L1_eEMRoI
```https://gitlab.cern.ch/atlas/athena/-/merge_requests/62061Update list of event views in EDM for muon triggers2023-04-04T15:22:09+02:00Savanna ShawUpdate list of event views in EDM for muon triggersUpdating the list of event view names for SA muon container in the EDM. This is needed because of the CA migration, the views are named automatically, and the former naming didn't follow a similar enough naming convention to continue to ...Updating the list of event view names for SA muon container in the EDM. This is needed because of the CA migration, the views are named automatically, and the former naming didn't follow a similar enough naming convention to continue to be used.
Bacause the L2 SA step is not completely migrated to CA, the EDM updates cause soem problems with the purely new JO trigger test, so temporarily renaming the views used in the newJO test case until the step is fully CA based (this way, the EDM won't need to be changed again when the migration for this step is completed).
Fixes ATR-27231.https://gitlab.cern.ch/atlas/athena/-/merge_requests/57596Adding Photon Isolation variables to TLA EDM2022-10-17T17:33:56+02:00Marco MontellaAdding Photon Isolation variables to TLA EDMThis MR adds the Photon isolation variables to the TLA stream as defined in TriggerEDMRun3.pyThis MR adds the Photon isolation variables to the TLA stream as defined in TriggerEDMRun3.pyhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/56400Fix photon trigger iso2022-09-03T20:18:13+02:00Fernando MonticelliFix photon trigger isoThis is to fix a bug on how the offset cut is applied in isolation selection affecting mainly icalotight.
Also a fix in the TrigEDM is in place so topoetcone40 is stored in output xAODs
Also implementing the dbg msgs fix for ATR-26259
...This is to fix a bug on how the offset cut is applied in isolation selection affecting mainly icalotight.
Also a fix in the TrigEDM is in place so topoetcone40 is stored in output xAODs
Also implementing the dbg msgs fix for ATR-26259
Pinging @safarzad @cjmeyer @eegidiop and @dbakshighttps://gitlab.cern.ch/atlas/athena/-/merge_requests/55861TrigEgam: Factorizing fast electron step to get rid of fastTrack dependency i...2022-10-14T11:00:46+02:00Debottam Bakshi GuptaTrigEgam: Factorizing fast electron step to get rid of fastTrack dependency in idperf chainsI am continuing from !54997 with a fresh narrative As discussed in ATR-25499 and ATR-25865 to keep the Fast step of electron independent of FastTracks for idperf chains in this MR we factorized fast electron step as following,
for Nomin...I am continuing from !54997 with a fresh narrative As discussed in ATR-25499 and ATR-25865 to keep the Fast step of electron independent of FastTracks for idperf chains in this MR we factorized fast electron step as following,
for Nominal electron the sequence will look like
```
FastCalo
|
V
FastTrack
|
V
FastElectron
|
V
PrecisionCalo
|
V
PrecisionTracking
|
V
GSFRefit
|
V
PrecisionElectron
```
and idperf will look like
```
FastCalo
|
V
FastTrack
|
V
Empty
|
V
PrecisionCalo
|
V
PrecisionTracking
|
V
GSFRefit
```
Apologies for the delays on this development as we wanted to conclude some core structure of our Electron chains. We will take a bit (shouldn't be long) to validate this MR as we will see some intermediate count/feature changes of electron chains. Adding @safarzad , @cjmeyer , @fernandoDebottam Bakshi GuptaDebottam Bakshi Guptahttps://gitlab.cern.ch/atlas/athena/-/merge_requests/54365Fixing bug in removing decorations from trigger EDM AODSLIM2022-06-18T11:18:40+02:00Catrin BerniusFixing bug in removing decorations from trigger EDM AODSLIMIt was first noticed in ATR-25724, the previous way of removing decorations was buggy.
I had in the meanwhile made an extensions to this mechanism in !54328 that would also avoid running into this issue for now through the added if stat...It was first noticed in ATR-25724, the previous way of removing decorations was buggy.
I had in the meanwhile made an extensions to this mechanism in !54328 that would also avoid running into this issue for now through the added if statement (if the list of decorations to remove is empty).
This MR should now handle the removal correctly. Has been tested with test_trigAna_RDOtoAOD_v1MC_build.py
Discussion of the concept of per target EDM: ATR-25505
Tagging @okuprash, @tamartin, @martindl for infohttps://gitlab.cern.ch/atlas/athena/-/merge_requests/54107TEgamTrig: Update supercluster calibration for electron and photon triggers, ...2022-07-13T22:47:14+02:00Chris Meyerchris.meyer@cern.chTEgamTrig: Update supercluster calibration for electron and photon triggers, add deltaEta1PearDistortion to electronsNew tunes from the offline e/gam group are now used to calibrate
online electrons and photons. These were derived using precision
electron and photon objects from the mc21 pre-production, and
validated in ATR-25588.
This also adds the d...New tunes from the offline e/gam group are now used to calibrate
online electrons and photons. These were derived using precision
electron and photon objects from the mc21 pre-production, and
validated in ATR-25588.
This also adds the deltaEta1PearDistortion shower-shape correction, which will be useful for future tuning campaigns.
Tagging: @safarzad, @tamartin, @aranzazu, @turra, @ludovicahttps://gitlab.cern.ch/atlas/athena/-/merge_requests/54084Adding missing bjet container to AODSLIM - NEEDED FOR MC PRODUCTION2022-06-08T16:09:01+02:00Catrin BerniusAdding missing bjet container to AODSLIM - NEEDED FOR MC PRODUCTIONAdding one last missing container for jets to the AODSLIM trigger EDM set.
This is very urgent, release deadline is today, so it has to be merged today.
Tagging also @bkerridg for trigger release coordination and @tamartin and @aranzaz...Adding one last missing container for jets to the AODSLIM trigger EDM set.
This is very urgent, release deadline is today, so it has to be merged today.
Tagging also @bkerridg for trigger release coordination and @tamartin and @aranzazu.
Apologies for the oversight!https://gitlab.cern.ch/atlas/athena/-/merge_requests/54019Adding Tile Legacy TriggerTower container to rerun Phase1 L1Calo Sim2022-06-10T08:15:16+02:00Sergi Rodriguez BoscaAdding Tile Legacy TriggerTower container to rerun Phase1 L1Calo SimThis MR is meant to add the Tile container to be able to rerun the Phase1 L1Calo simulation at the ESD/AOD level.
With this we will be able to spot bugs, modify and compare with previous containers since we will be able to rerun the sim...This MR is meant to add the Tile container to be able to rerun the Phase1 L1Calo simulation at the ESD/AOD level.
With this we will be able to spot bugs, modify and compare with previous containers since we will be able to rerun the simulation without running again jobs in the grid.
Adding @thompson as Monitoring Coordinator.https://gitlab.cern.ch/atlas/athena/-/merge_requests/53850ATR-25321: Adding jet and minbias containers to AODSLIM2022-06-07T16:00:58+02:00Catrin BerniusATR-25321: Adding jet and minbias containers to AODSLIMThis MR is adding additional jet and minbias containers to the trigger defined AODSLIM EDM set that is going to be used in the MC21 production.
Tagging @cantel, @ayana, @okuprash, as well as @tamartin and @aranzazu for information.
A...This MR is adding additional jet and minbias containers to the trigger defined AODSLIM EDM set that is going to be used in the MC21 production.
Tagging @cantel, @ayana, @okuprash, as well as @tamartin and @aranzazu for information.
Also tagging @tbold and @todorova for info.
I believe this will also be going into master, so adding the corresponding label.https://gitlab.cern.ch/atlas/athena/-/merge_requests/52412Adding fast FTagging on PFlow jets (for TLA)2023-08-17T20:51:42+02:00Stefano FranchellucciAdding fast FTagging on PFlow jets (for TLA)#### Main purpose
This MR is adding the steps for scheduling "fast" flavour tagging on PFlow jets as a simple modifier of the jets, without requesting any additional Hypo testing. The idea is to attach the b-tagger information on PFlow ...#### Main purpose
This MR is adding the steps for scheduling "fast" flavour tagging on PFlow jets as a simple modifier of the jets, without requesting any additional Hypo testing. The idea is to attach the b-tagger information on PFlow jets for TLA. (ATR-23560)
Adding @cantel.
Further details:
* Only fully calibrated PFlow jets are fast b-tagged.
* A flag is added `Trigger.Jet.fastbtagPFlow` (default `True`): If disabled, turns OFF fast b-tagging for PFlow jets.
* Shrinking cone track association is used.
* Configs for fixed cone association are added but not used here (considered as alternative, as network training was performed with fixed cone association)
* 2 neural networks are run: network (a) trained on b-jet precision tracks, network (b) trained on FS fast tracks.
* Additional jet info is added to the EDM: associated track links (for validation), b-tag outputs.
* Added to `TriggerEDMRun3`
* Added to `TriggerEDMAuxAccessors.h`
* Required modification in `TriggerEDMCLIDs.h` to save track links
#### Additional bug fix for b-jet presel jets
* fast b-tag outputs recorded for the preselection calo jets
* associated tracks for fast b-tag recorded for the preselection calo jets, for validation/commissioning.
* As noted above: Required modification of `TriggerEDMCLIDs.h`.https://gitlab.cern.ch/atlas/athena/-/merge_requests/52127Add recordable() checks and HLTEDMCreator directives for phase-1 L1 RoI EDM2022-04-12T21:43:56+02:00Rafal Bielskirafal.bielski@cern.chAdd recordable() checks and HLTEDMCreator directives for phase-1 L1 RoI EDMEnsure the following phase-1 L1 RoI containers are **always** present in HLT output to preserve EDM consistency:
| type | keys |
| ------ | ------ |
| xAOD::MuonRoIContainer | LVL1MuonRoIs, LVL1MuonRoIsBCm2, LVL1MuonRoIsBCm1, LVL1MuonRo...Ensure the following phase-1 L1 RoI containers are **always** present in HLT output to preserve EDM consistency:
| type | keys |
| ------ | ------ |
| xAOD::MuonRoIContainer | LVL1MuonRoIs, LVL1MuonRoIsBCm2, LVL1MuonRoIsBCm1, LVL1MuonRoIsBCp1, LVL1MuonRoIsBCp2 |
| xAOD::eFexEMRoIContainer | L1_eEMRoI |
| xAOD::eFexTauRoIContainer | L1_eTauRoI, L1_cTauRoI |
| xAOD::jFexTauRoIContainer | L1_jFexTauRoI |
| xAOD::jFexSRJetRoIContainer | L1_jFexSRJetRoI |
| xAOD::jFexLRJetRoIContainer | L1_jFexLRJetRoI |
| xAOD::jFexMETRoIContainer | L1_jFexMETRoI |
| xAOD::jFexSumETRoIContainer | L1_jFexSumETRoI |
| xAOD::gFexJetRoIContainer | L1_gFexSRJetRoI, L1_gFexLRJetRoI, L1_gFexRhoRoI |
| xAOD::gFexGlobalRoIContainer | L1_gScalarEJwoj, L1_gMETComponentsJwoj, L1_gMHTComponentsJwoj, L1_gMSTComponentsJwoj |
In addition, call the `recordable()` python check to assert the phase-1 L1 RoI are added in the TriggerEDMRun3 list. This requires minor adjustments to the funtion, to support DataHandles as argument and additional allowed prefixes.
Closes ATR-25333https://gitlab.cern.ch/atlas/athena/-/merge_requests/52039Adding extra variables to be stored in AOD2022-04-11T21:42:21+02:00Debottam Bakshi GuptaAdding extra variables to be stored in AODMentioned in ATR-24933 this MR is to store required variable in AOD to calculate deltaPoverPMentioned in ATR-24933 this MR is to store required variable in AOD to calculate deltaPoverPhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/51710refit LRT tracks with GSF and fixing eventView and wrong dataHandle name issue2022-03-30T21:43:06+02:00Debottam Bakshi Guptarefit LRT tracks with GSF and fixing eventView and wrong dataHandle name issueThis MR is taking care of LRT with GSF refit (ATR-24523), wrong eventViewName (ATR-25130), wrong naming of dataHandle (ATR-24826). Adding @longjon , @cjmeyer , @jodafonsThis MR is taking care of LRT with GSF refit (ATR-24523), wrong eventViewName (ATR-25130), wrong naming of dataHandle (ATR-24826). Adding @longjon , @cjmeyer , @jodafons