athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2024-01-16T18:03:24+01:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/68175Dev atr284432024-01-16T18:03:24+01:00Shaoguang Wushaoguang.wu@cern.chDev atr28443update chains for [ATR-28443](https://its.cern.ch/jira/browse/ATR-28443)
With available DJMASS cuts, the efficiency is too low, change DJMASS500j35 to DJMASS300j35;
use L1seed L1eEM26M, the trigger efficiency for VBFH-\>Z(-\>qq)y is ...update chains for [ATR-28443](https://its.cern.ch/jira/browse/ATR-28443)
With available DJMASS cuts, the efficiency is too low, change DJMASS500j35 to DJMASS300j35;
use L1seed L1eEM26M, the trigger efficiency for VBFH-\>Z(-\>qq)y is list in Table attached.
And test the performance of gamma + 3 jets trigger for ggF production modes.
![efficiency and rates](/uploads/cf7d5bb5bed1c0b1f8f11168963af6f7/image.png){width=737 height=294}Shaoguang Wushaoguang.wu@cern.chShaoguang Wushaoguang.wu@cern.chhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/67876Add Calratio trigger algorithm to the 23.0 for the MC production request2023-12-15T16:13:17+01:00Tatiana OvsiannikovaAdd Calratio trigger algorithm to the 23.0 for the MC production requestthe new Run3 calratio triggers
See merge request atlas/athena!66963
I just cherry peaking it from the mainthe new Run3 calratio triggers
See merge request atlas/athena!66963
I just cherry peaking it from the mainhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/67340Correcting for a factor in the outputs of the DIPZ regression in Athena2023-11-30T21:57:36+01:00Mohammed Aboelelamo.abdellrazekk@cern.chCorrecting for a factor in the outputs of the DIPZ regression in AthenaThe original current DIPZ output from Athena has a factor of "50" in the outputs that we want to get rid of. Thus we derived another neural network with an extral layer that does such change and validated it. We defined the output of the...The original current DIPZ output from Athena has a factor of "50" in the outputs that we want to get rid of. Thus we derived another neural network with an extral layer that does such change and validated it. We defined the output of the network with a new timestamp. Here, we modified the files that use DIPZ with the new timestamped variable name, and also pointed athena to the location of the new json file.
These changes passed the `test_trigAna_RDOtoAOD_v1Dev_build.py` tests and the new timestamped output variables were inspected in the output AOD from the test.Dan GuestInes OchoaChris PollardKatharine LeneyMohammed Aboelelamo.abdellrazekk@cern.chDan Guesthttps://gitlab.cern.ch/atlas/athena/-/merge_requests/63500Draft: Add alternative tagger hypo to fast GN12023-11-27T09:49:13+01:00Thandikire MadulaDraft: Add alternative tagger hypo to fast GN1WIP MR to add hypo for FastGN1_PVWIP MR to add hypo for FastGN1_PVhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/67127test chains for DPJ trigger ATR-284122023-11-15T15:15:50+01:00Zhongyukun Xuzhongyukun.xu@cern.chtest chains for DPJ trigger ATR-28412New trigger into Dev chains
test VBF inclusive low threshold
test VBF+msonly
test VBF+nscanNew trigger into Dev chains
test VBF inclusive low threshold
test VBF+msonly
test VBF+nscanhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/64732Add hypo for time-significance based selection of HLT jets2023-08-18T20:42:24+02:00Christian OhmAdd hypo for time-significance based selection of HLT jetsThis MR adds the `TimeSignificanceCondition` class to select jets at the HLT based on the significance of their delay. To be developed further before being put into production, but once marked ready the additions in this should be possib...This MR adds the `TimeSignificanceCondition` class to select jets at the HLT based on the significance of their delay. To be developed further before being put into production, but once marked ready the additions in this should be possible to merge in without causing any problems.
Longer-term improvements most importantly would include picking parameters for pT-dependent time resolution from a db or similar (instead of hardcoded). Tagging @mapatzwa who did the implementation for [his MSc thesis](http://cds.cern.ch/record/2865684), and @xingguo and @miochoa as jet trigger signature coordinators (and @cantel who previously held this role).
Also tagging @sfyrla and @jmontejo for info, as they've done work on similar things recently.https://gitlab.cern.ch/atlas/athena/-/merge_requests/64947Draft: Fix EtaPtFilter to avoid some missing parent links for leptons2023-08-11T10:18:04+02:00R D SchafferDraft: Fix EtaPtFilter to avoid some missing parent links for leptonsThis is a continuation of [!64793](https://gitlab.cern.ch/atlas/athena/-/merge_requests/64793#note_7000903).
This implements the missing truth filtering via EtaPtFilter. This is done only for the CA Hits to AOD production, i.e. it remai...This is a continuation of [!64793](https://gitlab.cern.ch/atlas/athena/-/merge_requests/64793#note_7000903).
This implements the missing truth filtering via EtaPtFilter. This is done only for the CA Hits to AOD production, i.e. it remains commented out in jobOpts. This uses the TruthParticleBuilder which was used in the past to go from GenEvent to TruthEvent - which is not xAOD formatted one. It also performed as a first step the filtering of the truth in a GenEvent to GenEvent step. Only the filtering is not done. This reduces the AOD by a few percent due to truth reduction. This MR also fixes a problem in the filtering where the parent child links can be lost for leptons with eta > 5.5. Note that dumpTruth.py was slighting changed to be more coherent in way one passes the CA arguments.
Pinging @zmarshal, @jchapman, @jcatmoreR D SchafferR D Schafferhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/64696Revert "Merge branch 'miochoa-23.0-HIjets' into '23.0'"2023-07-30T14:52:01+02:00Tomasz BoldRevert "Merge branch 'miochoa-23.0-HIjets' into '23.0'"This reverts merge request !64528
@miochoa - since we plan to buuld nghtly tomorrow we need a fix, either reverting your changes or !64693
Obviously the prefernce is for the later.This reverts merge request !64528
@miochoa - since we plan to buuld nghtly tomorrow we need a fix, either reverting your changes or !64693
Obviously the prefernce is for the later.https://gitlab.cern.ch/atlas/athena/-/merge_requests/63772TrigHLTJetHypo: Use std::set less2023-06-27T14:28:16+02:00Adam Edward BartonTrigHLTJetHypo: Use std::set less@smh 's profiles show TrigHLTJetHypo spending a large amount of time in std::set this seems unnecessary. I have reworked FastReducer to use the slow std::set less.
This should probably be checked quite carefully and maybe more optimizat...@smh 's profiles show TrigHLTJetHypo spending a large amount of time in std::set this seems unnecessary. I have reworked FastReducer to use the slow std::set less.
This should probably be checked quite carefully and maybe more optimizations can be considered.https://gitlab.cern.ch/atlas/athena/-/merge_requests/63505Updates to switch MU5VF_EMPTY to 2MU5VF_EMPTY, the muoncalib chain and fix fo...2023-06-06T21:07:43+02:00Francesco GiuliUpdates to switch MU5VF_EMPTY to 2MU5VF_EMPTY, the muoncalib chain and fix for online NoiseBurst flagging inefficiencyFix z0 calculation in emerging jets trigger
See merge request atlas/athena!63289Fix z0 calculation in emerging jets trigger
See merge request atlas/athena!63289https://gitlab.cern.ch/atlas/athena/-/merge_requests/63288Fix z0 calculation in emerging jets trigger2023-05-25T06:26:35+02:00Jackson Carl BurzynskiFix z0 calculation in emerging jets triggerThe z0 calculation in `TrigJetEJsHypoTool` did not take into account the beamspot z position which led to large rates for periods with significant beamspot shifts (see ATR-27603). The implementation now aligns with the recommended way to...The z0 calculation in `TrigJetEJsHypoTool` did not take into account the beamspot z position which led to large rates for periods with significant beamspot shifts (see ATR-27603). The implementation now aligns with the recommended way to compute z0 (see https://twiki.cern.ch/twiki/bin/view/AtlasProtected/TrackingCPRecsRun2Final#Calculating_z0_and_d0_significan)
This will lead to rate changes. I am not sure the exact protocol for updating active chains so please let me know if there are additional approvals or discussions needed.
Tagging @cpollard, @jmasik, @strom, @dguest, @ggustavi, @mgenesthttps://gitlab.cern.ch/atlas/athena/-/merge_requests/59762Draft: TriggerEDMConfig: Removing empty HLT jet containers (ATR-26841)2023-03-07T13:32:08+01:00Claire AntelDraft: TriggerEDMConfig: Removing empty HLT jet containers (ATR-26841)### Purpose
Removing HLT jet containers from that currently do not have any associated chains and are thus empty containers. HLT Jet containers removed (see ATR-26841):
```
"HLT_AntiKt4EMTopoJets_subjesIS_ftf"
"HLT_AntiKt4EMTopoJets_s...### Purpose
Removing HLT jet containers from that currently do not have any associated chains and are thus empty containers. HLT Jet containers removed (see ATR-26841):
```
"HLT_AntiKt4EMTopoJets_subjesIS_ftf"
"HLT_AntiKt4EMTopoJets_subjesgscIS_ftf"
"HLT_AntiKt4EMTopoJets_subresjesgsc_ftf"
"HLT_AntiKt4EMTopoJets_subjes"
"HLT_AntiKt4EMTopoSKJets_nojcalib"
"HLT_AntiKt4EMTopoCSSKJets_nojcalib"
"HLT_AntiKt4EMPFlowJets_subjesIS_ftf"
"HLT_AntiKt4EMPFlowJets_subjesgsc_ftf"
"HLT_AntiKt4EMPFlowJets_subresjesgsc_ftf"
"HLT_AntiKt4EMPFlowCSSKJets_nojcalib_ftf"
"HLT_AntiKt10LCTopoSoftDropBeta100Zcut10Jets_nojcalib"
"HLT_AntiKt10EMPFlowJets_nojcalib_ftf"
"HLT_AntiKt10EMPFlowSoftDropBeta100Zcut10Jets_nojcalib_ftf"
```
### Affects...
Trigger EDM size should decrease slightly from removing 13 empty xAOD containers.
### Tests
Ran over Physics, Dev, MC, HI, and Cosmics menu to make sure wasn't missing a chain creating one of these jet types.https://gitlab.cern.ch/atlas/athena/-/merge_requests/58689Eliminate code defects suggested by cppcheck2022-12-03T20:51:59+01:00Andrii VerbytskyiEliminate code defects suggested by cppcheckEliminate code defects suggested by cppcheck
Tag @sroe @fwinklEliminate code defects suggested by cppcheck
Tag @sroe @fwinklhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/53616jet hypo - adjustment to how jet moments are handled.2022-11-21T11:03:18+01:00Peter Sherwoodjet hypo - adjustment to how jet moments are handled.Changes to how jet moment Conditions are handled.
Correct the scale factor applied to all moments.
Simplify substrings relating to jet moments in the chain name.
ATR-25597
@ayana @cantel @peterChanges to how jet moment Conditions are handled.
Correct the scale factor applied to all moments.
Simplify substrings relating to jet moments in the chain name.
ATR-25597
@ayana @cantel @peterPeter SherwoodPeter Sherwoodhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/48701Draft: WIP Introduce TrigCaloInterface.py. Have trig calo clients use this mo...2022-09-26T13:29:09+02:00Peter SherwoodDraft: WIP Introduce TrigCaloInterface.py. Have trig calo clients use this module rather...This merge request fulfils need for a single point of access described in ATR-24678.
It replaces !48606. The location of TrigCaloInterface has been moved due to objections to using the TrigCaloRec package made in !48606. The new locati...This merge request fulfils need for a single point of access described in ATR-24678.
It replaces !48606. The location of TrigCaloInterface has been moved due to objections to using the TrigCaloRec package made in !48606. The new location, TrigT2CaloCommon, can still be changed.
The following diagrams show the changes to the import relations:
[close_g_to_TrigCaloRecConf_All.pdf](/uploads/9b82fbcb24afd29de570150eca5ddd69/close_g_to_TrigCaloRecConf_All.pdf)[close_g_to_TrigCaloRecConf_Dev.pdf](/uploads/be74fe76ae5b3f7d830536639ef38b90/close_g_to_TrigCaloRecConf_Dev.pdf)
@khoo @smh @damazio @joheinri @jmontejo @peterPeter SherwoodPeter Sherwoodhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/50293Draft: WIP: Online Monitoring for TLA Chains2022-06-27T15:14:00+02:00Marco MontellaDraft: WIP: Online Monitoring for TLA ChainsThis MR tracks the implementation of an online monitoring interface for TLA chains, as requested in [ATR-24876](https://its.cern.ch/jira/browse/ATR-24876).
We are currently following the example of the TrigDJPromptHypoAlgMonTool ([Link]...This MR tracks the implementation of an online monitoring interface for TLA chains, as requested in [ATR-24876](https://its.cern.ch/jira/browse/ATR-24876).
We are currently following the example of the TrigDJPromptHypoAlgMonTool ([Link](https://acode-browser1.usatlas.bnl.gov/lxr/source/athena/Trigger/TriggerCommon/TriggerMenuMT/python/HLT/UnconventionalTracking/DJTriggerConfiguration.py#0031)), by implementing the MonTool in TrigJetTLAHypoAlg.
Tagging @shanisch, @rbielski , @fpastore
Cheers,
Marco and @cantel
---
**CURRENT STATUS**
We tested the initial implementation on the full Dev menu. We see the new TLA histogram defined in TrigTLAJetHypoAlgMonTool, but it is empty, along with all other histograms. This is the command we used for the test run:
```
athenaHLT.py -l WARNING -c "doL1Sim=True;setMenu='Dev_pp_run3_v1';" -o output --imf --perfmon --threads=1 --concurrent-events=1 --nprocs=1 --number-of-events=30 --dump-config-reload --file=/cvmfs/atlas-nightlies.cern.ch/repo/data/data-art/TrigP1Test/data18_13TeV.00360026.physics_EnhancedBias.merge.RAW._lb0151._SFO-1._0001.1 TriggerJobOpts/runHLT_standalone.py
```https://gitlab.cern.ch/atlas/athena/-/merge_requests/47329ATR-22696 CalRatio migration including chain2022-06-09T14:31:16+02:00Emma Torro PastorATR-22696 CalRatio migration including chainIncludes CalRatio migration, adding a chain to the LS2_v1.py menu.
- The migrated algorithm is in the TrigHypothesis package, in the following files:
TrigJetCRHypoAlg.cxx, .h; TrigJetCRHypoTool.cxx , .h
- The chain is added to the Jet sl...Includes CalRatio migration, adding a chain to the LS2_v1.py menu.
- The migrated algorithm is in the TrigHypothesis package, in the following files:
TrigJetCRHypoAlg.cxx, .h; TrigJetCRHypoTool.cxx , .h
- The chain is added to the Jet slice, similar to the emerging jets chains defined in:
ExoticJetSequences.py, JetChainConfiguration.py.
I added the "calratio" signature in SignatureDicts.py
- To do: I still have to find how to input the calorimeter cells into the jetCRMenuSequence in ExoticJetSequences.py. Once I have that included I'll uncomment the part doing the BIB-removal, that needs the cells.
Tested with test_trig_mc_v1Dev_slice_jet_build.pyhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/52940Draft: A test for preselection2022-05-24T09:06:28+02:00Dan GuestDraft: A test for preselectionBetween me, @cpollard, and @cantel, we're not quite sure if our b-tagging preselection hypo is doing the right thing. This does something silly: we return a true dips test for anything under 10 GeV. If we get chain count increases someth...Between me, @cpollard, and @cantel, we're not quite sure if our b-tagging preselection hypo is doing the right thing. This does something silly: we return a true dips test for anything under 10 GeV. If we get chain count increases something is weird.https://gitlab.cern.ch/atlas/athena/-/merge_requests/49732ATR-22696: moving CalRatio triggers to up-to-date TrigHLTJetHypo and Menu2022-04-28T12:00:18+02:00Emma Torro PastorATR-22696: moving CalRatio triggers to up-to-date TrigHLTJetHypo and MenuThe last MR (!47329) failed because it was very far behind and had several conflicts.
I'm opening a new MR based on an up-to-date master (as of this morning).
The CalRatio code is the same as in the las MR with the following difference...The last MR (!47329) failed because it was very far behind and had several conflicts.
I'm opening a new MR based on an up-to-date master (as of this morning).
The CalRatio code is the same as in the las MR with the following differences:
- we previously had two independent signature bits (calratio and bibrm). This wasn't working as only one exotHypo is allowed. So I moved them to calratio and calratiormbib, where the last one applies the BIB removal part and the former one doesn't
- the chains were placed in LS2_v1.py. I've moved them to Dev_pp_run3_v1.py but I'm not sure this is the correct menu, so please let me know if I should move them somewhere elsehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/50352Emerging jets dev 2 9 222022-03-22T19:17:11+01:00Aaron Joseph KilgallonEmerging jets dev 2 9 22Modifies emerging jet chains to use chain dictionary rather than chain name.
Modifies dev menu to indicate primary and alternate emerging jets chains.Modifies emerging jet chains to use chain dictionary rather than chain name.
Modifies dev menu to indicate primary and alternate emerging jets chains.