athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2024-03-28T10:54:19+01:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/70165Update Enhanced Bias menu for 20242024-03-28T10:54:19+01:00Aleksandra PorebaUpdate Enhanced Bias menu for 2024- Move L1_6jJ40 (VeryHigh) to L1_5jJ40p0ETA25 (High) because the 6j item was removed from the menu
- Use L1_eEM18M_2eTAU20M_jXE70 as a replacement for L1_EM15VHI_2TAU12IM_XE35 (previously wrong item)
- Use L1_2eEM18 as a replacement for ...- Move L1_6jJ40 (VeryHigh) to L1_5jJ40p0ETA25 (High) because the 6j item was removed from the menu
- Use L1_eEM18M_2eTAU20M_jXE70 as a replacement for L1_EM15VHI_2TAU12IM_XE35 (previously wrong item)
- Use L1_2eEM18 as a replacement for L1_2EM15 instead of L1_2eEM18L (the rate L1_2eEM18L was too low for medium category)
Tagging @astruebi @lidiaz @tamartinhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/70138Add HLT_noalg_L1MU14EOF to express2024-03-28T11:30:33+01:00Muhammad AlhroobAdd HLT_noalg_L1MU14EOF to expresshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/701292024-03-26: merge of 24.0 into main2024-03-28T10:55:02+01:00Edward Moyse2024-03-26: merge of 24.0 into mainThis sweep contains the following MRs:
* !70090 ATR-28985 Trigger request for Multijet TLA ~Trigger, ~TriggerMenu
* !70113 MuonDQA: remove references to Run-2 monitoring config ~DQ, ~MuonSpectrometer
* !70115 LArMonitoring: delete leg...This sweep contains the following MRs:
* !70090 ATR-28985 Trigger request for Multijet TLA ~Trigger, ~TriggerMenu
* !70113 MuonDQA: remove references to Run-2 monitoring config ~DQ, ~MuonSpectrometer
* !70115 LArMonitoring: delete legacy job options ~DQ, ~LAr
* !70117 Pixel Calibration - adding getters and fixing typos ~InnerDetector
* !70112 ZdcMonitoring: cleanup references to legacy config ~ForwardDetectors
* !70109 Fix CMake warning in AthSimulation builds. ~Build
* !69914 Bug fix to generation of links between neutral FE and muons ~JetEtmiss, ~Reconstruction, ~Run2-DataReco-output-changed, ~Run2-MCReco-output-changed, ~Run3-DataReco-output-changed, ~Run3-MCReco-output-changed, ~Tools, ~frozen-tier0-violating
* !70100 Added maxParallelismExtra setting to AvalancheSchedulerSvcCfg ~Trigger
* !70096 Avoid duplicate streamer chain blocks ~Trigger, ~TriggerMenu
* !70108 Remove nullptr initialiser that causes a crashing ~Simulation
* !70048 Adding more test chains for delayed jets ~Trigger, ~TriggerMenu, ~changes-trigger-counts
* !70102 AthenaCommon: refactor --profile-python option ~Core
* !70097 remove legacy python config files form Calorimeter/CaloCnv ~Calorimeter
* !70095 ZDC reconstruction ART script, testing on ZDCCalib data ~ForwardDetectors
* !70092 remove obsolete config files from LArEventTest ~LAr
* !70091 remove obsolete config files from LArCondAthenaPool and LArDetMgrDetDescrCnv ~LAr
* !70089 remove obsolete config-files from LArByteStream ~LAr, ~Simulation
* !70074 AFP monitoring update code style ~DQ, ~ForwardDetectors
* !70069 Fix for the multi-threaded event service configuration ~Tools
* !70036 sTGC raw data monitoring: fix problem with shifter occupancy plots ~DQ, ~MuonSpectrometer
* !70060 Update eFexByteStreamTool.cxx - write multislice tobs as xtobs (since only... ~L1Calo, ~Trigger
* !70057 L1calo monitoring improvements ~Core, ~DQ, ~L1Calo, ~Trigger
* !70035 Update gfex parameters in trigger menu ~L1Calo, ~Trigger, ~TriggerMenu, ~changes-trigger-counts
* !69759 Monitoring of alternative L1 eTAU simulation ~DQ, ~Tau, ~Trigger
* !70030 ATR-28968: Reduce INFO messages from central trigger configuration code ~ACTS, ~Core, ~Tracking, ~Trigger
* !70011 fix failing DataQualityConfigurations tests in dbg build ~DQ
* !70045 CaloSamplingFractionAnalysis: delete legacy job options ~Simulation
* !69994 offline DQ for MMG trigger ~DQ, ~MuonSpectrometer
* !70073 fix StepName ~JetEtmiss, ~Trigger, ~TriggerJet, ~TriggerMenu
* !70061 IDTrig: do not switch on TRT with ITk, deal with InDet/ITk eta dependant cuts ~Trigger, ~TriggerID
* !70068 Run the TIDA Tier0 monitoring correctly ~Trigger
* !70042 pT filter for groomed jets before moment calculation ~JetEtmiss, ~Reconstruction
* !70044 adding missing et conversion factor for KFMET definition for Ph1Topo ~Trigger, ~TriggerMenu
* !70046 DumpGeo: delete legacy job options ~Geometry
* !69953 New efficiency DQ criteria for HLTmuon hanconfig ~DQ
* !70022 clean out legacy config code from LArCalorimeter/LArClusterRec ~LArhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/70105gFEX update jwoj threshold2024-03-28T11:30:34+01:00Cecilia ToscirigFEX update jwoj thresholdWith this MR the gFEX JwoJ thresholds defined in the Trigger Menu are updated as discussed in ATR-29036.With this MR the gFEX JwoJ thresholds defined in the Trigger Menu are updated as discussed in ATR-29036.https://gitlab.cern.ch/atlas/athena/-/merge_requests/70103Optimization of the Trigger Menu generation: move CA generation after the ali...2024-03-28T11:30:33+01:00Francesca PastoreOptimization of the Trigger Menu generation: move CA generation after the alignment (ATR-29039)Within the optimization of the menu generation, this MR moves the ability to generate the CAs after the menu alignment, so during the createDataFlow(). This requires few changes
1. When creating a ChainStep, the sequence generators are ...Within the optimization of the menu generation, this MR moves the ability to generate the CAs after the menu alignment, so during the createDataFlow(). This requires few changes
1. When creating a ChainStep, the sequence generators are stored in self.sequenceFunctions, passed via functools.partial
2. the ChainStep has self.create() function to create the CAs when needed, and store them in the self.sequences
3. all loops on self.sequences must be replaced by self.sequenceFucntions
4. in the alignment, use isEmptySequenceCfg to recognise an empty sequence
5. Changes in the emulation tests to use functools.partial
6. Changes in the jet and MET signatures code to handle functools.partial
7. the NoAlg chains that run PEBInfoWriter appears with one step during the sequence generation, so this requires a change in isNoAlg() function
Configuration comparison:
`Run with arguments: confTool.py --diff HLTJobOptions.json ../test_orig/HLTJobOptions.json Step 1: reference file #components: 79030 Step 2: file to check #components: 79030 Legend: Differences in components Settings in 1st file Settings in 2nd file Component PerfMonMTSvc may differ wallTimeOffset = 1711385097450.0 vs 1711129147120.0 << but all are suppressed by renaming/known differences/...`https://gitlab.cern.ch/atlas/athena/-/merge_requests/70096Avoid duplicate streamer chain blocks2024-03-26T14:38:23+01:00John Patrick Mc GowanAvoid duplicate streamer chain blockshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/70090ATR-28985 Trigger request for Multijet TLA2024-03-26T14:38:22+01:00Francesco CurcioATR-28985 Trigger request for Multijet TLAhttps://its.cern.ch/jira/browse/ATR-28985https://its.cern.ch/jira/browse/ATR-28985https://gitlab.cern.ch/atlas/athena/-/merge_requests/70073fix StepName2024-03-26T14:38:24+01:00Tatiana Ovsiannikovafix StepNameremove the chain name in the stepName definition for Calratio hypos (ATR-29044)remove the chain name in the stepName definition for Calratio hypos (ATR-29044)https://gitlab.cern.ch/atlas/athena/-/merge_requests/700712024-03-23: merge of 24.0 into main2024-03-24T15:44:57+01:00Frank Winklmeier2024-03-23: merge of 24.0 into mainThis sweep contains the following MRs:
* !69782 cTAU algorithm upgrade - added eTAU rCore/BDT and rHad score cuts ~Tau, ~Trigger, ~TriggerMenu
* !70013 xAODCnv: delete legacy job options referencing RecExConfig ~EDM, ~Tau, ~Trigger
* !7...This sweep contains the following MRs:
* !69782 cTAU algorithm upgrade - added eTAU rCore/BDT and rHad score cuts ~Tau, ~Trigger, ~TriggerMenu
* !70013 xAODCnv: delete legacy job options referencing RecExConfig ~EDM, ~Tau, ~Trigger
* !70031 Cherry pick - 69552 ~MuonSpectrometer, ~Trigger
* !70027 Reduce INFO to DEBUG in RorSeqFilter ( ATR-28971) ~Triggerhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/70048Adding more test chains for delayed jets2024-03-26T14:38:23+01:00Lucas BezioAdding more test chains for delayed jetsAs discussed on [28836](https://its.cern.ch/jira/browse/ATR-28836), chains requiring 2 delayed jets are added and copies of timing-based chains with upper limit are added.As discussed on [28836](https://its.cern.ch/jira/browse/ATR-28836), chains requiring 2 delayed jets are added and copies of timing-based chains with upper limit are added.https://gitlab.cern.ch/atlas/athena/-/merge_requests/70044adding missing et conversion factor for KFMET definition for Ph1Topo2024-03-26T14:38:24+01:00Ralf Gugelralf.gugel@cern.chadding missing et conversion factor for KFMET definition for Ph1TopoThis MR updates the final cut values/thresholds for the Ph1Topo based KFMET algorithm to more realistic values. The algorithm itself is still under commissioning and will certainly require more updates (thresholds but also filter coeffic...This MR updates the final cut values/thresholds for the Ph1Topo based KFMET algorithm to more realistic values. The algorithm itself is still under commissioning and will certainly require more updates (thresholds but also filter coefficients) once technically commissioned. Also the L1Topo simulation for this algorithm will still need updates. Yet, having more realistic thresholds configured in hardware at P1 is desirable to ease the commissioning of the firmware implementation, especially once LHC provides high energy+rate collisions again.
Related to https://its.cern.ch/jira/browse/ATR-28657https://gitlab.cern.ch/atlas/athena/-/merge_requests/70035Update gfex parameters in trigger menu2024-03-26T14:38:23+01:00Cecilia TosciriUpdate gfex parameters in trigger menuWith this MR the gFEX parameters in the Trigger Menu are changed as discussed in ATR-29036.With this MR the gFEX parameters in the Trigger Menu are changed as discussed in ATR-29036.https://gitlab.cern.ch/atlas/athena/-/merge_requests/700262024-03-21: merge of 24.0 into main2024-03-22T08:46:02+01:00Frank Winklmeier2024-03-21: merge of 24.0 into mainThis sweep contains the following MRs:
* !70032 fix for ATR-29037 - No such flag: minTRTonTrk ~Trigger, ~TriggerID
* !70018 Fix issue with incomplete hashing in HLT Nav conversion ~Trigger
* !70014 AthenaPython: delete copy_file and ...This sweep contains the following MRs:
* !70032 fix for ATR-29037 - No such flag: minTRTonTrk ~Trigger, ~TriggerID
* !70018 Fix issue with incomplete hashing in HLT Nav conversion ~Trigger
* !70014 AthenaPython: delete copy_file and read_file utilities ~Core
* !69991 LArCafJobs: delete legacy config referencing RecExConfig ~LAr
* !69714 MuonConfig: drop RPC cabling map override ~MuonSpectrometer, ~Run3-MCReco-output-changed, ~Tools
* !70015 TrigPSC+TrigServices: set ConcurrencyFlags::numProcs ~Core, ~Trigger
* !69969 ID trigger: dynamic creation of flags ~Trigger, ~TriggerID
* !70001 L1calo efex tau bdt add max and min thresholds ~L1Calo, ~Trigger
* !69992 Remove HLT_e5_lhvloose_bBeeM6000_L1BKeePrimary from T0 monitoring ~Trigger, ~TriggerMenu
* !69865 More fixes for !68913: hasFlag and iterators ~Core
* !69996 Fixes for wrong stream assignment VBFDelayed -> PhysicsStream ~Trigger, ~TriggerMenu
* !69833 AFP ToF monitoring new hist + bugfix ~DQ, ~ForwardDetectors
* !69984 Fix physval memory leak, ATLASDQ-1136 ~DQ
* !69988 TBDetDescrAlg: delete legacy config and cleanup ~TestBeam
* !69987 ForwardTransport[Svc]: delete legacy configuration ~ForwardDetectors
* !69958 Adding versioning in ZDC calibration files via parameter for TDirectory name ~ForwardDetectors
* !69796 fixes some details of the task, container names and updates file to be used. ~DQ, ~LAr
* !69945 Prevent ONNX from spawning additional threads ~Simulation
* !69930 ZDC CA synchronized with Tier0 version ~ForwardDetectors
* !69886 StoreGate: add SG::HiveMgrSvc::setNumProcs helper ~Core
* !68579 AFT-702: Add heterogeneous input support for GN2 ~Analysis, ~BTagging, ~JetEtmiss
* !69899 Fix LAr CAF jobs ~LAr
* !69857 CA-based script to populate the LAr Bad Feb database ~LAr
* !69981 AFP_GeoModel+Digitization: delete legacy job options ~Digitization, ~ForwardDetectors
* !69949 Protect possible rare FPEs in trigger ~Tracking
* !69963 gFEX pileup threshold update ~EDM, ~JetEtmiss, ~L1Calo, ~Trigger
* !69917 ZdcRec: delete legacy configuration ~ForwardDetectors
* !69967 NTUPtoNTUPCore: delete unused package ~Analysis
* !69971 ForwardRec: delete legacy job options ~ForwardDetectors
* !69966 LArL1Sim: delete legacy job options ~LAr
* !69959 Remove custom JetSuper Roi zedHalfWidth ~JetEtmiss, ~Trigger, ~TriggerID
* !69970 Disable ONNXRuntime CUDA Support, 24.0 branch (2024.03.20.) ~Build
* !69939 ATR-28870: add hh4b GN2 80% chain to physics ~Trigger, ~TriggerMenu, ~changes-trigger-countshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/69996Fixes for wrong stream assignment VBFDelayed -> PhysicsStream2024-03-21T15:21:42+01:00Damiano VannicolaFixes for wrong stream assignment VBFDelayed -> PhysicsStreamIt has been noticed that some chains have wrong stream assignment. VBFDelayed -> PhysicsStream
Closes ATR-29010It has been noticed that some chains have wrong stream assignment. VBFDelayed -> PhysicsStream
Closes ATR-29010https://gitlab.cern.ch/atlas/athena/-/merge_requests/69992Remove HLT_e5_lhvloose_bBeeM6000_L1BKeePrimary from T0 monitoring2024-03-21T15:21:42+01:00Semen TurchikhinRemove HLT_e5_lhvloose_bBeeM6000_L1BKeePrimary from T0 monitoringFollowing the introduction of prescales for HLT_e5_lhvloose_bBeeM6000_L1BKeePrimary (ATR-19501) we do not need to monitor this chain offline, hence removing it from the monGroup.
cc: @lyubushk , @abarton (for BLS trigger), @ebergeas , @...Following the introduction of prescales for HLT_e5_lhvloose_bBeeM6000_L1BKeePrimary (ATR-19501) we do not need to monitor this chain offline, hence removing it from the monGroup.
cc: @lyubushk , @abarton (for BLS trigger), @ebergeas , @jlieberm (for trigger DQ)https://gitlab.cern.ch/atlas/athena/-/merge_requests/699652024-03-20: merge of 24.0 into main2024-03-20T15:24:32+01:00Frank Winklmeier2024-03-20: merge of 24.0 into mainThis sweep contains the following MRs:
* !69825 Updating reference run in centrally managed references ~DQ
* !69916 DetectorStatus: delete legacy DetStatusMapGetter ~Geometry
* !69915 MuonDQA: delete MuonDQAMonFlags and related legacy...This sweep contains the following MRs:
* !69825 Updating reference run in centrally managed references ~DQ
* !69916 DetectorStatus: delete legacy DetStatusMapGetter ~Geometry
* !69915 MuonDQA: delete MuonDQAMonFlags and related legacy monitoring job options ~DQ, ~MuonSpectrometer
* !69913 PhysValMonitoring: remove legacy config from PhysValUtils ~Analysis
* !69905 MuonCondAlg+NSWCalibTools: delete legacy config ~MuonSpectrometer
* !69901 Update IPDVM README for CA config ~InnerDetector
* !69895 MuonCondSvc: delete legacy config and update link dependencies ~MuonSpectrometer
* !69892 MuonCnv+MuonCablings: delete legacy flags and job options ~MuonSpectrometer
* !69891 AthenaConfiguration: cleanup comments to legacy code ~Core
* !69912 TrigInDetAnalysisExample: delete obsolete tida_run2 script ~Trigger
* !69887 Delete a number of obsolete Calo-Geometry config files ~Calorimeter, ~Egamma, ~LAr, ~TestBeam
* !69877 Remove reference to RecExCommon_topOptions in RecExOnline ~Reconstruction
* !69876 Update jetMakeRefSamples.py with CA flags ~JetEtmiss, ~Reconstruction
* !69875 Delete legacy PanTauAlgs configs ~Reconstruction, ~Tau
* !69874 Delete legacy InDetAlignmentMonitoring configs ~DQ, ~InnerDetector
* !69873 Clean up legacy SCT_CalibAlgs configs ~InnerDetector
* !69858 Calo bad chan cleanup ~LAr
* !69849 Micromega digitization - Clean up the EDM ~Digitization, ~Egamma, ~MuonSpectrometer, ~Overlay, ~Trigger
* !69888 ATR-27782 ATR-21596 - Assorted Menu Actions for DiPhoton and DarkJet TLA+PEB ~Trigger, ~TriggerMenu, ~changes-trigger-counts
* !69911 TrigT2CaloEgamma: fix FPE ~Trigger
* !69820 gFEX Updates ~JetEtmiss, ~L1Calo, ~Trigger, ~changes-trigger-counts
* !69862 Added minIsoEt parameter to eTAUs ~Trigger, ~TriggerMenu
* !69868 NSW Simulation: fixed BC assignment for MM ~Trigger
* !69882 TrigEFMissingET: add missing ROOT find package call ~Trigger
* !69897 Remove broken seed phi calculation (already not in use) ~Trigger, ~TriggerID
* !69902 Clean up legacy TriggerMatchingTool configs ~Triggerhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/69939ATR-28870: add hh4b GN2 80% chain to physics2024-03-21T15:21:43+01:00Liaoshan ShiATR-28870: add hh4b GN2 80% chain to physicsAdd a looser option for the hh4b asymmetric 2b2j chain, relaxing GN2 from 77% to 80% if rate allows.
Tagging @lidiaz @astruebi @gipezzul for menu, @cpollard @kleney for HDBS, @lbezio @lbeemste for b-jet triggerAdd a looser option for the hh4b asymmetric 2b2j chain, relaxing GN2 from 77% to 80% if rate allows.
Tagging @lidiaz @astruebi @gipezzul for menu, @cpollard @kleney for HDBS, @lbezio @lbeemste for b-jet triggerhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/69888ATR-27782 ATR-21596 - Assorted Menu Actions for DiPhoton and DarkJet TLA+PEB2024-03-20T08:15:46+01:00Marco MontellaATR-27782 ATR-21596 - Assorted Menu Actions for DiPhoton and DarkJet TLA+PEBAdding full build support chains for DiPhoton and DarkPEB PEB+TLA. Moving DarkPEB chain to Physics Menu.Adding full build support chains for DiPhoton and DarkPEB PEB+TLA. Moving DarkPEB chain to Physics Menu.https://gitlab.cern.ch/atlas/athena/-/merge_requests/698842024-03-18: merge of 24.0 into main2024-03-18T12:15:00+01:00Frank Winklmeier2024-03-18: merge of 24.0 into mainThis sweep contains the following MRs:
* !69804 Drop SlimmingHelper legacy config ~BTagging, ~Derivation, ~InnerDetector, ~JetEtmiss, ~L1Calo, ~Trigger
* !69823 Updating pixel calibration - Adding recovery step ~InnerDetector
* !69824...This sweep contains the following MRs:
* !69804 Drop SlimmingHelper legacy config ~BTagging, ~Derivation, ~InnerDetector, ~JetEtmiss, ~L1Calo, ~Trigger
* !69823 Updating pixel calibration - Adding recovery step ~InnerDetector
* !69824 L1calo monitoring updates (main GfexSimMonitoring) ~DQ, ~L1Calo, ~Trigger
* !69817 Port updates to splash items from P1 ~L1Calo, ~Trigger, ~TriggerMenu
* !69830 Trigger: fix flake8 configuration ~EFTracking, ~JetEtmiss, ~Tau, ~Trigger, ~TriggerEDM, ~TriggerID, ~TriggerJet, ~TriggerMenu, ~TriggerMinBias
* !69831 TauTrig: move from INFO to DEBUG message (ATR-28972) ~Tau, ~Trigger
* !69812 TrigT1CaloFexPerf: delete legacy job options ~L1Calo, ~Trigger
* !69815 TrigT1CaloCalib: delete legacy job options ~DQ, ~L1Calo, ~Overlay, ~Trigger
* !69826 TrigT1CaloMonitoringTools: delete legacy LVL1CaloMonFlags ~DQ, ~L1Calo, ~Trigger
* !69827 Calo: remove a number of unused/obsolete python files ~Calorimeter, ~Trigger
* !69828 TriggerTest: fixes for fastMenuDiff test ~Trigger
* !69841 Change the message level in muon hypo for passthrough mode ~Trigger
* !69843 ControlTest: delete unused legacy tests ~Testhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/69862Added minIsoEt parameter to eTAUs2024-03-21T00:08:07+01:00Jean Yves Beaucampjean.yves.beaucamp@cern.chAdded minIsoEt parameter to eTAUsAdded the `minIsoEt` parameters to eTAUs (ATR-28991)
Tagging @dreikherAdded the `minIsoEt` parameters to eTAUs (ATR-28991)
Tagging @dreikher