athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2024-03-19T18:09:08+01:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/69205Protect possible rare FPEs2024-03-19T18:09:08+01:00Vadim KostyukhinProtect possible rare FPEsAdd some protection in an attempt to avoid rare FPEs observed in trigger ATLASRECTS-7659Add some protection in an attempt to avoid rare FPEs observed in trigger ATLASRECTS-7659https://gitlab.cern.ch/atlas/athena/-/merge_requests/69340Draft: TriggerMenuMT: centralize AccumulatorCache for steps and disable deepcopy2024-03-13T12:03:59+01:00Frank WinklmeierDraft: TriggerMenuMT: centralize AccumulatorCache for steps and disable deepcopyThis is a (for the moment) experimental change to the menu generation that should be discussed amongst experts and in a trigger core SW meeting.
Move the `AccumulatorCache` to the `getStep` method and remove it from the signature-specif...This is a (for the moment) experimental change to the menu generation that should be discussed amongst experts and in a trigger core SW meeting.
Move the `AccumulatorCache` to the `getStep` method and remove it from the signature-specific files. The actual change to review is in `ChainConfigurationBase.py` .
In addition, do not `deepcopy` the result of the sequence configuration (`ChainStep`) as it is not being re-used or modified afterwards. This was also the behavior of the original `RecoFragmentsPool` before it was migrated to `AccumulatorCache`. The deepcopy can be enabled again by setting `Trigger.fastMenuGeneration=False`.
**Reduces the menu generation time of Dev_pp_run3_v1 by a factor 2**. It does however introduce (harmless) changes in the order of some of the `HypoTools` and `InputMakerInputDecisions` properties. In case we decide to move forward with this we would definitely want to add an ART test that checks the configuration is equivalent with/without `fastMenuGeneration` (see this recent [confTool improvement](https://gitlab.cern.ch/atlas/athena/-/merge_requests/69329 "confTool: add ignoreOrder command line option")).
E.g. in the HI menu, the following properties change order (many more in the pp menu):
```plaintext
IM_EFMuMSReco_RoI.InputMakerInputDecisions
IM_L2MuCombReco.InputMakerInputDecisions
SPCountHypoAlg.HypoTools
TrigHIFwdGapHypoAlg.HypoTools
TrigL2MuCBHypoAlg.HypoTools
TrigL2MufastHypoAlg.HypoTools
TrigMuonEFCombinerHypoAlg.HypoTools
TrigMuonEFMSonlyHypo_RoI.HypoTools
```
cc @tbold @fpastore @tamartin
Relates to [ATR-26996](https://its.cern.ch/jira/browse/ATR-26996).https://gitlab.cern.ch/atlas/athena/-/merge_requests/69208b+tau triggers for HH->bbtt, ATR-281982024-02-27T16:40:02+01:00Muhammad Alhroobb+tau triggers for HH->bbtt, ATR-28198Edited Physics_pp_run3-v1 and Dev_pp_run3-v1 Menus for the benefit of JIRA ATR-28198
HLT_tau25_mediumRNN_tracktwoMVA_probe_j65c_020jvt_j40c_020jvt_j25c_020jvt_j20c_020jvt_SHARED_j20c_020jvt_bgn185_pf_ftf_presel3c20XX1c20bg85_L1jJ85p0ETA...Edited Physics_pp_run3-v1 and Dev_pp_run3-v1 Menus for the benefit of JIRA ATR-28198
HLT_tau25_mediumRNN_tracktwoMVA_probe_j65c_020jvt_j40c_020jvt_j25c_020jvt_j20c_020jvt_SHARED_j20c_020jvt_bgn185_pf_ftf_presel3c20XX1c20bg85_L1jJ85p0ETA21_3jJ40p0ETA25
HLT_tau25_mediumRNN_tracktwoMVA_probe_j65c_020jvt_j40c_020jvt_j25c_020jvt_j20c_020jvt_SHARED_j20c_020jvt_bgn185_pf_ftf_presel3c20XX1c20bg85_L1jJ85p0ETA21_3jJ40p0ETA25https://gitlab.cern.ch/atlas/athena/-/merge_requests/68889Draft:Cleanup after legacy removal2024-02-27T13:23:05+01:00Damiano VannicolaDraft:Cleanup after legacy removalCloses ATR-28783Closes ATR-28783https://gitlab.cern.ch/atlas/athena/-/merge_requests/69128Delayed jets, additional chains, ATR-288362024-02-22T12:27:39+01:00Leon BozianuDelayed jets, additional chains, ATR-28836Closes ATR-28836, includes 6 new HLT chains for delayed jet studies.Closes ATR-28836, includes 6 new HLT chains for delayed jet studies.https://gitlab.cern.ch/atlas/athena/-/merge_requests/68465Draft: Adding new HH4b DIPZ chains to the Dev menu2024-02-15T15:42:58+01:00Mohammed Aboelelamo.abdellrazekk@cern.chDraft: Adding new HH4b DIPZ chains to the Dev menuIn order to see the effect of DIPZ on different stages in the main and preselection stages in HH4b chains, we add new sets of DIPZ chains each with a different configuration for the main/preselection to aid in performance comparison.
Pa...In order to see the effect of DIPZ on different stages in the main and preselection stages in HH4b chains, we add new sets of DIPZ chains each with a different configuration for the main/preselection to aid in performance comparison.
Passed the runTrigART.py tests successfully.
Tagging @miochoa @dguest @kleney @jlsmith @cpollard @khoo @lbeemste @lshiMohammed Aboelelamo.abdellrazekk@cern.chMohammed Aboelelamo.abdellrazekk@cern.chhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/68532Draft: Reverting DiPhoton TLA L1Topo Items to Incl2 algorithm2024-02-02T00:42:31+01:00Marco MontellaDraft: Reverting DiPhoton TLA L1Topo Items to Incl2 algorithmThis MR partially reverts the changes in [!68188](https://gitlab.cern.ch/atlas/athena/-/merge_requests/68188), after it was found that using a single input list and evaluating all combinations of the 6 leading TOBs resulted in excessive ...This MR partially reverts the changes in [!68188](https://gitlab.cern.ch/atlas/athena/-/merge_requests/68188), after it was found that using a single input list and evaluating all combinations of the 6 leading TOBs resulted in excessive rates.
The MR reverts the algorithm behaviour to separate input lists, checking only combinations of the leading TOB with any of the 5 sub-leading TOBs.https://gitlab.cern.ch/atlas/athena/-/merge_requests/68489ATR-28679: L1 XE items legacy removal2024-02-01T14:51:56+01:00Marta Lanzac BerrocalATR-28679: L1 XE items legacy removalEdits to the L1 menu to remove L1 XE legacy items from the Physics and added to the MC Menu and to add L1 jXE/gXE Phase-I items. This task has required to edit the input files in /L1 package and some edits in the HLT Menu.
tagging Trigg...Edits to the L1 menu to remove L1 XE legacy items from the Physics and added to the MC Menu and to add L1 jXE/gXE Phase-I items. This task has required to edit the input files in /L1 package and some edits in the HLT Menu.
tagging Trigger Menu Coordinators: @astruebi @lidiazhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/61658Draft: idcalib work rebased on 23.02024-01-26T13:04:13+01:00Sean GalantzanDraft: idcalib work rebased on 23.0As part of my QT (ATR-23204), I implemented a few changes to the IDCalib chains:
- Increased the rough track pT cut from 1GeV to 2GeV to reduce the number of tracks evaluated by the Hypo. This should not affect the output as the current ...As part of my QT (ATR-23204), I implemented a few changes to the IDCalib chains:
- Increased the rough track pT cut from 1GeV to 2GeV to reduce the number of tracks evaluated by the Hypo. This should not affect the output as the current cuts in the menus are 4 and 9 GeV.
- Added track quality cuts to the Hypo, which are based on the `TightPrimary` quality cuts. As explained by the alignment group, they preform those track quality cuts offline, and by moving those cuts online we would only save tracks that are relevant to the alignment, and allow us to run with lower rescales and have more useful tracks.
- Made the second pT cut dependent on eta, this allows to have strict cuts in the low eta regions and loose cuts in the high eta region where we have much less tracks for alignment. Currently, I didn't touch the Menu configuration yet, but added a support for a `trketa6` signature that enables a cut distribution that I optimised, with minimum pT of 6GeV at the high eta region, and higher pT cuts as eta gets lower such that the final eta distribution is somewhat flat. The current `trk4` and `trk9` chains will use my updated code, but with a flat cut distribution which is consistent with the current implementation.https://gitlab.cern.ch/atlas/athena/-/merge_requests/65901Draft: TrigEgamma:Migrating Electron precision tracks to ca2024-01-18T09:56:00+01:00Debottam Bakshi GuptaDraft: TrigEgamma:Migrating Electron precision tracks to caMigrating Electron precision tracks to ca (linking the jira ATR-26736 created for this)Migrating Electron precision tracks to ca (linking the jira ATR-26736 created for this)https://gitlab.cern.ch/atlas/athena/-/merge_requests/65986Draft: Moving GSF refit to ca2024-01-18T09:53:58+01:00Debottam Bakshi GuptaDraft: Moving GSF refit to caMoving GSF refit to ca (linking the jira ATR-26736 created for this)Moving GSF refit to ca (linking the jira ATR-26736 created for this)https://gitlab.cern.ch/atlas/athena/-/merge_requests/68175Dev atr284432024-01-16T18:03:24+01:00Shaoguang Wushaoguang.wu@cern.chDev atr28443update chains for [ATR-28443](https://its.cern.ch/jira/browse/ATR-28443)
With available DJMASS cuts, the efficiency is too low, change DJMASS500j35 to DJMASS300j35;
use L1seed L1eEM26M, the trigger efficiency for VBFH-\>Z(-\>qq)y is ...update chains for [ATR-28443](https://its.cern.ch/jira/browse/ATR-28443)
With available DJMASS cuts, the efficiency is too low, change DJMASS500j35 to DJMASS300j35;
use L1seed L1eEM26M, the trigger efficiency for VBFH-\>Z(-\>qq)y is list in Table attached.
And test the performance of gamma + 3 jets trigger for ggF production modes.
![efficiency and rates](/uploads/cf7d5bb5bed1c0b1f8f11168963af6f7/image.png){width=737 height=294}Shaoguang Wushaoguang.wu@cern.chShaoguang Wushaoguang.wu@cern.chhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/68071Trigger: improve handling of geometry tags in tests2024-01-11T07:31:51+01:00Tadej Novaktadej.novak@cern.chTrigger: improve handling of geometry tags in testsImprove handling of geometry tags in trigger tests. Note that this only covers unit tests, but some additional ART tests may fail after !65253 is merged.
I also added a helper method for tests that have variable input files.
/cc @marti...Improve handling of geometry tags in trigger tests. Note that this only covers unit tests, but some additional ART tests may fail after !65253 is merged.
I also added a helper method for tests that have variable input files.
/cc @martindl @fwinkl @khoohttps://gitlab.cern.ch/atlas/athena/-/merge_requests/65154Draft: Fix ATR-280842023-12-27T16:36:31+01:00Edson Carquin LopezDraft: Fix ATR-28084Closes ATR-28084Closes ATR-28084https://gitlab.cern.ch/atlas/athena/-/merge_requests/67876Add Calratio trigger algorithm to the 23.0 for the MC production request2023-12-15T16:13:17+01:00Tatiana OvsiannikovaAdd Calratio trigger algorithm to the 23.0 for the MC production requestthe new Run3 calratio triggers
See merge request atlas/athena!66963
I just cherry peaking it from the mainthe new Run3 calratio triggers
See merge request atlas/athena!66963
I just cherry peaking it from the mainhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/67331Draft: triggermenu - correct the condition / dead code2023-12-04T09:02:55+01:00Jiri MasikDraft: triggermenu - correct the condition / dead codetry to fix a suspicious condition in the code which evaluates always to True and skips the rest of the sequenceScanner as a consequence.
Maybe the intention was different - leaving to menu experts to commenttry to fix a suspicious condition in the code which evaluates always to True and skips the rest of the sequenceScanner as a consequence.
Maybe the intention was different - leaving to menu experts to commenthttps://gitlab.cern.ch/atlas/athena/-/merge_requests/67340Correcting for a factor in the outputs of the DIPZ regression in Athena2023-11-30T21:57:36+01:00Mohammed Aboelelamo.abdellrazekk@cern.chCorrecting for a factor in the outputs of the DIPZ regression in AthenaThe original current DIPZ output from Athena has a factor of "50" in the outputs that we want to get rid of. Thus we derived another neural network with an extral layer that does such change and validated it. We defined the output of the...The original current DIPZ output from Athena has a factor of "50" in the outputs that we want to get rid of. Thus we derived another neural network with an extral layer that does such change and validated it. We defined the output of the network with a new timestamp. Here, we modified the files that use DIPZ with the new timestamped variable name, and also pointed athena to the location of the new json file.
These changes passed the `test_trigAna_RDOtoAOD_v1Dev_build.py` tests and the new timestamped output variables were inspected in the output AOD from the test.Dan GuestInes OchoaChris PollardKatharine LeneyMohammed Aboelelamo.abdellrazekk@cern.chDan Guesthttps://gitlab.cern.ch/atlas/athena/-/merge_requests/66018Draft: Issue with Calib Chain2023-11-27T12:14:14+01:00Debottam Bakshi GuptaDraft: Issue with Calib ChainAs mentioned in ATR-28177 this MR tries to rectify `unmet INPUT dependencies`As mentioned in ATR-28177 this MR tries to rectify `unmet INPUT dependencies`https://gitlab.cern.ch/atlas/athena/-/merge_requests/66646Draft: Initial commit adding eEM9M as a new 2-bit threshold in physics menu, ...2023-11-27T10:53:15+01:00Marco MontellaDraft: Initial commit adding eEM9M as a new 2-bit threshold in physics menu, and...Initial commit adding eEM9M as a new 2-bit threshold in physics menu, and copies of the DiPhoton TLA chain with eEM9M and eEM10L. DPHI version also amended to range from 0.2 to 2.0.
Tagging @khoo for review.
Current status: Running, no...Initial commit adding eEM9M as a new 2-bit threshold in physics menu, and copies of the DiPhoton TLA chain with eEM9M and eEM10L. DPHI version also amended to range from 0.2 to 2.0.
Tagging @khoo for review.
Current status: Running, no counts (will have to re-run on larger stats)https://gitlab.cern.ch/atlas/athena/-/merge_requests/63500Draft: Add alternative tagger hypo to fast GN12023-11-27T09:49:13+01:00Thandikire MadulaDraft: Add alternative tagger hypo to fast GN1WIP MR to add hypo for FastGN1_PVWIP MR to add hypo for FastGN1_PV