athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2021-03-30T03:04:21+02:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/42036Include MBTS monitoring in the main DQ setup2021-03-30T03:04:21+02:00Tomasz BoldInclude MBTS monitoring in the main DQ setupThis is a small reorganization of MBTS monitoring. Now the main script includes MBTS and SPTRK.
Small (automatic) refactors were also done to the later.
Tagging @kburkaThis is a small reorganization of MBTS monitoring. Now the main script includes MBTS and SPTRK.
Small (automatic) refactors were also done to the later.
Tagging @kburkahttps://gitlab.cern.ch/atlas/athena/-/merge_requests/42002Allow setting of the truth PT threshold for the ntuple creation2021-03-30T11:29:15+02:00Mark SuttonAllow setting of the truth PT threshold for the ntuple creationChange to reduce the selection cut for the truth selection in the minbias testsChange to reduce the selection cut for the truth selection in the minbias testshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/42125Updates to HLT mb_sptrk chains monitoring2021-04-01T03:02:26+02:00Tomasz BoldUpdates to HLT mb_sptrk chains monitoringSmall updates to DQ for min bias triggers:
- more consistent naming of histograms
- basic histograms added
- more plots in DQ display for shifterSmall updates to DQ for min bias triggers:
- more consistent naming of histograms
- basic histograms added
- more plots in DQ display for shifterhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/42130TrigInDetValidation: remove LRT specific flags and add more general ones2021-04-06T03:02:48+02:00Julie KirkTrigInDetValidation: remove LRT specific flags and add more general onesRemove LRT specific flags
For RDO->AOD step add preclude file. Preinclude file in the test itself now need to include step (previously we assumed it was RDOtoRDOTrigger)
Instead of LRT flag for the analysis step add a more general "Ex...Remove LRT specific flags
For RDO->AOD step add preclude file. Preinclude file in the test itself now need to include step (previously we assumed it was RDOtoRDOTrigger)
Instead of LRT flag for the analysis step add a more general "ExtraAna" input.
Change some test names so everything is now lowercasehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/40457[ATR-19768] Implementing a consistent naming scheme for HLT menu configuratio...2021-04-09T03:03:10+02:00Teng Jian Khoo[ATR-19768] Implementing a consistent naming scheme for HLT menu configuration modules across signaturesAddresses ATR-19768 by renaming python files and adjusting imports as needed.
Will provide an update to atlassoftwaredocs in parallel.
Also in the process simplified some of the import statements using relative paths where possible. As...Addresses ATR-19768 by renaming python files and adjusting imports as needed.
Will provide an update to atlassoftwaredocs in parallel.
Also in the process simplified some of the import statements using relative paths where possible. As there aren't (yet) any very explicit guidelines for how to organise the code, nothing is imposed on the signature subfolders other than what was already there, i.e.:
* `[Signature]ChainConfiguration` object is now defined in `[Signature]ChainConfiguration.py` instead of `[Signature]Def.py`
* `[Signature]RecoSequences.py` is where reconstruction sequences should be defined (changed from `[Signature]Setup.py`
* Functions returning `MenuSequence` go in `[Signature]MenuSequences.py`, but in some cases (notably egamma) are in other modules ending in "MenuSequences.py"
* The files in `CommonSequences` don't exactly follow the convention, but were renamed to just be called `[X]Sequences`, and still remain fairly intuitive.
Merging this may need some attention from the RC, in case the changes conflict with MRs from signature developers.https://gitlab.cern.ch/atlas/athena/-/merge_requests/42395ALFAROB monitoring chain added to LS2_v1 menu2021-04-12T11:07:51+02:00Tomasz BoldALFAROB monitoring chain added to LS2_v1 menuThis MR adds ALFAROB monitoring chains. This chain effectively always rejects but runs the algorithm responsible for the collection of vital monitoring information.
Tagging @korcyl
Tagging @rbielski for opinion abut modification to th...This MR adds ALFAROB monitoring chains. This chain effectively always rejects but runs the algorithm responsible for the collection of vital monitoring information.
Tagging @korcyl
Tagging @rbielski for opinion abut modification to the streamer
Tagging @hrussell & @khoo & @dzanzi about the location & name of the chain
(We did not have such a chain in Run 2).https://gitlab.cern.ch/atlas/athena/-/merge_requests/42462Add HMT with pu suppression placeholder chain2021-04-15T03:02:35+02:00Tomasz BoldAdd HMT with pu suppression placeholder chainThis MR adds an additional step for HMT triggers that are meant to suppress some events in moderate pileup (mu ~2-3) conditions.
In this MR the algorithm is not there but placeholders (streaming algs) are used.
It is to facilitate furt...This MR adds an additional step for HMT triggers that are meant to suppress some events in moderate pileup (mu ~2-3) conditions.
In this MR the algorithm is not there but placeholders (streaming algs) are used.
It is to facilitate further development of pu suppressing algorithm.
It is copy paste of changes made by @algilber in here: https://gitlab.cern.ch/algilber/athena/-/commit/50ba749af461193e3b27c5357e1aa5e2f2ee5803
Related to ATR-19952
Anyways, when testing this I found a following menu compilation error:
```
Py:TriggerMenuMT.HLTMenuConfig.Menu.HLTCFConfig ERROR sequenceScanner: Sequence TrkRecoSeq is expected in more than one step: {'2', '3'}
Py:TriggerMenuMT.HLTMenuConfig.Menu.HLTCFConfig ERROR sequenceScanner: Sequence TrkSequence is expected in more than one step: {'2', '3'}
... exception follows ...
```
Can menu experts: @hrussel @dzanzi ... have a look and advice. We need to have two kind of chains in the setup:
```
1) HMT : space points counting -> -> tracks counting
2) HMT wiht PUSUppression : space points counting -> pu suppresion -> tracks counting
```
How can we setup this? I though menu alignment will take care and insert "empty" step in the 1st case.https://gitlab.cern.ch/atlas/athena/-/merge_requests/42481Adding new histograms for monitoring esp SP vs TRK hists2021-04-15T03:03:42+02:00Somadutta BhattaAdding new histograms for monitoring esp SP vs TRK histsThis MR is to add new monitoring histogram for mbsptrk trigger/s. Also, a few changes to binnings and ranges has been implemented to a few histograms.
Tagging: @tboldThis MR is to add new monitoring histogram for mbsptrk trigger/s. Also, a few changes to binnings and ranges has been implemented to a few histograms.
Tagging: @tboldhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/42642TrigMinBiasMonitoring: Fix clang warning.2021-04-17T03:04:44+02:00Scott SnyderTrigMinBiasMonitoring: Fix clang warning.Fix spurious copy in range-for.Fix spurious copy in range-for.https://gitlab.cern.ch/atlas/athena/-/merge_requests/42661Configuring min-bias chains using chain parts2021-04-20T03:03:57+02:00Tomasz BoldConfiguring min-bias chains using chain partsThis is a small technical change on how the min-bias chains are configured.
It is recommended not to use chainDicts becuase for merged chains that may cause "missunderstandings".
Min bias chains are unlikely to be ever affected but bet...This is a small technical change on how the min-bias chains are configured.
It is recommended not to use chainDicts becuase for merged chains that may cause "missunderstandings".
Min bias chains are unlikely to be ever affected but better be sure.https://gitlab.cern.ch/atlas/athena/-/merge_requests/42823Add L1TE Info for monitoring2021-04-23T03:06:00+02:00Somadutta BhattaAdd L1TE Info for monitoringThis MR is to add L1 TE info for monitoring for MinBias triggers.
Tagging @tboldThis MR is to add L1 TE info for monitoring for MinBias triggers.
Tagging @tboldhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/42840Reduce PT truth cut overall, reduce PT Offline for minbias tests2021-04-24T03:05:07+02:00Mark SuttonReduce PT truth cut overall, reduce PT Offline for minbias testsThe Truth particle selection had a generic 3 TeV selection, which was somehow
inconsistent with the 1 GeV offline cut, so this has been reduced to 1 GeV
for the trith also.
Similarly, the ID Trigger minbias has a limit of ~400 MeV, and ...The Truth particle selection had a generic 3 TeV selection, which was somehow
inconsistent with the 1 GeV offline cut, so this has been reduced to 1 GeV
for the trith also.
Similarly, the ID Trigger minbias has a limit of ~400 MeV, and the truth selection
was reduced to this, but the offline selection was still set to 1 GeV, so this
reduces the minbias offline selection to 400 MeV tracking alsohttps://gitlab.cern.ch/atlas/athena/-/merge_requests/43434Trigger: drop "MT" from component names2021-05-13T03:03:08+02:00Frank WinklmeierTrigger: drop "MT" from component namesDrop the obsolete "MT" suffix from several trigger algorithms and hypo tools. No longer necessary now that the Run-2 trigger code has been deleted from master.Drop the obsolete "MT" suffix from several trigger algorithms and hypo tools. No longer necessary now that the Run-2 trigger code has been deleted from master.https://gitlab.cern.ch/atlas/athena/-/merge_requests/43331MR to move LArMCSym to become a condition.2021-05-14T03:04:05+02:00Denis Oliveira DamazioMR to move LArMCSym to become a condition.With a lot of help from Scott Snyder, but more directed towards the needs of HLTCalo.With a lot of help from Scott Snyder, but more directed towards the needs of HLTCalo.https://gitlab.cern.ch/atlas/athena/-/merge_requests/43430Trigger: Enforce strict scheduler dependencies when running on data2021-05-18T03:05:45+02:00Rafal Bielskirafal.bielski@cern.chTrigger: Enforce strict scheduler dependencies when running on dataThe whole point of this MR is to set:
```py
AlgScheduler.setDataLoaderAlg("")
SGInputLoader.FailIfNoProxy = True
```
to enforce that all **unmet** input dependencies are a configuration failure.
This is enabled for all Trigger jobs runn...The whole point of this MR is to set:
```py
AlgScheduler.setDataLoaderAlg("")
SGInputLoader.FailIfNoProxy = True
```
to enforce that all **unmet** input dependencies are a configuration failure.
This is enabled for all Trigger jobs running on data inputs. We're not there yet for MC inputs.
This means that all objects which are loaded from the input file directly (for ByteStream this means through BS Converters) need to be **explicitly** added to the `SGInputLoader.Load` list.
A couple of additional fixes and improvements are included to make everything work:
1. Add newJO config for SGInputLoader, make use of it in MainServicesConfig, ByteStreamConfig, TrigByteStreamConfig
2. Fix configuration of objects loaded from ByteStream in a few places in Trigger job options.
3. Make HelloWorldOptions use AtlasUnixStandardJob instead of AtlasUnixGeneratorJob since the latter unnecessarily configured EventInfoCnvAlg, and also didn't really match the use cases of the job options. The corresponding unit test references are also updated.
Note the newJO config for SGInputLoader includes special merging function for the Load property where different configurations are appended. This matches what one would expect from the use cases - each configuration fragment can tell SGInputLoader which objects it needs to load, and the final configuration is the sum of all these lists.
cc @tbold, @smh, @bwynne, @tadejhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/43293add mbts energy & timing histograms2021-05-20T03:02:33+02:00Klaudia Majadd mbts energy & timing histogramsThis MR is to add MBTS monitoring histograms: energy & timing per MBTS channel, and MBTS A&C side hits correlation. Tag @tboldThis MR is to add MBTS monitoring histograms: energy & timing per MBTS channel, and MBTS A&C side hits correlation. Tag @tboldKlaudia MajKlaudia Majhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/43625Adding Z Finder Algorithm.2021-05-22T15:43:44+02:00Alexander Kevin GilbertAdding Z Finder Algorithm.This algorithm is to find z reconstructed from space points in PixelID.
This is a progress of my qualification task in [ATR-22986](https://its.cern.ch/jira/browse/ATR-22986) under [ATR-19952](https://its.cern.ch/jira/browse/ATR-19952).
...This algorithm is to find z reconstructed from space points in PixelID.
This is a progress of my qualification task in [ATR-22986](https://its.cern.ch/jira/browse/ATR-22986) under [ATR-19952](https://its.cern.ch/jira/browse/ATR-19952).
cc: @tbold, @sutt.Alexander Kevin GilbertAlexander Kevin Gilberthttps://gitlab.cern.ch/atlas/athena/-/merge_requests/43773Fixes of MinBias monitoring plots2021-05-25T03:02:46+02:00Tomasz BoldFixes of MinBias monitoring plotsThis MS is a bunch of rather minor fixes to monitoring of MinBias (both online and DQ).
- tuning histogram limits
- added pt/eta histograms
- fixed names of monitored variables so all is filled (thanks to @algliber for reviewing reproces...This MS is a bunch of rather minor fixes to monitoring of MinBias (both online and DQ).
- tuning histogram limits
- added pt/eta histograms
- fixed names of monitored variables so all is filled (thanks to @algliber for reviewing reprocessing results and spotting those)
- detailed histograms are produced only for the primary chain
Also fixed one bug in hypo tool. We were by default requiring that number of tracks is ">" that the threshold whereas we should be ">=".
Related to ATR-23439https://gitlab.cern.ch/atlas/athena/-/merge_requests/43935TrigMonitoring: enable thread-checker2021-06-01T03:03:32+02:00Frank WinklmeierTrigMonitoring: enable thread-checkerEnable thread-checker and fix warnings for several `TrigMonitoring` packages. Also move some private header files to the `src` directory.Enable thread-checker and fix warnings for several `TrigMonitoring` packages. Also move some private header files to the `src` directory.https://gitlab.cern.ch/atlas/athena/-/merge_requests/42041Trig afp dev2021-06-01T03:05:30+02:00Luisa CarvalhoTrig afp devSimplified chain `HLT_mb_afprec_2j20_L1RD0_FILLED` added to the menu. Should do jet + AFP track reco and then apply dijet AFP combo hypo. Trigger test runs without errors. AFP combo hypo is not being executed, not sure why
JIRA: https:/...Simplified chain `HLT_mb_afprec_2j20_L1RD0_FILLED` added to the menu. Should do jet + AFP track reco and then apply dijet AFP combo hypo. Trigger test runs without errors. AFP combo hypo is not being executed, not sure why
JIRA: https://its.cern.ch/jira/browse/ATR-23177