athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2024-03-28T17:05:29+01:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/70195refine Phase-2 eta hough transform2024-03-28T17:05:29+01:00Maximilian Emanuel Goblirsch-Kolbrefine Phase-2 eta hough transformMake the Phase-2 eta hough transform dynamically adapt its tan(theta) search space to the location of the current search bucket in the detector.
Gain a factor 10 speed and improve resolutions.
Also make some properties configurable.
...Make the Phase-2 eta hough transform dynamically adapt its tan(theta) search space to the location of the current search bucket in the detector.
Gain a factor 10 speed and improve resolutions.
Also make some properties configurable.
CC @jojungge and @minionshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/70182Revert "Merge branch 'sTgcPads' into 'main'"2024-03-28T17:01:03+01:00Edward MoyseRevert "Merge branch 'sTgcPads' into 'main'"This reverts merge request !69314
https://its.cern.ch/jira/browse/ATLASRECTS-7946This reverts merge request !69314
https://its.cern.ch/jira/browse/ATLASRECTS-7946https://gitlab.cern.ch/atlas/athena/-/merge_requests/70172PadDesign - Fixing sTgc Pad Positions2024-03-28T16:08:54+01:00Ishan Kiritbhai VyasPadDesign - Fixing sTgc Pad Positions- Pad Corners Aligned.
- Adding frameOffset parameter in Geometry Tool to correct beamline radius until we find a fix.
- Modifying the globalChannelPosition function in the readout element to correct last half-strip position in gasgap la...- Pad Corners Aligned.
- Adding frameOffset parameter in Geometry Tool to correct beamline radius until we find a fix.
- Modifying the globalChannelPosition function in the readout element to correct last half-strip position in gasgap layers
- Fixing minor errors and bugs
@alainb @jojungge @pscholerhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/70169Only run HLTJetFTagDecoration if trigger included (ATLSWUPGR-245)2024-03-28T14:34:30+01:00Thomas StreblerOnly run HLTJetFTagDecoration if trigger included (ATLSWUPGR-245)Follow up to !700062
Solves PHYSVAL crashes when no trigger is present as in Run 4 tests ATLSWUPGR-245Follow up to !700062
Solves PHYSVAL crashes when no trigger is present as in Run 4 tests ATLSWUPGR-245https://gitlab.cern.ch/atlas/athena/-/merge_requests/69314R4 sTGC Geometry - Adding Pad Readout Element2024-03-28T07:37:46+01:00Ishan Kiritbhai VyasR4 sTGC Geometry - Adding Pad Readout ElementAdding Pads to sTgc similar to wireGroup and Strips.
@alainb @jojungge @pscholerAdding Pads to sTgc similar to wireGroup and Strips.
@alainb @jojungge @pscholerhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/70148Drop DL1dv00 and GN1 from Upgrade ART test monitored plots2024-03-27T17:55:31+01:00Thomas StreblerDrop DL1dv00 and GN1 from Upgrade ART test monitored plotsFollow up to !70085
FYI @ligang @bdong @htorre @schFollow up to !70085
FYI @ligang @bdong @htorre @schhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/70147MuonChamberAssembleTool - Fix crash when geometry does not schedule Rpc2024-03-27T17:50:49+01:00Johannes Junggeburthjohannes.josef.junggeburth@cern.chMuonChamberAssembleTool - Fix crash when geometry does not schedule Rpchttps://gitlab.cern.ch/atlas/athena/-/merge_requests/68333Add R4 version of MDT hough transform2024-03-27T08:30:29+01:00Maximilian Emanuel Goblirsch-KolbAdd R4 version of MDT hough transformAdd a first version of the Muon Hough transform for the WIP Phase-2 muon reconstruction.
Use ACTS as back-end, while detector-specific work is handled in athena.
Also add validation package and required event data classes.
Documentat...Add a first version of the Muon Hough transform for the WIP Phase-2 muon reconstruction.
Use ACTS as back-end, while detector-specific work is handled in athena.
Also add validation package and required event data classes.
Documentation has been presented in the [ITK Acts integration meeting](https://indico.cern.ch/event/1354978/contributions/5875823).
Large MR since required ACTS version in Externals only recently arrived. Further development will happen in smaller MR.https://gitlab.cern.ch/atlas/athena/-/merge_requests/70106Draft: ActsGeometryContext - Non const access2024-03-27T08:20:11+01:00Johannes Junggeburthjohannes.josef.junggeburth@cern.chDraft: ActsGeometryContext - Non const accesshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/66616Draft: TgcReadoutGeometry clean up & removal of a couple of bugs2024-03-27T00:33:16+01:00Johannes Junggeburthjohannes.josef.junggeburth@cern.chDraft: TgcReadoutGeometry clean up & removal of a couple of bugs- Clean up interface of the TgcReadoutElement
- Optimize calculation of the wire group position. Remove recursive calculation approach in favour of a caching
- Fix the calculation of the trapezoidal width for negative z- Clean up interface of the TgcReadoutElement
- Optimize calculation of the wire group position. Remove recursive calculation approach in favour of a caching
- Fix the calculation of the trapezoidal width for negative zhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/68497RpcReadoutElement - Initial clean-up of this beauty2024-03-24T12:45:04+01:00Johannes Junggeburthjohannes.josef.junggeburth@cern.chRpcReadoutElement - Initial clean-up of this beauty- Remove unneeded `localStripPanelPos`, `stripPanelPos` methods
- Do not parse the unused doubletZ through the interface
- Useage of the ATH_MSG macros
- Steamline of strip position calculation & positions of the gas gap positions
- Fix ...- Remove unneeded `localStripPanelPos`, `stripPanelPos` methods
- Do not parse the unused doubletZ through the interface
- Useage of the ATH_MSG macros
- Steamline of strip position calculation & positions of the gas gap positions
- Fix the strip positions of the BIS chambers.
- Augment GeoModelTest to ensure consistency
Tests have been performed on 160k DRAW_ZMUMU events: [AllPerigeeChecks.pdf](/uploads/60bba699efb5ffd5bb6ceed328d934b3/AllPerigeeChecks.pdf)https://gitlab.cern.ch/atlas/athena/-/merge_requests/70070Fixed clang warnings2024-03-23T14:35:53+01:00Vakhtang TsulaiaFixed clang warnings1. `AFPToFAlgorithm`. Uninitialized variable (plus a few cosmetic changes)
2. `MuonSpacePoint`. Unused local variable1. `AFPToFAlgorithm`. Uninitialized variable (plus a few cosmetic changes)
2. `MuonSpacePoint`. Unused local variablehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/70039MuonChamberAssembleTool -- Split BOL7 chambers from the generic BOL sector2024-03-22T17:22:44+01:00Johannes Junggeburthjohannes.josef.junggeburth@cern.chMuonChamberAssembleTool -- Split BOL7 chambers from the generic BOL sectorThe BOL7 chamber is actually the BOE chamber and should not belong to the generic BOL sector
Tagging: @goblirsc, @damperiaThe BOL7 chamber is actually the BOE chamber and should not belong to the generic BOL sector
Tagging: @goblirsc, @damperiahttps://gitlab.cern.ch/atlas/athena/-/merge_requests/70038MuonSpacePoints - Fix Tgc covariance under the stereo angle2024-03-22T17:22:21+01:00Johannes Junggeburthjohannes.josef.junggeburth@cern.chMuonSpacePoints - Fix Tgc covariance under the stereo angleTagging: @goblirscTagging: @goblirschttps://gitlab.cern.ch/atlas/athena/-/merge_requests/70034Correcting the nameing for firstPadPhiDivision and PadPhiShift in R42024-03-22T14:12:11+01:00Ishan Kiritbhai VyasCorrecting the nameing for firstPadPhiDivision and PadPhiShift in R4@jojungge @pscholer@jojungge @pscholerhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/69993RadialStripDesign - Calculate the strip length from the mounting points2024-03-21T09:43:40+01:00Johannes Junggeburthjohannes.josef.junggeburth@cern.chRadialStripDesign - Calculate the strip length from the mounting pointsTagging @goblirscTagging @goblirschttps://gitlab.cern.ch/atlas/athena/-/merge_requests/69910MuonReadoutGeometryR4 - Return the global -> local as copy instead of returni...2024-03-19T17:41:55+01:00Johannes Junggeburthjohannes.josef.junggeburth@cern.chMuonReadoutGeometryR4 - Return the global -> local as copy instead of returning by referenceglobal -> local transformations do not need to be returned by reference. They can be quickly calculated on-the fly by inverting the local-> global transformations... Reduce the memory footprint of the muon readout geometry by 50MBs
```
B...global -> local transformations do not need to be returned by reference. They can be quickly calculated on-the fly by inverting the local-> global transformations... Reduce the memory footprint of the muon readout geometry by 50MBs
```
Building of GeoModelSvc.MuonDetectorToolR4.MdtReadoutGeomTool consumed 201 MB memory
Building of GeoModelSvc.MuonDetectorToolR4.RpcReadoutGeomTool consumed 8 MB memory
Building of GeoModelSvc.MuonDetectorToolR4.TgcReadoutGeomTool consumed 7 MB memory
Building of GeoModelSvc.MuonDetectorToolR4.sTgcReadoutGeomTool consumed 1 MB memory
Building of GeoModelSvc.MuonDetectorToolR4.MmReadoutGeomTool consumed 1 MB memory
Building of GeoModelSvc.MuonDetectorToolR4.MuonChamberAssembleTool consumed 0 MB memory
```
After:
```
Building of GeoModelSvc.MuonDetectorToolR4.MdtReadoutGeomTool consumed 147 MB memory
Building of GeoModelSvc.MuonDetectorToolR4.RpcReadoutGeomTool consumed 7 MB memory
Building of GeoModelSvc.MuonDetectorToolR4.TgcReadoutGeomTool consumed 6 MB memory
Building of GeoModelSvc.MuonDetectorToolR4.sTgcReadoutGeomTool consumed 1 MB memory
Building of GeoModelSvc.MuonDetectorToolR4.MmReadoutGeomTool consumed 0 MB memory
Building of GeoModelSvc.MuonDetectorToolR4.MuonChamberAssembleTool consumed 0 MB memory
```
Tagging: @asalzbur, @pagessin, @damperiahttps://gitlab.cern.ch/atlas/athena/-/merge_requests/69638Add config to make Topo Towers at all eta2024-03-18T14:19:02+01:00Dylan Sheldon RankinAdd config to make Topo Towers at all etaThis MR adds a config that can be used to create topo towers without a restriction on eta while leaving the nominal forward topo towers untouched. This is needed for Upgrade studies/samples.
@mswiatlo @tmhong @sch @htorreThis MR adds a config that can be used to create topo towers without a restriction on eta while leaving the nominal forward topo towers untouched. This is needed for Upgrade studies/samples.
@mswiatlo @tmhong @sch @htorrehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/67602Update HepMcParticleLink to handle creation with GenParticle::id() as well as...2024-03-18T09:20:30+01:00John Derek ChapmanUpdate HepMcParticleLink to handle creation with GenParticle::id() as well as barcodesTransient HepMcParticleLink objects can now be built using either `GenParticle::id()` or the `GenParticle` barcode Attribute as the unique ID for the particle.
Eventually support for the barcode-based syntax will be restricted to legacy ...Transient HepMcParticleLink objects can now be built using either `GenParticle::id()` or the `GenParticle` barcode Attribute as the unique ID for the particle.
Eventually support for the barcode-based syntax will be restricted to legacy TP converter code. Until the migration is complete it is better to explicitly force the use of `HepMcParticleLink::IS_BARCODE` and `HepMcParticleLink::IS_ID` in the constructors in an attempt to ensure that the correct input is being provided.
HepMcParticleLink TP converters work for most use-cases. Some awkwardness for links to GenParticles that have been cut from the `McEventCollection`, mostly in deciding whether the unique ID is a barcode or an id. The value is preserved though, so the links can still be used to group EDM objects linked to the same truth particle.
Added `HepMcParticleLink_p3` and `HepMcParticleLinkCnv_p3` - based on `GenParticle::id()`. This works as well as the existing `HepMcParticleLink_p1/p2` versions. New persistent versions of other EDM classes which depend on HepMcParticleLink will be added in future merge requests.
Output matches except for the output of `DetailedTrackTruthBuilder`. This relies on sorting by HepMcParticleLinks. The old implementation sorted based on barcode, whereas the new implementation sorts based on `GenParticle::id()`. In some cases (quasi-stable particle simulation) the barcode-based ordering of GenParticles sometimes differs from the id-based ordering. This means that some objects appear in a different order in the output containers. I don't think that this is an issue, but I need to discuss with Tracking experts.
Once these changes are merged then it becomes simpler to migrate clients to be `id()`-based. It should be possible to do this in multiple smaller merge requests.
See ATLASSIM-6999, ATLASSIM-6912https://gitlab.cern.ch/atlas/athena/-/merge_requests/69536Update HepMcParticleLink interface and clients without changing behaviour2024-03-18T09:09:00+01:00John Derek ChapmanUpdate HepMcParticleLink interface and clients without changing behaviour!67602 adapts HepMcParticleLink to use `GenParticle::id()` internally rather than the old GenParticle barcodes from HEPMC2.
In some cases (particularly in the case of quasi-stable particle simulation), then the ordering of particles by b...!67602 adapts HepMcParticleLink to use `GenParticle::id()` internally rather than the old GenParticle barcodes from HEPMC2.
In some cases (particularly in the case of quasi-stable particle simulation), then the ordering of particles by barcode does not
always match the ordering of particles by id. This results in some containers which are ordered by `HepMcParticleLink` being slightly different after the change (same information different order). This merge request updates the HepMcParticleLink interface without updating the internals, allowing the clients to be updated without the output changing. A smaller output-changing merge request can then be made afterwards.
See ATLASSIM-6999.