athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2021-09-02T10:16:17+02:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/46129ATLFAST2: fudge energy ratio and eta range, to avoid rare run-time crashes2021-09-02T10:16:17+02:00Liza MijovicATLFAST2: fudge energy ratio and eta range, to avoid rare run-time crashesThis MR is to fix crashes in ART tests, as in [5372](https://its.cern.ch/jira/browse/ATLASSIM-5372)
ATLFAST2 gives a rare run-time crash when simulating photons close to the gap region. The ATLFAST2 is at the end of it's life, but we'll...This MR is to fix crashes in ART tests, as in [5372](https://its.cern.ch/jira/browse/ATLASSIM-5372)
ATLFAST2 gives a rare run-time crash when simulating photons close to the gap region. The ATLFAST2 is at the end of it's life, but we'll still want to use it a bit longer because of it's lower memory footprint. We therefore suggest to fudge the energy threshold and eta range as in this MR.
Committing the fix obo @mduehrss who proposed it.https://gitlab.cern.ch/atlas/athena/-/merge_requests/45780FATRAS: fix TRT building in complex geometry mode2022-03-10T11:24:08+01:00Liza MijovicFATRAS: fix TRT building in complex geometry modeThis is a bug-fix for TRT material layer building in FATRAS. The code should build a number of material layers (m_modelBarrelLayers) from a larger number of straw layers (nTotalBarrelLayers). It however uses a too large step (nMaterialLa...This is a bug-fix for TRT material layer building in FATRAS. The code should build a number of material layers (m_modelBarrelLayers) from a larger number of straw layers (nTotalBarrelLayers). It however uses a too large step (nMaterialLayerStep). Therefore an incorrect number of material layers is built.
The fix provides the correct step size, for each of TRT barrel and TRT endcaps, and issues a WARNING in case of the incorrect number of material layers.
Fix and implications were discussed at the [Fast Chain meeting](https://indico.cern.ch/event/1066823/contributions/4486007/attachments/2294182/3901486/Mijovic_FATRAS_13082021.pdf). The p5 of the linked slides shows a numerical example of why the original step was too large, p6 a numerical example of the fix. The bug only affects the TRT tracking geometry building for FATRAS. The TRT tracking geometry of reconstruction geometry is not affected, as this does not use the complex geometry fixed here.
@golling @pagacova @tcuhadar @jchapmanhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/45167remove unused MM_Response_DigitTool2021-07-16T14:28:32+02:00Patrick Scholerremove unused MM_Response_DigitToolThis MR removes the unused `MM_Response_DigitTool` which might cause warnings about random number seeds discussed in ATLASSIM-5311This MR removes the unused `MM_Response_DigitTool` which might cause warnings about random number seeds discussed in ATLASSIM-5311https://gitlab.cern.ch/atlas/athena/-/merge_requests/44011MdtDigitization - Use calibration tool by default2021-07-09T18:00:44+02:00Johannes Junggeburthjohannes.josef.junggeburth@cern.chMdtDigitization - Use calibration tool by defaultHi,
as discussed in ATLASRECTS-6203, a potential reason for the low MDT efficiencies in the run IV layout could be the usage of the default drift-time relations instead of the proper ones in the calibration database. From this MR on, we...Hi,
as discussed in ATLASRECTS-6203, a potential reason for the low MDT efficiencies in the run IV layout could be the usage of the default drift-time relations instead of the proper ones in the calibration database. From this MR on, we use the calibration tool by default and remove the property to switch it off optionally. These developments have been made by @nkoehler. They are his last ones before moving on to other tasks outside ATLAS. Marking the end of an era @minions:
![image](https://media.giphy.com/media/oW7fkm9V1sYEg/giphy.gif)
To continue the game philosopher of the day let me also mention: @goblirsc, @sroe, @npetters, @pgadow, @fsforza, @szambito, @sabidi, @gartoni, @mvanadia:
![image](/uploads/da005f12642ccee130fe9b9da2ef7b1f/image.png)https://gitlab.cern.ch/atlas/athena/-/merge_requests/43748FATRAS: update parent parameters after brem2021-06-01T01:02:36+02:00Liza MijovicFATRAS: update parent parameters after bremFATRAS parameters were not updated after brem, this MR fixes it.
- The implementation of brem parameters update is the same way as for the update after ionization/MS
- Changes discussed at FastChain MTG: https://indico.cern.ch/event/10...FATRAS parameters were not updated after brem, this MR fixes it.
- The implementation of brem parameters update is the same way as for the update after ionization/MS
- Changes discussed at FastChain MTG: https://indico.cern.ch/event/1041710/
- This fixes energy non-conservation in case of brem, @tcuhadar : will have visible effects on eg electron spectra
- 10-event test run log: /afs/cern.ch/work/l/lmijovic/public/sim/mr/brem_fix_43748
@pagacova @gollinghttps://gitlab.cern.ch/atlas/athena/-/merge_requests/43648TrigL0GepPerf: Add custom jet algorithm functionality2021-06-23T01:13:29+02:00Maria MazzaTrigL0GepPerf: Add custom jet algorithm functionalityAdded ability to include custom jet algorithms implemented in pure C++ and store the resulting jets in Athena containers for them to be accessible to downstream algorithms. This follows the same procedure that is used in TrigL0GepPerf to...Added ability to include custom jet algorithms implemented in pure C++ and store the resulting jets in Athena containers for them to be accessible to downstream algorithms. This follows the same procedure that is used in TrigL0GepPerf to add custom topoclustering algorithms.https://gitlab.cern.ch/atlas/athena/-/merge_requests/43533bug-fixes to FATRAS photon conversion screening functions2021-05-25T17:08:27+02:00Liza Mijovicbug-fixes to FATRAS photon conversion screening functions- ISF_FATRAS photon conversion screening functions had two bugs (incorrect signs) in screening function implementation
- The fixes were discussed at the fast chain meeting: https://indico.cern.ch/event/1037188/
- These fixes bring ISF_FA...- ISF_FATRAS photon conversion screening functions had two bugs (incorrect signs) in screening function implementation
- The fixes were discussed at the fast chain meeting: https://indico.cern.ch/event/1037188/
- These fixes bring ISF_FATRAS (closer) in line with GEANT4 and ACTS implementations
- Small effect on observable e/gamma distributions ( @tcuhadar : will cause a diff in FastChain nightly test )
@pagacova @gollinghttps://gitlab.cern.ch/atlas/athena/-/merge_requests/43247Deweight NSW hits in the TrackTruthSelector2021-05-10T18:04:36+02:00William Axel LeightDeweight NSW hits in the TrackTruthSelectorBecause there are many more hits in the NSW than there are in the other stations, they need to be deweighted here so they don't dominate the truth matching. The weight of 0.25 is chosen as there would be 24 hits expected in the NSW and 6...Because there are many more hits in the NSW than there are in the other stations, they need to be deweighted here so they don't dominate the truth matching. The weight of 0.25 is chosen as there would be 24 hits expected in the NSW and 6 MDT hits in one of the other stations. This should help to resolve the issues with poor efficiency reported in ATLASRECTS-5610.https://gitlab.cern.ch/atlas/athena/-/merge_requests/42961Cleanup of eFEX tau algorithm to work with cells2021-04-30T16:51:36+02:00Ben CarlsonCleanup of eFEX tau algorithm to work with cellshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/42887Bring FATRAS conversion child energy sharing code in-line with GEANT42021-05-10T18:05:47+02:00Liza MijovicBring FATRAS conversion child energy sharing code in-line with GEANT4Bug-fixes to FATRAS photon conversion, discussed and approved at FastChain meeting (https://indico.cern.ch/e/1032355)
- Bring the conversion child energy sharing code in-line with GEANT4: fix energy sharing cross-section function and sa...Bug-fixes to FATRAS photon conversion, discussed and approved at FastChain meeting (https://indico.cern.ch/e/1032355)
- Bring the conversion child energy sharing code in-line with GEANT4: fix energy sharing cross-section function and sampling formulas. The bug-fixes correspond to GEANT4 implementation (and are in-line with ACTS-fatras)
- Set m_childEnergyScaleFactor default to 1: modelling improved after bug-fixes above, SF of 2 no longer required. As SF=1 corresponds to GEANT4 behavior, we choose this as the default.
Test run on 10 single-photon events: /afs/cern.ch/work/l/lmijovic/public/sim/mr
tagging @pagacova @gollinghttps://gitlab.cern.ch/atlas/athena/-/merge_requests/42421Add some flags so we can work with phase II2021-04-14T14:57:57+02:00Ben CarlsonAdd some flags so we can work with phase IIhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/42384Fix issue with short index for IOVPayload PT conversion2021-04-30T16:59:19+02:00Joerg StelzerFix issue with short index for IOVPayload PT conversionThis applies the same fix to `Database/IOVDbPTCnv/ IOVPayloadContainerPTCnv_p1`
as it was already done for `Database/IOVDbTPCnv/ IOVPayloadContainerCnv_p1` in !37346
The related Jira ticket is ATR-22116
This should go into all releases...This applies the same fix to `Database/IOVDbPTCnv/ IOVPayloadContainerPTCnv_p1`
as it was already done for `Database/IOVDbTPCnv/ IOVPayloadContainerCnv_p1` in !37346
The related Jira ticket is ATR-22116
This should go into all releases.
cc @schaffer @adimitrihttps://gitlab.cern.ch/atlas/athena/-/merge_requests/42154Fix for BIS78: do not use COOL db for efficiency and cluster size for RUN3, s...2021-04-07T18:26:59+02:00Massimo CorradiFix for BIS78: do not use COOL db for efficiency and cluster size for RUN3, see also ATLASRECTS-5800Default behaviour is to load efficiency and cluster size from COOL, anyway efficiency and CS maps including BIS78 are not yet available for RUN3 and this gives because entries in the maps corresponding to BIS78 are missing.
Two new JO h...Default behaviour is to load efficiency and cluster size from COOL, anyway efficiency and CS maps including BIS78 are not yet available for RUN3 and this gives because entries in the maps corresponding to BIS78 are missing.
Two new JO have been introduced:
ClusterSize_BIS78_fromCOOL = false
Efficiency_BIS78_fromCOOL = false
this allows to take efficiency and CS for BIS78 from parameters that can be set by JO and have reasonable default values.
In addition I changed the default behaviour for RUN3/4 : we don't use efficiency and CS maps taken from COOL but default ones.
modified: MuonSpectrometer/MuonDigitization/RPC_Digitization/RPC_Digitization/RpcDigitizationTool.h
modified: MuonSpectrometer/MuonDigitization/RPC_Digitization/src/RpcDigitizationTool.cxxhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/41742Tight current PLImprovedVeryTight working point of muon2021-03-21T03:05:05+01:00Fudong HeTight current PLImprovedVeryTight working point of muonA recent study shows a tighter working point will give a better overall performance in the ttW ML analysis: [slides from Tamara at ttW meeting](https://indico.cern.ch/event/1018469/contributions/4279421/attachments/2210014/3740056/031621...A recent study shows a tighter working point will give a better overall performance in the ttW ML analysis: [slides from Tamara at ttW meeting](https://indico.cern.ch/event/1018469/contributions/4279421/attachments/2210014/3740056/031621_ttWML_PCTemplateFit_TVS.pdf).
Propose to tight current muon PLImprovedVeryTight working point as this MR.
Tagging @rustem ,@fcardill, @htorres, @yoyamagu, @pfalke and @tvazquezhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/41696Fix syntax in 21.3/9 muon ART geometry override2021-03-19T17:17:48+01:00Nicolas KoehlerFix syntax in 21.3/9 muon ART geometry overrideHi,
this MR fixes the syntax to override muon geometries in ART which was taken from a sweep from ~master where the syntax diverges.
Best, NicoHi,
this MR fixes the syntax to override muon geometries in ART which was taken from a sweep from ~master where the syntax diverges.
Best, Nicohttps://gitlab.cern.ch/atlas/athena/-/merge_requests/41605Manual sweep of !41572 and !41597 (Enable running full muon chain using phase...2021-03-17T10:41:11+01:00Nicolas KoehlerManual sweep of !41572 and !41597 (Enable running full muon chain using phase2 layout and add ART test)Hi,
since the automatic sweep of https://gitlab.cern.ch/atlas/athena/-/merge_requests/41572 and https://gitlab.cern.ch/atlas/athena/-/merge_requests/41597 into ~"21.3" and ~"21.9" will fail, here the manual sweep.
It enables running the...Hi,
since the automatic sweep of https://gitlab.cern.ch/atlas/athena/-/merge_requests/41572 and https://gitlab.cern.ch/atlas/athena/-/merge_requests/41597 into ~"21.3" and ~"21.9" will fail, here the manual sweep.
It enables running the full muon chain (sim/digi/reco) using the laatest amdb-based phase2 layout and adds an ART test for it.
More checks on the reconstruction output are needed before this can be combined with ITK+HGTD for phase2 upgrade physics studies.
Best, Nicohttps://gitlab.cern.ch/atlas/athena/-/merge_requests/41597Update number of sMDT tubes in phase2 layout2021-03-17T10:41:11+01:00Nicolas KoehlerUpdate number of sMDT tubes in phase2 layoutHi,
there was an update on the design of the phase2 sMDT chambers, cf. https://indico.cern.ch/event/858218/contributions/3626149/attachments/1940465/3217270/sMDT_ATLAS_param_v1.5.pdf
The BIS1 chambers are planned to contain 70tubes per...Hi,
there was an update on the design of the phase2 sMDT chambers, cf. https://indico.cern.ch/event/858218/contributions/3626149/attachments/1940465/3217270/sMDT_ATLAS_param_v1.5.pdf
The BIS1 chambers are planned to contain 70tubes per tubeLayer, the BIS2-6 chambers 58tubes per tubeLayer, adapting the IdDict file accordingly.
Best, Nicohttps://gitlab.cern.ch/atlas/athena/-/merge_requests/41572Enable running full muon chain using phase2 layout and add ART test2021-03-17T10:41:11+01:00Nicolas KoehlerEnable running full muon chain using phase2 layout and add ART testHi,
this MR enables running the full muon chain (sim/digi/reco) using the amdb-based phase2 layout and adds an ART test for it.
Best, NicoHi,
this MR enables running the full muon chain (sim/digi/reco) using the amdb-based phase2 layout and adds an ART test for it.
Best, Nicohttps://gitlab.cern.ch/atlas/athena/-/merge_requests/41309Set `cluster_z` to zero when outside gas volume.2021-03-20T03:02:41+01:00Vincent PascuzziSet `cluster_z` to zero when outside gas volume.Slightly wrong Fatras geometry results in z-value of hits to
be in some cases largely outside the TRT gas volume, leading
to crashes in ATLFASTIIF and ATLFASTIIF_G4MS simulators.
It is safe to simply set `cluster_z` to zero when this o...Slightly wrong Fatras geometry results in z-value of hits to
be in some cases largely outside the TRT gas volume, leading
to crashes in ATLFASTIIF and ATLFASTIIF_G4MS simulators.
It is safe to simply set `cluster_z` to zero when this occurs.
Fixes: ATLASSIM-4510https://gitlab.cern.ch/atlas/athena/-/merge_requests/41099Muon reconstruction fix association of hit information from the proper track2021-04-07T18:26:59+02:00Johannes Junggeburthjohannes.josef.junggeburth@cern.chMuon reconstruction fix association of hit information from the proper trackHi,
the Medium selection efficiency for standalone muons showed holes periodic along phi. The issue has been chased up and should be resolved in this MR. More details can be found in this presentation https://indico.cern.ch/event/981257...Hi,
the Medium selection efficiency for standalone muons showed holes periodic along phi. The issue has been chased up and should be resolved in this MR. More details can be found in this presentation https://indico.cern.ch/event/981257/contributions/4261023/
Cheers,
Johannes