athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2021-04-05T20:12:24+02:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/41168Draft: Radiation damage digitisation updates2021-04-05T20:12:24+02:00Tomas DadoDraft: Radiation damage digitisation updatesI opened this MR to start a discussion about potential speed up of the code.
The MR brings two things:
* A minor speed up by factoring out the HepMC links calculation form the loops (this was probably done by the compiler anyway) and a...I opened this MR to start a discussion about potential speed up of the code.
The MR brings two things:
* A minor speed up by factoring out the HepMC links calculation form the loops (this was probably done by the compiler anyway) and also adding a simple speed up by skipping loops where the ramo potentials for electrons and holes were set to 0 and the iduced charge was thus zero as well. The second part actually changes the digitisation output - probably due to floating point precision or some random numbers, but this impact only radiation code and the changes are tiny (0.1%).
* The second part of the MR is the main point for discussion. It adds two cutoff values that can be set via JO file. The allow to skip some loops and thus significanctly reduce the reunning time, however, they also impact the result. The cutoff values are for ramo potential diffence (induced charge), these are rather safe but gain only a bit of CPU time since they do not really skip loops just the expensive part of the chanrge addition. The other cut simply skips the digitisation if the deposited energy is smaller than the cutoff - this is obviously more dangerous but also gains huge speed up. E.g. I tested a setup where the number of charges was reduced by 1-1.5% and gained a speed of around 30%. By default, both of the cutoff values are set to -1 so no cut is applied. Note that this also adds small CPU processing time since the condition has to be evaluated in the loops and by default it will always return false.
After a discusion in yesterdays radiation damage meeting it was agree that the changes are ok (reminderL by default this will _not_ apply any cut).
Cheers,
Tomas
cc @tadej @bnachmanhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/40513update to handle year dependent TGC deadchamber list2021-04-14T11:33:21+02:00Kentaro Kawadeupdate to handle year dependent TGC deadchamber listhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/38486Activation of new deadmap folder (ATLASRECTS-5014)2021-01-25T10:42:09+01:00Soshi TsunoActivation of new deadmap folder (ATLASRECTS-5014)The deadmap format will be changed in rel.22.
The previous DB folder was /PIXEL/PixMapOverlay, and new folder /PIXEL/PixelModuleFeMask .
This new folder is not included in old global tag.
Thus, in the job option, the DB-tag is specified...The deadmap format will be changed in rel.22.
The previous DB folder was /PIXEL/PixMapOverlay, and new folder /PIXEL/PixelModuleFeMask .
This new folder is not included in old global tag.
Thus, in the job option, the DB-tag is specified, but this should be removed when the q-test update new global tag.
Unfortunately, q221 uses old global tag, OFLCOND-MC16-SDR-25, which associates PixMapOverlay-SIM-MC16-000-02.
But the RUN-2 best-knowledge tag is based on PixMapOverlay-SIM-MC16-000-03, and new deadmap conditions also based on this tag (-03).
Therefore, the q221 test will not pass T0 policy. The reference file is updated.
On the other hand, the data q431 is no problem.https://gitlab.cern.ch/atlas/athena/-/merge_requests/36196Divide ADC,TDC of sMDT with HPTDC digitization chip by 4 to give same ticksiz...2021-01-11T21:01:07+01:00Edward DiehlDivide ADC,TDC of sMDT with HPTDC digitization chip by 4 to give same ticksize as MDT chambersDivide ADC,TDC of sMDT with HPTDC digitization chip by 4 to give same ticksize as MDT chambers. This applies to BMG and new BIS7 chambers being installed in LS2, all of which use the HPTDC digitization chip. By adjusting ticksize in Pr...Divide ADC,TDC of sMDT with HPTDC digitization chip by 4 to give same ticksize as MDT chambers. This applies to BMG and new BIS7 chambers being installed in LS2, all of which use the HPTDC digitization chip. By adjusting ticksize in PrepRawData, reconstruction with these chambers will be done identically to other MDT chambers without further code changes. Hence, can remove special treatment of BMG in MdtCalibrationTool. Also modify MdtDigitizationTool so that BMG, BIS7 will use HPTDC ticksize in MC data. This change fixes reconstruction of BMG chambers by altering ADC values which causes timeslew correction to be made and ADC cuts to work. Due to altered ADC RunTier0Tests.py fails q431.ESD and q431.ESD tests, see attached log file.[RunTier0Tests.log](/uploads/7f42c94bee52062cff9734170129e394/RunTier0Tests.log)Nicolas KoehlerEdward DiehlNicolas Koehlerhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/28453RPC digitization for fractional charged particles2019-12-03T14:22:54+01:00Quanyin LiRPC digitization for fractional charged particlesAdd a correction factor of RPC efficiency for fractional charged particles.Add a correction factor of RPC efficiency for fractional charged particles.https://gitlab.cern.ch/atlas/athena/-/merge_requests/27498WIP:Update transient HepMcParticleLink to use unsigned int for eventIndex2021-03-02T13:20:43+01:00John Derek ChapmanWIP:Update transient HepMcParticleLink to use unsigned int for eventIndexhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/27145WIP:Update transient HepMcParticleLink to use unsigned int for eventIndex2021-03-01T19:17:31+01:00John Derek ChapmanWIP:Update transient HepMcParticleLink to use unsigned int for eventIndex