athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2020-01-29T14:51:00+01:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/28242WIP: Updates for ATLIDTRKCP-1742020-01-29T14:51:00+01:00Susumu OdaWIP: Updates for ATLIDTRKCP-174Updates for https://its.cern.ch/jira/browse/ATLIDTRKCP-174
* Implement remaining SCT changes of https://gitlab.cern.ch/atlas/athena/commit/3c8195a6b22683e5f616815f0d4ceaea6f923512#678f505287cc9b488bd548a3d0c17bf6b95d4a20
of ~21.9 in ...Updates for https://its.cern.ch/jira/browse/ATLIDTRKCP-174
* Implement remaining SCT changes of https://gitlab.cern.ch/atlas/athena/commit/3c8195a6b22683e5f616815f0d4ceaea6f923512#678f505287cc9b488bd548a3d0c17bf6b95d4a20
of ~21.9 in ~master.
* Previously, some changes were implemented by https://gitlab.cern.ch/atlas/athena/merge_requests/28054
* Remove obsolete stuff.
RunTier0Tests.py found differences.
* [RunTier0Tests.log](/uploads/e1185daa5550defd738764705c2b304e/RunTier0Tests.log)
* [diff-root-q221.RDO.log](/uploads/316be544fe7cd0ea25a0acde9b270cbb/diff-root-q221.RDO.log)
* [diff-root-q221.ESD.log](/uploads/e636e66b8b2054beec3306a86bc40dae/diff-root-q221.ESD.log)
* [diff-root-q221.AOD.log](/uploads/3bc8957829cd074c8675c7219b79683d/diff-root-q221.AOD.log)
* q431 ESD files have many differences (240 MB)
* [diff-root-q431.AOD.log](/uploads/907a587e1e6fb5c1d51eedcb85ef764b/diff-root-q431.AOD.log)
```
[lxplus766 run] acmd.py diff-pool /tmp/oda/clean_run_q221_79cc4174-f312-4d79-bf2e-1c5f30483e32/myRDO.pool.root run_q221/myRDO.pool.root
Py:Acmd INFO running sub-command [diff-pool]...
## opening file [/tmp/oda/clean_run_q221_79cc4174-f312-4d79-bf2e-1c5f30483e32/myRDO.pool.root]...
## importing ROOT...
## importing ROOT... [DONE]
## opening file [OK]
## opening file [run_q221/myRDO.pool.root]...
## importing ROOT...
## importing ROOT... [DONE]
## opening file [OK]
================================================================================
::: Comparing POOL files...
ref : /tmp/oda/clean_run_q221_79cc4174-f312-4d79-bf2e-1c5f30483e32/myRDO.pool.root
chk : run_q221/myRDO.pool.root
--------------------------------------------------------------------------------
::: comparing common content (mem-size)...
================================================================================
## Comparison : [OK]
[lxplus766 run] acmd.py diff-pool /tmp/oda/clean_run_q221_79cc4174-f312-4d79-bf2e-1c5f30483e32/myESD.pool.root run_q221/myESD.pool.root
Py:Acmd INFO running sub-command [diff-pool]...
## opening file [/tmp/oda/clean_run_q221_79cc4174-f312-4d79-bf2e-1c5f30483e32/myESD.pool.root]...
## importing ROOT...
## importing ROOT... [DONE]
## opening file [OK]
## opening file [run_q221/myESD.pool.root]...
## importing ROOT...
## importing ROOT... [DONE]
## opening file [OK]
================================================================================
::: Comparing POOL files...
ref : /tmp/oda/clean_run_q221_79cc4174-f312-4d79-bf2e-1c5f30483e32/myESD.pool.root
chk : run_q221/myESD.pool.root
--------------------------------------------------------------------------------
::: comparing common content (mem-size)...
[ERR] 20.161 kb (ref) ==> 20.536 kb (chk) | CaloClusterCellLinkContainer_p1_MuonClusterCollection_links
[ERR] 1.771 kb (ref) ==> 1.775 kb (chk) | DataVector<xAOD::CaloCluster_v1>_MuonClusterCollection
[ERR] 16.360 kb (ref) ==> 16.274 kb (chk) | xAOD::BTagVertexAuxContainer_v1_BTagging_AntiKt4EMTopoJFVtxAux.
[ERR] 4.569 kb (ref) ==> 4.542 kb (chk) | xAOD::BTaggingAuxContainer_v1_BTagging_AntiKt4EMTopoAuxDyn.JetFitter_JFvertices
[ERR] 5.094 kb (ref) ==> 5.090 kb (chk) | xAOD::BTaggingAuxContainer_v1_BTagging_AntiKt4EMTopoAuxDyn.JetFitter_fittedCov
[ERR] 5.132 kb (ref) ==> 5.128 kb (chk) | xAOD::BTaggingAuxContainer_v1_BTagging_AntiKt4EMTopoAuxDyn.JetFitter_fittedPosition
[ERR] 3.464 kb (ref) ==> 3.491 kb (chk) | xAOD::BTaggingAuxContainer_v1_BTagging_AntiKt4EMTopoAuxDyn.Muons
[ERR] 11.887 kb (ref) ==> 11.980 kb (chk) | xAOD::CaloClusterAuxContainer_v2_MuonClusterCollectionAux.
[ERR] 7.293 kb (ref) ==> 7.301 kb (chk) | xAOD::CaloClusterAuxContainer_v2_MuonClusterCollectionAuxDyn.CellLink
[ERR] 5.358 kb (ref) ==> 5.417 kb (chk) | xAOD::CaloClusterAuxContainer_v2_MuonClusterCollectionAuxDyn.constituentClusterLinks
[ERR] 3.437 kb (ref) ==> 3.468 kb (chk) | xAOD::CaloClusterAuxContainer_v2_MuonClusterCollectionAuxDyn.eta_sampl
[ERR] 3.437 kb (ref) ==> 3.468 kb (chk) | xAOD::CaloClusterAuxContainer_v2_MuonClusterCollectionAuxDyn.phi_sampl
[ERR] 83.058 kb (ref) ==> 83.269 kb (chk) | xAOD::MissingETAuxAssociationMap_v2_METAssoc_AntiKt4EMPFlowAux.
[ERR] 79.471 kb (ref) ==> 79.635 kb (chk) | xAOD::MissingETAuxAssociationMap_v2_METAssoc_AntiKt4EMTopoAux.
[ERR] 81.624 kb (ref) ==> 81.788 kb (chk) | xAOD::MissingETAuxAssociationMap_v2_METAssoc_AntiKt4LCTopoAux.
[ERR] 49.728 kb (ref) ==> 49.985 kb (chk) | xAOD::MuonAuxContainer_v5_MuonsAux.
[ERR] 1.584 kb (ref) ==> 1.588 kb (chk) | xAOD::MuonAuxContainer_v5_MuonsAuxDyn.CT_EL_Type
[ERR] 1.584 kb (ref) ==> 1.588 kb (chk) | xAOD::MuonAuxContainer_v5_MuonsAuxDyn.CT_ET_Core
[ERR] 1.680 kb (ref) ==> 1.684 kb (chk) | xAOD::MuonAuxContainer_v5_MuonsAuxDyn.CT_ET_FSRCandidateEnergy
[ERR] 1.639 kb (ref) ==> 1.643 kb (chk) | xAOD::MuonAuxContainer_v5_MuonsAuxDyn.CT_ET_LRLikelihood
[ERR] 1.563 kb (ref) ==> 1.567 kb (chk) | xAOD::MuonAuxContainer_v5_MuonsAuxDyn.ET_Core
[ERR] 1.577 kb (ref) ==> 1.581 kb (chk) | xAOD::MuonAuxContainer_v5_MuonsAuxDyn.ET_EMCore
[ERR] 1.584 kb (ref) ==> 1.588 kb (chk) | xAOD::MuonAuxContainer_v5_MuonsAuxDyn.ET_HECCore
[ERR] 1.591 kb (ref) ==> 1.595 kb (chk) | xAOD::MuonAuxContainer_v5_MuonsAuxDyn.ET_TileCore
[ERR] 1.646 kb (ref) ==> 1.649 kb (chk) | xAOD::MuonAuxContainer_v5_MuonsAuxDyn.FSR_CandidateEnergy
[ERR] 1.618 kb (ref) ==> 1.622 kb (chk) | xAOD::MuonAuxContainer_v5_MuonsAuxDyn.InnerDetectorPt
[ERR] 1.639 kb (ref) ==> 1.643 kb (chk) | xAOD::MuonAuxContainer_v5_MuonsAuxDyn.MuonSpectrometerPt
[ERR] 1.600 kb (ref) ==> 1.601 kb (chk) | xAOD::MuonAuxContainer_v5_MuonsAuxDyn.combinedTrackOutBoundsPrecisionHits
[ERR] 1.570 kb (ref) ==> 1.574 kb (chk) | xAOD::MuonAuxContainer_v5_MuonsAuxDyn.d0_staco
[ERR] 1.584 kb (ref) ==> 1.588 kb (chk) | xAOD::MuonAuxContainer_v5_MuonsAuxDyn.deltaphi_0
[ERR] 1.584 kb (ref) ==> 1.588 kb (chk) | xAOD::MuonAuxContainer_v5_MuonsAuxDyn.deltaphi_1
[ERR] 1.598 kb (ref) ==> 1.602 kb (chk) | xAOD::MuonAuxContainer_v5_MuonsAuxDyn.deltatheta_0
[ERR] 1.598 kb (ref) ==> 1.602 kb (chk) | xAOD::MuonAuxContainer_v5_MuonsAuxDyn.deltatheta_1
[ERR] 1.570 kb (ref) ==> 1.574 kb (chk) | xAOD::MuonAuxContainer_v5_MuonsAuxDyn.etcone20
[ERR] 1.570 kb (ref) ==> 1.574 kb (chk) | xAOD::MuonAuxContainer_v5_MuonsAuxDyn.etcone30
[ERR] 1.570 kb (ref) ==> 1.574 kb (chk) | xAOD::MuonAuxContainer_v5_MuonsAuxDyn.etcone40
[ERR] 1.625 kb (ref) ==> 1.629 kb (chk) | xAOD::MuonAuxContainer_v5_MuonsAuxDyn.etconeCorrBitset
[ERR] 1.721 kb (ref) ==> 1.725 kb (chk) | xAOD::MuonAuxContainer_v5_MuonsAuxDyn.etconecoreMuonEnergyCorrection
[ERR] 1.538 kb (ref) ==> 1.539 kb (chk) | xAOD::MuonAuxContainer_v5_MuonsAuxDyn.extendedClosePrecisionHits
[ERR] 1.565 kb (ref) ==> 1.566 kb (chk) | xAOD::MuonAuxContainer_v5_MuonsAuxDyn.extendedOutBoundsPrecisionHits
[ERR] 1.518 kb (ref) ==> 1.519 kb (chk) | xAOD::MuonAuxContainer_v5_MuonsAuxDyn.innerClosePrecisionHits
[ERR] 1.545 kb (ref) ==> 1.546 kb (chk) | xAOD::MuonAuxContainer_v5_MuonsAuxDyn.innerOutBoundsPrecisionHits
[ERR] 1.483 kb (ref) ==> 1.484 kb (chk) | xAOD::MuonAuxContainer_v5_MuonsAuxDyn.isEndcapGoodLayers
[ERR] 1.483 kb (ref) ==> 1.484 kb (chk) | xAOD::MuonAuxContainer_v5_MuonsAuxDyn.isSmallGoodSectors
[ERR] 1.524 kb (ref) ==> 1.525 kb (chk) | xAOD::MuonAuxContainer_v5_MuonsAuxDyn.middleClosePrecisionHits
[ERR] 1.552 kb (ref) ==> 1.553 kb (chk) | xAOD::MuonAuxContainer_v5_MuonsAuxDyn.middleOutBoundsPrecisionHits
[ERR] 1.632 kb (ref) ==> 1.636 kb (chk) | xAOD::MuonAuxContainer_v5_MuonsAuxDyn.nUnspoiledCscHits
[ERR] 1.598 kb (ref) ==> 1.602 kb (chk) | xAOD::MuonAuxContainer_v5_MuonsAuxDyn.neflowisol20
[ERR] 1.598 kb (ref) ==> 1.602 kb (chk) | xAOD::MuonAuxContainer_v5_MuonsAuxDyn.neflowisol30
[ERR] 1.598 kb (ref) ==> 1.602 kb (chk) | xAOD::MuonAuxContainer_v5_MuonsAuxDyn.neflowisol40
[ERR] 1.652 kb (ref) ==> 1.656 kb (chk) | xAOD::MuonAuxContainer_v5_MuonsAuxDyn.neflowisolCorrBitset
[ERR] 1.748 kb (ref) ==> 1.752 kb (chk) | xAOD::MuonAuxContainer_v5_MuonsAuxDyn.neflowisolcoreConeEnergyCorrection
[ERR] 2.580 kb (ref) ==> 2.584 kb (chk) | xAOD::MuonAuxContainer_v5_MuonsAuxDyn.nphiMatchedHitsPerChamberLayer
[ERR] 3.206 kb (ref) ==> 3.210 kb (chk) | xAOD::MuonAuxContainer_v5_MuonsAuxDyn.nprecMatchedHitsPerChamberLayer
[ERR] 2.607 kb (ref) ==> 2.611 kb (chk) | xAOD::MuonAuxContainer_v5_MuonsAuxDyn.ntrigEtaMatchedHitsPerChamberLayer
[ERR] 1.659 kb (ref) ==> 1.663 kb (chk) | xAOD::MuonAuxContainer_v5_MuonsAuxDyn.numEnergyLossPerTrack
[ERR] 1.545 kb (ref) ==> 1.546 kb (chk) | xAOD::MuonAuxContainer_v5_MuonsAuxDyn.numberOfGoodPrecisionLayers
[ERR] 1.518 kb (ref) ==> 1.519 kb (chk) | xAOD::MuonAuxContainer_v5_MuonsAuxDyn.outerClosePrecisionHits
[ERR] 1.545 kb (ref) ==> 1.546 kb (chk) | xAOD::MuonAuxContainer_v5_MuonsAuxDyn.outerOutBoundsPrecisionHits
[ERR] 1.584 kb (ref) ==> 1.588 kb (chk) | xAOD::MuonAuxContainer_v5_MuonsAuxDyn.phi0_staco
[ERR] 1.570 kb (ref) ==> 1.574 kb (chk) | xAOD::MuonAuxContainer_v5_MuonsAuxDyn.ptcone20
[ERR] 1.570 kb (ref) ==> 1.574 kb (chk) | xAOD::MuonAuxContainer_v5_MuonsAuxDyn.ptcone30
[ERR] 1.570 kb (ref) ==> 1.574 kb (chk) | xAOD::MuonAuxContainer_v5_MuonsAuxDyn.ptcone40
[ERR] 1.625 kb (ref) ==> 1.629 kb (chk) | xAOD::MuonAuxContainer_v5_MuonsAuxDyn.ptconeCorrBitset
[ERR] 1.707 kb (ref) ==> 1.711 kb (chk) | xAOD::MuonAuxContainer_v5_MuonsAuxDyn.ptconecoreTrackPtrCorrection
[ERR] 1.591 kb (ref) ==> 1.595 kb (chk) | xAOD::MuonAuxContainer_v5_MuonsAuxDyn.ptvarcone20
[ERR] 1.591 kb (ref) ==> 1.595 kb (chk) | xAOD::MuonAuxContainer_v5_MuonsAuxDyn.ptvarcone30
[ERR] 1.591 kb (ref) ==> 1.595 kb (chk) | xAOD::MuonAuxContainer_v5_MuonsAuxDyn.ptvarcone40
[ERR] 1.618 kb (ref) ==> 1.622 kb (chk) | xAOD::MuonAuxContainer_v5_MuonsAuxDyn.qOverPErr_staco
[ERR] 1.598 kb (ref) ==> 1.602 kb (chk) | xAOD::MuonAuxContainer_v5_MuonsAuxDyn.qOverP_staco
[ERR] 1.618 kb (ref) ==> 1.622 kb (chk) | xAOD::MuonAuxContainer_v5_MuonsAuxDyn.sigmadeltaphi_0
[ERR] 1.618 kb (ref) ==> 1.622 kb (chk) | xAOD::MuonAuxContainer_v5_MuonsAuxDyn.sigmadeltaphi_1
[ERR] 1.632 kb (ref) ==> 1.636 kb (chk) | xAOD::MuonAuxContainer_v5_MuonsAuxDyn.sigmadeltatheta_0
[ERR] 1.632 kb (ref) ==> 1.636 kb (chk) | xAOD::MuonAuxContainer_v5_MuonsAuxDyn.sigmadeltatheta_1
[ERR] 1.591 kb (ref) ==> 1.595 kb (chk) | xAOD::MuonAuxContainer_v5_MuonsAuxDyn.theta_staco
[ERR] 1.598 kb (ref) ==> 1.602 kb (chk) | xAOD::MuonAuxContainer_v5_MuonsAuxDyn.topoetcone20
[ERR] 1.598 kb (ref) ==> 1.602 kb (chk) | xAOD::MuonAuxContainer_v5_MuonsAuxDyn.topoetcone30
[ERR] 1.598 kb (ref) ==> 1.602 kb (chk) | xAOD::MuonAuxContainer_v5_MuonsAuxDyn.topoetcone40
[ERR] 1.652 kb (ref) ==> 1.656 kb (chk) | xAOD::MuonAuxContainer_v5_MuonsAuxDyn.topoetconeCorrBitset
[ERR] 1.748 kb (ref) ==> 1.752 kb (chk) | xAOD::MuonAuxContainer_v5_MuonsAuxDyn.topoetconecoreConeEnergyCorrection
[ERR] 1.591 kb (ref) ==> 1.595 kb (chk) | xAOD::MuonAuxContainer_v5_MuonsAuxDyn.truthOrigin
[ERR] 6.842 kb (ref) ==> 6.850 kb (chk) | xAOD::MuonAuxContainer_v5_MuonsAuxDyn.truthParticleLink
[ERR] 1.577 kb (ref) ==> 1.581 kb (chk) | xAOD::MuonAuxContainer_v5_MuonsAuxDyn.truthType
[ERR] 1.570 kb (ref) ==> 1.574 kb (chk) | xAOD::MuonAuxContainer_v5_MuonsAuxDyn.z0_staco
================================================================================
## Comparison : [ERR]
[lxplus766 run] acmd.py diff-pool /tmp/oda/clean_run_q221_79cc4174-f312-4d79-bf2e-1c5f30483e32/myAOD.pool.root run_q221/myAOD.pool.root
Py:Acmd INFO running sub-command [diff-pool]...
## opening file [/tmp/oda/clean_run_q221_79cc4174-f312-4d79-bf2e-1c5f30483e32/myAOD.pool.root]...
## importing ROOT...
## importing ROOT... [DONE]
## opening file [OK]
## opening file [run_q221/myAOD.pool.root]...
## importing ROOT...
## importing ROOT... [DONE]
## opening file [OK]
================================================================================
::: Comparing POOL files...
ref : /tmp/oda/clean_run_q221_79cc4174-f312-4d79-bf2e-1c5f30483e32/myAOD.pool.root
chk : run_q221/myAOD.pool.root
--------------------------------------------------------------------------------
::: comparing common content (mem-size)...
[ERR] 254.070 kb (ref) ==> 254.168 kb (chk) | AODCellContainer
[ERR] 4.103 kb (ref) ==> 4.075 kb (chk) | BTagging_AntiKt4EMTopoAuxDyn.JetFitter_JFvertices
[ERR] 4.629 kb (ref) ==> 4.625 kb (chk) | BTagging_AntiKt4EMTopoAuxDyn.JetFitter_fittedCov
[ERR] 4.657 kb (ref) ==> 4.653 kb (chk) | BTagging_AntiKt4EMTopoAuxDyn.JetFitter_fittedPosition
[ERR] 2.881 kb (ref) ==> 2.908 kb (chk) | BTagging_AntiKt4EMTopoAuxDyn.Muons
[ERR] 15.915 kb (ref) ==> 15.829 kb (chk) | BTagging_AntiKt4EMTopoJFVtxAux.
[ERR] 82.667 kb (ref) ==> 82.878 kb (chk) | METAssoc_AntiKt4EMPFlowAux.
[ERR] 79.225 kb (ref) ==> 79.389 kb (chk) | METAssoc_AntiKt4EMTopoAux.
[ERR] 81.378 kb (ref) ==> 81.542 kb (chk) | METAssoc_AntiKt4LCTopoAux.
[ERR] 1.339 kb (ref) ==> 1.343 kb (chk) | MuonClusterCollection
[ERR] 11.446 kb (ref) ==> 11.540 kb (chk) | MuonClusterCollectionAux.
[ERR] 5.413 kb (ref) ==> 5.421 kb (chk) | MuonClusterCollectionAuxDyn.CellLink
[ERR] 4.702 kb (ref) ==> 4.761 kb (chk) | MuonClusterCollectionAuxDyn.constituentClusterLinks
[ERR] 2.821 kb (ref) ==> 2.853 kb (chk) | MuonClusterCollectionAuxDyn.eta_sampl
[ERR] 2.821 kb (ref) ==> 2.853 kb (chk) | MuonClusterCollectionAuxDyn.phi_sampl
[ERR] 19.724 kb (ref) ==> 20.099 kb (chk) | MuonClusterCollection_links
[ERR] 49.458 kb (ref) ==> 49.716 kb (chk) | MuonsAux.
[ERR] 1.197 kb (ref) ==> 1.201 kb (chk) | MuonsAuxDyn.CT_EL_Type
[ERR] 1.197 kb (ref) ==> 1.201 kb (chk) | MuonsAuxDyn.CT_ET_Core
[ERR] 1.266 kb (ref) ==> 1.270 kb (chk) | MuonsAuxDyn.CT_ET_FSRCandidateEnergy
[ERR] 1.236 kb (ref) ==> 1.240 kb (chk) | MuonsAuxDyn.CT_ET_LRLikelihood
[ERR] 1.183 kb (ref) ==> 1.187 kb (chk) | MuonsAuxDyn.ET_Core
[ERR] 1.192 kb (ref) ==> 1.196 kb (chk) | MuonsAuxDyn.ET_EMCore
[ERR] 1.197 kb (ref) ==> 1.201 kb (chk) | MuonsAuxDyn.ET_HECCore
[ERR] 1.202 kb (ref) ==> 1.206 kb (chk) | MuonsAuxDyn.ET_TileCore
[ERR] 1.241 kb (ref) ==> 1.245 kb (chk) | MuonsAuxDyn.FSR_CandidateEnergy
[ERR] 1.222 kb (ref) ==> 1.226 kb (chk) | MuonsAuxDyn.InnerDetectorPt
[ERR] 1.236 kb (ref) ==> 1.240 kb (chk) | MuonsAuxDyn.MuonSpectrometerPt
[ERR] 1.164 kb (ref) ==> 1.165 kb (chk) | MuonsAuxDyn.combinedTrackOutBoundsPrecisionHits
[ERR] 1.188 kb (ref) ==> 1.191 kb (chk) | MuonsAuxDyn.d0_staco
[ERR] 1.197 kb (ref) ==> 1.201 kb (chk) | MuonsAuxDyn.deltaphi_0
[ERR] 1.197 kb (ref) ==> 1.201 kb (chk) | MuonsAuxDyn.deltaphi_1
[ERR] 1.207 kb (ref) ==> 1.211 kb (chk) | MuonsAuxDyn.deltatheta_0
[ERR] 1.207 kb (ref) ==> 1.211 kb (chk) | MuonsAuxDyn.deltatheta_1
[ERR] 1.188 kb (ref) ==> 1.191 kb (chk) | MuonsAuxDyn.etcone20
[ERR] 1.188 kb (ref) ==> 1.191 kb (chk) | MuonsAuxDyn.etcone30
[ERR] 1.188 kb (ref) ==> 1.191 kb (chk) | MuonsAuxDyn.etcone40
[ERR] 1.227 kb (ref) ==> 1.230 kb (chk) | MuonsAuxDyn.etconeCorrBitset
[ERR] 1.295 kb (ref) ==> 1.299 kb (chk) | MuonsAuxDyn.etconecoreMuonEnergyCorrection
[ERR] 1.120 kb (ref) ==> 1.121 kb (chk) | MuonsAuxDyn.extendedClosePrecisionHits
[ERR] 1.140 kb (ref) ==> 1.141 kb (chk) | MuonsAuxDyn.extendedOutBoundsPrecisionHits
[ERR] 1.105 kb (ref) ==> 1.106 kb (chk) | MuonsAuxDyn.innerClosePrecisionHits
[ERR] 1.125 kb (ref) ==> 1.126 kb (chk) | MuonsAuxDyn.innerOutBoundsPrecisionHits
[ERR] 1.081 kb (ref) ==> 1.082 kb (chk) | MuonsAuxDyn.isEndcapGoodLayers
[ERR] 1.081 kb (ref) ==> 1.082 kb (chk) | MuonsAuxDyn.isSmallGoodSectors
[ERR] 1.110 kb (ref) ==> 1.111 kb (chk) | MuonsAuxDyn.middleClosePrecisionHits
[ERR] 1.130 kb (ref) ==> 1.131 kb (chk) | MuonsAuxDyn.middleOutBoundsPrecisionHits
[ERR] 1.231 kb (ref) ==> 1.235 kb (chk) | MuonsAuxDyn.nUnspoiledCscHits
[ERR] 1.207 kb (ref) ==> 1.211 kb (chk) | MuonsAuxDyn.neflowisol20
[ERR] 1.207 kb (ref) ==> 1.211 kb (chk) | MuonsAuxDyn.neflowisol30
[ERR] 1.207 kb (ref) ==> 1.211 kb (chk) | MuonsAuxDyn.neflowisol40
[ERR] 1.246 kb (ref) ==> 1.250 kb (chk) | MuonsAuxDyn.neflowisolCorrBitset
[ERR] 1.314 kb (ref) ==> 1.318 kb (chk) | MuonsAuxDyn.neflowisolcoreConeEnergyCorrection
[ERR] 2.154 kb (ref) ==> 2.158 kb (chk) | MuonsAuxDyn.nphiMatchedHitsPerChamberLayer
[ERR] 2.628 kb (ref) ==> 2.632 kb (chk) | MuonsAuxDyn.nprecMatchedHitsPerChamberLayer
[ERR] 2.174 kb (ref) ==> 2.178 kb (chk) | MuonsAuxDyn.ntrigEtaMatchedHitsPerChamberLayer
[ERR] 1.251 kb (ref) ==> 1.255 kb (chk) | MuonsAuxDyn.numEnergyLossPerTrack
[ERR] 1.125 kb (ref) ==> 1.126 kb (chk) | MuonsAuxDyn.numberOfGoodPrecisionLayers
[ERR] 1.105 kb (ref) ==> 1.106 kb (chk) | MuonsAuxDyn.outerClosePrecisionHits
[ERR] 1.125 kb (ref) ==> 1.126 kb (chk) | MuonsAuxDyn.outerOutBoundsPrecisionHits
[ERR] 1.197 kb (ref) ==> 1.201 kb (chk) | MuonsAuxDyn.phi0_staco
[ERR] 1.188 kb (ref) ==> 1.191 kb (chk) | MuonsAuxDyn.ptcone20
[ERR] 1.188 kb (ref) ==> 1.191 kb (chk) | MuonsAuxDyn.ptcone30
[ERR] 1.207 kb (ref) ==> 1.211 kb (chk) | MuonsAuxDyn.topoetcone30
[ERR] 1.207 kb (ref) ==> 1.211 kb (chk) | MuonsAuxDyn.topoetcone40
[ERR] 1.246 kb (ref) ==> 1.250 kb (chk) | MuonsAuxDyn.topoetconeCorrBitset
[ERR] 1.314 kb (ref) ==> 1.318 kb (chk) | MuonsAuxDyn.topoetconecoreConeEnergyCorrection
[ERR] 1.202 kb (ref) ==> 1.206 kb (chk) | MuonsAuxDyn.truthOrigin
[ERR] 5.242 kb (ref) ==> 5.250 kb (chk) | MuonsAuxDyn.truthParticleLink
[ERR] 1.192 kb (ref) ==> 1.196 kb (chk) | MuonsAuxDyn.truthType
[ERR] 1.188 kb (ref) ==> 1.191 kb (chk) | MuonsAuxDyn.z0_staco
================================================================================
## Comparison : [ERR]
[lxplus766 run] acmd.py diff-pool /tmp/oda/clean_run_q431_79cc4174-f312-4d79-bf2e-1c5f30483e32/myESD.pool.root run_q431/myESD.pool.root
Py:Acmd INFO running sub-command [diff-pool]...
## opening file [/tmp/oda/clean_run_q431_79cc4174-f312-4d79-bf2e-1c5f30483e32/myESD.pool.root]...
## importing ROOT...
## importing ROOT... [DONE]
## opening file [OK]
## opening file [run_q431/myESD.pool.root]...
## importing ROOT...
## importing ROOT... [DONE]
## opening file [OK]
================================================================================
::: Comparing POOL files...
ref : /tmp/oda/clean_run_q431_79cc4174-f312-4d79-bf2e-1c5f30483e32/myESD.pool.root
chk : run_q431/myESD.pool.root
--------------------------------------------------------------------------------
::: comparing common content (mem-size)...
[ERR] 39.986 kb (ref) ==> 40.010 kb (chk) | DataVector<xAOD::TrackParticle_v1>_InDetTrackParticles
[ERR] 115.447 kb (ref) ==> 115.490 kb (chk) | InDet::PixelGangedClusterAmbiguities_p1_SplitClusterAmbiguityMap
[ERR] 99886.720 kb (ref) ==> 99954.090 kb (chk) | Trk::TrackCollection_tlp6_CombinedInDetTracks
[ERR] 126.259 kb (ref) ==> 126.396 kb (chk) | xAOD::JetAuxContainer_v1_AntiKt10LCTopoJetsAuxDyn.GhostTrack
[ERR] 2009.658 kb (ref) ==> 2010.871 kb (chk) | xAOD::TrackParticleAuxContainer_v5_InDetTrackParticlesAux.
[ERR] 40.533 kb (ref) ==> 40.557 kb (chk) | xAOD::TrackParticleAuxContainer_v5_InDetTrackParticlesAuxDyn.TRTdEdx
[ERR] 11.488 kb (ref) ==> 11.651 kb (chk) | xAOD::TrackParticleAuxContainer_v5_InDetTrackParticlesAuxDyn.TRTdEdxUsedHits
[ERR] 40.544 kb (ref) ==> 40.567 kb (chk) | xAOD::TrackParticleAuxContainer_v5_InDetTrackParticlesAuxDyn.nBC_meas
[ERR] 85.186 kb (ref) ==> 85.232 kb (chk) | xAOD::TrackParticleAuxContainer_v5_InDetTrackParticlesAuxDyn.trackLink
================================================================================
## Comparison : [ERR]
[lxplus766 run] acmd.py diff-pool /tmp/oda/clean_run_q431_79cc4174-f312-4d79-bf2e-1c5f30483e32/myAOD.pool.root run_q431/myAOD.pool.root
Py:Acmd INFO running sub-command [diff-pool]...
## opening file [/tmp/oda/clean_run_q431_79cc4174-f312-4d79-bf2e-1c5f30483e32/myAOD.pool.root]...
## importing ROOT...
## importing ROOT... [DONE]
## opening file [OK]
## opening file [run_q431/myAOD.pool.root]...
## importing ROOT...
## importing ROOT... [DONE]
## opening file [OK]
================================================================================
::: Comparing POOL files...
ref : /tmp/oda/clean_run_q431_79cc4174-f312-4d79-bf2e-1c5f30483e32/myAOD.pool.root
chk : run_q431/myAOD.pool.root
--------------------------------------------------------------------------------
::: comparing common content (mem-size)...
[ERR] 39.056 kb (ref) ==> 39.079 kb (chk) | InDetTrackParticles
[ERR] 1980.189 kb (ref) ==> 1981.402 kb (chk) | InDetTrackParticlesAux.
[ERR] 39.452 kb (ref) ==> 39.476 kb (chk) | InDetTrackParticlesAuxDyn.TRTdEdx
[ERR] 10.664 kb (ref) ==> 10.670 kb (chk) | InDetTrackParticlesAuxDyn.TRTdEdxUsedHits
[ERR] 39.462 kb (ref) ==> 39.485 kb (chk) | InDetTrackParticlesAuxDyn.nBC_meas
[ERR] 81.895 kb (ref) ==> 81.941 kb (chk) | InDetTrackParticlesAuxDyn.trackLink
================================================================================
## Comparison : [ERR]
```
Validation will be done.https://gitlab.cern.ch/atlas/athena/-/merge_requests/31456WIP: Move Jet and MET reco sequences into views2020-04-14T11:23:44+02:00Benjamin Michael WynneWIP: Move Jet and MET reco sequences into viewsAlternative approach to !31170, hopefully without causing the same problems, and fitting more generally with the HLT menu.
Replaces the jet input marker alg with an EventViewCreator, and modifies the HLT MT hypothesis algorithm to loa...Alternative approach to !31170, hopefully without causing the same problems, and fitting more generally with the HLT menu.
Replaces the jet input marker alg with an EventViewCreator, and modifies the HLT MT hypothesis algorithm to load jets from a view. (Thanks to @tamartin for instructions)
Similar modifications to MET.
Likely to break stuff, but I want to see the CI test results. Should also change/fix some problems with muon slice.https://gitlab.cern.ch/atlas/athena/-/merge_requests/37591Correcting allowed b-tag values and adding ERROR exit of the code when no pro...2020-11-03T11:43:41+01:00Malik AlievCorrecting allowed b-tag values and adding ERROR exit of the code when no proper chain bit(s) foundAs the title says, correcting allowed b-tag values and adding ERROR exit of the code when no proper chain bit(s) found. This is related to curing of the problem risen in the JIRAs !ATR-22165 and !ATR-22180.As the title says, correcting allowed b-tag values and adding ERROR exit of the code when no proper chain bit(s) found. This is related to curing of the problem risen in the JIRAs !ATR-22165 and !ATR-22180.https://gitlab.cern.ch/atlas/athena/-/merge_requests/38646Add PFlow Jvt chains2020-12-02T13:49:50+01:00Jonathan BossioAdd PFlow Jvt chainsThis would help to carry on the studies summarized in ATR-22434
If possible, it would be good to have it merged in on time for the production of the next AthenaMT validation round.
@valentemThis would help to carry on the studies summarized in ATR-22434
If possible, it would be good to have it merged in on time for the production of the next AthenaMT validation round.
@valentemhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/38707Partial fulfilment of reporting jet hypo passing jets "by leg"2020-12-03T11:00:46+01:00Peter SherwoodPartial fulfilment of reporting jet hypo passing jets "by leg"See title
ATR-20700
The final reporting of the jets is not yet in place.
This MR contains the modifications to how jets are collected.
These modifications will allow the jets to be reported as requested.
@bossio @valentem @khoo @tamart...See title
ATR-20700
The final reporting of the jets is not yet in place.
This MR contains the modifications to how jets are collected.
These modifications will allow the jets to be reported as requested.
@bossio @valentem @khoo @tamartin @peterPeter SherwoodPeter Sherwoodhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/38947New ringer low et tuning files2020-12-14T21:56:36+01:00Micael Verissimo De AraujoNew ringer low et tuning filesThis MR is related to Ringer migration (ART-20143).
The main change is the ringer selector files to be used in TrigEgammaFastCaloHypoTool.
The new files are TrigL2_20201018_r3, the suffix r3 indicates the third release of Ringer which ...This MR is related to Ringer migration (ART-20143).
The main change is the ringer selector files to be used in TrigEgammaFastCaloHypoTool.
The new files are TrigL2_20201018_r3, the suffix r3 indicates the third release of Ringer which contains the models for ET higher, and below 15 GeV.
Pinning @fernando, @cjmeyer and @jodafons.https://gitlab.cern.ch/atlas/athena/-/merge_requests/39185WIP: Ringer new tunings configs2020-12-22T21:14:21+01:00Micael Verissimo De AraujoWIP: Ringer new tunings configsThis MR is related to ATR-20143 and has the objective to change the ringer configuration files in order to use the new low energy models.
The tests are passing and the counts were updated.
I'm pinning @fernando, @cjmeyer and @jodafonsThis MR is related to ATR-20143 and has the objective to change the ringer configuration files in order to use the new low energy models.
The tests are passing and the counts were updated.
I'm pinning @fernando, @cjmeyer and @jodafonshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/39509Add L0 and L1 ,if they fall inside *any* of the range for the Barrel or...2021-01-07T06:49:30+01:00Christos Anastopouloschristos.anastopoulos@cern.chAdd L0 and L1 ,if they fall inside *any* of the range for the Barrel or...Add L0 and L1 ,if they fall inside *any* of the range for the Barrel or Endcap. Should fix ATLASRECTS-5870
Closes ATLASRECTS-5870
Should be reviewed / merged only after
https://gitlab.cern.ch/atlas/athena/-/merge_requests/39480
gets...Add L0 and L1 ,if they fall inside *any* of the range for the Barrel or Endcap. Should fix ATLASRECTS-5870
Closes ATLASRECTS-5870
Should be reviewed / merged only after
https://gitlab.cern.ch/atlas/athena/-/merge_requests/39480
gets merged.
I expect some small changes in egamma particles cluster energy
Mentioning @turra @jmaurerhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/39420Tile ROBs order dependency fixed2021-01-15T14:00:44+01:00Denis Oliveira DamazioTile ROBs order dependency fixedFixing issue for Tile cal unpacking. As noted in other JIRAs and, in particular, noted in this one : ATR-22496, Tile cells seem to be different depending on the unpacking order.
Even worst, it seems like an old setEnergy method (probably...Fixing issue for Tile cal unpacking. As noted in other JIRAs and, in particular, noted in this one : ATR-22496, Tile cells seem to be different depending on the unpacking order.
Even worst, it seems like an old setEnergy method (probably from CaloCells) that was deprecated seems to be completely wrongly used, resulting in mixture of energy and time variables for D0 cells.
@solodkov and @harkusha need to look at it.
I tested with different order of unpacking (ROBs presentation) and it is stable now.
Best Regards,
DenisDenis Oliveira DamazioDenis Oliveira Damaziohttps://gitlab.cern.ch/atlas/athena/-/merge_requests/38486Activation of new deadmap folder (ATLASRECTS-5014)2021-01-25T10:42:09+01:00Soshi TsunoActivation of new deadmap folder (ATLASRECTS-5014)The deadmap format will be changed in rel.22.
The previous DB folder was /PIXEL/PixMapOverlay, and new folder /PIXEL/PixelModuleFeMask .
This new folder is not included in old global tag.
Thus, in the job option, the DB-tag is specified...The deadmap format will be changed in rel.22.
The previous DB folder was /PIXEL/PixMapOverlay, and new folder /PIXEL/PixelModuleFeMask .
This new folder is not included in old global tag.
Thus, in the job option, the DB-tag is specified, but this should be removed when the q-test update new global tag.
Unfortunately, q221 uses old global tag, OFLCOND-MC16-SDR-25, which associates PixMapOverlay-SIM-MC16-000-02.
But the RUN-2 best-knowledge tag is based on PixMapOverlay-SIM-MC16-000-03, and new deadmap conditions also based on this tag (-03).
Therefore, the q221 test will not pass T0 policy. The reference file is updated.
On the other hand, the data q431 is no problem.https://gitlab.cern.ch/atlas/athena/-/merge_requests/39935fix for applying NTrack cut in tau perf chains2021-01-24T15:43:36+01:00Antonio De Mariafix for applying NTrack cut in tau perf chainsFix for applying Ntrack cut in tau perf chains:
before the fix:
* "idperf" : pass all events
* "perf" : pass all events
after the fix:
* "idperf" pass all events
* "perf" : apply Ntrack cut but no TauID cut
pinging @carquin and @malco...Fix for applying Ntrack cut in tau perf chains:
before the fix:
* "idperf" : pass all events
* "perf" : pass all events
after the fix:
* "idperf" pass all events
* "perf" : apply Ntrack cut but no TauID cut
pinging @carquin and @malconad
Updating reference count files : decreasing count of tau "perf" chains as expectedhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/39770Jet Hypo configuration refactorisation2021-01-28T15:17:24+01:00Peter SherwoodJet Hypo configuration refactorisationAdd root node to jet chain labels
Allow only one ComoundCondition specification per node tree node.
Avoids the need to split multi-CompoundCondition nodes.
ATR-22634
@jbossios @valentem @khoo @peterAdd root node to jet chain labels
Allow only one ComoundCondition specification per node tree node.
Avoids the need to split multi-CompoundCondition nodes.
ATR-22634
@jbossios @valentem @khoo @peterPeter SherwoodPeter Sherwoodhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/39683WIP Jet Hypo: add Phi Condition - possible use: define a hole in the detector.2021-01-28T15:21:35+01:00Peter SherwoodWIP Jet Hypo: add Phi Condition - possible use: define a hole in the detector.The new Phi Condition together with an eta Condition and Condition Inverter will make it possible to mask off Eta-Phi regions of the detector when running the jet hypo.
@jbossio @valentem @khoo @peterThe new Phi Condition together with an eta Condition and Condition Inverter will make it possible to mask off Eta-Phi regions of the detector when running the jet hypo.
@jbossio @valentem @khoo @peterPeter SherwoodPeter Sherwoodhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/40118removing manual tau track assignement2021-01-31T02:34:51+01:00Antonio De Mariaremoving manual tau track assignementThis MR removes a tau jet <-> track association done manually together with TauTrackFinder.
Manual association is leading to double counting of tracks for "tracktwo" and "track" chains as shown here:
https://atlas.web.cern.ch/Atlas/proj...This MR removes a tau jet <-> track association done manually together with TauTrackFinder.
Manual association is leading to double counting of tracks for "tracktwo" and "track" chains as shown here:
https://atlas.web.cern.ch/Atlas/project/trigger/trigcaf/www/ATR-22624/TrigTauRecMerged_TauPrecision_Track/nRoI_EFTauTracks.html
https://atlas.web.cern.ch/Atlas/project/trigger/trigcaf/www/ATR-22624/TrigTauRecMerged_TauPrecision_TrackTwo/nRoI_EFTauTracks.html
After removing, distributions look correct
pinging @malconad, @carquin and @martindlhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/41237Fix the Tau second stage Roi sizes2021-03-06T21:28:48+01:00Mark SuttonFix the Tau second stage Roi sizesThe second stage tau Roi is intended to be wider than the first stage Tau Roi,
this adds configurable parameters to allow the second stage Roi size to be
adjusted.
At present, the second stage tau Roi takes it eta and phi widths from th...The second stage tau Roi is intended to be wider than the first stage Tau Roi,
this adds configurable parameters to allow the second stage Roi size to be
adjusted.
At present, the second stage tau Roi takes it eta and phi widths from the first stage Roi, but tightens the Roi in z at the beamline, and is thus a strict subset of the first stage Roi meaning the second stage tracking would not be needed at all. This increases the Roi eta-phi width for the second stage taus.
As a result of increasing the second stage Roi width, the tau counts will likely change. These will be updated once the CI tests have executed.https://gitlab.cern.ch/atlas/athena/-/merge_requests/41322fix 2tau+met chain (ATR-22966)2021-03-07T20:56:51+01:00Daniele Zanzifix 2tau+met chain (ATR-22966)addition of 2tau+met chain with a fix in the merging step provided by @hrusselladdition of 2tau+met chain with a fix in the merging step provided by @hrussellhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/41475small fix in noalg chain name (ATR-22305)2021-03-11T13:23:20+01:00Daniele Zanzismall fix in noalg chain name (ATR-22305)trivial change in name of noalg chains as requested by Tiletrivial change in name of noalg chains as requested by Tilehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/41364Switch to the new configuration for the ID Trigger2021-03-31T13:12:52+02:00Mark SuttonSwitch to the new configuration for the ID TriggerAdded additional variables and implemented the fetching of the
configuration from the Config Settings for the InDetTrigConfig code
and the FTF Configuration
Parameters can be set in pre-includes etc using eg
```
from InDetTrigConfig.Conf...Added additional variables and implemented the fetching of the
configuration from the Config Settings for the InDetTrigConfig code
and the FTF Configuration
Parameters can be set in pre-includes etc using eg
```
from InDetTrigConfig.ConfgSettings import getInDetTrigConfig ; getInDetTrigConfig("Muon")._etaHalfWidth = 0.1
```
Also, for these changes we rename many of the variable, such that they more
properly correspond to the variables that they are actually being set to make
it clearer what is being set and wherehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/42109ATR-23120: comment out VBF chains for now2021-04-06T15:08:50+02:00Heather RussellATR-23120: comment out VBF chains for nowTemporary fix for ATR-23120Temporary fix for ATR-23120https://gitlab.cern.ch/atlas/athena/-/merge_requests/41873WIP: Switch to default use of the adaptive multi vetex finder in the trigger2021-04-09T00:04:00+02:00Mark SuttonWIP: Switch to default use of the adaptive multi vetex finder in the triggerAdd a new option to allow the vertex collection name to be set from a config flag,
and change the default vertex from the iterative to the adaptive multi vertex finder as discussed in ATR-23022, ATR-23018.
NB: this change might be expec...Add a new option to allow the vertex collection name to be set from a config flag,
and change the default vertex from the iterative to the adaptive multi vertex finder as discussed in ATR-23022, ATR-23018.
NB: this change might be expected to change the counts for the jets, bjets and MET
slices in the tests.
(Leave as a WIP until we are ready to actually make the switch)