athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2019-10-16T03:02:13+02:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/27186Avoid double inclusion of PixelConfigCondAlg2019-10-16T03:02:13+02:00Tulay Cuhadar DonszelmannAvoid double inclusion of PixelConfigCondAlgThe problem is discussed in https://its.cern.ch/jira/browse/ATLASSIM-4320.
Due to double adding of the PixelConfigCondAlg, FastChain tests fail in master. The fix is provided for that.
Adding @jchapman, @tlari, @vpascuzzThe problem is discussed in https://its.cern.ch/jira/browse/ATLASSIM-4320.
Due to double adding of the PixelConfigCondAlg, FastChain tests fail in master. The fix is provided for that.
Adding @jchapman, @tlari, @vpascuzzhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/27185Some factorisation of the muon trigger decoding sequence2019-10-17T03:02:23+02:00Savanna ShawSome factorisation of the muon trigger decoding sequenceMoving slightly the decoding for the muon triggers to be within the individual menu sequences instead of within the algorithm sequences, and allowing to pass the RoI name to the decoding sequence. This will be needed for the late muon tr...Moving slightly the decoding for the muon triggers to be within the individual menu sequences instead of within the algorithm sequences, and allowing to pass the RoI name to the decoding sequence. This will be needed for the late muon triggers (ATR-17553).
Also removed the 'eventAlg' setup of the decoding, as it doesn't seem to be used anywhere.https://gitlab.cern.ch/atlas/athena/-/merge_requests/27180MET Offline DQ2019-11-29T03:02:36+01:00Marianna TestaMET Offline DQhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/27177JetEventAthenaPool: Migrate to templated converters where possible.2019-10-15T03:02:09+02:00Scott SnyderJetEventAthenaPool: Migrate to templated converters where possible.Use templated pool converters from AthenaPoolCnvSvc.Use templated pool converters from AthenaPoolCnvSvc.https://gitlab.cern.ch/atlas/athena/-/merge_requests/27176TileRecAlgs+TileEvent: Remove #define private.2019-10-15T03:02:14+02:00Scott SnyderTileRecAlgs+TileEvent: Remove #define private.Remove non-standard use of #define private.
Declare default move ops for TileRawEvent + other extensions.Remove non-standard use of #define private.
Declare default move ops for TileRawEvent + other extensions.https://gitlab.cern.ch/atlas/athena/-/merge_requests/27175TPTools+AthenaPoolCnvSvc: Fix cppcheck warnings.2019-10-15T03:02:24+02:00Scott SnyderTPTools+AthenaPoolCnvSvc: Fix cppcheck warnings.Prefer preincrement to postincrement for iterators.Prefer preincrement to postincrement for iterators.https://gitlab.cern.ch/atlas/athena/-/merge_requests/27174xAODBTaggingAthenaPool: Remove unneeded custom pool converters.2019-10-15T03:02:08+02:00Scott SnyderxAODBTaggingAthenaPool: Remove unneeded custom pool converters.xAOD objects no longer need custom pool converters.
Remove those that are no longer needed.
Change xAOD converters with versioning to use the templated pool converter,
and make the TP class interfaces const.xAOD objects no longer need custom pool converters.
Remove those that are no longer needed.
Change xAOD converters with versioning to use the templated pool converter,
and make the TP class interfaces const.https://gitlab.cern.ch/atlas/athena/-/merge_requests/27173xAODTrigRingerAthenaPool: Remove unneeded custom pool converters.2019-10-15T03:01:56+02:00Scott SnyderxAODTrigRingerAthenaPool: Remove unneeded custom pool converters.xAOD objects no longer need custom pool converters.
Remove those that are no longer needed.
Change xAOD converters with versioning to use the templated pool converter,
and make the TP class interfaces const.xAOD objects no longer need custom pool converters.
Remove those that are no longer needed.
Change xAOD converters with versioning to use the templated pool converter,
and make the TP class interfaces const.https://gitlab.cern.ch/atlas/athena/-/merge_requests/27171Athena-dependency free trigger config libs2019-12-13T03:01:59+01:00Joerg StelzerAthena-dependency free trigger config libsL1 software will need to use the packages TrigConfIO (configuration loader), TrigConfData (configuration data), and implicitly TrigConfBase. But they do not want to introduce a dependency on athena. By setting a cmake flag ```BuildWithou...L1 software will need to use the packages TrigConfIO (configuration loader), TrigConfData (configuration data), and implicitly TrigConfBase. But they do not want to introduce a dependency on athena. By setting a cmake flag ```BuildWithoutAthena``` AthenaKernel (for creating CLID) will not be included and linked.
Alternatively I could create a package TrigConfDataAth that includes the classes from TrigConfData and adds the CLASSDEF. And I could get rid of the tests in TrigConfMessaging and remove the dependence on TrigConfBase.
Tagging @fwinkl , @akraszna , @ssnyder for advice.https://gitlab.cern.ch/atlas/athena/-/merge_requests/27169Add timing measurement to the summary algorithm2019-10-16T03:02:15+02:00Tomasz BoldAdd timing measurement to the summary algorithmTwo things fixed here. Number of. TimeStamp method that was supposed to return milliseconds now does so. Before it was micro second. Uff.
Secondly, timing histograms were added to summary making algs.Two things fixed here. Number of. TimeStamp method that was supposed to return milliseconds now does so. Before it was micro second. Uff.
Secondly, timing histograms were added to summary making algs.https://gitlab.cern.ch/atlas/athena/-/merge_requests/27168LArPileUpTool , static -> static const2019-10-15T03:01:58+02:00Christos Anastopouloschristos.anastopoulos@cern.chLArPileUpTool , static -> static constJust change a few ``static`` to ``static const``Just change a few ``static`` to ``static const``https://gitlab.cern.ch/atlas/athena/-/merge_requests/27167Allow chains that do not have any steps2019-10-16T03:02:04+02:00Tomasz BoldAllow chains that do not have any stepsWhile trying to add chains to the menu that do not have any steps this was the only place in which the fix was needed.
Tagging @fpastore @tamartin
In the next step we can use it to build streamers and other technical chains that are ess...While trying to add chains to the menu that do not have any steps this was the only place in which the fix was needed.
Tagging @fpastore @tamartin
In the next step we can use it to build streamers and other technical chains that are essentially costless.https://gitlab.cern.ch/atlas/athena/-/merge_requests/27163Temporary fix for ATLASRECTS-5160 also for e/gamma pile-up ART tests2019-10-16T03:02:18+02:00Christos Anastopouloschristos.anastopoulos@cern.chTemporary fix for ATLASRECTS-5160 also for e/gamma pile-up ART testsApply temporary fix for ATLASRECTS-5160 also for the e/gamma pile-up ART tests.Apply temporary fix for ATLASRECTS-5160 also for the e/gamma pile-up ART tests.https://gitlab.cern.ch/atlas/athena/-/merge_requests/27161TileMonitoring: Update Tile MBTS monitoring for Run32019-10-15T03:02:10+02:00Siarhei HarkushaTileMonitoring: Update Tile MBTS monitoring for Run3Tile MBTS monitoring algorithm for run 3 has been updated
in order to not fill histograms per MBTS cell by default
and to avoid using Tile digits container if filling of histograms
per MBTS cell is not requested.
Tests of Tile MBTS moni...Tile MBTS monitoring algorithm for run 3 has been updated
in order to not fill histograms per MBTS cell by default
and to avoid using Tile digits container if filling of histograms
per MBTS cell is not requested.
Tests of Tile MBTS monitoring and Tile timing with jets monitoring
algorithms for run 3 have been fixed (avoid using trigger here).https://gitlab.cern.ch/atlas/athena/-/merge_requests/27160AthenaMonitoringKernel: Fix MonitoredCollection2019-10-15T03:02:11+02:00Siarhei HarkushaAthenaMonitoringKernel: Fix MonitoredCollectionCorrected check if element type in collection is convertible to double.Corrected check if element type in collection is convertible to double.https://gitlab.cern.ch/atlas/athena/-/merge_requests/27159Be more explicit on what energy is used , instead of relying on different emF...2019-10-15T03:02:13+02:00Christos Anastopouloschristos.anastopoulos@cern.chBe more explicit on what energy is used , instead of relying on different emFrac definitionsIn Various places different definition of EM energy were used depending on the flavour of EMFrac.
The default EMFrac does not include the presampler as EM layer (used EMB1,2,3, EME1,2,3).
Be explicit on what energy is used in each stage...In Various places different definition of EM energy were used depending on the flavour of EMFrac.
The default EMFrac does not include the presampler as EM layer (used EMB1,2,3, EME1,2,3).
Be explicit on what energy is used in each stage.
Also for central electrons/photons we prb want to have some energy in the second layer for the seed topo clustershttps://gitlab.cern.ch/atlas/athena/-/merge_requests/27158New message counter for Trigger ART tests2019-10-15T03:02:06+02:00Rafal Bielskirafal.bielski@cern.chNew message counter for Trigger ART testsAs requested in ATR-17076, adding a new script to count messages inside event loop. Summary of the counts per level is printed and saved to JSON. A new step is added in the TrigValSteering framework (ATR-20038) which runs the script and ...As requested in ATR-17076, adding a new script to count messages inside event loop. Summary of the counts per level is printed and saved to JSON. A new step is added in the TrigValSteering framework (ATR-20038) which runs the script and compares the counts to given thresholds. If thresholds are exceeded, this ART test step will return a non-zero code. It will be executed for all Trigger ART tests based on TrigValSteering.
Also removing the predecessor of this script - RunMsgFinder.py from TrigP1Test.https://gitlab.cern.ch/atlas/athena/-/merge_requests/27155Fixed algorithm to include BCID in the HLT and included some test algorithm t...2019-10-24T03:02:06+02:00Denis Oliveira DamazioFixed algorithm to include BCID in the HLT and included some test algorithm to compare offline and online cellsFixed algorithm to include BCID in the HLT and included some test algorithm to compare offline and online cellsFixed algorithm to include BCID in the HLT and included some test algorithm to compare offline and online cellshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/27154update Gaudi to v32r2.0022019-10-15T03:02:01+02:00Charles Leggettupdate Gaudi to v32r2.002new tag for xenv that works with Python 3new tag for xenv that works with Python 3https://gitlab.cern.ch/atlas/athena/-/merge_requests/27153introducing new Mdt Monitorig Algorithm for Run3/athenaMT2019-11-05T03:02:20+01:00Michela Bigliettiintroducing new Mdt Monitorig Algorithm for Run3/athenaMTFirst introduction of MDT Raw data algorithm for Run3 DQ Monitoring. It has been locally tested with tens of events against the latest master nightly.
https://its.cern.ch/jira/browse/ATLASDQ-689First introduction of MDT Raw data algorithm for Run3 DQ Monitoring. It has been locally tested with tens of events against the latest master nightly.
https://its.cern.ch/jira/browse/ATLASDQ-689