athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2022-06-08T17:31:26+02:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/53488Master flip tagger implementation hl2022-06-08T17:31:26+02:00Angela Maria BurgerMaster flip tagger implementation hlImplement the flip version of the High-Level b-taggers in Rel.22Implement the flip version of the High-Level b-taggers in Rel.22https://gitlab.cern.ch/atlas/athena/-/merge_requests/53484Ported ITk detailed hit info from 21.92022-05-23T09:52:21+02:00Thomas StreblerPorted ITk detailed hit info from 21.9Porting `DetailedHitInfo` from 21.9, originally developed by @ncalace, which allows to save extra hit-level information customised for the ITk layout.
FYI @pagessin @lgagnonPorting `DetailedHitInfo` from 21.9, originally developed by @ncalace, which allows to save extra hit-level information customised for the ITk layout.
FYI @pagessin @lgagnonhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/52695Update the expected properties of G4AtlasAlg in test_AtlasG4_tf_configuration...2022-04-29T00:14:52+02:00John Derek ChapmanUpdate the expected properties of G4AtlasAlg in test_AtlasG4_tf_configuration after !52585This should fix the failing unit test.
Tagging @abarton.This should fix the failing unit test.
Tagging @abarton.https://gitlab.cern.ch/atlas/athena/-/merge_requests/51125Draft: EventBookkeeperTools: lower log level Fix ATLASRECTS-68732022-03-15T14:52:13+01:00Frank Berghausfrank.berghaus@cern.chDraft: EventBookkeeperTools: lower log level Fix ATLASRECTS-6873Should the FileMetaData object be missing from the input file's metadata we can recover. Thus, the message informing the user about the missing object should be DEBUG.
@gemmerenShould the FileMetaData object be missing from the input file's metadata we can recover. Thus, the message informing the user about the missing object should be DEBUG.
@gemmerenhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/50228Move AthenaPool setup to CA2022-06-13T15:09:52+02:00Stewart Martin-HaughMove AthenaPool setup to CAChange from old to new-style configuration. Tested to give identical python configuration.Change from old to new-style configuration. Tested to give identical python configuration.https://gitlab.cern.ch/atlas/athena/-/merge_requests/49182Remove obsolete ObjectBrowser, remove print_function, cleanup2022-05-04T13:20:45+02:00Stewart Martin-HaughRemove obsolete ObjectBrowser, remove print_function, cleanupMainly removing print_function (a python 2 helper function to allow migration to python 3). Also remove ObjectBrowser, which doesn't load - I don't know what the exact equivalent is in more recent Python...Mainly removing print_function (a python 2 helper function to allow migration to python 3). Also remove ObjectBrowser, which doesn't load - I don't know what the exact equivalent is in more recent Python...https://gitlab.cern.ch/atlas/athena/-/merge_requests/49108Wrapping CaloRecoConfig, next attempt2021-12-20T13:04:00+01:00Walter LamplWrapping CaloRecoConfig, next attemptAttempt to wrap CaloRecoConfig from RecExCommon.
The AOD compares identical, tiny difference in the ESD as discussed below.
Replaces !48455Attempt to wrap CaloRecoConfig from RecExCommon.
The AOD compares identical, tiny difference in the ESD as discussed below.
Replaces !48455https://gitlab.cern.ch/atlas/athena/-/merge_requests/47900Draft: Remove const cast and add map to TrackingGeometry2022-02-22T15:10:48+01:00Robert Johannes LangenbergDraft: Remove const cast and add map to TrackingGeometryThis PR removes Surface::associatedLayer() and adds a map<Surface*, Layer*> to the TrackingGeometry. All calls to Surface::associatedLayer() have been replaced by a call to TrackingGeometry::associatedLayer(). While my tests show that 70...This PR removes Surface::associatedLayer() and adds a map<Surface*, Layer*> to the TrackingGeometry. All calls to Surface::associatedLayer() have been replaced by a call to TrackingGeometry::associatedLayer(). While my tests show that 7000 calls (avg number of calls per event in q431) to a map with 7000 entries takes just 0.0005s (std::map) respectively 0.0001s (std::unordered_map), I'm not sure about the impact of having to retrieve the TrackingGeometry in places this was not necessary before.
This PR for starters should run all tests to see if the results are good.
If this produces the desired results, the Surface::associateLayer method should also be removed.https://gitlab.cern.ch/atlas/athena/-/merge_requests/47532Draft: Add support for CLI arguments to TrigValSteering ART test framework2022-01-25T15:27:54+01:00Rafal Bielskirafal.bielski@cern.chDraft: Add support for CLI arguments to TrigValSteering ART test frameworkImplement features requested in ATR-24229
Draft for now. To do:
* test thoroughly in all combinations
* add unit test for CLI parsing
* integrate the new parsing with the custom TrigInDetValidation parsing on top in a way that doesn't b...Implement features requested in ATR-24229
Draft for now. To do:
* test thoroughly in all combinations
* add unit test for CLI parsing
* integrate the new parsing with the custom TrigInDetValidation parsing on top in a way that doesn't break any TIDV feature
* add more arguments if requested
* update TrigValSteering README
* document in Trigger Developer Guide
* add option `--input-info` to list all possible inputs from `TrigValInputs.json`https://gitlab.cern.ch/atlas/athena/-/merge_requests/47430Basic connections among graph nodes added2021-10-28T13:40:15+02:00Witold Wojciech PrzygodaBasic connections among graph nodes addedCreating IM - H nodes (decision objects) within a proxy object. Creating "seed" edges between current node and its parents / children nodes.Creating IM - H nodes (decision objects) within a proxy object. Creating "seed" edges between current node and its parents / children nodes.https://gitlab.cern.ch/atlas/athena/-/merge_requests/46275Draft: Merge new components into old rather than old components into new2021-11-29T18:09:55+01:00John Derek ChapmanDraft: Merge new components into old rather than old components into newAfter the discussion in the configuration meeting of 3rd September 2021 on why the order of the Detector Tools in the `GeoModelSvc.DetectorTools` ToolHandleArrya was reversed in the CA-based configuration compared to the old-style config...After the discussion in the configuration meeting of 3rd September 2021 on why the order of the Detector Tools in the `GeoModelSvc.DetectorTools` ToolHandleArrya was reversed in the CA-based configuration compared to the old-style configuration, we found an inconsistency in the `deduplicate` method, which merged existing components into new components, rather than new components into the existing versions.
This merge request changes that, so that the ordering now agrees (unfortunately it didn't fix the FATAL errors I was seeing though).
I'm leaving this as a draft for now in case there was some reason that the function was written in that way.
FYI @wlampl, @tbold, @emoyse, @tadejhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/44954Include fwd towers per default in AODs2021-07-19T18:36:40+02:00Chris Malena DelitzschInclude fwd towers per default in AODsThis MR replaces the long preExec used for the second round CP tuning samples
'ESDtoAOD:from CaloRec.CaloRecFlags import jobproperties;jobproperties.CaloRecFlags.Enabled.set_Value_and_Lock(True);jobproperties.CaloRecFlags.doCaloTopoClu...This MR replaces the long preExec used for the second round CP tuning samples
'ESDtoAOD:from CaloRec.CaloRecFlags import jobproperties;jobproperties.CaloRecFlags.Enabled.set_Value_and_Lock(True);jobproperties.CaloRecFlags.doCaloTopoCluster.set_Value_and_Lock(False);jobproperties.CaloRecFlags.doCaloTowerFromCluster.set_Value_and_Lock(False);jobproperties.CaloRecFlags.doCaloTopoTower.set_Value_and_Lock(True);jobproperties.CaloRecFlags.doCaloFwdTopoTower.set_Value_and_Lock(True);'
and includes towers now per default in the AODs (tested using q221 test). Towers are now produced in the RAWtoESD step and then stored in the AODs. This also avoids the issue reported in ATLASRECTS-6451 where CaloCalTopoTowers were stored by accident when using the above command.
Tagging @mswiatlo @wbalunas @sawyer @loch @tchowdhu @wlampl @mhodgkin for their information and in case of feedback.https://gitlab.cern.ch/atlas/athena/-/merge_requests/44411AthenaCommon: Force create ClassIDSvc2021-06-25T17:47:30+02:00Frank WinklmeierAthenaCommon: Force create ClassIDSvcAdd `ClassIDSvc` to the `CreateSvc` list to ensure it gets initialized
early in the job. This fixes a problem seen when running the HLT from
the trigger database where the `ClassIDSvc` is used by the
`ByteStreamAddressProviderSvc` before...Add `ClassIDSvc` to the `CreateSvc` list to ensure it gets initialized
early in the job. This fixes a problem seen when running the HLT from
the trigger database where the `ClassIDSvc` is used by the
`ByteStreamAddressProviderSvc` before it has been initialized.
Fixes ATR-23634.https://gitlab.cern.ch/atlas/athena/-/merge_requests/43721Draft: Change AthenaMP chunk size default to dispatch cluster of events for LZMA2021-05-26T17:41:40+02:00Peter Van GemmerenDraft: Change AthenaMP chunk size default to dispatch cluster of events for LZMAThis change will have default AthenaMP dispatch chunks of events equal to auto-flush when reading LZMA compressed data (most data PxAOD and up) to avoid duplicating de-compression work.
For Run3 this is most applicable for derivation, wh...This change will have default AthenaMP dispatch chunks of events equal to auto-flush when reading LZMA compressed data (most data PxAOD and up) to avoid duplicating de-compression work.
For Run3 this is most applicable for derivation, which will be run in AthenaMP on LZMA data with 100 events per cluster.https://gitlab.cern.ch/atlas/athena/-/merge_requests/43664Small optimisation for TDT chain group search2021-05-20T17:05:26+02:00Benjamin Michael WynneSmall optimisation for TDT chain group searchFollowing ATR-23427 and related discussion, a (potential) improvement to the string searching approach when ChainGroups are updated.
@tamartin or @akraszna if you have the time could you compare with current performance? I don't expect ...Following ATR-23427 and related discussion, a (potential) improvement to the string searching approach when ChainGroups are updated.
@tamartin or @akraszna if you have the time could you compare with current performance? I don't expect much change, but I'd be interested to see what happens.https://gitlab.cern.ch/atlas/athena/-/merge_requests/42713Draft: Tier0Tests modernisation and cleanup2021-11-28T15:15:45+01:00Tadej Novaktadej.novak@cern.chDraft: Tier0Tests modernisation and cleanupTier0 tests (`RunTier0Tests.py`) are a popular and nice tool but which unfortunately got a bit too big. In an effort to make the infrastructure reusable (for example for `RunUpgradeTests.py`) I started some cleanup. The idea is to have o...Tier0 tests (`RunTier0Tests.py`) are a popular and nice tool but which unfortunately got a bit too big. In an effort to make the infrastructure reusable (for example for `RunUpgradeTests.py`) I started some cleanup. The idea is to have object-based base infrastructure which can then be implemented for individual tests.
For now I created a base `Tier0Test` which can be executed in a clean or patched environment. The overlay test was ported over and integrated in the existing steering.
@amete, does this look similar enough to what you proposed?
/cc @jchapman @nstyleshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/42008Draft: A first try for adding an EventContext aware shallowCopy. The bit clun...2021-03-26T23:40:46+01:00Christos Anastopouloschristos.anastopoulos@cern.chDraft: A first try for adding an EventContext aware shallowCopy. The bit clunky part...A first try for adding an EventContext aware shallowCopy.
The bit clunky part is the AnalysisBase cases where we do not really have an ``EventContext``
that can be used.
We move the implementation in one common functions
Then we have...A first try for adding an EventContext aware shallowCopy.
The bit clunky part is the AnalysisBase cases where we do not really have an ``EventContext``
that can be used.
We move the implementation in one common functions
Then we have
- Function accepting cont and EventContext, this is available only for ``Athena``, returning smart ptr.
- Function accepting cont and ptr to EventContext, this is usable from AnalysisBase , although the ptr is ``nullptr`` there. Returns smart ptr.
- The existing function signature no smart ptr for now (Compatibility).
If at some stage we have a complete ``EventContext`` type and we can create one we can make the one with ref also dual-use.
Christoshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/40872Add postprocessing to NTUP_PHYSVAL merge2021-02-20T00:59:07+01:00James FerrandoAdd postprocessing to NTUP_PHYSVAL mergeThis change adds a post-processing step to NTUP_PHYSVAL merge
Post-processing is done by postProcessIDPVMHistos.
Output has been verified by the physics validation contacts for the CP tracking group.This change adds a post-processing step to NTUP_PHYSVAL merge
Post-processing is done by postProcessIDPVMHistos.
Output has been verified by the physics validation contacts for the CP tracking group.https://gitlab.cern.ch/atlas/athena/-/merge_requests/40641WIP refactorisation + ctest for JetTrigTimer2021-02-16T15:34:37+01:00Peter SherwoodWIP refactorisation + ctest for JetTrigTimerMinor refactorisation for the development tool JetTrigTimer, Clean out obsolete tests in TrigHLTJetHypoUnitTests. Add tests for JetTrigTimer, ProductGen
ATR-22821
@jbossios @valentem @peterMinor refactorisation for the development tool JetTrigTimer, Clean out obsolete tests in TrigHLTJetHypoUnitTests. Add tests for JetTrigTimer, ProductGen
ATR-22821
@jbossios @valentem @peterPeter SherwoodPeter Sherwoodhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/39308Draft: Safer version of shallow copy2021-04-21T16:54:32+02:00Dan GuestDraft: Safer version of shallow copyThis is more a discussion piece than anything else: we could make it more exception safe etc if we want to go this way. @ssnyder is there any reason a function like this should not exist?This is more a discussion piece than anything else: we could make it more exception safe etc if we want to go this way. @ssnyder is there any reason a function like this should not exist?