athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2023-03-09T18:08:47+01:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/61173MUCTPI detMask fix in BSMon2023-03-09T18:08:47+01:00Aimilianos KoulourisMUCTPI detMask fix in BSMonFollowing up from JIRA: https://its.cern.ch/jira/browse/ATR-27018
Adding a check for detectorMask in the L1CT `BSMonitoringAlgorithm.py` file to skip MUCTPI BS algo if MUCTPI not in detMask.Following up from JIRA: https://its.cern.ch/jira/browse/ATR-27018
Adding a check for detectorMask in the L1CT `BSMonitoringAlgorithm.py` file to skip MUCTPI BS algo if MUCTPI not in detMask.https://gitlab.cern.ch/atlas/athena/-/merge_requests/61166Simplified isolation and disabled truth tools when running on data to resolve...2023-03-05T20:31:33+01:00Samuel William AlibocusSimplified isolation and disabled truth tools when running on data to resolve WARNING messages- Changed isolation from IsolationSelectionTool to simple isolation cuts to resolve WARNING messages in log file.
- Disabled truth tool and container when running on data to resolve WARNING messages in log file.- Changed isolation from IsolationSelectionTool to simple isolation cuts to resolve WARNING messages in log file.
- Disabled truth tool and container when running on data to resolve WARNING messages in log file.https://gitlab.cern.ch/atlas/athena/-/merge_requests/61163athenaHLT: configure online/offline THistSvc consistently2023-03-03T15:42:49+01:00Frank WinklmeierathenaHLT: configure online/offline THistSvc consistentlyAdd a flag for configuring the offline `THistSvc` vs the online
`TrigMonTHistSvc` and use it in the CA config function.
Closes ATR-27041.Add a flag for configuring the offline `THistSvc` vs the online
`TrigMonTHistSvc` and use it in the CA config function.
Closes ATR-27041.https://gitlab.cern.ch/atlas/athena/-/merge_requests/61137Need to fix reference for one chain2023-03-01T16:57:54+01:00Lidija ZivkovicNeed to fix reference for one chainThis is to fix a reference file that are now blocking other MRs.
chainComp INFO Found 1 chain with count differences:
chainComp INFO HLT_j80c_020jvt_j55c_020jvt_j28c_020jvt_j20c_020jvt_SHARED_3j20c_020jvt_bgn175_pf_ftf_presel2...This is to fix a reference file that are now blocking other MRs.
chainComp INFO Found 1 chain with count differences:
chainComp INFO HLT_j80c_020jvt_j55c_020jvt_j28c_020jvt_j20c_020jvt_SHARED_3j20c_020jvt_bgn175_pf_ftf_presel2c20XX2c20bg85_L1J45p0ETA21_3J15p0ETA25:
chainComp INFO stepFeatures:
chainComp INFO 1: 143 -> 145https://gitlab.cern.ch/atlas/athena/-/merge_requests/61134MSTrackBuilding - Fix memory leak from phi hit selection2023-03-01T21:43:37+01:00Johannes Junggeburthjohannes.josef.junggeburth@cern.chMSTrackBuilding - Fix memory leak from phi hit selectionCloses ATLASRECTS-7506Closes ATLASRECTS-7506https://gitlab.cern.ch/atlas/athena/-/merge_requests/61130Externals Update, master branch (2023.03.01)2023-03-02T21:42:31+01:00Marilena BandieramonteExternals Update, master branch (2023.03.01)Update externals version to 2.0.151.
This should fix: ATLASSIM-6403Update externals version to 2.0.151.
This should fix: ATLASSIM-6403https://gitlab.cern.ch/atlas/athena/-/merge_requests/61105AthenaPoolCnvSvc: Switch back to ZLIB for tmp files2023-03-01T12:38:33+01:00Alaettin Serhan MeteAthenaPoolCnvSvc: Switch back to ZLIB for tmp filesOK, I underestimated how ancient the ROOT version in release 21 is. It doesn't even have `LZ4` since that is only introduced in `v6-10-08` whereas we use `v6-08-06`. This should address ATLASRECTS-7504 after a full circle.
BTW, I should...OK, I underestimated how ancient the ROOT version in release 21 is. It doesn't even have `LZ4` since that is only introduced in `v6-10-08` whereas we use `v6-08-06`. This should address ATLASRECTS-7504 after a full circle.
BTW, I should also note that we typically don't support forward compatibility. It's not only the technical ROOT things per se but a lot is different between master and release 21 as far as the core I/O is concerned, including but not limited to the `DataHeader`. I see Marcin introduced the new version of the `DataHeader` to release 21 in !24664 but I'm not sure if there are any other important fixes/changes (in `DataHeader` or elsewhere) that are not back-ported. I assumes things are thoroughly validated but we should be really careful not to be bitten by something more convoluted in general.
cc: @gemmeren @mnowak @tadej @jcatmore @nstyleshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/61085runHLT_standalone: couple superCellWithBCID with doL1Sim2023-02-28T16:15:21+01:00Bertrand Martin Dit LatourrunHLT_standalone: couple superCellWithBCID with doL1SimHello,
This MR is hopefully fixing a bug introduced in !60990, where superCellWithBCID implicitly assumes that opt.doL1Sim=True (ATR-27019).
Maybe this could be replaced with a solution based on config flags in the future.
Local testin...Hello,
This MR is hopefully fixing a bug introduced in !60990, where superCellWithBCID implicitly assumes that opt.doL1Sim=True (ATR-27019).
Maybe this could be replaced with a solution based on config flags in the future.
Local testing underway.
Adding the urgent flag.
@fwinkl , should we run `full-unit-tests`?
Bertrandhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/61082Use LZ4 for temporary files2023-02-28T15:43:28+01:00Tadej Novaktadej.novak@cern.chUse LZ4 for temporary filesAs agreed on ATLASRECTS-7504 use LZ4 as the compression algorithm for temporary files. This is needed so the files can be read in old releases.
/cc @amete @gemmerenAs agreed on ATLASRECTS-7504 use LZ4 as the compression algorithm for temporary files. This is needed so the files can be read in old releases.
/cc @amete @gemmerenhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/61080Migrate to ONNX FastCalo code2023-03-03T21:43:26+01:00Joao Victor Da Fonseca PintoMigrate to ONNX FastCalo code* This MR is a part of ringer Run 3 commissioning.
* Move to ONNX ringer selector reader.
* All Run 2 tunings were converted to ONNX format (electron Run 2 v8/v1 and photon v1)
* Fix normalization bug in the new code w.r.t the referenc...* This MR is a part of ringer Run 3 commissioning.
* Move to ONNX ringer selector reader.
* All Run 2 tunings were converted to ONNX format (electron Run 2 v8/v1 and photon v1)
* Fix normalization bug in the new code w.r.t the reference code (this cause some count changes in electrons chains);
* treat tansig output in the new code (this cause some count changes in photon side)
Next step:
* Remove TrigMultiVarHypo
* Switch to Run 3 tunings.
ping @safarzad @eegidiop @mverissi @jlieberm @cjmeyer @dbakshigJoao Victor Da Fonseca PintoJoao Victor Da Fonseca Pintohttps://gitlab.cern.ch/atlas/athena/-/merge_requests/61050Fix ART header content2023-02-27T21:42:59+01:00Mark HodgkinsonFix ART header contentUpdate ART header content to correct formatting.
This solves ATLINFR-4853Update ART header content to correct formatting.
This solves ATLINFR-4853https://gitlab.cern.ch/atlas/athena/-/merge_requests/61048Update bjet SuperRoI zwidth (ATR-26766)2023-02-28T21:43:00+01:00Julie KirkUpdate bjet SuperRoI zwidth (ATR-26766)Update the jet_SuperRoI width to be consistent with the new default in MR!60960
Revert this in IDTrig_MC23a_preInclude.py for MC23a production
modified: Trigger/TrigTools/TrigInDetConfig/python/ConfigSettings.py
Tagging @tamartin, @...Update the jet_SuperRoI width to be consistent with the new default in MR!60960
Revert this in IDTrig_MC23a_preInclude.py for MC23a production
modified: Trigger/TrigTools/TrigInDetConfig/python/ConfigSettings.py
Tagging @tamartin, @sshaw, @sutt, @cpollard , @lbeemstehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/61023Prevent FPE from division by zero in MM L1 Simulation2023-02-26T21:42:23+01:00Francesco Giuseppe GraviliPrevent FPE from division by zero in MM L1 SimulationQuick fix to avoid FPE INVALID in gitlab pipelines, as reported in ATR-27008Quick fix to avoid FPE INVALID in gitlab pipelines, as reported in ATR-27008https://gitlab.cern.ch/atlas/athena/-/merge_requests/61015ATLASRECTS-7503 : Remove cout from DQTGlobalWZFinderAlg2023-02-26T21:42:52+01:00Samuel William AlibocusATLASRECTS-7503 : Remove cout from DQTGlobalWZFinderAlgRemoved unnecessary print outs in DQTGlobalWZFinderAlgRemoved unnecessary print outs in DQTGlobalWZFinderAlghttps://gitlab.cern.ch/atlas/athena/-/merge_requests/60983[ATR-27004] Revert parameter names in L1Topo algorithm2023-02-27T09:53:00+01:00Varsha Senthilkumar[ATR-27004] Revert parameter names in L1Topo algorithmhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/60956ATR-26902, added new L1 items for HHbbtt studies2023-03-15T15:43:46+01:00Gianantonio Pezzullog.pezzullo@yale.eduATR-26902, added new L1 items for HHbbtt studieshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/60940AnalysisTop: Changes needed for Electron triggers and global triggers2023-02-23T09:43:08+01:00Tomas DadoAnalysisTop: Changes needed for Electron triggers and global triggersThe re are some horrible hacks in the code, but this is needed because the trigger setup from electrons is not consistent between Run2 and Run3The re are some horrible hacks in the code, but this is needed because the trigger setup from electrons is not consistent between Run2 and Run3https://gitlab.cern.ch/atlas/athena/-/merge_requests/60916PileUpUtils: fix run and lumi profile generation2023-02-22T15:42:30+01:00Tadej Novaktadej.novak@cern.chPileUpUtils: fix run and lumi profile generationFix run and lumi profile generation where mu values may be the same by accident (as in case with flat profiles). The step number should override the mu so that it is used as the sorting criterium (we use the same code as for standard pil...Fix run and lumi profile generation where mu values may be the same by accident (as in case with flat profiles). The step number should override the mu so that it is used as the sorting criterium (we use the same code as for standard pile-up jobs). Also sort the resulting profile by step.
Sorry, I also fixed some whitespace inconsistencies when reading the code in detail to spot the issues.
/cc @jchapman @tlari @mbandierhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/60898Configuration for MC23c campaign2023-02-22T21:43:57+01:00Tommaso LariConfiguration for MC23c campaignI cloned all MC23a configurations (hopefully I catched all) to MC23c equivalents, changed the run number to the MC23c one, and included a flat pileup profile, to be replaced by the actual MC23c profile when available. However, simulation...I cloned all MC23a configurations (hopefully I catched all) to MC23c equivalents, changed the run number to the MC23c one, and included a flat pileup profile, to be replaced by the actual MC23c profile when available. However, simulation will not need that, so we don't need to wait for the actual
profile (in preparation).
Still a draft, waiting for @tadej to comment. The CI should be fine as they will not run the mc23c workflow, but I will run a test job to check it does not crash.
Tommasohttps://gitlab.cern.ch/atlas/athena/-/merge_requests/60871New depedencies to be handled by L1 simulation2023-02-20T17:47:54+01:00Denis Oliveira DamazioNew depedencies to be handled by L1 simulationFix for ATR-26993. Would be nice to have @pavol commenting.
This would be easily handled if I made my old promise of transferring all the configuration to
LAr code (from L1Calo). To be done soon. In the mean time, this fixes the issue fo...Fix for ATR-26993. Would be nice to have @pavol commenting.
This would be easily handled if I made my old promise of transferring all the configuration to
LAr code (from L1Calo). To be done soon. In the mean time, this fixes the issue found in the referenced JIRA.
For me, it is important to have it.
It is a bit weird that dependency through the algorithm to the tool. I did not know
that this could be the case (that tool dependencies go to the algorithm they pertain to).
Anyway, the calib line (as in the MR !60680) introduced is not necessary for other uses of the
BS converter code, hence, the AllowEmpty and, of course, the resetting of the property in
the python side.