athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2023-07-13T21:30:48+02:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/63924Muon Geometry - Add flag to toggle between the GeoModelXML & legacy description2023-07-13T21:30:48+02:00Johannes Junggeburthjohannes.josef.junggeburth@cern.chMuon Geometry - Add flag to toggle between the GeoModelXML & legacy descriptionA new flag in MuonConfig has been added to toggle between the 2 readout geometries. The flag is meant to ease the developments for the new Sensitive detectors.A new flag in MuonConfig has been added to toggle between the 2 readout geometries. The flag is meant to ease the developments for the new Sensitive detectors.https://gitlab.cern.ch/atlas/athena/-/merge_requests/63915Daily merge of 23.0 into master2023-06-24T21:41:53+02:00Vakhtang TsulaiaDaily merge of 23.0 into masterConflicts:
1. `InnerDetector/InDetRecTools/SiClusterOnTrackTool/src/ITkStripClusterOnTrackTool.cxx`. Kept the ~master version as discussed with @ncalace and @christos
2. Three scripts in `Simulation/G4Atlas/G4AtlasApps/test`: `test_Atla...Conflicts:
1. `InnerDetector/InDetRecTools/SiClusterOnTrackTool/src/ITkStripClusterOnTrackTool.cxx`. Kept the ~master version as discussed with @ncalace and @christos
2. Three scripts in `Simulation/G4Atlas/G4AtlasApps/test`: `test_AtlasG4_cosmics_configuration.py`, `test_AtlasG4_tf_configuration.py`, `test_TestBeam_tf_configuration.py` coming from conflicting changes in `test___G4AtlasAlg_ListOfSetProperties` functions from ~"23.0" and the ~master. Conflicts resolved manually. CC @jchapman. Hopefully, I got it right
3. `Tools/WorkflowTestRunner/python/References.py`. As always, this will require updating refs after the first CI run fails ...
This sweep contains the following MRs:
* !63731 Use isGenStable from TruthUtils inside the TruthParticle class ~EDM, ~Generators
* !63556 Muon inside -> chain.. Do not use the NSW for seeding ~Reconstruction, ~Run3-DataReco-output-changed, ~Tools, ~frozen-tier0-violating
* !63895 Remove the use of TDirectory::TContext when opening a container ~Database
* !63894 pip8 and flake fixes for python scripts in DerivationFrameworkEGamma ~Derivation, ~Egamma
* !63890 idalconv2_jo rm commented code ~InnerDetector
* !63891 Update FastShowerCellBuilderTool_test.py -- use only status=2 for particles ~Simulation
* !63889 TrfTestsART: Start using CA based merging and tighten the diff-root check in test_trf_q445_aodmerge.sh ~Tools
* !63886 Fix for .gitconfig in dev containers ~Build
* !63877 DerivationFrameworkL1Calo: add objects for phase 1 topo simple cone studies ~Derivation
* !63879 Update html link for output of ttbarPU40 IDPVM test ~InnerDetector, ~Tracking
* !63884 Fix DQ steering in HI ~Core, ~DQ
* !63861 Update tracking flags for PrimaryPassConfig ~ITk, ~InnerDetector, ~Tracking
* !63832 Updated the WebDisplay configuration for the ID DQ Alignment Plots ~DQ
* !63059 Avoid removing particles from the GenEvent after SimHit creation has started ~Generators, ~Simulation
* !63743 allow brem specific settings in FTF ~InnerDetector, ~Trigger, ~TriggerID
* !63846 ATR-27780, added two g5_nopid photon triggers in the MC Menu ~Trigger, ~TriggerMenu, ~changes-trigger-counts
* !63701 L1Topo enabling LateMuon reading through RoI Container ~Trigger
* !63883 end_with forgotten inline ~Core
* !63750 ATR-27757: VBF test chains to check downshift impact ~Trigger, ~TriggerMenu, ~changes-trigger-counts
* !63852 TileSimAlgs: Fix multiple hits for the same channel (ATLASSIM-6608) ~Digitization, ~Tile
* !63872 Drop boost::is_same and BOOST_STATIC_ASSERT in favor of std:: versions ~Core, ~Trigger
* !63869 Only make vector of DetectorElements if needed (i.e. for Run 4) (23.0 edition) ~InnerDetector
* !63868 PixelOnCluster add move ctors , clean up. Use them in SiClusterOnTrackTool ~InnerDetector
* !63842 FTF: HitDV optimisation + timers fix ~Trigger, ~TriggerID
* !63801 TriggerEgamma : Fixing TrigPhotonIsolationBuilder issue mentioned in ATR-27767 ~Trigger, ~TriggerMenu
* !63817 Add monGroups for ID trigger in cosmic menu ~Trigger, ~TriggerMenu
* !63793 Use CxxUtils:: instead of boost for starts_with in TrigCompositeUtils ~Trigger
* !63802 ALFA_EINE with and without TRT fast-OR, TRT streamers ALFA (ATR-23602) ~Trigger, ~TriggerMenu
* !63396 Make FlowElement container name adjustments more generalised. ~JetEtmiss, ~Reconstruction
* !63680 skip unnecessary extrapolation steps ~Trigger
* !63780 TrigL2MuonSA: Fix test. ~Trigger
* !63783 TrigMuonToolInterfaces+TrigMuonEF: Fix cppcheck warning. ~Trigger
* !63753 23.0-coverity-TrigT1TGC ~Trigger
* !63270 fix phiBE/etaBE for clusters in crack with negative energy in some samples ~Calorimeter, ~EDM, ~Egamma, ~Reconstruction, ~Run2-DataReco-output-changed, ~Run2-MCReco-output-changed, ~Run3-DataReco-output-changed, ~Run3-MCReco-output-changed, ~Tools, ~frozen-tier0-violating
* !63831 Protection against invalid btaggingLinkInfo ~DQ, ~Trigger
* !63729 Allow only comparing branches of interest in WorkflowTests ~Tools
* !63867 LArRawChannel: Does not seem to inherit or be inherited. rm virtual and add all ctors ~LAr
* !63850 skip NSMM or stgc A and B lines if they are not included in the geometry ~MuonSpectrometer
* !63785 Drop special condition for Herwig++ particle status codes ~Analysis, ~Tau
* !63755 Updating jFEX monitoring with updated information ~DQ, ~Triggerhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/63913Fix for V0Finder config in IDTR22023-06-29T18:29:40+02:00Jackson Carl BurzynskiFix for V0Finder config in IDTR2Fixes for IDTR2 after https://gitlab.cern.ch/atlas/athena/-/merge_requests/62568
Tagging @calpigiaFixes for IDTR2 after https://gitlab.cern.ch/atlas/athena/-/merge_requests/62568
Tagging @calpigiahttps://gitlab.cern.ch/atlas/athena/-/merge_requests/63912Restructure Monitoring2023-06-26T15:42:00+02:00Carlo Varnicarlo.varni@cern.chRestructure MonitoringAs suggested by @goetz we are grouping similar algs and tools in the same project. The tool's interface are not moved.
In this MR I'm moving our monitoring/analysis suite in an `ActsMonitoring` project. This includes monitoring algorith...As suggested by @goetz we are grouping similar algs and tools in the same project. The tool's interface are not moved.
In this MR I'm moving our monitoring/analysis suite in an `ActsMonitoring` project. This includes monitoring algorithms that can be scheduled during/after reconstruction and the monitoring tools used in IDVPMhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/63907Store the jvt selection flag as char in the CP algorithm block configuration2023-06-27T21:42:09+02:00Oliver MajerskyStore the jvt selection flag as char in the CP algorithm block configurationThis changes the data type of the jet JVT selection decision from unsigned int to char. There are three reasons for this:
1. this is a simple selection (single bit), so char is simpler and more compact (perhaps this argument is not so im...This changes the data type of the jet JVT selection decision from unsigned int to char. There are three reasons for this:
1. this is a simple selection (single bit), so char is simpler and more compact (perhaps this argument is not so important with ROOT compression)
2. This avoids necessity for bit arithmetic because, e.g. doing a TTree::Scan() is pretty inconvenient for this selection variables since it's basically either max value of unsigned int or max value - 1 (since only the least significant bit is 0/1, all other are 1).
3. It is more consistent with selection names for various object working point definitions and `baselineSelection` which are all also stored as char.
NOTE that this may mean that under certain circumstances, a conversion may be necessary, if combining decisions of `unsigned int` bitmask and a char selection, e.g. `AnaJets.baselineSelection&&jvt_selection,as_char`.https://gitlab.cern.ch/atlas/athena/-/merge_requests/63905EFTrackingSmearingAlg: Fix missing aux container in output container2023-06-26T21:41:52+02:00Mark Andrew OwenEFTrackingSmearingAlg: Fix missing aux container in output containerEFTrackingSmearingAlg: Fix missing aux container in output container. Also remove string variables that were never setEFTrackingSmearingAlg: Fix missing aux container in output container. Also remove string variables that were never sethttps://gitlab.cern.ch/atlas/athena/-/merge_requests/63897Further updates in CSV dumper2023-06-23T21:41:52+02:00Marcus Vinicius Gonzalez RodriguesFurther updates in CSV dumperThis MR is inline with !63818 and related to EFTRACK-63. It moves the dictionary with variables to a common place so it can be accessed by other scripts.
TrackParticle information were also added as requested.
Extra protection was adde...This MR is inline with !63818 and related to EFTRACK-63. It moves the dictionary with variables to a common place so it can be accessed by other scripts.
TrackParticle information were also added as requested.
Extra protection was added to the Dumper script.
Tagging @tbold @fpastore @mastrandhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/63893Archive failing muon ART tests2023-06-23T21:42:04+02:00Nicholas StylesArchive failing muon ART testsAs discussed in ATLASRECTS-7092, archiving tests which fail consistently.
If needed they should be re-added in a working configuration.As discussed in ATLASRECTS-7092, archiving tests which fail consistently.
If needed they should be re-added in a working configuration.https://gitlab.cern.ch/atlas/athena/-/merge_requests/63892Add defaulted virtual destr to ITrackFindingTool::Measurements2023-06-23T21:41:56+02:00Paul Gessinger-BefurtAdd defaulted virtual destr to ITrackFindingTool::MeasurementsFixes ATLASRECTS-7661Fixes ATLASRECTS-7661https://gitlab.cern.ch/atlas/athena/-/merge_requests/63887Archive not working tau ART tests ATLASRECTS-70952023-09-23T18:56:15+02:00Christos Anastopouloschristos.anastopoulos@cern.chArchive not working tau ART tests ATLASRECTS-7095This seem to not be working for 1 year or more. ATLASRECTS-7095
Archiving in git.
I would hope new working ones will be provided when needed.This seem to not be working for 1 year or more. ATLASRECTS-7095
Archiving in git.
I would hope new working ones will be provided when needed.https://gitlab.cern.ch/atlas/athena/-/merge_requests/63885FPGATrackSimReadRawRandomHitsTool.h fix clang warnings2023-06-23T04:54:07+02:00Christos Anastopouloschristos.anastopoulos@cern.chFPGATrackSimReadRawRandomHitsTool.h fix clang warningsFPGATrackSimReadRawRandomHitsTool.h fix clang warnings
```
In file included from /build/atnight/localbuilds/nightlies/Athena/master/athena/Trigger/EFTracking/FPGATrackSim/FPGATrackSimInput/src/FPGATrackSimReadRawRandomHitsTool.cxx:5:
/b...FPGATrackSimReadRawRandomHitsTool.h fix clang warnings
```
In file included from /build/atnight/localbuilds/nightlies/Athena/master/athena/Trigger/EFTracking/FPGATrackSim/FPGATrackSimInput/src/FPGATrackSimReadRawRandomHitsTool.cxx:5:
/build/atnight/localbuilds/nightlies/Athena/master/athena/Trigger/EFTracking/FPGATrackSim/FPGATrackSimInput/FPGATrackSimInput/FPGATrackSimReadRawRandomHitsTool.h:34:16: warning: private field 'm_nEntries' is not used [-Wunused-private-field]
unsigned int m_nEntries = 0U;
^
1 warning generated.
```https://gitlab.cern.ch/atlas/athena/-/merge_requests/63882Fix negative covariance2023-06-23T04:54:03+02:00Vadim KostyukhinFix negative covarianceCatch cases with negative diagonal elements of vertex covariance matrix. Presumably solves ATLASRECTS-7659Catch cases with negative diagonal elements of vertex covariance matrix. Presumably solves ATLASRECTS-7659https://gitlab.cern.ch/atlas/athena/-/merge_requests/63866Daily merge of 23.0 into master2023-06-22T15:42:00+02:00Vakhtang TsulaiaDaily merge of 23.0 into masterConflict in `References.py` because the sweep includes an FT0V MR !63714. Updated reference ESD-s for four q-tests, and updated corresponding version tags in the `References.py`.
This sweep contains the following MRs:
* !63854 add LArH...Conflict in `References.py` because the sweep includes an FT0V MR !63714. Updated reference ESD-s for four q-tests, and updated corresponding version tags in the `References.py`.
This sweep contains the following MRs:
* !63854 add LArHVIdMapping and LArCalibLineMapping to selection.xml ~LAr
* !63848 ParticleGun: fix pdgid and status of incoming particles ~Generators
* !63844 Updating MET Trigger Monitoring for nnmet and partly reverting to L1XE50 plots ~DQ, ~JetEtmiss, ~Trigger
* !63836 Use CxxUtils:: instead of boost:: for starts_with in ReweightUtils ~Analysis
* !63840 TRT_RawDataByteStreamCnv clang-tidy fixes ~InnerDetector
* !63835 Use CxxUtils:: instead of boost:: for starts_with in RDBAccessSvc ~Database
* !63816 Use ArenaPoolSTLAllocator for PRD and inverse multimap ~Tracking
* !63833 Updated logic for trigger function if DQ.useTrigger flag is disabled ~DQ
* !63714 Part of ATLASRECTS-7656 : TrackParametersCnv_p2 lets try to use Trk::SurfaceType::Curvilinear and fix FitQuality ~Run2-DataReco-output-changed, ~Run2-MCReco-output-changed, ~Run3-DataReco-output-changed, ~Run3-MCReco-output-changed, ~Tools, ~Tracking, ~frozen-tier0-violating
* !63799 Fix for ATR-27420 causing error in GenerateMenuMT stage of trig_mc_newJO_ITk_build in master ~Tau, ~Trigger, ~TriggerID, ~TriggerMenu
* !63849 Revert "PyUtils: Speed up processing of skipped branches in diff-root." ~Tools
* !63796 btagging configuration for HI data/MC in rel23 ~Analysis, ~BTagging, ~Derivation, ~JetEtmiss, ~Reconstruction
* !63806 CxxUtils starts/ends _with : Add overloads for const char* inputs ~Core
* !63737 Remove expressions with Truthparticle::status()%1000 ~Analysis, ~BTagging, ~Derivation, ~Egamma, ~Generators, ~InnerDetector, ~JetEtmiss, ~Reconstruction, ~Tracking
* !63662 Monitoring of clustered cells ~Calorimeter, ~DQ
* !63794 TrigJetMon: replacing HLT_HT1000 preselj180 with preselcHT450 ~DQ, ~JetEtmiss, ~Trigger, ~TriggerJethttps://gitlab.cern.ch/atlas/athena/-/merge_requests/63864Duplicate seed removal2023-06-27T21:42:14+02:00Tim AdyeDuplicate seed removal* Add duplicate seed removal using `TrackFindingTool::DuplicateSeedDetector`.
* Duplicate seeds are those where all measurements were already located in a previously followed trajectory.
* Currently removes duplicates separately for ...* Add duplicate seed removal using `TrackFindingTool::DuplicateSeedDetector`.
* Duplicate seeds are those where all measurements were already located in a previously followed trajectory.
* Currently removes duplicates separately for pixels and strips (local to `findTracks()`), so won't remove duplicate seeds between pixels and strips.
* We may eventually want to move this functionality to Acts Core, but good test to try it out here.
* Start `findTracks()` for pixel seeds (previously started with strip seeds).
* This is probably best until the CKF can do a backward search to find pixel hits from strip seeds.
* Afterwards, we could start with strips where the occupancy is lower.
* Actually only relevant when we can remove pixel/strip duplicates.
* `TrackStatePrinter` prints measurement indices for seeds (instead of stats) and track states (instead of surface names).
* `TrackFindingAlg`'s inputs now optional, allowing to eg. switch off strips seeds.
* Fix broken `ATLASSourceLinkGeneric::operator==()`.https://gitlab.cern.ch/atlas/athena/-/merge_requests/63859SUSYTools - apply isolation corrections for electrons and photons2023-06-28T15:42:08+02:00Michael HolzbockSUSYTools - apply isolation corrections for electrons and photonsApply isolation corrections for photons and electrons in SUSYTools (fix potential discrepancies in the isolation variables between PHYS and PHYSLITE reported in ATLASG-2530)
Tagging @mrimoldiApply isolation corrections for photons and electrons in SUSYTools (fix potential discrepancies in the isolation variables between PHYS and PHYSLITE reported in ATLASG-2530)
Tagging @mrimoldihttps://gitlab.cern.ch/atlas/athena/-/merge_requests/63858Configure the ACTS geometry tool in legacy trigger via wrapped CA [ATR-27768]2023-06-26T15:56:58+02:00Teng Jian KhooConfigure the ACTS geometry tool in legacy trigger via wrapped CA [ATR-27768]Same as !63857, but for master (sweep not possible due to renaming of `ActsGeometry.ActsGeometryConfig` to `ActsConfig.ActsTrkGeometryConfig`).Same as !63857, but for master (sweep not possible due to renaming of `ActsGeometry.ActsGeometryConfig` to `ActsConfig.ActsTrkGeometryConfig`).https://gitlab.cern.ch/atlas/athena/-/merge_requests/63851master-coverity-FPGATrackSimBanks2023-06-21T21:41:56+02:00Shaun Roemaster-coverity-FPGATrackSimBanksFix coverity defects:
19260, 19261, 19263 : unchecked dynamic cast (check the dynamic cast where a temporary casted ptr exists, use static_cast otherwise)
19258, 19259, 19262 : dereference of pointer after null check (exited with warning...Fix coverity defects:
19260, 19261, 19263 : unchecked dynamic cast (check the dynamic cast where a temporary casted ptr exists, use static_cast otherwise)
19258, 19259, 19262 : dereference of pointer after null check (exited with warning)
minor header cleanup also.https://gitlab.cern.ch/atlas/athena/-/merge_requests/63845Only make vector of DetectorElements if needed (i.e. for Run 4)2023-06-23T20:14:01+02:00Stewart Martin-HaughOnly make vector of DetectorElements if needed (i.e. for Run 4)The spacePointsToClusters method creates a `std::vector<const InDetDD::SiDetectorElement*>` but this is only needed for ITk reconstruction (see !44886. Make it optional and save some reserves and push_backs.
Appears in heaptrack profili...The spacePointsToClusters method creates a `std::vector<const InDetDD::SiDetectorElement*>` but this is only needed for ITk reconstruction (see !44886. Make it optional and save some reserves and push_backs.
Appears in heaptrack profiling as a temporary allocation:
```
2211351 temporary allocations of 2211356 allocations in total (100.00%) from
__gnu_cxx::new_allocator<>::allocate(unsigned long, void const*)
at /cvmfs/sft.cern.ch/lcg/releases/gcc/11.2.0-8a51a/x86_64-centos7/include/c++/11.2.0/ext/new_allocator.h:127
in /cvmfs/atlas-nightlies.cern.ch/repo/sw/23.0_Athena_x86_64-centos7-gcc11-opt/2023-06-02T2101/Athena/23.0.32/InstallArea/x86_64-centos7-gcc11-opt/lib/libSiCombinatorialTrack
FinderTool_xk.so
std::allocator_traits<>::allocate(std::allocator<>&, unsigned long)
at /cvmfs/sft.cern.ch/lcg/releases/gcc/11.2.0-8a51a/x86_64-centos7/include/c++/11.2.0/bits/alloc_traits.h:460
std::_Vector_base<>::_M_allocate(unsigned long)
at /cvmfs/sft.cern.ch/lcg/releases/gcc/11.2.0-8a51a/x86_64-centos7/include/c++/11.2.0/bits/stl_vector.h:346
std::vector<>::reserve(unsigned long)
at /cvmfs/sft.cern.ch/lcg/releases/gcc/11.2.0-8a51a/x86_64-centos7/include/c++/11.2.0/bits/vector.tcc:78
InDet::SiCombinatorialTrackFinder_xk::spacePointsToClusters(std::vector<> const&, std::vector<>&, std::vector<>&)
at /build/atnight/localbuilds/nightlies/Athena/23.0/athena/InnerDetector/InDetRecTools/SiCombinatorialTrackFinderTool_xk/src/SiCombinatorialTrackFinder_xk.cxx:955
2206087 temporary allocations of 2206092 allocations in total (100.00%) from:
InDet::SiCombinatorialTrackFinder_xk::spacePointsToClusters(std::vector<> const&, std::vector<>&)
at /build/atnight/localbuilds/nightlies/Athena/23.0/athena/InnerDetector/InDetRecTools/SiCombinatorialTrackFinderTool_xk/src/SiCombinatorialTrackFinder_xk.cxx:917
in /cvmfs/atlas-nightlies.cern.ch/repo/sw/23.0_Athena_x86_64-centos7-gcc11-opt/2023-06-02T2101/Athena/23.0.32/InstallArea/x86_64-centos7-gcc11-opt/lib/libSiCombinatorialTrackFinderTool_xk.so
InDet::SiCombinatorialTrackFinder_xk::findTrack(InDet::SiCombinatorialTrackFinderData_xk&, Trk::ParametersBase<> const&, std::vector<> const&, std::vector<> const&, std::vector<>&, std::multimap<>&, EventContext const&) const
at /build/atnight/localbuilds/nightlies/Athena/23.0/athena/InnerDetector/InDetRecTools/SiCombinatorialTrackFinderTool_xk/src/SiCombinatorialTrackFinder_xk.cxx:628
in /cvmfs/atlas-nightlies.cern.ch/repo/sw/23.0_Athena_x86_64-centos7-gcc11-opt/2023-06-02T2101/Athena/23.0.32/InstallArea/x86_64-centos7-gcc11-opt/lib/libSiCombinatorialT
rackFinderTool_xk.so
InDet::SiCombinatorialTrackFinder_xk::getTracks[abi:cxx11](InDet::SiCombinatorialTrackFinderData_xk&, Trk::ParametersBase<> const&, std::vector<> const&, std::vector<> const&, std::vector<>&, std::multimap<>&, EventContext const&) const
at /build/atnight/localbuilds/nightlies/Athena/23.0/athena/InnerDetector/InDetRecTools/SiCombinatorialTrackFinderTool_xk/src/SiCombinatorialTrackFinder_xk.cxx:411
in /cvmfs/atlas-nightlies.cern.ch/repo/sw/23.0_Athena_x86_64-centos7-gcc11-opt/2023-06-02T2101/Athena/23.0.32/InstallArea/x86_64-centos7-gcc11-opt/lib/libSiCombinatorialTrackFinderTool_xk.so
InDet::SiTrackMaker_xk::getTracks[abi:cxx11](EventContext const&, InDet::SiTrackMakerEventData_xk&, std::vector<> const&) const
at /build/atnight/localbuilds/nightlies/Athena/23.0/athena/InnerDetector/InDetRecTools/SiTrackMakerTool_xk/src/SiTrackMaker_xk.cxx:723
in /cvmfs/atlas-nightlies.cern.ch/repo/sw/23.0_Athena_x86_64-centos7-gcc11-opt/2023-06-02T2101/Athena/23.0.32/InstallArea/x86_64-centos7-gcc11-opt/lib/libSiTrackMakerTool_xk.so
TrigFastTrackFinder::findTracks(InDet::SiTrackMakerEventData_xk&, TrigRoiDescriptor const&, DataVector<> const*, DataVector<>&, EventContext const&) const
at /build/atnight/localbuilds/nightlies/Athena/23.0/athena/Trigger/TrigAlgorithms/TrigFastTrackFinder/src/TrigFastTrackFinder.cxx:679
in /cvmfs/atlas-nightlies.cern.ch/repo/sw/23.0_Athena_x86_64-centos7-gcc11-opt/2023-06-02T2101/Athena/23.0.32/InstallArea/x86_64-centos7-gcc11-opt/lib/libTrigFastTrackFinder.so
TrigFastTrackFinder::execute(EventContext const&) const
at /build/atnight/localbuilds/nightlies/Athena/23.0/athena/Trigger/TrigAlgorithms/TrigFastTrackFinder/src/TrigFastTrackFinder.cxx:443
in /cvmfs/atlas-nightlies.cern.ch/repo/sw/23.0_Athena_x86_64-centos7-gcc11-opt/2023-06-02T2101/Athena/23.0.32/InstallArea/x86_64-centos7-gcc11-opt/lib/libTrigFastTrackFinder.so
```
Average fullscan trigger track finding time (on ttbar) goes down from 297 ms to 289 ms, about a 2-3% improvement.https://gitlab.cern.ch/atlas/athena/-/merge_requests/63843fix order of arguments (bug) in FPGATrackSimHitFilteringTool2023-06-21T21:41:44+02:00Jahred Adelmanjahreda@gmail.comfix order of arguments (bug) in FPGATrackSimHitFilteringToolArguments were reversed between function declaration and usage in FPGATrackSimHitFilteringTool
SEE: https://its.cern.ch/jira/browse/EFTRACK-244Arguments were reversed between function declaration and usage in FPGATrackSimHitFilteringTool
SEE: https://its.cern.ch/jira/browse/EFTRACK-244https://gitlab.cern.ch/atlas/athena/-/merge_requests/63839Adding 422 clusters for GEP emulation2023-08-22T18:34:35+02:00Dylan Sheldon RankinAdding 422 clusters for GEP emulationThis MR creates a config in the `TrigGepPerf` package to add 422 clusters. It can be used as a `postInclude` with `Reco_tf.py`.
Tested with an RDO from mc21: `Reco_tf.py --CA 'all:True' --autoConfiguration 'everything' --conditionsTag ...This MR creates a config in the `TrigGepPerf` package to add 422 clusters. It can be used as a `postInclude` with `Reco_tf.py`.
Tested with an RDO from mc21: `Reco_tf.py --CA 'all:True' --autoConfiguration 'everything' --conditionsTag 'all:OFLCOND-MC15c-SDR-14-05' --geometryVersion 'all:ATLAS-P2-RUN4-03-00-00' --multithreaded 'True' --preInclude 'all:Campaigns.PhaseIINoPileUp' --steering 'doRAWtoALL' --inputRDOFile ../../../../mc21_14TeV.601229.PhPy8EG_A14_ttbar_hdamp258p75_SingleLep.recon.RDO.e8481_s4149_r14697/RDO.33629009._000002.pool.root.1 --outputAODFile aod.root --postInclude 'all:PyJobTransforms.UseFrontier' 'TrigGepPerf.Add422Config.Add422Cfg'`
@htorre @tstreble @mswiatlo
Previous discussion in ATLSWUPGR-194