athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2023-04-07T00:00:31+02:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/61408Draft: Implementation of additional eFEX L1 Topo under the INVM_DPHI_eEMsl6 a...2023-04-07T00:00:31+02:00Marco MontellaDraft: Implementation of additional eFEX L1 Topo under the INVM_DPHI_eEMsl6 algorithm + chains in Dev MenuThis MR tracks the implementation of the following Phase 1 L1 Topo Items, as discussed in ATR-21637:
```
MenuItem('L1_DPHI12-M70-2eEM9M').setLogic(d.TOPO_0INVM70_0DPHI12_eEM9sm1_eEM9sm6 & physcond)
MenuItem('L1_DPHI12-M70-2eEM12M').setL...This MR tracks the implementation of the following Phase 1 L1 Topo Items, as discussed in ATR-21637:
```
MenuItem('L1_DPHI12-M70-2eEM9M').setLogic(d.TOPO_0INVM70_0DPHI12_eEM9sm1_eEM9sm6 & physcond)
MenuItem('L1_DPHI12-M70-2eEM12M').setLogic(d.TOPO_0INVM70_0DPHI12_eEM12sm1_eEM12sm6 & physcond)
MenuItem('L1_DPHI12-M70-2eEM15M').setLogic(d.TOPO_0INVM70_0DPHI12_eEM15sm1_eEM15sm6 & physcond)
```
Targeting the boosted low-mass diPhoton signature.
**Current status is:**
Working, aside from the 2eEM12M version, due to eEM12 not being among the listed thresholds for eFEX.
--
@rgugel as L1 Menu practices are not my forte, I am not sure if this current implementation would actually have the new algorithms running at P1 from the get go or not. Just to clarify, that is NOT what I want at the moment, I'm only interested in introducing these algorithm to the Menu so that they can be evaluated for rate in the next reprocessings.
Also tagging @lidiaz and @astruebi on the Menu sidehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/61399ATLAS Trigger SoftwareATR-266292023-03-09T16:25:10+01:00Zhongyukun Xuzhongyukun.xu@cern.chATLAS Trigger SoftwareATR-26629Request of adding support tau20_idperf/perf chainsRequest of adding support tau20_idperf/perf chainshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/61389ATR-23470: Lowering minEt Threshold_cut('eTAU', 12) for new boosted Low PT D...2023-03-16T15:31:32+01:00Damiano VannicolaATR-23470: Lowering minEt Threshold_cut('eTAU', 12) for new boosted Low PT DiTau ChainLowering minEt Threshold_cut('eTAU', 12) for new boosted Low PT DiTau ChainLowering minEt Threshold_cut('eTAU', 12) for new boosted Low PT DiTau Chainhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/61372Draft: Heavy Ion reco flags to use in preInclude2023-04-11T10:24:39+02:00Sebastian Tapia ArayaDraft: Heavy Ion reco flags to use in preIncludeAdding functionality to switch between HI and HIP mode using preInclude syntax, as discussed in ATLHI-480Adding functionality to switch between HI and HIP mode using preInclude syntax, as discussed in ATLHI-480https://gitlab.cern.ch/atlas/athena/-/merge_requests/61343Adding ZRad trigger2023-03-16T07:25:17+01:00Francesco GiuliAdding ZRad triggerhttps://its.cern.ch/jira/browse/ATR-27030https://its.cern.ch/jira/browse/ATR-27030https://gitlab.cern.ch/atlas/athena/-/merge_requests/61320Add `bunchgroupset` to the list of allowable trigger menu JSON file types whe...2023-03-08T12:41:32+01:00Tim MartinAdd `bunchgroupset` to the list of allowable trigger menu JSON file types when peeking the metadataThis reacts to an observation in the CI from !60495
```
Py:MetaReader WARNING Got an xAOD::TriggerMenuJson called bunchgroupset but only expecting hltmenu or l1menu
```
`bunchgroupset` is a valid identifier, albeit one which was a...This reacts to an observation in the CI from !60495
```
Py:MetaReader WARNING Got an xAOD::TriggerMenuJson called bunchgroupset but only expecting hltmenu or l1menu
```
`bunchgroupset` is a valid identifier, albeit one which was added quite late. Hence being missing here.https://gitlab.cern.ch/atlas/athena/-/merge_requests/61318Master2023-03-14T19:07:32+01:00Kyle Scott JonesMasterRemoved topoetcone plots from the egamma trigger monitoring for electrons since the plots were not needed and were causing issues for trigger monitoring.Removed topoetcone plots from the egamma trigger monitoring for electrons since the plots were not needed and were causing issues for trigger monitoring.https://gitlab.cern.ch/atlas/athena/-/merge_requests/61277CaloRec: Allow CaloTopoClusterConfig to accept run arguments2023-03-07T10:07:41+01:00Alaettin Serhan MeteCaloRec: Allow CaloTopoClusterConfig to accept run argumentsAfter this MR, the user can simply set flags while running this configuration in the standalone mode, e.g.:
```
python -m CaloRec.CaloTopoClusterConfig Output.StorageTechnology="ROOTRNTUPLE"
```
The way things are coded, not all flags ...After this MR, the user can simply set flags while running this configuration in the standalone mode, e.g.:
```
python -m CaloRec.CaloTopoClusterConfig Output.StorageTechnology="ROOTRNTUPLE"
```
The way things are coded, not all flags will be respected, e.g., maximum number of events, but that's out of the scope of this MR.
cc: @mnowakhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/61221Master2023-03-03T15:18:19+01:00Kyle Scott JonesMasterRemoved etcone plots in the TrigEgamma monitoring for electrons since they were unneeded and causing issues in monitoring.Removed etcone plots in the TrigEgamma monitoring for electrons since they were unneeded and causing issues in monitoring.https://gitlab.cern.ch/atlas/athena/-/merge_requests/61217Add missing BeamSpot condition algo for InDetPhysValTruthDecoratorAlg CA config2023-03-08T11:59:30+01:00Thomas StreblerAdd missing BeamSpot condition algo for InDetPhysValTruthDecoratorAlg CA configAs noticed in @srettie tests, the `InDetPhysValTruthDecoratorAlg` relies on `InDet::BeamSpotData` conditions. This is now properly included in the CA config.As noticed in @srettie tests, the `InDetPhysValTruthDecoratorAlg` relies on `InDet::BeamSpotData` conditions. This is now properly included in the CA config.https://gitlab.cern.ch/atlas/athena/-/merge_requests/61079Attempting to set ROOT error level around file opening in EL2023-03-06T13:31:26+01:00Zach MarshallAttempting to set ROOT error level around file opening in ELWe have this notorious problem that ROOT doesn't always communicate
error messages in a reasonable way when opening a file fails. One of the
only ways to catch them is to set ROOT to abort if an error message is
printed to the log.
This...We have this notorious problem that ROOT doesn't always communicate
error messages in a reasonable way when opening a file fails. One of the
only ways to catch them is to set ROOT to abort if an error message is
printed to the log.
This attempts to set that abort level around the time that the file is
opened in event loop, which should protect us against those errors (if
it works).https://gitlab.cern.ch/atlas/athena/-/merge_requests/61008Draft: AthConfigFlags: add hasValue method2023-03-09T15:45:06+01:00Frank WinklmeierDraft: AthConfigFlags: add hasValue methodAdd the `hasValue` method that can be used to check if a flag has a
value.
My use-case is to be able to check if the user has set an explicit value for `flags.IOVDb.GlobalTag` which is otherwise [auto-configured by IOVDbAutoCfgFlags](ht...Add the `hasValue` method that can be used to check if a flag has a
value.
My use-case is to be able to check if the user has set an explicit value for `flags.IOVDb.GlobalTag` which is otherwise [auto-configured by IOVDbAutoCfgFlags](https://gitlab.cern.ch/atlas/athena/-/blob/master/Database/IOVDbSvc/python/IOVDbAutoCfgFlags.py#L6). However, this method doesn't take into account the [default settings for the HLT](https://gitlab.cern.ch/atlas/athena/-/blob/837e61e0625cc3b510bbccbd712105518dac67bf/Trigger/TriggerCommon/TriggerJobOpts/share/runHLT_standalone.py#L183). An alternative could be to add that code directly into `IOVDbAutoCfgFlags`.
Would like to hear opinions from e.g. @tbold @tamartin @wlampl @tadej.https://gitlab.cern.ch/atlas/athena/-/merge_requests/60993Draft: Updated FastChain ART tests2023-03-14T11:08:32+01:00Martina JavurkovaDraft: Updated FastChain ART testsAll FastChain ART tests have been revised:
* obsolete tests deleted
* tests with pileup digitization and MC-overlay
* updated for Run 2 and Run 3
* added comparison CA vs legacy
* tests with Track-overlay
* only for Run 3...All FastChain ART tests have been revised:
* obsolete tests deleted
* tests with pileup digitization and MC-overlay
* updated for Run 2 and Run 3
* added comparison CA vs legacy
* tests with Track-overlay
* only for Run 3 and CA
* two tests: one runs simulation + Track-overlay and the other standalone Track-overlayhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/60951Draft: Associate last DataHeaderForms to all DataHeader objects w/o relying o...2023-02-23T23:29:20+01:00Peter Van GemmerenDraft: Associate last DataHeaderForms to all DataHeader objects w/o relying on DHF tokenIn the past some issues with robustness of the token information linking the DataHeader to its DataHeaderForm.
With '_p6' versions, a DataHeaderForm is written only when changes occur and its Token is added to the DataHeader, after both ...In the past some issues with robustness of the token information linking the DataHeader to its DataHeaderForm.
With '_p6' versions, a DataHeaderForm is written only when changes occur and its Token is added to the DataHeader, after both are registered for writing, but before data is stored on disk. This cycle is fragile in client/server cases or with non-ROOT technologies. However, since the information in DataHeaderForm is accumulated, the last DataHeaderForm can be used to decode all DataHeader.
The placement of the DataHeaderForm is fixed relative to the DataHeader itself and therefore the Token to the last DataHeaderForm can be determined. This MR will no longer use the DataHeaderForm Token store as part of the DataHeader, but use the last DataHeaderForm in the corresponding container. The MR changes reading of all data, but won't affect writing, in particular, the DataHeaderForm Token is still attached to the DataHeader.https://gitlab.cern.ch/atlas/athena/-/merge_requests/60941Draft: Should build the trajectories faster2023-06-05T11:22:59+02:00Andrii VerbytskyiDraft: Should build the trajectories fasterThis MR should help to build the truth trajectories faster in the MuonSpectrometer and in the Tracking.
This is done with a reimplementation of the `getDaughter()` and `getMother()` functions.
The previous implementation of those funct...This MR should help to build the truth trajectories faster in the MuonSpectrometer and in the Tracking.
This is done with a reimplementation of the `getDaughter()` and `getMother()` functions.
The previous implementation of those functions always created a copy of the particle used in
the argument using the `truthTrajectoryCuts` function,
which always returned a pair of particles.
Tag @jojungge @jchapman @christoshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/60896Draft: Simplerplinks22023-04-11T19:56:32+02:00Andrii VerbytskyiDraft: Simplerplinks2Try to find out how may places need an explicit constructor with particlesTry to find out how may places need an explicit constructor with particleshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/60871New depedencies to be handled by L1 simulation2023-02-20T17:47:54+01:00Denis Oliveira DamazioNew depedencies to be handled by L1 simulationFix for ATR-26993. Would be nice to have @pavol commenting.
This would be easily handled if I made my old promise of transferring all the configuration to
LAr code (from L1Calo). To be done soon. In the mean time, this fixes the issue fo...Fix for ATR-26993. Would be nice to have @pavol commenting.
This would be easily handled if I made my old promise of transferring all the configuration to
LAr code (from L1Calo). To be done soon. In the mean time, this fixes the issue found in the referenced JIRA.
For me, it is important to have it.
It is a bit weird that dependency through the algorithm to the tool. I did not know
that this could be the case (that tool dependencies go to the algorithm they pertain to).
Anyway, the calib line (as in the MR !60680) introduced is not necessary for other uses of the
BS converter code, hence, the AllowEmpty and, of course, the resetting of the property in
the python side.https://gitlab.cern.ch/atlas/athena/-/merge_requests/60863Draft: Fix trt smearing2023-02-21T10:53:09+01:00Joshua Eldon PuddefootDraft: Fix trt smearingmoved to https://gitlab.cern.ch/atlas/athena/-/merge_requests/60868moved to https://gitlab.cern.ch/atlas/athena/-/merge_requests/60868https://gitlab.cern.ch/atlas/athena/-/merge_requests/60832Tweaks to !58463 : fix bug & rename property2023-02-17T21:41:26+01:00Peter OnyisiTweaks to !58463 : fix bug & rename propertyChanges:
- use argument to `trigChainsArePassed` for list of triggers (unbreaks monitoring algorithms that use this directly)
- rename "`isExpressStreamJob`" to "`EnforceExpressTriggers`" to make intent of flag clearerChanges:
- use argument to `trigChainsArePassed` for list of triggers (unbreaks monitoring algorithms that use this directly)
- rename "`isExpressStreamJob`" to "`EnforceExpressTriggers`" to make intent of flag clearerhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/60825Draft: Add ability to build AthGeneration writing out legacy McEventCollectio...2023-06-05T11:22:41+02:00Tadej Novaktadej.novak@cern.chDraft: Add ability to build AthGeneration writing out legacy McEventCollection_p5Add ability to build `AthGeneration` writing out legacy `McEventCollection_p5`.
The motivation for this is to avoid building legacy branches to have working EVNT merge that writes out `McEventCollection_p5`. This is needed for MC16 and ...Add ability to build `AthGeneration` writing out legacy `McEventCollection_p5`.
The motivation for this is to avoid building legacy branches to have working EVNT merge that writes out `McEventCollection_p5`. This is needed for MC16 and MC20 sample production with EVNT made in master-based releases.
While probably some old 22.6 release is enough, this took me very little time to implement and test and now have it ready even if we do not decide to merge. Keeping draft for now to allow discussion.
/cc @ewelina @jchapman @akraszna @fwinkl @nstyles @jcatmore