athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2023-04-07T00:00:31+02:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/61408Draft: Implementation of additional eFEX L1 Topo under the INVM_DPHI_eEMsl6 a...2023-04-07T00:00:31+02:00Marco MontellaDraft: Implementation of additional eFEX L1 Topo under the INVM_DPHI_eEMsl6 algorithm + chains in Dev MenuThis MR tracks the implementation of the following Phase 1 L1 Topo Items, as discussed in ATR-21637:
```
MenuItem('L1_DPHI12-M70-2eEM9M').setLogic(d.TOPO_0INVM70_0DPHI12_eEM9sm1_eEM9sm6 & physcond)
MenuItem('L1_DPHI12-M70-2eEM12M').setL...This MR tracks the implementation of the following Phase 1 L1 Topo Items, as discussed in ATR-21637:
```
MenuItem('L1_DPHI12-M70-2eEM9M').setLogic(d.TOPO_0INVM70_0DPHI12_eEM9sm1_eEM9sm6 & physcond)
MenuItem('L1_DPHI12-M70-2eEM12M').setLogic(d.TOPO_0INVM70_0DPHI12_eEM12sm1_eEM12sm6 & physcond)
MenuItem('L1_DPHI12-M70-2eEM15M').setLogic(d.TOPO_0INVM70_0DPHI12_eEM15sm1_eEM15sm6 & physcond)
```
Targeting the boosted low-mass diPhoton signature.
**Current status is:**
Working, aside from the 2eEM12M version, due to eEM12 not being among the listed thresholds for eFEX.
--
@rgugel as L1 Menu practices are not my forte, I am not sure if this current implementation would actually have the new algorithms running at P1 from the get go or not. Just to clarify, that is NOT what I want at the moment, I'm only interested in introducing these algorithm to the Menu so that they can be evaluated for rate in the next reprocessings.
Also tagging @lidiaz and @astruebi on the Menu sidehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/62134AF3: mirror showers for positrons and negative hadrons2023-04-05T19:17:28+02:00Christopher YoungAF3: mirror showers for positrons and negative hadronsWhen we derived the showers for AF3 we derived them for electrons and positive hadrons. We should therefore impose a phi -> -phi change for positrons and negative hadrons rather than all negative particles which was previously in the cod...When we derived the showers for AF3 we derived them for electrons and positive hadrons. We should therefore impose a phi -> -phi change for positrons and negative hadrons rather than all negative particles which was previously in the code.
These changes are pretty small but might help some electron ID agreement. Tests of the change on the angle of topoclusters are shown here;
https://indico.cern.ch/event/1274181/
indicating that this will be a small change to the physics but is in the correct direction.
Note that this will change the AF3 nightly output.https://gitlab.cern.ch/atlas/athena/-/merge_requests/62001MuonCondTest: Fix compilation with clang15.2023-04-04T04:25:13+02:00Scott SnyderMuonCondTest: Fix compilation with clang15.Work around an apparent clang15 bug involving using a destructured variable
in a lambda capture.Work around an apparent clang15 bug involving using a destructured variable
in a lambda capture.https://gitlab.cern.ch/atlas/athena/-/merge_requests/62002Enable DQ coolflask bridge2023-04-01T21:17:15+02:00Peter OnyisiEnable DQ coolflask bridgeUse coolflask server for hancool running (address ATLASDQ-1064)Use coolflask server for hancool running (address ATLASDQ-1064)https://gitlab.cern.ch/atlas/athena/-/merge_requests/61975MET Trigger menu changes2023-03-31T16:27:48+02:00Jonas WurzingerMET Trigger menu changesChanging the MET Trigger menu as described in https://its.cern.ch/jira/browse/ATR-27220
tagging @hpacey, @astruebi, @lidiazChanging the MET Trigger menu as described in https://its.cern.ch/jira/browse/ATR-27220
tagging @hpacey, @astruebi, @lidiazhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/61688edited dcube config2023-03-30T16:37:42+02:00Jacob Edwin Crosbyedited dcube configGreatly reduced the amount of plots in the "BTag" section in the dcube config file as documented [here](https://codimd.web.cern.ch/jJ_Tik5yTP6be2CeRPe5kQ).
ROCs and discriminants will be added soon.
Tagging @duperrin, @ligang and @ywng...Greatly reduced the amount of plots in the "BTag" section in the dcube config file as documented [here](https://codimd.web.cern.ch/jJ_Tik5yTP6be2CeRPe5kQ).
ROCs and discriminants will be added soon.
Tagging @duperrin, @ligang and @ywng for awareness.Jacob Edwin CrosbyJacob Edwin Crosbyhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/61905flip signed IPs for flavor tagging2023-03-30T05:15:14+02:00Yinmiao Wangflip signed IPs for flavor taggingHave modified the struct FTagTrackInputConfig and seqFromTracks in DataPrepUtilities.cxx/h to get flipped signed IPs.
Tested with release AnalysisBase,22.2.110Have modified the struct FTagTrackInputConfig and seqFromTracks in DataPrepUtilities.cxx/h to get flipped signed IPs.
Tested with release AnalysisBase,22.2.110https://gitlab.cern.ch/atlas/athena/-/merge_requests/61953getCompatibleSurfaces : tidy up a bit the code2023-03-29T17:46:11+02:00Christos Anastopouloschristos.anastopoulos@cern.chgetCompatibleSurfaces : tidy up a bit the codegetCompatibleSurfaces : tidy up a bit the codegetCompatibleSurfaces : tidy up a bit the codehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/61941Switch to Ringer Run3 Version2023-03-29T17:40:40+02:00Joao Victor Da Fonseca PintoSwitch to Ringer Run3 VersionMove to ringer v1 tuning
Waiting for Calib area copy
@safarzad @eegidiop @mverissi @cjmeyer @fernandoMove to ringer v1 tuning
Waiting for Calib area copy
@safarzad @eegidiop @mverissi @cjmeyer @fernandohttps://gitlab.cern.ch/atlas/athena/-/merge_requests/61889NSW pad trigger: fix bug of double assignment2023-03-27T19:26:57+02:00Alexander Naip TunaNSW pad trigger: fix bug of double assignmentOops, that is my bad.Oops, that is my bad.https://gitlab.cern.ch/atlas/athena/-/merge_requests/61883Separate legacy and phase 1 triggers in data quality web display2023-03-27T19:07:55+02:00Kristin DonaSeparate legacy and phase 1 triggers in data quality web displayThis merge request modifies the L1Calo data quality monitoring web display to accommodate small organizational changes to the output histograms made in MR [!61542](https://gitlab.cern.ch/atlas/athena/-/merge_requests/61542#note_6565658)....This merge request modifies the L1Calo data quality monitoring web display to accommodate small organizational changes to the output histograms made in MR [!61542](https://gitlab.cern.ch/atlas/athena/-/merge_requests/61542#note_6565658). The major change is the separation of phase 1 and legacy triggers, just to make data quality checks more organized.ATLAS RobotATLAS Robothttps://gitlab.cern.ch/atlas/athena/-/merge_requests/61797MuonNSWCommonDecode: cmake fix2023-03-23T16:35:15+01:00Scott SnyderMuonNSWCommonDecode: cmake fixProfiling should not be enabled in release builds.
Fixes compilation failure in the clang build.Profiling should not be enabled in release builds.
Fixes compilation failure in the clang build.https://gitlab.cern.ch/atlas/athena/-/merge_requests/61720Remove obsolete TrigAnalysisExamples package2023-03-22T11:03:17+01:00Jon BurrRemove obsolete TrigAnalysisExamples packageCloses ATR-27134, relates to ATR-19150
This package is now old and obsolete. While replacing it eventually would be a good idea, keeping it as it is is actively harmful as it encourages people to use it as example code (as its name reco...Closes ATR-27134, relates to ATR-19150
This package is now old and obsolete. While replacing it eventually would be a good idea, keeping it as it is is actively harmful as it encourages people to use it as example code (as its name recommends) rather than looking at the actual documentation on the twiki...https://gitlab.cern.ch/atlas/athena/-/merge_requests/61693VP1TrackSystems: Fix cppcheck warning.2023-03-21T05:40:05+01:00Scott SnyderVP1TrackSystems: Fix cppcheck warning.Redundant test.Redundant test.https://gitlab.cern.ch/atlas/athena/-/merge_requests/61622Merge branch 'share-code-in-createTrigTrackingPassFlags' into '23.0'2023-03-20T13:37:11+01:00Edward MoyseMerge branch 'share-code-in-createTrigTrackingPassFlags' into '23.0'restructure createTrigTrackingPassFlags to avoid code duplication in ITk
See merge request atlas/athena!61127
(cherry picked from commit c98283aff3ec54b2e6a3748aa59728be7c37249c)
4a904d7d restructure createTrigTrackingPassFlags to avo...restructure createTrigTrackingPassFlags to avoid code duplication in ITk
See merge request atlas/athena!61127
(cherry picked from commit c98283aff3ec54b2e6a3748aa59728be7c37249c)
4a904d7d restructure createTrigTrackingPassFlags to avoid code duplication in ITkhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/60218Draft: Remove the vertex weights used in a wrong way2023-03-17T17:32:18+01:00Andrii VerbytskyiDraft: Remove the vertex weights used in a wrong wayRemove the vertex weights used in a wrong way
Tag @jchapmanRemove the vertex weights used in a wrong way
Tag @jchapmanhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/61560Draft: fixing warnings in TRUTH[0,1,3]2023-03-17T11:17:29+01:00James CatmoreDraft: fixing warnings in TRUTH[0,1,3]ATLASG-2480
This attempts to fix two warnings in TRUTH[0,1,3]:
First:
```
Derivation 22:37:32 Py:ComponentAccumulator WARNING addPublicTool: Overwriting primary component of this CA. Was EventDensityTool/DFCommonTruthCentralEDTool, no...ATLASG-2480
This attempts to fix two warnings in TRUTH[0,1,3]:
First:
```
Derivation 22:37:32 Py:ComponentAccumulator WARNING addPublicTool: Overwriting primary component of this CA. Was EventDensityTool/DFCommonTruthCentralEDTool, now EventDensityTool/DFCommonTruthForwardEDTool
Derivation 22:37:32 Py:ComponentAccumulator WARNING addPublicTool: Overwriting primary component of this CA. Was EventDensityTool/DFCommonTruthForwardEDTool, now DerivationFramework::TruthEDDecorator/DFCommonTruthEDDecorator
```
caused by inappropriate use of the primary tool setting
Second:
```
Derivation 22:37:35 MCTruthCommonPr...WARNING Implicit circular data dependency detected for id ( 'xAOD::TruthParticleContainer' , 'StoreGateSvc+TruthMuons' )
Derivation 22:37:35 MCTruthCommonPr...WARNING Implicit circular data dependency detected for id ( 'xAOD::TruthParticleContainer' , 'StoreGateSvc+TruthElectrons’ )
```
This seems to be coming from:
https://gitlab.cern.ch/atlas/athena/-/blob/master/PhysicsAnalysis/DerivationFramework/DerivationFrameworkMCTruth/DerivationFrameworkMCTruth/TruthDressingTool.h
but it isn't clear what the problem is. So far just tidied up the tool, but doesn't suppress the warning.https://gitlab.cern.ch/atlas/athena/-/merge_requests/58937Draft: Commented lines in the process file can still affect the guess of ktdu...2023-03-17T10:26:37+01:00Javier Montejo BerlingenDraft: Commented lines in the process file can still affect the guess of ktdurham scale, fixingSpotted unwanted behaviour where the ktdurham scale is set wrongly because it reads SUSY particles showing up in commented lineSpotted unwanted behaviour where the ktdurham scale is set wrongly because it reads SUSY particles showing up in commented linehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/61389ATR-23470: Lowering minEt Threshold_cut('eTAU', 12) for new boosted Low PT D...2023-03-16T15:31:32+01:00Damiano VannicolaATR-23470: Lowering minEt Threshold_cut('eTAU', 12) for new boosted Low PT DiTau ChainLowering minEt Threshold_cut('eTAU', 12) for new boosted Low PT DiTau ChainLowering minEt Threshold_cut('eTAU', 12) for new boosted Low PT DiTau Chainhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/61545Draft: Bug fixes in DQTGlobalWZFinder Muon T&P2023-03-16T10:53:15+01:00Samuel William AlibocusDraft: Bug fixes in DQTGlobalWZFinder Muon T&P- Redefined bools inside for loop in DQTGlobalWZFinderAlg.cxx doMuonLooseTP()
- Corrected truth matching in doMuonLooseTP()
@uta @jkretz @ponyisi @jnewell- Redefined bools inside for loop in DQTGlobalWZFinderAlg.cxx doMuonLooseTP()
- Corrected truth matching in doMuonLooseTP()
@uta @jkretz @ponyisi @jnewell