athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2019-03-27T20:16:22+01:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/20057Add RoIBResult BS decoder alg and restructure the corresponding tool2019-03-27T20:16:22+01:00Rafal Bielskirafal.bielski@cern.chAdd RoIBResult BS decoder alg and restructure the corresponding tool1. Added `RoIBResultByteStreamDecoderAlg` which should replace the Converter call to decode RoIBResult from BS.
2. Restructured `RoIBResultByteStreamTool`:
* added new, non-template decoding `convert` method to be used by the new alg...1. Added `RoIBResultByteStreamDecoderAlg` which should replace the Converter call to decode RoIBResult from BS.
2. Restructured `RoIBResultByteStreamTool`:
* added new, non-template decoding `convert` method to be used by the new alg
* the old template `convert` method only transforms the arguments and calls the new method
* conversion from RoIBResult to ByteStream (BS encoding) is left untouched
* removed RoIBResultByteStreamTool.icc as the new non-template method is implemented in .cxx
* the new method does identical job as the old one, but is rearranged for better readability and maintainability
3. Made the list of ROB IDs for decoding configurable in RoIBResultByteStreamTool properties. This makes the corresponding properties of `ByteStreamAddressProviderSvc` obsolete. `ByteStreamAddressL1R` is also obsolete as the ROBFragments can be retrieved using ROBDataProviderSvc. However, both are still used in the legacy workflow. Another MR will come in the future to remove the obsolete code and use only the properties of `RoIBResultByteStreamTool` to define the list of ROBs.
4. Added two lines in `testHLT_MT.py` to make use of the new algorithm (instead of SGInputLoader indirectly calling the Converter) for RoIBResult decoding.
Tested by running `test_l1decoder.sh` with and without these changes and comparing the outputs - no difference observed.https://gitlab.cern.ch/atlas/athena/-/merge_requests/20122StorageSvc: Fix gcc9 warnings.2018-12-27T03:02:28+01:00Scott SnyderStorageSvc: Fix gcc9 warnings.In C++11, implicit declarations of copy and assignment are deprecated if the
class has a user defined destructor or copy or assignment. gcc9 now warns
about this by default.
Adjust to avoid the warning.In C++11, implicit declarations of copy and assignment are deprecated if the
class has a user defined destructor or copy or assignment. gcc9 now warns
about this by default.
Adjust to avoid the warning.https://gitlab.cern.ch/atlas/athena/-/merge_requests/20118TrigCaloRec: Fix clang warning.2018-12-27T03:02:26+01:00Scott SnyderTrigCaloRec: Fix clang warning.Use std::fabs() instead fabsf().Use std::fabs() instead fabsf().https://gitlab.cern.ch/atlas/athena/-/merge_requests/20113FastCaloSim: Add a basic test for FastShowerCellBuilderTool.2018-12-27T03:02:19+01:00Scott SnyderFastCaloSim: Add a basic test for FastShowerCellBuilderTool.Add a basic test for FastShowerCellBuilderTool.Add a basic test for FastShowerCellBuilderTool.https://gitlab.cern.ch/atlas/athena/-/merge_requests/20119TrigGenericAlgs: Fix clang warnings.2018-12-28T03:02:13+01:00Scott SnyderTrigGenericAlgs: Fix clang warnings.clang warnings: unused private class members.clang warnings: unused private class members.https://gitlab.cern.ch/atlas/athena/-/merge_requests/20111Cleanup of SCT_ReadoutTestAlg and addition of TestReadout (ATLASRECTS-4575)2018-12-28T03:02:11+01:00Susumu OdaCleanup of SCT_ReadoutTestAlg and addition of TestReadout (ATLASRECTS-4575)Cleanup of SCT_ReadoutTestAlg and addition of TestReadout.
https://its.cern.ch/jira/browse/ATLASRECTS-4575Cleanup of SCT_ReadoutTestAlg and addition of TestReadout.
https://its.cern.ch/jira/browse/ATLASRECTS-4575https://gitlab.cern.ch/atlas/athena/-/merge_requests/20127ForwardRegionGeoModel: Avoid use of non-bound DataHandle.2018-12-29T03:02:31+01:00Scott SnyderForwardRegionGeoModel: Avoid use of non-bound DataHandle.Deprecating use of non-bound DataHandle, especially non-const.Deprecating use of non-bound DataHandle, especially non-const.https://gitlab.cern.ch/atlas/athena/-/merge_requests/20126AthenaServices: Fix typo in include guard.2018-12-29T03:02:18+01:00Scott SnyderAthenaServices: Fix typo in include guard.Fix typo in include guard.Fix typo in include guard.https://gitlab.cern.ch/atlas/athena/-/merge_requests/20074TileRecUtils: Decrease dependency on TileInfo2018-12-29T03:02:30+01:00Siarhei HarkushaTileRecUtils: Decrease dependency on TileInfoTileInfo is used to return any detector-dependent constants
or information regarding the Tile Calorimeter,
including conditions data via different conditions tools.
It is not good for AthenaMT.
So functionality of TileInfo which is pro...TileInfo is used to return any detector-dependent constants
or information regarding the Tile Calorimeter,
including conditions data via different conditions tools.
It is not good for AthenaMT.
So functionality of TileInfo which is provided via tools
will be removed and clients will be migrated to use tools directly.
It is supposed that TileInfo will keep and provide only constants
which will be initialized during initialization of job.
TileRecUtils package has been migrated to use tools directly.https://gitlab.cern.ch/atlas/athena/-/merge_requests/20097TileByteStream: Make OFW access in TileROD_Decoder thread-safe.2018-12-29T03:02:11+01:00Scott SnyderTileByteStream: Make OFW access in TileROD_Decoder thread-safe.TileROD_Decoder caches OFW information.
Make this cache thread-safe.TileROD_Decoder caches OFW information.
Make this cache thread-safe.https://gitlab.cern.ch/atlas/athena/-/merge_requests/20098TileRecUtils+TileRecEx: Update configuration for tile tools being made private.2018-12-29T03:02:24+01:00Scott SnyderTileRecUtils+TileRecEx: Update configuration for tile tools being made private.Probably not complete, but sufficient to get the TileRecEx tests working again.Probably not complete, but sufficient to get the TileRecEx tests working again.https://gitlab.cern.ch/atlas/athena/-/merge_requests/20130RegSelLUT: Fix gcc9 warnings.2018-12-29T03:02:33+01:00Scott SnyderRegSelLUT: Fix gcc9 warnings.In C++11, implicit declarations of copy and assignment are deprecated if the
class has a user defined destructor or copy or assignment. gcc9 now warns
about this by default.
Adjust to avoid the warning.In C++11, implicit declarations of copy and assignment are deprecated if the
class has a user defined destructor or copy or assignment. gcc9 now warns
about this by default.
Adjust to avoid the warning.https://gitlab.cern.ch/atlas/athena/-/merge_requests/20129StorageSvc: Fix clang warning.2018-12-29T03:02:25+01:00Scott SnyderStorageSvc: Fix clang warning.clang warning: unused variable.clang warning: unused variable.https://gitlab.cern.ch/atlas/athena/-/merge_requests/20133TriggerTest: cmake fix.2018-12-29T03:02:22+01:00Scott SnyderTriggerTest: cmake fix.Remove reference to nonexistent file.Remove reference to nonexistent file.https://gitlab.cern.ch/atlas/athena/-/merge_requests/20132ISF_Algorithms: Fix clang warning.2018-12-29T03:02:10+01:00Scott SnyderISF_Algorithms: Fix clang warning.Clang warning: missing inconsistent use of override keyword.Clang warning: missing inconsistent use of override keyword.https://gitlab.cern.ch/atlas/athena/-/merge_requests/20128TrigSerializeCnvSvc: cmake fix.2018-12-29T03:02:28+01:00Scott SnyderTrigSerializeCnvSvc: cmake fix.Remove unneeded root link dependency.Remove unneeded root link dependency.https://gitlab.cern.ch/atlas/athena/-/merge_requests/20121MuonConfig: More patterns to ignore.2019-01-04T12:03:06+01:00Scott SnyderMuonConfig: More patterns to ignore.Output can change depending on whether or not FRONTIER_SERVER
is defined. Add extra patterns to ignore these diferences.
Should fix failures need in nightlies.Output can change depending on whether or not FRONTIER_SERVER
is defined. Add extra patterns to ignore these diferences.
Should fix failures need in nightlies.https://gitlab.cern.ch/atlas/athena/-/merge_requests/20112Code cleanup and addition of TestSCT_DistortionsTool (ATLASRECTS-4575)2018-12-29T03:02:40+01:00Susumu OdaCode cleanup and addition of TestSCT_DistortionsTool (ATLASRECTS-4575)Code cleanup and addition of TestSCT_DistortionsTool
https://its.cern.ch/jira/browse/ATLASRECTS-4575Code cleanup and addition of TestSCT_DistortionsTool
https://its.cern.ch/jira/browse/ATLASRECTS-4575https://gitlab.cern.ch/atlas/athena/-/merge_requests/20080athenaHLT: Write histograms into their own directory for child processes2018-12-29T03:02:34+01:00Frank WinklmeierathenaHLT: Write histograms into their own directory for child processesWe were getting basically empty histogram files when running in `athenaHLT.py` because the mother overwrote the ROOT file of the children. This MR fixes this by placing the ROOT files into their own directory when running with the offlin...We were getting basically empty histogram files when running in `athenaHLT.py` because the mother overwrote the ROOT file of the children. This MR fixes this by placing the ROOT files into their own directory when running with the offline `THistSvc`.
- Add the missing call to `updateDFProps` after the fork to
individualize the child properties (e.g. app name).
- Use the `IoComponentMgr` to mange the I/O for child processes as done in
athenaMP. This creates a sub-directory for each child into which histogram
files are being written.
- With the above we can run also in `athenaHLT.py` using the offline
`THistSvc`.
TODO: It's not nice that we are creating empty directories in case the
online `THistSvc` is used. Can probably add a check on the number of
registered files and if zero, don't bother with the I/O component
manager. But this is for a future MR.https://gitlab.cern.ch/atlas/athena/-/merge_requests/20131LArG4H6SD: Fix gcc9 warnings.2018-12-29T03:02:38+01:00Scott SnyderLArG4H6SD: Fix gcc9 warnings.In C++11, implicit declarations of copy and assignment are deprecated if the
class has a user defined destructor or copy or assignment. gcc9 now warns
about this by default.
Adjust to avoid the warning.In C++11, implicit declarations of copy and assignment are deprecated if the
class has a user defined destructor or copy or assignment. gcc9 now warns
about this by default.
Adjust to avoid the warning.