athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2023-06-09T15:41:55+02:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/63580Switch OnDemandMB to False for low pt minbias.2023-06-09T15:41:55+02:00Beojan Stanislausbeojan.stanislaus@cern.chSwitch OnDemandMB to False for low pt minbias.I thought I had already made this change, but it looks like I hadn't. This should help with the I/O issues seen in the MT pileup ART tests.I thought I had already made this change, but it looks like I hadn't. This should help with the I/O issues seen in the MT pileup ART tests.https://gitlab.cern.ch/atlas/athena/-/merge_requests/63579Fix URL and instructions in package_filters_example2023-06-09T15:41:49+02:00Jahred Adelmanjahreda@gmail.comFix URL and instructions in package_filters_exampleThe URL in the example file was broken. So were the instructions, slightly. This was fixed. Not sure why I happened to notice it :)The URL in the example file was broken. So were the instructions, slightly. This was fixed. Not sure why I happened to notice it :)https://gitlab.cern.ch/atlas/athena/-/merge_requests/63578Kill "HTT" from the name of everything2023-06-20T09:03:00+02:00Jahred Adelmanjahreda@gmail.comKill "HTT" from the name of everythingHTT goes away in our simulation. It's all EFTracking simulation now.
No practical changes and no changes to code. Just renaming files and folders and changing copyright dates. At some point this will be problematic to do because we will...HTT goes away in our simulation. It's all EFTracking simulation now.
No practical changes and no changes to code. Just renaming files and folders and changing copyright dates. At some point this will be problematic to do because we will have files with objects that have these names. We don't really have ones that we're using. Yet. But we hope to soon.https://gitlab.cern.ch/atlas/athena/-/merge_requests/635762023-06-08: Sweep of 23.0 into master2023-06-09T15:41:47+02:00Adam Edward Barton2023-06-08: Sweep of 23.0 into masterThis sweep contains the following MRs:
* !63564 TriggerJobOpts: delete obsolete triggerMenuModifier flag ~Trigger
* !63503 MuonDetectorManager - Rely on hashing mechanism to find the detector element ~MuonSpectrometer
* !63559 Fixing ...This sweep contains the following MRs:
* !63564 TriggerJobOpts: delete obsolete triggerMenuModifier flag ~Trigger
* !63503 MuonDetectorManager - Rely on hashing mechanism to find the detector element ~MuonSpectrometer
* !63559 Fixing LAr NoiseBurst issue (ATR-27632) ~Trigger, ~TriggerMenu
* !63557 Replace the use of the pointer to Trk::Track in the TauTrack access ~Trigger
* !63552 runHLT_standalone: remove L1NSW and BIS78 options in favor of flags ~Trigger
* !63541 MuonCombinedConfig: Fix typo that removed track collections from MC ESD ~Reconstruction, ~Run3-MCReco-output-changed, ~Tools, ~frozen-tier0-violating
* !63526 RootUtils+PyUtils: Add retvecs option to PyROOTInspector. ~Core, ~Tools
* !63525 Cleanup the HepMCHelpers code ~Generators, ~JetEtmiss, ~Simulation
* !63538 Update ISimulatorTool and ISimulationSvc implementations to handle shadow Truth events. ~ACTS, ~Simulation
* !63547 Update SCT coverage histogram loaded in DQWebDisplay ~DQ
* !63478 Tidying of OutputStreamCfg syntax ~Database, ~Overlay, ~Reconstruction, ~Simulation, ~Trigger
* !63540 Adjust chains to be read in the egammaCP monitoring ~DQ, ~Egamma, ~Trigger
* !63535 TileCosmicAlgs: Fix cppcheck warnings. ~Tile, ~Trigger
* !63533 TrigHLTJetHypo: Fix cppcheck warning. ~JetEtmiss, ~Trigger, ~TriggerJet
* !63539 add TCT test to check file merging ~Tools
* !63502 MdtVsRpcValMonitoring - Fix Mdt <-> Rpc stationame assocaition ~DQ, ~MuonSpectrometer
* !63523 add missing containers for the simulation and pre-sampling jobs ATLINFR-4920 ~Toolshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/63570BPHY24 Fix2023-06-08T21:41:58+02:00Adam Edward BartonBPHY24 FixI think in my original merge request my local and remote branch weren't synced so the merge missed some commits.
This will hopefully fix the failure in ART.I think in my original merge request my local and remote branch weren't synced so the merge missed some commits.
This will hopefully fix the failure in ART.https://gitlab.cern.ch/atlas/athena/-/merge_requests/63568AnalysisTop: Update small-R jet uncertainty prescription to bugfix version2023-06-12T15:41:59+02:00Chris ScheulenAnalysisTop: Update small-R jet uncertainty prescription to bugfix versionThis MR updates the R22 Jet/MET phase-1 small-R jet pre-recommendations to a recently released version derived using the calibrations with GSC/energy-per-layer bugfixes. This should decrease in-situ uncertainties - especially for high |e...This MR updates the R22 Jet/MET phase-1 small-R jet pre-recommendations to a recently released version derived using the calibrations with GSC/energy-per-layer bugfixes. This should decrease in-situ uncertainties - especially for high |eta| - as reported [here in the Jet/MET Main meeting](https://indico.cern.ch/event/1240678/contributions/5215420/attachments/2652835/4593614/JETM_Intro-13.pdf#page=4). The new recommendations are also summarised on the [Jet/MET R22 JetUncertainties twiki](https://twiki.cern.ch/twiki/bin/view/AtlasProtected/JetUncertaintiesRel22#R_0_4_particle_flow_JES_JER_unce) already and largely consist of changing the config folder from `Winter2023_PreRec` to `Summer2023_PreRec`.
Additionally, the R22 jet calibration config documentation is improved with this MR. Lastly, a new JMS override flag is introduced to steer output until JMS recommendations are available for R22.
This MR addresses ANALYSISTO-1321.Chris ScheulenChris Scheulenhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/63565Fixing FPE in track finding for ITk2023-06-08T21:41:46+02:00Noemi CalaceFixing FPE in track finding for ITkFixing DIVBYZEROs in ITkSiSpTrackFinder. Recently noticed in [test_run4_mu100_reco](https://atlas-art-data.web.cern.ch/atlas-art-data/grid-output/master/Athena/x86_64-centos7-gcc11-opt/2023-06-06T2101/InDetPhysValMonitoring/test_run4_mu1...Fixing DIVBYZEROs in ITkSiSpTrackFinder. Recently noticed in [test_run4_mu100_reco](https://atlas-art-data.web.cern.ch/atlas-art-data/grid-output/master/Athena/x86_64-centos7-gcc11-opt/2023-06-06T2101/InDetPhysValMonitoring/test_run4_mu100_reco/tarball_logs/log.RAWtoALL).
```
04:47:39 PerfMonMTSvc INFO Event [ 4670] CPU Time: 00h02m17s, Wall Time: 00h02m41s, Vmem: 2.38 GB, Rss: 1.64 GB, Pss: 1.63 GB, Swap: 0.00 KB
04:48:09 PerfMonMTSvc INFO Event [ 6515] CPU Time: 00h02m46s, Wall Time: 00h03m11s, Vmem: 2.38 GB, Rss: 1.64 GB, Pss: 1.63 GB, Swap: 0.00 KB
04:48:23 FPEAuditor WARNING FPE DIVBYZERO in [Execute] of [ITkSiSpTrackFinder] on event 7357 0 0
04:48:39 PerfMonMTSvc INFO Event [ 8303] CPU Time: 00h03m15s, Wall Time: 00h03m41s, Vmem: 2.38 GB, Rss: 1.64 GB, Pss: 1.64 GB, Swap: 0.00 KB
```
Performance is unchanged.Noemi CalaceNoemi Calacehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/63551Added recording & exporting of StripHits in CSV format2023-06-08T09:41:53+02:00Tomasz BoldAdded recording & exporting of StripHits in CSV formatThis MR is a followup of !63121 & !63137 & !63415 and completes half of the task described in: EFTRACK-63
FI @mvgonzal - in addition to adding Strips saving I have also made protection agains missing input (convenient for testing and I...This MR is a followup of !63121 & !63137 & !63415 and completes half of the task described in: EFTRACK-63
FI @mvgonzal - in addition to adding Strips saving I have also made protection agains missing input (convenient for testing and I guess generally useful).
also @fpastore @mastrandhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/63550SUSYTools - Update PRW Handling2023-06-08T09:41:52+02:00Michael HolzbockSUSYTools - Update PRW HandlingThis MR updates the handling of PRW within SUSYTools:
* removes the support of mc16 r-tags
* adds support of m23a
* removes some outdated functionality to retrieve fixed PRW files for some HF-filtered V+jets samples
Fulfills a request i...This MR updates the handling of PRW within SUSYTools:
* removes the support of mc16 r-tags
* adds support of m23a
* removes some outdated functionality to retrieve fixed PRW files for some HF-filtered V+jets samples
Fulfills a request in ATLSUSYBGF-670, tagging @mrimoldi & @martindl.https://gitlab.cern.ch/atlas/athena/-/merge_requests/63548SUSYTools - Update Jet UncertConfig2023-06-07T21:41:45+02:00Marco RimoldiSUSYTools - Update Jet UncertConfigJetEtmiss reccomandations updates from here:
https://twiki.cern.ch/twiki/bin/view/AtlasProtected/JetUncertaintiesRel22JetEtmiss reccomandations updates from here:
https://twiki.cern.ch/twiki/bin/view/AtlasProtected/JetUncertaintiesRel22Marco RimoldiMarco Rimoldihttps://gitlab.cern.ch/atlas/athena/-/merge_requests/63546Change place where the TrackContainer is constructed2023-06-26T16:18:13+02:00Tomasz BoldChange place where the TrackContainer is constructedIn this MR the place where TrackContainer is constructed is moved from TrackFindingTool to the calling algorithm.
Once we migrate to track container with persistifiable backend the algorithm will be responsible for recording it in SG.
In...In this MR the place where TrackContainer is constructed is moved from TrackFindingTool to the calling algorithm.
Once we migrate to track container with persistifiable backend the algorithm will be responsible for recording it in SG.
In meantime the tool creates two collections/containers with new & old EDM.
The changes are somewhat extensive and given !63217 is in works this MR is only draft. Tagging @cvarni to decide if this should go or wait.
FI usual suspects: @ncalace @adye @pagessinhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/63545Manual sweep of !63355 from 21.2 to master2023-06-12T15:41:50+02:00Patrycja Anna PotepaManual sweep of !63355 from 21.2 to masterAdd signed eta support for gluon fractions in p+Pb collisions
See merge request !63355Add signed eta support for gluon fractions in p+Pb collisions
See merge request !63355https://gitlab.cern.ch/atlas/athena/-/merge_requests/635422023-06-07: Sweep of 23.0 into master2023-06-07T21:41:52+02:00Adam Edward Barton2023-06-07: Sweep of 23.0 into masterA bit early today to get some urgent fixes in
This sweep contains the following MRs:
* !63534 TrigT1CTP+TrigT1MBTS: Fix cppcheck warning. ~Trigger
* !63464 TriggerJobOpts: make runHLT the main CA config module ~Trigger
* !63536 MuonT...A bit early today to get some urgent fixes in
This sweep contains the following MRs:
* !63534 TrigT1CTP+TrigT1MBTS: Fix cppcheck warning. ~Trigger
* !63464 TriggerJobOpts: make runHLT the main CA config module ~Trigger
* !63536 MuonTesterTree: Fix cppcheck warning. ~MuonSpectrometer
* !63528 TrkDetDescrTools: Avoid potential FPE with clang. ~Tracking
* !63446 InDetSurveyConstraintTool: Remove use of AIDA. ~InnerDetector
* !63473 Adding SC containers creation ~Calorimeter, ~LAr, ~Trigger
* !63521 TrigValidation: update minbias RDO ~Trigger
* !63520 ATLASRECTS-7652: Fix for autoloading of enum values ~DQ, ~InnerDetector
* !63522 Updates to the muoncalib chain and switch MU5VF_EMPTY to 2MU5VF_EMPTY ~Trigger, ~TriggerMenu, ~changes-trigger-counts
* !63529 EvgenProdTools: Fix compilation with hepmc2. ~Generators
* !63527 EvtGen_i+BarcodeServices: Fix clang warnings. ~Generators, ~Simulation
* !63532 InDetConversionFinderTools: Fix pi calculation bugs ~Egamma, ~InnerDetector
* !63531 TrkExAlgs: Fix clang warning. ~Tracking
* !63530 TRT_RawDataByteStreamCnv: Fix warning in lto build. ~InnerDetector
* !63462 Update the InputConverter to work with ShadowEvents ~Simulation
* !63492 Set MC campaign flag for PhaseII ~Tools
* !63510 23.0-script-PixelCalibAlgs ~InnerDetector
* !63514 Fix output file comparisons in test_Digi_tf_mc20a_qballs.sh ART job (ATLASSIM-6570) ~Digitization, ~Simulation
* !63224 TrigNav: Run2 to Run3 navigation converter fixing object comparison ~Derivation, ~Trigger
* !63516 adding eEM28 to mon ~DQ, ~Egamma, ~Trigger
* !63508 TrigServices+TriggerJobOpts: fix MessageSvc format for online running ~Trigger
* !63507 runTrigART: add --rerun-failed option ~Triggerhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/63537make a version of PhaseII compatible with the new Run 4 run numbers2023-06-28T11:58:23+02:00Jiri Masikmake a version of PhaseII compatible with the new Run 4 run numbersattempt to create a version of PhaseIISimulation using the new run number convention to be able to deploy the new conditions tag
https://twiki.cern.ch/twiki/bin/viewauth/AtlasComputing/ConditionsRun1RunNumbers#RUN_4_IOV_Schemes
tagging @...attempt to create a version of PhaseIISimulation using the new run number convention to be able to deploy the new conditions tag
https://twiki.cern.ch/twiki/bin/viewauth/AtlasComputing/ConditionsRun1RunNumbers#RUN_4_IOV_Schemes
tagging @tstreble, @sch, @tlari, @mbandier, @lderamo, @tadej and @dshope for comments (please also add relevant experts)https://gitlab.cern.ch/atlas/athena/-/merge_requests/63524SUSYTools - Suppressing Output Dependence in Jet Tools for AthAnalysis2023-06-08T08:17:42+02:00Michael HolzbockSUSYTools - Suppressing Output Dependence in Jet Tools for AthAnalysisThis MR makes use of some new properties recently added with !63461 to suppress the output dependence of a couple of JetEtmiss CP tools in AthAnalysis. That's required to comply with some (currently reverted) additional checks in the TAu...This MR makes use of some new properties recently added with !63461 to suppress the output dependence of a couple of JetEtmiss CP tools in AthAnalysis. That's required to comply with some (currently reverted) additional checks in the TAuxStore from !62822 (see also the discussion in ATLSUSYBGF-672).
Tagging @mrimoldi & @akraszna.https://gitlab.cern.ch/atlas/athena/-/merge_requests/63515Update master to Gaudi v36r132023-06-27T16:39:50+02:00Frank WinklmeierUpdate master to Gaudi v36r13Update ~master to [Gaudi v36r13](https://gitlab.cern.ch/gaudi/Gaudi/-/releases/v36r13) (we skipped [Gaudi v36r12](https://gitlab.cern.ch/gaudi/Gaudi/-/releases/v36r12)).
The only relevant new feature for us should be:
- Adds the ability...Update ~master to [Gaudi v36r13](https://gitlab.cern.ch/gaudi/Gaudi/-/releases/v36r13) (we skipped [Gaudi v36r12](https://gitlab.cern.ch/gaudi/Gaudi/-/releases/v36r12)).
The only relevant new feature for us should be:
- Adds the ability to show the data dependencies of AlgTools
- GaudiConfig2: add clone for Configurable
Should also fix build failures in dev3/4 (ATLINFR-4955).https://gitlab.cern.ch/atlas/athena/-/merge_requests/635132023-06-06: Sweep of 23.0 into master2023-06-07T09:41:49+02:00Adam Edward Barton2023-06-06: Sweep of 23.0 into masterThis sweep contains the following MRs:
* !63485 AthConfigFlags: make --pmon command line arg case insensitive ~Core
* !63459 Update the TruthSvc to work with ShadowEvents ~Simulation
* !63498 TrfTestsART: Add Merge_tf test for AODs wi...This sweep contains the following MRs:
* !63485 AthConfigFlags: make --pmon command line arg case insensitive ~Core
* !63459 Update the TruthSvc to work with ShadowEvents ~Simulation
* !63498 TrfTestsART: Add Merge_tf test for AODs with MP, CA and SharedWriter ~Tools
* !63484 Clean up InDetSecVxFinderTool properties ~Analysis, ~BTagging, ~Derivation, ~InnerDetector, ~JetEtmiss, ~Tracking
* !63254 Adding jFexTower builder to fill jTower for jFEX simulation ~EDM, ~Trigger
* !63483 TrigPSC+TrigExamples: make strict dependency checking the default ~Trigger
* !63487 InDetConversionFinderTools: Reduce dependences ~Egamma, ~InnerDetector
* !62995 Add isValid to SysReadHandle ~Analysis
* !63468 RecExOnline: Adding CA style Global Monitoring job option ~Reconstruction
* !63450 ISF: Punchthrough parse (try 2) ~Simulation
* !63460 Update the GenParticleSimWhiteList tool to work with ShadowEvents ~Simulation
* !63418 G4Ultilities: Optimize String parsing ~Simulation
* !63458 athenaHLT: use 'main' as default entry point for CA modules ~Triggerhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/63512bugfix for retrieving truth links to soft muons in AnalysisTop2023-06-16T15:42:08+02:00Marco Vanadiabugfix for retrieving truth links to soft muons in AnalysisToptentative fix for ANALYSISTO-1313tentative fix for ANALYSISTO-1313https://gitlab.cern.ch/atlas/athena/-/merge_requests/63511Sweeping !63200 from 21.6 to master.
MGC: Force b massless with 5FS in SUSY M...2023-06-07T09:41:53+02:00Atlas NightlybuildSweeping !63200 from 21.6 to master.
MGC: Force b massless with 5FS in SUSY MGC includesMGC: Force b massless with 5FS in SUSY MGC includes
See merge request atlas/athena!63200MGC: Force b massless with 5FS in SUSY MGC includes
See merge request atlas/athena!63200https://gitlab.cern.ch/atlas/athena/-/merge_requests/63509introduce AnaAlgorithm::efficiency() as alias for AnaAlgorithm::histeff()2023-06-07T09:41:58+02:00Nils Erik Krumnackintroduce AnaAlgorithm::efficiency() as alias for AnaAlgorithm::histeff()It was pointed out that the name in AnalysisBase wasn't matching the
name in Athena, so I added an alias in AnalysisBase. I kept the old
version around because removing it would break users code.It was pointed out that the name in AnalysisBase wasn't matching the
name in Athena, so I added an alias in AnalysisBase. I kept the old
version around because removing it would break users code.