athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2024-03-29T00:57:09+01:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/69382Adding new AthenaExamples package - AthExBasics2024-03-29T00:57:09+01:00James CatmoreAdding new AthenaExamples package - AthExBasicsThis MR adds a new package to AthenaExamples. It is intended to contain examples of tools, algorithms and config scripts for doing very basic real-world tasks such as reading the trigger decision, accessing and selecting xAOD objects, ru...This MR adds a new package to AthenaExamples. It is intended to contain examples of tools, algorithms and config scripts for doing very basic real-world tasks such as reading the trigger decision, accessing and selecting xAOD objects, running trigger matching &c. It is hoped developers will add to these over time.
Obviously this will have no impact on any existing workflows.
This is part of the lead-up to the documentation week in April.https://gitlab.cern.ch/atlas/athena/-/merge_requests/70201Clean up unused decisionTool in makeTriggerGlobalEffCorrAlg2024-03-29T00:54:44+01:00Thomas StreblerClean up unused decisionTool in makeTriggerGlobalEffCorrAlgFollow up to !69869
FYI @ravinabFollow up to !69869
FYI @ravinabhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/70198CaloRec: delete unused legacy python modules2024-03-29T00:54:02+01:00Frank WinklmeierCaloRec: delete unused legacy python modulesA few modules are still remaining that are referenced outside this package.
cc @wlamplA few modules are still remaining that are referenced outside this package.
cc @wlamplhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/70178Move secondary track pass flags to global tracking flags2024-03-29T00:52:55+01:00Thomas StreblerMove secondary track pass flags to global tracking flagsRelevant for ATLASRECTS-7947
The secondary tracking pass flags are actually identical for all passes in most cases.
The `RobustReco` is removed with !70177 so they can be promoted to global tracking flags.Relevant for ATLASRECTS-7947
The secondary tracking pass flags are actually identical for all passes in most cases.
The `RobustReco` is removed with !70177 so they can be promoted to global tracking flags.https://gitlab.cern.ch/atlas/athena/-/merge_requests/70190Adding nonEmpty file check in functions to fix memory crash2024-03-29T00:51:28+01:00Revital KopelianskyAdding nonEmpty file check in functions to fix memory crashSeveral functions in TimingClass.cxx are operating over 4 txt files (EMB, EMEC, HCAL FCAL), if one is empty due to zero stat, the script crashes.
As solution I have added a dedicated function that checks if the file is empty beforehand, ...Several functions in TimingClass.cxx are operating over 4 txt files (EMB, EMEC, HCAL FCAL), if one is empty due to zero stat, the script crashes.
As solution I have added a dedicated function that checks if the file is empty beforehand, and if so, the process will return to the calling function avoiding the crash.
Hopefully...https://gitlab.cern.ch/atlas/athena/-/merge_requests/70200Update L1CaloFEXSimCfg.py - enable heuristic eTAU when running DQ environment...2024-03-29T00:50:10+01:00Will ButtingerUpdate L1CaloFEXSimCfg.py - enable heuristic eTAU when running DQ environment...Update L1CaloFEXSimCfg.py - enable heuristic eTAU when running DQ environment at tier0, so that monitoring plots can compare BDT tau (new nominal) to themUpdate L1CaloFEXSimCfg.py - enable heuristic eTAU when running DQ environment at tier0, so that monitoring plots can compare BDT tau (new nominal) to themhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/70191Suppress some PathResolver output2024-03-29T00:48:46+01:00Samuel Van StroudSuppress some PathResolver output- I don't think we need to `INFO` when a file is downloaded
- A `WARN` is better if the download fails than a `DEBUG`
- I'm disabling the progress bar in `TFile::Cp`- I don't think we need to `INFO` when a file is downloaded
- A `WARN` is better if the download fails than a `DEBUG`
- I'm disabling the progress bar in `TFile::Cp`https://gitlab.cern.ch/atlas/athena/-/merge_requests/70193Fix timing monitoring histograms for ITk TrigInDetValidation ART tests (EFTRA...2024-03-29T00:46:03+01:00Elliot WattonFix timing monitoring histograms for ITk TrigInDetValidation ART tests (EFTRACK-463)Currently, the timing histograms for the ITk trigger ART tests are setup with x-axis ranges being too small, leading to many entries in overflow for certain situations (e.g fullscan chains when running on ttbar + 200 PU ITk RDO). This sm...Currently, the timing histograms for the ITk trigger ART tests are setup with x-axis ranges being too small, leading to many entries in overflow for certain situations (e.g fullscan chains when running on ttbar + 200 PU ITk RDO). This small change fixes the issue by sending the correct signature name to be checked against when setting up the monitoring. This only impacts the monitoring for ITk jobs, but targetting 24.0 to keep configurations in step. Changes will be eventually swept to main.
This work for running FTF with ITk in the trigger is tracked by EFTRACK-463
Tagging @baineshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/70192HltAsyncEventLoopMgr: backport fixes from HltEventLoopMgr2024-03-29T00:45:05+01:00Frank WinklmeierHltAsyncEventLoopMgr: backport fixes from HltEventLoopMgrPort the following changes to the `HltAsyncEventLoopMgr` that were missed in the original fork (https://gitlab.cern.ch/atlas/athena/-/merge_requests/69464):
- set the default of `HltAsyncEventLoopMgr.setMagFieldFromPtree` to `true` (145e...Port the following changes to the `HltAsyncEventLoopMgr` that were missed in the original fork (https://gitlab.cern.ch/atlas/athena/-/merge_requests/69464):
- set the default of `HltAsyncEventLoopMgr.setMagFieldFromPtree` to `true` (145e0240)
- Use C++17 std::filesystem instead of boost::filesystem where possible (2b7217bc)
- only send event to debug stream if severely truncated (34b5d520)
None of these have any impact on P1 operations.
Relates to ATR-26285.https://gitlab.cern.ch/atlas/athena/-/merge_requests/70172PadDesign - Fixing sTgc Pad Positions2024-03-29T00:44:11+01:00Ishan Kiritbhai VyasPadDesign - Fixing sTgc Pad Positions- Pad Corners Aligned.
- Adding frameOffset parameter in Geometry Tool to correct beamline radius until we find a fix.
- Modifying the globalChannelPosition function in the readout element to correct last half-strip position in gasgap la...- Pad Corners Aligned.
- Adding frameOffset parameter in Geometry Tool to correct beamline radius until we find a fix.
- Modifying the globalChannelPosition function in the readout element to correct last half-strip position in gasgap layers
- Fixing minor errors and bugs
@alainb @jojungge @pscholerhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/70188Cleanup string/token writing code in APR Containers2024-03-29T00:37:11+01:00Marcin NowakCleanup string/token writing code in APR ContainersCode cleanup as side effect of the investigation into ROOT string writing bug (in ROOT HEAD)
No functionality changes expectedCode cleanup as side effect of the investigation into ROOT string writing bug (in ROOT HEAD)
No functionality changes expectedhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/70161Clean up TRT-only tracking pass flags2024-03-29T00:27:14+01:00Thomas StreblerClean up TRT-only tracking pass flagsEither setting those in place in the config or promoting them to global flags
Should reduce already by 7*31 the amount of tracking flags.
Similar clean ups to be expected in the near future.
Relevant for ATLASRECTS-7947Either setting those in place in the config or promoting them to global flags
Should reduce already by 7*31 the amount of tracking flags.
Similar clean ups to be expected in the near future.
Relevant for ATLASRECTS-7947https://gitlab.cern.ch/atlas/athena/-/merge_requests/69604Add new code to allow creation of electron and muon free particle flow jets (V3)2024-03-28T21:21:47+01:00Mark HodgkinsonAdd new code to allow creation of electron and muon free particle flow jets (V3)This includes updates to JetPFlowSelectionAlg.cxx to add options to remove all neutral contributions from particle flow jets that belong to electrons or muons of a given particle ID level.
On the python side new configuration functional...This includes updates to JetPFlowSelectionAlg.cxx to add options to remove all neutral contributions from particle flow jets that belong to electrons or muons of a given particle ID level.
On the python side new configuration functionality has been added to allow users to make use of these workflows.
This should not change the output of standard particle flow jets and hence should preserve frozen tier0 for jets.
The new muon free jets rely on an additional decoration that is added to charged FlowElement - thus this aspect violates frozen tier0 and adds a new decoration:
JetETMissChargedParticleFlowObjectsAuxDyn.FE_efrac_matched_muon
This is used by the new muon-less jet finding configuration included in this MR.
Whilst testing this I found two further unexpected differences in neutral FlowElements:
JetETMissNeutralParticleFlowObjectsAuxDyn.FE_efrac_matched_muon
JetETMissNeutralParticleFlowObjectsAuxDyn.FE_nMatchedMuons
MuonsAuxDyn.muon_efrac_matched_FE
as well as changes in MET container output.
Further investigation revealed an existing bug in the eflowRec code here:
https://gitlab.cern.ch/atlas/athena/-/blob/main/Reconstruction/eflowRec/src/PFMuonFlowElementAssoc.cxx?ref_type=heads#L253
whereby an iterator over the muon calormeter clusters cells is not reset to begin() in each loop over a calorimeter clusters cells. Thus only one cell can ever be matched, rather than N. This was (unintentionally) fixed in this MR because the code we redesigned and switched to range based for loops.
Due to the MET changes, this is a bug fix that affects MET output so it ought to go into 24.0? Flagging to @jdandoy and @christos .
I can prepare a MR for 24.0 that only contains the eflowRec bug fix.https://gitlab.cern.ch/atlas/athena/-/merge_requests/70164Add CA-based configuration for the FastIDKiller2024-03-28T16:41:23+01:00John Derek ChapmanAdd CA-based configuration for the FastIDKillerInitial version of FastIDKiller configuration - can be expanded as required.
Needed for egamma studies.Initial version of FastIDKiller configuration - can be expanded as required.
Needed for egamma studies.https://gitlab.cern.ch/atlas/athena/-/merge_requests/69780Adding SUSY20 derivation format2024-03-26T17:12:03+01:00Alessandro Salaalessandro.sala@cern.chAdding SUSY20 derivation formatSUSY20 derivation format is needed by compressed SUSY analyses aiming to exploit both Run-2 and Run-3 data. The format is obtained by upgrading the one already existing in R21 and makes use of a tool that will be added by the linked merg...SUSY20 derivation format is needed by compressed SUSY analyses aiming to exploit both Run-2 and Run-3 data. The format is obtained by upgrading the one already existing in R21 and makes use of a tool that will be added by the linked merge request (currently pending). Code lines in the python scripts that are commented out refer to variables/tools not needed for the moment but that will be restored once all compressed SUSY analyses will join the effort in R24.
Tagging also @tlarihttps://gitlab.cern.ch/atlas/athena/-/merge_requests/69870Cherry-pick 4846494a to 23.02024-03-18T12:26:01+01:00Chad Stephen LantzCherry-pick 4846494a to 23.0Manual sweep of !69676 to 23.0 : ZDC RPD centroid max ADC fixManual sweep of !69676 to 23.0 : ZDC RPD centroid max ADC fixhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/69871ZDC Monte Carlo Truth Algorithm2024-03-18T12:02:36+01:00Chad Stephen LantzZDC Monte Carlo Truth AlgorithmAdds MC truth from CaloCalibrationHits to ZdcRec and ZdcNtupleAdds MC truth from CaloCalibrationHits to ZdcRec and ZdcNtuplehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/69878Changed ZDC module placement to allow for the RPD foot2024-03-18T10:16:13+01:00Chad Stephen LantzChanged ZDC module placement to allow for the RPD footMoved module placement to within each module to give the RPD information about the mother volume so the RPD foot could extend to the bottom of the volume.Moved module placement to within each module to give the RPD information about the mother volume so the RPD foot could extend to the bottom of the volume.